Re: [Flightgear-devel] [BUG] simgear/math/polar3d.cxx: both functions assume inverted longitude
On 2/26/07, Melchior FRANZ [EMAIL PROTECTED] wrote: * Melchior FRANZ -- Sunday 25 February 2007: I would fix the files if people agree that what I consider a bug is indeed a bug. I assume that the whole stuff should be dumped and replaced with geo_*_wgs_84() functions, right? And this is the end of my one-man thread. :-) For what it's worth, the geo*wgs_84() functions are *much* more computationally intensive than the spherical functions. For *many* purposes, the less accurate (but still pretty close) and more efficient functions work just fine. We do need the wgs_84() functions for precise scenery calculations and precise navigation calculations. Regards, Curt. -- Curtis Olson - University of Minnesota - FlightGear Project http://baron.flightgear.org/~curt/ http://www.humanfirst.umn.edu/ http://www.flightgear.org Unique text: 2f585eeea02e2c79d7b1d8c4963bae2d - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] simgear/math/polar3d.cxx: both functions assume inverted longitude
* Melchior FRANZ -- Sunday 25 February 2007: I would fix the files if people agree that what I consider a bug is indeed a bug. I assume that the whole stuff should be dumped and replaced with geo_*_wgs_84() functions, right? And this is the end of my one-man thread. :-) m. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] [BUG] simgear/math/polar3d.cxx: both functions assume inverted longitude
I noticed today that functions calc_gc_course_dist() and calc_gc_lon_lat() in simgear/math/polar3d.cxx wrongly assume that positive longitude values are in the West, and negative in the East. Apparently the functions were copied/adapted from the Aviation Formulary site (http://williams.best.vwh.net/avform.htm), which says: For the convenience of North Americans I will take North latitudes and West longitudes as positive and South and East negative. Consequently, calc_gc_course_dist() returns 270 for heading East. Apparently, all users of the functions throughout sg and fg (and there are quite some) hacked around this oddness, probably without knowing WTF went on. Or am I missing something? :-} m. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] simgear/math/polar3d.cxx: both functions assume inverted longitude
* Melchior FRANZ -- Sunday 25 February 2007: Apparently, all users of the functions throughout sg and fg (and there are quite some) hacked around this oddness, [...] And the winners are ... SimGear/simgear/environment/visual_enviro.cxx SimGear/simgear/route/waypoint.cxx SimGear/simgear/scene/sky/cloudfield.cxx SimGear/simgear/scene/sky/cloud.cxx FlightGear/src/ATC/approach.cxx FlightGear/src/AIModel/AIBase.cxx FlightGear/src/Cockpit/hud_rwy.cxx FlightGear/src/Instrumentation/HUD/HUD_runway.cxx m. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] simgear/math/polar3d.cxx: both functions assume inverted longitude
* Melchior FRANZ -- Sunday 25 February 2007: After looking into those files, it looks less dramatic. These would be the only ones to fix: SimGear/simgear/route/waypoint.cxx SimGear/simgear/scene/sky/cloudfield.cxx SimGear/simgear/scene/sky/cloud.cxx FlightGear/src/ATC/approach.cxx Those use only the distance, which is correct. Nothing to fix here: SimGear/simgear/environment/visual_enviro.cxx FlightGear/src/Cockpit/hud_rwy.cxx FlightGear/src/Instrumentation/HUD/HUD_runway.cxx And here the function use is commented out: FlightGear/src/AIModel/AIBase.cxx I would fix the files if people agree that what I consider a bug is indeed a bug. Shouldn't be hard to do, only checking if the respective subsystems work still as the authors had intended will be a bit tedious. m. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
