Re: [Flightgear-devel] [Flightgear-commitlogs] FlightGear branch, next, updated. 1dbc2c83e5c0514b1a51eb0c2aee9f6dbe577492
On 4 Sep 2012, at 23:09, Flightgear-commitlogs wrote: commit 6745d27691039e2ce477b2e823dbae6c59bc5d00 Author: ThorstenB Date: Tue Sep 4 23:57:25 2012 +0200 #858: Fix loading issue with aircraft models in --fg-aircraft directories Something after FG 2.8.0 has broken loading aircraft models from --fg-aircraft directories. Issue is fixed by resolving the aircraft path in FGAircraftModel (though this module itself hasn't changed and things were working before...). I'm very suspicious of this - I don't think there's been any post 2.8 commit that could change such a core behaviour. (I don't read every single commit in detail, but I look at the summaries) The change is certainly valid, but I'd be much happier knowing why it worked before and what broke it. I'll take a quick look myself but any help would be appreciated. James -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Flightgear-commitlogs] FlightGear branch, next, updated. 1dbc2c83e5c0514b1a51eb0c2aee9f6dbe577492
I can confirm that it (--fg-aircraft directories)was broken,and was about to investigate further when ThorstenB made it work again. Thanks. I think that the bug appeared very recently, perhaps within the last 2 weeks, but cannot be 100% sure when Alan -Original Message- From: James Turner Sent: Wednesday, September 05, 2012 9:00 AM To: FlightGear developers discussions Subject: Re: [Flightgear-devel] [Flightgear-commitlogs] FlightGear branch, next, updated. 1dbc2c83e5c0514b1a51eb0c2aee9f6dbe577492 On 4 Sep 2012, at 23:09, Flightgear-commitlogs wrote: commit 6745d27691039e2ce477b2e823dbae6c59bc5d00 Author: ThorstenB Date: Tue Sep 4 23:57:25 2012 +0200 #858: Fix loading issue with aircraft models in --fg-aircraft directories Something after FG 2.8.0 has broken loading aircraft models from --fg-aircraft directories. Issue is fixed by resolving the aircraft path in FGAircraftModel (though this module itself hasn't changed and things were working before...). I'm very suspicious of this - I don't think there's been any post 2.8 commit that could change such a core behaviour. (I don't read every single commit in detail, but I look at the summaries) The change is certainly valid, but I'd be much happier knowing why it worked before and what broke it. I'll take a quick look myself but any help would be appreciated. James -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Flightgear-commitlogs] FlightGear branch, next, updated. 1dbc2c83e5c0514b1a51eb0c2aee9f6dbe577492
I'm very suspicious of this - I don't think there's been any post 2.8 commit
that could change such a core behaviour. (I don't read every single commit in
detail, but I look at the summaries)
The change is certainly valid, but I'd be much happier knowing why it worked
before and what broke it. I'll take a quick look myself but any help would be
appreciated.
I checked commit comments, but couldn't find anything related. Checked a
bit closer now: my best _guess_ is, it's related to the following
simgear change:
commit f1201eaebc3fbb8964e06b7ef158fd34a12901aa
Author: Mathias Froehlich
Date: Sat Aug 25 08:43:12 2012 +0200
scene: Reorganize stg loading.
Specifically, the diff contains:
SGReaderWriterXML::readNode(const std::string fileName,
{
+std::string fileName = osgDB::findDataFile(name, options);
+
osg::Node *result=0;
try {
SGPath p = SGModelLib::findDataFile(fileName);
The XML reader relies on osgDB to resolve paths now. If
osgDB::findDataFile cannot find the file, it returns , in which case
SGModelLib::findDataFile cannot search any additional directories.
So, maybe osgDB::findDataFile doesn't know about extra directories,
while SGModelLib::findDataFile was fg-aircraft aware. Not sure why the
change was applied in the first place.
Again, I haven't tested - it just looks plausible and somehow related.
Maybe you or Mathias can investigate if that's what triggered it and
whether anything else may still be broken now.
cheers,
Thorsten
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Flightgear-commitlogs] FlightGear branch, next, updated. 1dbc2c83e5c0514b1a51eb0c2aee9f6dbe577492
On 5 Sep 2012, at 21:13, ThorstenB wrote: The XML reader relies on osgDB to resolve paths now. If osgDB::findDataFile cannot find the file, it returns , in which case SGModelLib::findDataFile cannot search any additional directories. So, maybe osgDB::findDataFile doesn't know about extra directories, while SGModelLib::findDataFile was fg-aircraft aware. Not sure why the change was applied in the first place. Ah, that's exactly it - we need to use the SGModelLib to get the additional paths searched! Mathias, can you explain what was the problem here which required you to use the plain OSG version? My version is simply a wrapper which tries the aircraft-dir paths (and soon, some other data directories!) before the default osg paths. James -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
