Re: [Flightgear-devel] [Flightgear-commitlogs] SimGear branch, next, updated. 54db2e0ab196b659e4297c0d93f088b2212409f5

2011-12-18 Thread James Turner

On 18 Dec 2011, at 16:44, Flightgear-commitlogs wrote:

#479: avoid issues due to trailing path separators
Cut trailing separators when converting from string to sgpath.
Also, SGPath::fix does NOT replace :. It only replaces \ with /,
so the i!=1 check for Windows made no sense (rule #9: never believe
a source code comment).

Ah, but it used too, until I removed the Mac OS *9* supporting code :)

Mac pre OS-X used ':' as the path separator.

James

--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] [Flightgear-commitlogs] SimGear branch, next, updated. 54db2e0ab196b659e4297c0d93f088b2212409f5

2011-12-18 Thread ThorstenB
Am 18.12.2011 20:13, schrieb James Turner:
 On 18 Dec 2011, at 16:44, Flightgear-commitlogs wrote:
 (rule #9: never believe a source code comment).

 Ah, but it used too, until I removed the Mac OS *9* supporting code :)

Yes, I guessed it was some copypaste issue or some left-over. Actually 
reminded me of something (much worse) I recently found in a RL code review:

// set flag to 1
SomeObject.SomeFunction.Flag = 0;

... the most useless comment ever - yet plain wrong at the same time. :)

cheers,
Thorsten

--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel