Re: [Flightgear-devel] METAR interpolation?
I wrote : Csaba wrote: On Fri, Dec 19, 2008 at 11:38 PM, Stuart Buchanan wrote: The patch below backs out that change. Unfortunately this means the change to the cloud coverage due to changing METAR will not be reflected in the 3D clouds (2D clouds are unaffected). Unfortunately I don't think it will be possible to fix this before the release. I personally consider that a show-stopper (unless we disable 3d clouds in the release). Just to be clear: a) The patch I provided fixes METAR interpolation. b) However, it means that 3D clouds are not completely interpolated. A change in cloudbase will be interpolated (quite nicely). However, a change in cloud coverage (including the removing or adding of layers) will _not_ have any effect. I agree that its bad. Unfortunately I don't have time to fix it this weekend before the release. I've managed to fix this by differentiating rebuilding the 3D layers (e.g. due to METAR updates) from rebuilding the entire environment (due to a change in scenario). Could someone apply the attached patch please? Thanks -Stuart clouds.tar.gz Description: GNU Zip compressed data -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] METAR interpolation?
You're right. That's why I have implemented quickly a smooth changement precipitations. I think that the changement should be refactoring. Mostly for wind... Regards, Le vendredi 19 décembre 2008 à 14:35 -0600, Curtis Olson a écrit : I just did a cross country flight with the latest CVS cloud/weather/metar changes and I noticed that the weather interpolation that smoothed out abrubt changes to wind and clouds when a new METAR report comes in seems to have now been lost. We are back to abrubt wind and cloud changes. I haven't had a chance to dig in myself, but thought I'd mention this to the folks that currently have their heads immersed in that section of the code. Regards, Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Nicolas VIVIEN -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] METAR interpolation?
I just did a cross country flight with the latest CVS cloud/weather/metar changes and I noticed that the weather interpolation that smoothed out abrubt changes to wind and clouds when a new METAR report comes in seems to have now been lost. We are back to abrubt wind and cloud changes. I haven't had a chance to dig in myself, but thought I'd mention this to the folks that currently have their heads immersed in that section of the code. Regards, Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] METAR interpolation?
Curt wrote:
I just did a cross country flight with the latest CVS cloud/weather/metar
changes and I noticed that the weather interpolation that smoothed out
abrubt changes to wind and clouds when a new METAR report comes
in seems to have now been lost. We are back to abrubt wind and cloud
changes. I haven't had a chance to dig in myself, but thought I'd mention
this to the folks that currently have their heads immersed in that section of
the code.
Thanks for the bug report.
The culprit as you guessed is some of the 3D cloud changes. The attached patch
reverts one of my changes which ensured that the 3D clouds were updated with
METAR. Unfortunately this had the side-effect of over-writing the environment
properties, and therefore nuking the interpolation work.
The patch below backs out that change. Unfortunately this means the change
to the cloud coverage due to changing METAR will not be reflected in the 3D
clouds
(2D clouds are unaffected). Unfortunately I don't think it will be possible to
fix
this before the release.
Could someone please commit this? Thanks.
-Stuart
Index: environment_ctrl.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/Environment/environment_ctrl.cxx,v
retrieving revision 1.58
diff -u -p -r1.58 environment_ctrl.cxx
--- environment_ctrl.cxx19 Dec 2008 07:42:13 -1.58
+++ environment_ctrl.cxx19 Dec 2008 22:36:48 -
@@ -502,7 +502,6 @@ FGMetarEnvironmentCtrl::update_env_confi
double aircraft_alt = fgGetDouble(/position/altitude-ft);
char s[128];
int i;
-bool rebuild_clouds = false;
for (i = 0, layer = layers.begin(); layer != layers_end; ++layer, i++)
{
double currentval;
@@ -520,7 +519,6 @@ FGMetarEnvironmentCtrl::update_env_confi
const char* coverage = (*layer)-getStringValue(coverage,
clear);
if (strncmp(fgGetString(s), coverage, 128) != 0) {
fgSetString(s, coverage);
-rebuild_clouds = true;
}
snprintf(s, 128, cl, i);
@@ -570,10 +568,6 @@ FGMetarEnvironmentCtrl::update_env_confi
}
}
-if (rebuild_clouds) {
-// Force an update of the 3D clouds
-fgSetDouble(/environment/rebuild-layers, 1.0);
-}
} else {
// We haven't already loaded a METAR, so apply it immediately.
dir_from = fgGetDouble(/environment/metar/base-wind-range-from);
--
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] METAR interpolation?
On Fri, Dec 19, 2008 at 11:38 PM, Stuart Buchanan stuart_d_bucha...@yahoo.co.uk wrote: The patch below backs out that change. Unfortunately this means the change to the cloud coverage due to changing METAR will not be reflected in the 3D clouds (2D clouds are unaffected). Unfortunately I don't think it will be possible to fix this before the release. I personally consider that a show-stopper (unless we disable 3d clouds in the release). -- Csaba/Jester -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] METAR interpolation?
Csaba wrote: On Fri, Dec 19, 2008 at 11:38 PM, Stuart Buchanan wrote: The patch below backs out that change. Unfortunately this means the change to the cloud coverage due to changing METAR will not be reflected in the 3D clouds (2D clouds are unaffected). Unfortunately I don't think it will be possible to fix this before the release. I personally consider that a show-stopper (unless we disable 3d clouds in the release). Just to be clear: a) The patch I provided fixes METAR interpolation. b) However, it means that 3D clouds are not completely interpolated. A change in cloudbase will be interpolated (quite nicely). However, a change in cloud coverage (including the removing or adding of layers) will _not_ have any effect. I agree that its bad. Unfortunately I don't have time to fix it this weekend before the release. If someone else wants to look, the place to start is the fgclouds.cxx code, in particular update_metar_properties() and update_env_config(). There is currently a split between fgclouds and the environment manager setting up these properties. -Stuart -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] METAR interpolation?
On Fri, 2008-12-19 at 23:30 +, Stuart Buchanan wrote: Csaba wrote: On Fri, Dec 19, 2008 at 11:38 PM, Stuart Buchanan wrote: The patch below backs out that change. Unfortunately this means the change to the cloud coverage due to changing METAR will not be reflected in the 3D clouds (2D clouds are unaffected). Unfortunately I don't think it will be possible to fix this before the release. I personally consider that a show-stopper (unless we disable 3d clouds in the release). Just to be clear: a) The patch I provided fixes METAR interpolation. b) However, it means that 3D clouds are not completely interpolated. A change in cloudbase will be interpolated (quite nicely). However, a change in cloud coverage (including the removing or adding of layers) will _not_ have any effect. I agree that its bad. Unfortunately I don't have time to fix it this weekend before the release. If someone else wants to look, the place to start is the fgclouds.cxx code, in particular update_metar_properties() and update_env_config(). There is currently a split between fgclouds and the environment manager setting up these properties. -Stuart I agree with Jester, I'd rather have fully functional 3D clouds in the release and fix the METAR Interpolation later. Ron -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
