Re: [Flightgear-devel] Small Bug in COM1 (Cessna C-172)?

2006-11-02 Thread Steve Hosgood
Steve Hosgood wrote:

>So it's doing something like "intfreq = (int)real_kHz * 100;" or 
>"intfreq = (int)(real_kHz * 100.0);"
>
>  
>
Let's just catch my own bug before everyone else does :-)
It's the second of those options of course.

Steve

-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Small Bug in COM1 (Cessna C-172)?

2006-11-02 Thread Steve Hosgood
Torsten Dreyer wrote:

>There seems to be a float/rounding issue somewhere in the property system. I 
>noticed this too, when modeling the Seneca. I did some debugging and found 
>that some values - probably 911.00 is one of these - are converted to a float 
>of 910.9 so the display shows 910.99. Same with 700 
>(shows 699.99) 710 (shows 709.99) etc.
>
>  
>
Hmm - that's interesting. If the value had been stored as a float (or 
double) and printed with (say) %6.2f it should have been rounded off 
correctly. I suspect therefore that the radio display code has converted 
this value to an integer in 10Hz steps and failed to do its own rounding.

So it's doing something like "intfreq = (int)real_kHz * 100;" or 
"intfreq = (int)(real_kHz * 100.0);"

If real_kHz had been 910.99 as suggested, this would give 91099 as 
"intfreq" and yield the reported effect.

What *should* have been done would be more like "intfreq = 
(int)(real_kHz + 0.005) * 100;"

>You can work around this issue by entering 911.001. But I think this is a bug 
>that should be fixed. I try to look into this again in the next week.
>
>Torsten
>  
>

Hopefully, there's a clue or two above! I'd look for it myself, but 
don't have a set of sources on this machine.
Steve.


-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Small Bug in COM1 (Cessna C-172)?

2006-11-02 Thread Holger Wirtz
Torsten,

On Thu, Nov 02, 2006 at 11:49:24AM +0100, Torsten Dreyer wrote:
> There seems to be a float/rounding issue somewhere in the property system. I 
> noticed this too, when modeling the Seneca. I did some debugging and found 
> that some values - probably 911.00 is one of these - are converted to a float 
> of 910.9 so the display shows 910.99. Same with 700 
> (shows 699.99) 710 (shows 709.99) etc.
> 
> You can work around this issue by entering 911.001. But I think this is a bug 
> that should be fixed. I try to look into this again in the next week.

Great! It seems only to be a bug in the visualisation inside the COM1
(perhaps also in the NAVs?). The values in the property tree are the
right ones.

Holger

> 
> Torsten
> 
> Am Donnerstag, 2. November 2006 11:16 schrieb Holger Wirtz:
> > Hi,
> >
> > I don't know if this really an error and if this is known...
> >
> > When I use the menu for setting the radio frequncies and write "911.00"
> > in the standby field I get on the display in the cockpit 910.99. In the
> > properties the right frequency (911.00) is submitted. Only in the
> > cockpit there is the wrong one.
> >
> > Ok - I know that 911.00 Mhz is not an official frequency...
> >
> > Regards, Holger
> 
> -- 
> 
> Herzlichen Gruß
> 
> Torsten Dreyer
> 
> -
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> ___
> Flightgear-devel mailing list
> Flightgear-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/flightgear-devel

-- 
#   ##  ##   Holger Wirtz Phone : (+49 30) 884299-40
##  ## ##   ### ##   DFN-Verein   Fax   : (+49 30) 884299-70
##  ##  ##   Stresemannstr. 78E-Mail: [EMAIL PROTECTED]
##  ## ##   ## ###   10963 Berlin
#  ##   ##  ##   GERMANY  WWW   : http://www.dfn.de
GPG-Fingerprint: ABFA 1F51 DD8D 503C 85DC  0C51 E961 79E2 6685 9BCF

-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Small Bug in COM1 (Cessna C-172)?

2006-11-02 Thread Torsten Dreyer
There seems to be a float/rounding issue somewhere in the property system. I 
noticed this too, when modeling the Seneca. I did some debugging and found 
that some values - probably 911.00 is one of these - are converted to a float 
of 910.9 so the display shows 910.99. Same with 700 
(shows 699.99) 710 (shows 709.99) etc.

You can work around this issue by entering 911.001. But I think this is a bug 
that should be fixed. I try to look into this again in the next week.

Torsten

Am Donnerstag, 2. November 2006 11:16 schrieb Holger Wirtz:
> Hi,
>
> I don't know if this really an error and if this is known...
>
> When I use the menu for setting the radio frequncies and write "911.00"
> in the standby field I get on the display in the cockpit 910.99. In the
> properties the right frequency (911.00) is submitted. Only in the
> cockpit there is the wrong one.
>
> Ok - I know that 911.00 Mhz is not an official frequency...
>
> Regards, Holger

-- 

Herzlichen Gruß

Torsten Dreyer

-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


[Flightgear-devel] Small Bug in COM1 (Cessna C-172)?

2006-11-02 Thread Holger Wirtz
Hi,

I don't know if this really an error and if this is known...

When I use the menu for setting the radio frequncies and write "911.00"
in the standby field I get on the display in the cockpit 910.99. In the
properties the right frequency (911.00) is submitted. Only in the
cockpit there is the wrong one.

Ok - I know that 911.00 Mhz is not an official frequency...

Regards, Holger
-- 
#   ##  ##   Holger Wirtz Phone : (+49 30) 884299-40
##  ## ##   ### ##   DFN-Verein   Fax   : (+49 30) 884299-70
##  ##  ##   Stresemannstr. 78E-Mail: [EMAIL PROTECTED]
##  ## ##   ## ###   10963 Berlin
#  ##   ##  ##   GERMANY  WWW   : http://www.dfn.de
GPG-Fingerprint: ABFA 1F51 DD8D 503C 85DC  0C51 E961 79E2 6685 9BCF

-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel