Re: [Flightgear-devel] flightgear merge request #14 and airportinfo()/navinfo()

2011-12-13 Thread Arnt Karlsen
On Tue, 13 Dec 2011 19:53:07 +1100, Scott wrote in message 
<1323766387.24670.6.ca...@goat.planetscott.net>:

> Greetings all,
> 
>After a number of discussions on the forums and e.mails I've put a
> patch together that extends the nasal interfaces for airportinfo() and
> navinfo(). 

..these can be used to "open closed airports"???  8o)

> As the patch outlines these are backward compatible, they
> only look for optional extra parameters, otherwise existing nasal code
> works as before.


-- 
..med vennlig hilsen = with Kind Regards from Arnt Karlsen
...with a number of polar bear hunters in his ancestry...
  Scenarios always come in sets of three: 
  best case, worst case, and just in case.

--
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] flightgear merge request #14 and airportinfo()/navinfo()

2011-12-13 Thread Csaba Halász
On Tue, Dec 13, 2011 at 9:53 AM, Scott  wrote:
>
>   Could someone have a look at
>
> https://gitorious.org/fg/flightgear/merge_requests/14
>
>   and review.

>From a quick glance, you create a hash unnecessarily on line 744:
naRef reply = naNewHash(c);
It's either overwritten or discarded later.

-- 
Csaba/Jester

--
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


[Flightgear-devel] flightgear merge request #14 and airportinfo()/navinfo()

2011-12-13 Thread Scott
Greetings all,

   After a number of discussions on the forums and e.mails I've put a
patch together that extends the nasal interfaces for airportinfo() and
navinfo(). As the patch outlines these are backward compatible, they
only look for optional extra parameters, otherwise existing nasal code
works as before.

   Could someone have a look at 

https://gitorious.org/fg/flightgear/merge_requests/14

   and review.  While it doesn't support all use cases that I had wanted
(because some parts of the API for the nav info I couldn't work out) it
does help extend those two functions, primarily to help FMS/FMC glass
cockpit builders.



   Many thanks
  S.



--
Systems Optimization Self Assessment
Improve efficiency and utilization of IT resources. Drive out cost and 
improve service delivery. Take 5 minutes to use this Systems Optimization 
Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel