Re: [Flightgear-devel] patch: don't warn if a sound is clipped, was Re: For the - Author of Concorde - Continued (Email in Unicode format)
Hi Curt, Curtis Olson schrieb am 29.05.2007 16:23: On 5/29/07, *Erik Hofman* wrote: Maik Justus wrote: Hi, the enclosed patch would do the thing (but maybe SG_DEBUG would be better, it's really only a debug message, the user need not to be warned about this). Indeed and that's what the warning is for; the author should fix the sound configuration file. Hi Maik, I do see your point, these scrolling warnings slow down FlightGear and are annoying. But I'm more with Erik on this one. These warnings indicate there is a serious problem in how the author configured the sound effects for their model and they are not getting the audio output that they expected. Ideally the aircraft author would fix the sound effects configuration so the results are in the allowable range. Curt. I agree that fixing of the sound-configuration would be the best. But this message is not a bug neither critical. The program will continue without any trouble. And I would like to have some more messages to be removed in the release. It's ok to have all these messages switched on in the development, but not in the release. Maybe we can add a new --warning-level=devel for all these messages being displayed on the console now. Think of msfs. What would the user think, if he would get messages like these on the console: ←[36m** FDM initialized **←[m prepare_ground_cache(): trying to build cache without any scenery below the airc raft Failed to untie property /consumables/fuel/tank[0]/level-gal_us Failed to untie property /consumables/fuel/tank[1]/level-gal_us FGMultiplayMgr::MP_ProcessData: No such file or directory Unknown animation type pick Unknown animation type pick Unknown animation type pick Unknown animation type pick Unknown animation type pick Unknown animation type pick None of these messages are necessary for the normal user, but all can confuse him. Maik - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] patch: don't warn if a sound is clipped, was Re: For the - Author of Concorde - Continued (Email in Unicode format)
Hi, I just got aware, that I am running flightgear with log-level=warn (I thought I am using the default setting, thanks to Melchior). Therefore all (or most of) these messages are not displayed by default. Sorry for the noise. Maik Maik Justus schrieb am 31.05.2007 23:05: Hi Curt, Curtis Olson schrieb am 29.05.2007 16:23: On 5/29/07, *Erik Hofman* wrote: Maik Justus wrote: Hi, the enclosed patch would do the thing (but maybe SG_DEBUG would be better, it's really only a debug message, the user need not to be warned about this). Indeed and that's what the warning is for; the author should fix the sound configuration file. Hi Maik, I do see your point, these scrolling warnings slow down FlightGear and are annoying. But I'm more with Erik on this one. These warnings indicate there is a serious problem in how the author configured the sound effects for their model and they are not getting the audio output that they expected. Ideally the aircraft author would fix the sound effects configuration so the results are in the allowable range. Curt. I agree that fixing of the sound-configuration would be the best. But this message is not a bug neither critical. The program will continue without any trouble. And I would like to have some more messages to be removed in the release. It's ok to have all these messages switched on in the development, but not in the release. Maybe we can add a new --warning-level=devel for all these messages being displayed on the console now. Think of msfs. What would the user think, if he would get messages like these on the console: ←[36m** FDM initialized **←[m prepare_ground_cache(): trying to build cache without any scenery below the airc raft Failed to untie property /consumables/fuel/tank[0]/level-gal_us Failed to untie property /consumables/fuel/tank[1]/level-gal_us FGMultiplayMgr::MP_ProcessData: No such file or directory Unknown animation type pick Unknown animation type pick Unknown animation type pick Unknown animation type pick Unknown animation type pick Unknown animation type pick None of these messages are necessary for the normal user, but all can confuse him. Maik - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] patch: don't warn if a sound is clipped, was Re: For the - Author of Concorde - Continued (Email in Unicode format)
Maik Justus wrote: Hi, the enclosed patch would do the thing (but maybe SG_DEBUG would be better, it's really only a debug message, the user need not to be warned about this). Indeed and that's what the warning is for; the author should fix the sound configuration file. Erik - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] patch: don't warn if a sound is clipped, was Re: For the - Author of Concorde - Continued (Email in Unicode format)
On 5/29/07, Erik Hofman wrote: Maik Justus wrote: Hi, the enclosed patch would do the thing (but maybe SG_DEBUG would be better, it's really only a debug message, the user need not to be warned about this). Indeed and that's what the warning is for; the author should fix the sound configuration file. Hi Maik, I do see your point, these scrolling warnings slow down FlightGear and are annoying. But I'm more with Erik on this one. These warnings indicate there is a serious problem in how the author configured the sound effects for their model and they are not getting the audio output that they expected. Ideally the aircraft author would fix the sound effects configuration so the results are in the allowable range. Curt. -- Curtis Olson - University of Minnesota - FlightGear Project http://baron.flightgear.org/~curt/ http://www.humanfirst.umn.edu/ http://www.flightgear.org Unique text: 2f585eeea02e2c79d7b1d8c4963bae2d - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] patch: don't warn if a sound is clipped, was Re: For the - Author of Concorde - Continued (Email in Unicode format)
Hi,
the enclosed patch would do the thing (but maybe SG_DEBUG would be
better, it's really only a debug message, the user need not to be warned
about this).
Please commit.
Maik
Maik Justus schrieb am 28.05.2007 21:49:
Hi,
these messages are no real error messages, just warnings, but I think
Volume larger than 1.0 in configuration for '***', clipping.
should be at a warning-level, which is not displayed by default, because
it is not a real error (it is clipped and does not harm).
Maik
? sound.diff
Index: xmlsound.cxx
===
RCS file: /var/cvs/SimGear-0.3/source/simgear/sound/xmlsound.cxx,v
retrieving revision 1.19
diff -u -p -r1.19 xmlsound.cxx
--- xmlsound.cxx30 Jul 2006 21:02:36 - 1.19
+++ xmlsound.cxx28 May 2007 21:36:25 -
@@ -428,7 +428,7 @@ SGXmlSound::update (double dt)
if ((volume_offset + volume ) 1.0)
{
_sample-set_volume( 1.0 );
- SG_LOG(SG_GENERAL, SG_WARN,
+ SG_LOG(SG_GENERAL, SG_INFO,
Volume larger than 1.0 in configuration for ' _name
', clipping.);
} else
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
