Re: [fltk.development] [RFE] STR #2942: Buttons keep the same color when clicked

2013-04-01 Thread Greg Ercolano

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2942
Version: 1.3-feature


Hmm, doesn't that patch take /away/ the current control
an app has over the button pushed color via selection_color()?

selection_color() can be changed by the app to control what color
a button is when it's pressed, and the patch seems to comment that out
and replace it with the fl_darker() algorithm. Seems like a step away
from what we want.

Perhaps Albrecht's comments are more to do specifically with the
theme code not taking into account the current selection_color(),
as opposed to Fl_Button's existing default draw code..?


Link: http://www.fltk.org/str.php?L2942
Version: 1.3-feature

___
fltk-dev mailing list
fltk-dev@easysw.com
http://lists.easysw.com/mailman/listinfo/fltk-dev


Re: [fltk.development] [RFE] STR #2942: Buttons keep the same color when clicked

2013-04-01 Thread Albrecht Schlosser

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2942
Version: 1.3-feature


Yes, indeed, I hadn't looked at the code and thus missed that
selection_color() bit. Edmanuel, I apologize for the confusion...

So, if it's in the user's control (via selection_color()) then we should
NOT use this patch.

Any objections to closing *this* STR ?


Link: http://www.fltk.org/str.php?L2942
Version: 1.3-feature

___
fltk-dev mailing list
fltk-dev@easysw.com
http://lists.easysw.com/mailman/listinfo/fltk-dev


Re: [fltk.development] [RFE] STR #2942: Buttons keep the same color when clicked

2013-04-01 Thread Edmanuel Torres

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2942
Version: 1.3-feature


Thanks for your analysis, I think this patch should be closed. However, I
will use it until a better one is out.


Link: http://www.fltk.org/str.php?L2942
Version: 1.3-feature

___
fltk-dev mailing list
fltk-dev@easysw.com
http://lists.easysw.com/mailman/listinfo/fltk-dev