[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #16 from Kevin Fenzi 2010-10-16 17:14:52 EDT --- Git done (by process-git-requests). There is already a f14 branch, so only did the EL-6 one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 René Ribaud changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #15 from René Ribaud 2010-10-16 08:05:10 EDT --- Package Change Request == Package Name: kanjistrokeorders-fonts New Branches: F14 EL6 Owners: uggla -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Fedora Update System changed: What|Removed |Added Fixed In Version|kanjistrokeorders-fonts-2.0 |kanjistrokeorders-fonts-2.0 |14-4.fc13 |14-4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #14 from Fedora Update System 2010-05-24 15:44:17 EDT --- kanjistrokeorders-fonts-2.014-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||kanjistrokeorders-fonts-2.0 ||14-4.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #13 from Fedora Update System 2010-05-24 15:38:33 EDT --- kanjistrokeorders-fonts-2.014-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #11 from Fedora Update System 2010-05-21 14:58:27 EDT --- kanjistrokeorders-fonts-2.014-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kanjistrokeorders-fonts-2.014-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #12 from Fedora Update System 2010-05-21 14:58:32 EDT --- kanjistrokeorders-fonts-2.014-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kanjistrokeorders-fonts-2.014-4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Dennis Gilmore 2010-05-18 14:40:23 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 René Ribaud changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from René Ribaud 2010-05-14 06:46:56 EDT --- New Package CVS Request === Package Name: kanjistrokeorders-fonts Short Description: Font to view stroke order diagrams for Kanji, Kana and etc... Owners: uggla Branches: F-12 F-13 EL-5 InitialCC: fonts-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #8 from René Ribaud 2010-05-14 06:41:35 EDT --- Parag, thank you very much. Best regards. René -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Parag AN(पराग) changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) 2010-05-14 06:11:54 EDT --- APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #6 from René Ribaud 2010-05-13 14:03:22 EDT --- I have just forgotten to paste the Koji URL in the above msg... You can look at the F12 result here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186156 F13 here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186166 and F14 here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186173 Best regards. René. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579369
--- Comment #5 from René Ribaud 2010-05-13 13:58:48 EDT
---
Hi Parag,
Thanks for the review, I have fixed the package.
> Suggestions:
> 1) remove following comments from SPEC
> #ln -s /dev/null \
> # %{buildroot}%{_fontconfig_confdir}/%{fontconf}
Removed
>
> 2) Give newline after each changelog entry and also between BuildRequires:
> line
> and %description line
>
Done
> 3) Instead of adding BuildRequires: dos2unix, you can do following in %prep.
> ==
> for file in copyright.txt readme_en_v2.014.txt; do
> sed "s|\r||g" $file > $file.new && \
> touch -r $file $file.new && \
> mv $file.new $file
> done
> ===
>
> This will help not to increase build time dependency on dos2unix package.
Done, I used "sed -i" instead of dos2unix.
Anyway we will find the updated package here :
Spec URL: http://uggla.free.fr/rpmbuild/SPECS/kanjistrokeorders-fonts.spec
SRPM URL:
http://uggla.free.fr/rpmbuild/SRPMS/12/kanjistrokeorders-fonts-2.014-4.fc12.src.rpm
RPMLINT output :
[...@uggla SRPMS]$ rpmlint kanjistrokeorders-fonts-2.014-4.fc12.src.rpm
kanjistrokeorders-fonts.src: W: spelling-error %description -l en_US kanji ->
Kantian, Kanpur, Kansas
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[...@uggla noarch]$ rpmlint kanjistrokeorders-fonts-2.014-4.fc12.noarch.rpm
kanjistrokeorders-fonts.noarch: W: spelling-error %description -l en_US kanji
-> Kantian, Kanpur, Kansas
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
KOJI output :
-
I have built the package with koji on all architectures for F12, F13 and
rawhide.
You can look at the F12 result here :
http://koji.fedoraproject.org/koji/taskinfo?taskID=2186156
F13 here :
and F14 here :
Waiting for your feedbacks.
Best regards.
René
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
fonts-bugs mailing list
fonts-bugs@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579369
--- Comment #4 from Parag AN(पराग) 2010-05-07 06:28:41 EDT
---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2171526
+ rpmlint is silent for SRPM and for RPM.
kanjistrokeorders-fonts.src: W: spelling-error %description -l en_US kanji ->
Kantian, Kanpur, Kansas
kanjistrokeorders-fonts.noarch: W: spelling-error %description -l en_US kanji
-> Kantian, Kanpur, Kansas
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
+ source files match upstream url (sha1sum)
ba3a6a7904431c0969f196d2b2915ef6c87cff47 KanjiStrokeOrders_v2.014.zip
there is no direct download url working using wget though.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Follow fonts packaging guidelines.
Suggestions:
1) remove following comments from SPEC
#ln -s /dev/null \
# %{buildroot}%{_fontconfig_confdir}/%{fontconf}
2) Give newline after each changelog entry and also between BuildRequires: line
and %description line
3) Instead of adding BuildRequires: dos2unix, you can do following in %prep.
==
for file in copyright.txt readme_en_v2.014.txt; do
sed "s|\r||g" $file > $file.new && \
touch -r $file $file.new && \
mv $file.new $file
done
===
This will help not to increase build time dependency on dos2unix package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
fonts-bugs mailing list
fonts-bugs@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #3 from René Ribaud 2010-05-06 14:06:02 EDT --- Hi Parag, First thanks to assigned you this review. No worries, I can wait. This package is not an urgent one, so just take all the time you need. Best regards. René. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #2 from Parag AN(पराग) 2010-05-06 09:26:40 EDT --- sorry I am busy with some other work. Will review this tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #1 from Mamoru Tasaka 2010-04-04 13:56:29 EDT --- (Removing NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 Mamoru Tasaka changed: What|Removed |Added CC||fonts-b...@lists.fedoraproj ||ect.org, ||mtas...@ioa.s.u-tokyo.ac.jp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ fonts-bugs mailing list fonts-bugs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
