DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-09-18 17:48 --- I have applied this patch. Thanks, Peter, for the contribution. Here are some comments: 1. I'm not going to pretend to understand all of what is going on in the code, but the testing I did, and the limited code review I did generally looked good. 2. There were quite a few style issues in the submitted code. This is understandable, as I assume that you were trying to take preexisting code and submit it intact, so I checked it in that way (mostly), then made an additional commit to fix the easy style changes. In case you are not familiar with the FOP style requirements, please see: http://xml.apache.org/fop/dev/conventions.html The unresolved style issues mostly are variable names and javadoc comments that are missing or incomplete. Please address these at your earliest convenience. (The remainder of FOP code still has quite a few such things to do as well). 3. It took me quite a while to apply the patch because there was an intervening patch. Patching patches confuses the automated patch command. We will probably actually make faster progress if you wait to submit the subsequent patch until after the earlier patch is applied. I know this isn't always practical, but I thought it worth mentioning. 4. It looks like a change that I made to background color has disappeared. I think I had reset that and other attributes automatically at the beginning of a paragraph. IIRC, RTF treats these things sequentially, i.e. if changed, the change remains effective until changed again. FO tends to work more on chunks (blocks, inlines), having attributes, and assuming that each chunk is reset to some default value (e.g. white background, parent value, etc.) when the chunk is completed. If you want to see an example, run examples/fo/basic/normal.fo, where the title should have a background color of blue, but in fact, all subsequent text does as well. Thanks for all of your efforts here. Please let us know if there are things we can do to help.
DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table --- Additional Comments From [EMAIL PROTECTED] 2003-09-14 22:07 --- Created an attachment (id=8214) RtfTable: method getHeaderAttribs added
DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table --- Additional Comments From [EMAIL PROTECTED] 2003-09-14 22:08 --- Created an attachment (id=8215) TableBody: call of startBody/endBody added
DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table --- Additional Comments From [EMAIL PROTECTED] 2003-09-14 22:09 --- Created an attachment (id=8216) BuilderContext: new module
DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table --- Additional Comments From [EMAIL PROTECTED] 2003-09-14 22:09 --- Created an attachment (id=8217) FoUnitsConverter: new module
DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table --- Additional Comments From [EMAIL PROTECTED] 2003-09-14 22:10 --- Created an attachment (id=8218) TableAttributesConverter: new module
DO NOT REPLY [Bug 23166] - [PATCH] RTF: support for fo:table
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23166 [PATCH] RTF: support for fo:table --- Additional Comments From [EMAIL PROTECTED] 2003-09-14 22:10 --- Created an attachment (id=8219) TableContext: new module
