Re: RendererFactory - hardcoded list of RendererMakers
On Feb 24, 2006, at 03:51, Nils Meier wrote: Hi Nils, Just noticed this one has gone unanswered so far... snip / Applied patch adds the dynamic lookup in the factory and the necessary service definition file residing in META-INF. I kind of liked this idea, but would prefer to use FOP's own org.apache.fop.util.Service for that. see commit: http://svn.apache.org/viewcvs?rev=383384view=rev Cheers, Andreas
Re: svn commit: r379883 - /xmlgraphics/fop/branches/Temp_API_Finalization/examples/embedding/java/embedding/ExampleFO2PDF.java
On Thu, Feb 23, 2006 at 10:03:29PM +0100, Simon Pepping wrote: On Wed, Feb 22, 2006 at 10:22:39PM +0100, Jeremias Maerki wrote: On 22.02.2006 21:55:36 Simon Pepping wrote: Would it not be nicer to have a constructor that takes the output stream as an argument? If this is preferred, no objections. However, not all output formats take an OutputStream which means an increase of factory methods. For those formats that do require an OutputStream the created object is inconsistent, and one is only notified at runtime. The presence of another factory method at least suggests that it under some circumstances it may be necessary to create the object with an OutputStream. Added the methods. As you see from my example, I prefer early testing of the consistency of the Fop object. Regards, Simon -- Simon Pepping home page: http://www.leverkruid.nl
Test errors in API finalization branch [Re: svn commit: r383398 - in /xmlgraphics/fop/branches/Temp_API_Finalization: examples/embedding/java/embedding/MultipleFO2PDF.java src/java/org/apache/fop/apps
I am getting two test errors in the FOTreeTestSuite in the API finalization branch, on page-dimension_auto_fallback.fo and page-dimension_both_indefinite.fo. Because I also get them without my changes, I committed anyway. Regards, Simon On Sun, Mar 05, 2006 at 08:47:02PM -, [EMAIL PROTECTED] wrote: Author: spepping Date: Sun Mar 5 12:47:00 2006 New Revision: 383398 URL: http://svn.apache.org/viewcvs?rev=383398view=rev Log: Add Fop constructor and corresponding FopFactory methods with an output stream. Adapt MultipleFO2PDF example. Modified: xmlgraphics/fop/branches/Temp_API_Finalization/examples/embedding/java/embedding/MultipleFO2PDF.java xmlgraphics/fop/branches/Temp_API_Finalization/src/java/org/apache/fop/apps/Fop.java xmlgraphics/fop/branches/Temp_API_Finalization/src/java/org/apache/fop/apps/FopFactory.java -- Simon Pepping home page: http://www.leverkruid.nl
Re: RendererFactory - hardcoded list of RendererMakers
On Mar 5, 2006, at 20:52, Andreas L Delmelle wrote:
On Feb 24, 2006, at 03:51, Nils Meier wrote:
Hi Nils,
Just noticed this one has gone unanswered so far...
snip /
Applied patch adds the dynamic lookup in the
factory and the necessary service definition file
residing in META-INF.
I kind of liked this idea, but would prefer to use FOP's own
org.apache.fop.util.Service for that.
see commit: http://svn.apache.org/viewcvs?rev=383384view=rev
BTW, any devs object to doing the same for *all* default
ElementMappings?
Index: src/java/META-INF/services/org.apache.fop.fo.ElementMapping
===
--- src/java/META-INF/services/org.apache.fop.fo.ElementMapping
(revision 0)
+++ src/java/META-INF/services/org.apache.fop.fo.ElementMapping
(revision 0)
@@ -0,0 +1,7 @@
+org.apache.fop.fo.FOElementMapping
+org.apache.fop.fo.extensions.svg.SVGElementMapping
+org.apache.fop.fo.extensions.svg.BatikExtensionElementMapping
+org.apache.fop.fo.extensions.ExtensionElementMapping
+org.apache.fop.fo.extensions.xmp.XMPElementMapping
+org.apache.fop.fo.extensions.xmp.RDFElementMapping
+org.apache.fop.render.ps.extensions.PSExtensionElementMapping
\ No newline at end of file
Index: src/java/org/apache/fop/fo/ElementMappingRegistry.java
===
--- src/java/org/apache/fop/fo/ElementMappingRegistry.java
(revision 382930)
+++ src/java/org/apache/fop/fo/ElementMappingRegistry.java
(working copy)
@@ -74,14 +74,6 @@
* Sets all the element and property list mappings to their
default values.
*/
private void setupDefaultMappings() {
-addElementMapping(org.apache.fop.fo.FOElementMapping);
-addElementMapping
(org.apache.fop.fo.extensions.svg.SVGElementMapping);
-addElementMapping
(org.apache.fop.fo.extensions.svg.BatikExtensionElementMapping);
-addElementMapping
(org.apache.fop.fo.extensions.ExtensionElementMapping);
-addElementMapping
(org.apache.fop.fo.extensions.xmp.XMPElementMapping);
-addElementMapping
(org.apache.fop.fo.extensions.xmp.RDFElementMapping);
-addElementMapping
(org.apache.fop.render.ps.extensions.PSExtensionElementMapping);
-
// add mappings from available services
Iterator providers = Service.providers(ElementMapping.class);
if (providers != null) {
Cheers,
Andreas
Bug report for Fop [2006/03/06]
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) |
| | +-+
| | | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| | | MIN=Minor NOR=Normal ENH=Enhancement |
| | | +-+
| | | | Date Posted |
| | | | +--+
| | | | | Description |
| | | | | |
| 953|Opn|Nor|2001-03-12|Incorrect hyperlinks area rendering in justified t|
| 1063|New|Nor|2001-03-21|fop does not handle large fo files|
| 1180|New|Maj|2001-04-02|Problem with monospaced font |
| 1859|Opn|Min|2001-05-22|org.apache.fop.apps.Driver.reset() doesn't fully r|
| 1998|New|Nor|2001-06-05|linefeed-treatment not understood |
| 2150|Ass|Maj|2001-06-13|New page with a table-header but without any tabl|
| 2475|Ass|Nor|2001-07-06|Borders don't appear to work in fo:table-row|
| 2740|New|Maj|2001-07-23|multi-page tables sometimes render badly |
| 2909|New|Maj|2001-07-30|Gradient render error |
| 2964|Ass|Nor|2001-08-02|problems with height of cells in tables |
| 2988|New|Maj|2001-08-03|0.19: list-item-label does not stick to list-item-|
| 3044|Ass|Maj|2001-08-08|keep-together not functioning |
| 3280|New|Nor|2001-08-27|PCL Renderer doesn't work |
| 3305|Opn|Nor|2001-08-28|list-block overlapping footnote body |
| 3497|New|Cri|2001-09-07|id already exists error when using span=all attr|
| 3824|New|Blk|2001-09-25|MIF option with tables|
| 4030|New|Nor|2001-10-08|IOException creating Postscript with graphics on S|
| 4126|New|Nor|2001-10-12|FontState.width() returns pts instead of millipts |
| 4226|New|Nor|2001-10-17|The orphans property doesn't seem to work |
| 4388|New|Nor|2001-10-24|Nullpointer exception in the construction of new D|
| 4415|New|Nor|2001-10-25|scaling=uniform does not work on images... |
| 4510|New|Nor|2001-10-30|fo:inline common properties ignored? |
| 4535|New|Maj|2001-10-31|PCL renderer 1.13 not rendering SVG |
| 4767|New|Nor|2001-11-09|SVG text is distored in PDF output|
| 5001|New|Nor|2001-11-21|content-width and content-height ignored? |
| 5010|New|Enh|2001-11-21|Better error reporting needed |
| 5124|New|Maj|2001-11-27|fo:block-container is not rendered properly using |
| 5335|Opn|Min|2001-12-10|Text with embedded CID fonts not retrievable from |
| 5655|Ass|Nor|2002-01-02|text-decoration cannot take multiple values |
| 6094|Opn|Maj|2002-01-29|0.20.3rc hangs in endless loop|
| 6237|Opn|Nor|2002-02-05|#xFB01 (fi ligature) produces a sharp? |
| 6305|New|Nor|2002-02-07|Using fo:table-and-caption results in empty output|
| 6427|New|Enh|2002-02-13|Adding additional Type 1 fonts problem|
| 6437|New|Maj|2002-02-13|Tables without fo:table-column don't render |
| 6483|New|Nor|2002-02-15|Table, Loop, footer could not fit on page, moving|
| 6844|New|Nor|2002-03-04|No line breaks inserted in list-item-label|
| 6918|New|Enh|2002-03-06|reference-orientation has no effect |
| 6997|New|Nor|2002-03-09|[PATCH] Row-spanned row data breaks over a page wi|
| 7140|New|Enh|2002-03-15|page-position attribute set to last on condition|
| 7241|New|Nor|2002-03-19|keep-with-previous, keep-with-next only working on|
| 7283|New|Nor|2002-03-20|Table border misaligned when using margin-left in |
| 7337|New|Nor|2002-03-21|border around external image leaves empty space |
| 7487|New|Nor|2002-03-26|break-before=page for table inserts empty page |
| 7496|New|Nor|2002-03-26|The table header borders are not adjusted to the b|
| 7525|New|Cri|2002-03-27|table with spans inside a list-block |
| 7919|New|Cri|2002-04-10|problem to use attribute linefeed-treatment and li|
| 8003|Ass|Maj|2002-04-12|FopImageFactory never releases cached images |
| 8050|New|Nor|2002-04-13|Soft hyphen (shy;) is not handled properly |
| 8321|New|Nor|2002-04-19|from-parent('width') returns 0 for nested tables |
| 8463|New|Nor|2002-04-24|SVG clipping in external.fo example doc when rende|
| 8767|Ass|Min|2002-05-03|Image and solid colour background rectangle sizes |
|
