DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

Simon Pepping spepp...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
 OS/Version||All

--- Comment #2 from Simon Pepping spepp...@apache.org 2010-12-09 04:01:53 EST 
---
Resolved in revision 1043871.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

--- Comment #3 from Simon Pepping spepp...@apache.org 2010-12-09 07:01:32 EST 
---
(In reply to comment #0)
 Apparently the KnuthElement's position is null (oldElement.getPosition()). I
 attached a patch which adds an additional check in order to avoid the
 exception. This might not be a real solution, because I'm not sure if it's
 valid that the position is null.

I spent some more time on the validity of a null position. Auxiliary positions
have null subposition, see InlineLayoutManager.getAuxiliaryPosition(), line:
597.

If a position is unwrapped often enough, this null position is reached. The
chosen solution, i.e. not unwrapping if the null position is reached, adds a
layer of wrapping around the null position, because later in the method all
positions are wrapped again. Apparently that is not a problem.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


FOP build

2010-12-09 Thread Eric Douglas
Is there a way to simplify FOP?  I have the 1.0 source.  I can run the
ant build and it creates a new jar.  Now I tried excluding a font class
I don't need, and it failed the build on a junit test.  I tried
commenting that test out and it failed a different test.  I excluded a
few tests and it succeeded but it didn't create the jar.  It should
still be executing that step which creates the jar.  I'm passing in
custom fonts so I'd like to be able to save some overhead by removing
all of those base 14 fonts.


Re: FOP build

2010-12-09 Thread Pascal Sancho
Hi,
Junit tests are for pre-commit purpose.
You can easily avoid them by running the right ant option:
 ant package.

see [1] for further info on running ant with fop.

[1] http://xmlgraphics.apache.org/fop/1.0/compiling.html#env-ant

Le 09/12/2010 14:08, Eric Douglas a écrit :
 Is there a way to simplify FOP?  I have the 1.0 source.  I can run the
 ant build and it creates a new jar.  Now I tried excluding a font class
 I don't need, and it failed the build on a junit test.  I tried
 commenting that test out and it failed a different test.  I excluded a
 few tests and it succeeded but it didn't create the jar.  It should
 still be executing that step which creates the jar.  I'm passing in
 custom fonts so I'd like to be able to save some overhead by removing
 all of those base 14 fonts.
 

--
pascal


DO NOT REPLY [Bug 35500] Missing .close() call on stream opened for JPEG images

2010-12-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=35500

--- Comment #2 from Andreas Gilmut andreasgil...@gmx.de 2010-12-09 11:23:19 
EST ---
The affected class is org.apache.fop.image.JpegImage. It is part of fop itself
in version 0.20.5.
In the method loadImage() the close call of inStream is missing.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


RE: FOP build

2010-12-09 Thread Eric Douglas
I tried commenting out the base 14 collection statement here and it created 
fop.jar but I've set it up differently than on my hone PC.
Here my ant build starts out telling me this.
 [echo] --- Apache FOP 1.0 [1999-2010] 
 [echo] See build.properties and build-local.properties for additional 
build settings
 [echo] Apache Ant version 1.7.1 compiled on June 27 2008
 [echo] VM: 14.3-b01, Sun Microsystems Inc.
 [echo] JAVA_HOME: ${env.JAVA_HOME}
 [echo] JAI Support PRESENT
 [echo] JCE Support PRESENT
 [echo] JUnit Support NOT Present - Committers are required to have JUnit 
working
 [echo] XMLUnit Support NOT Present - you can get it from 
http://xmlunit.sourceforge.net

On my home PC I believe it's saying JAI Support is not present, I'm not sure 
what that's looking for, but it says JUnit and XMLUnit support are present.  I 
can test again to let you know exactly what it complains about when JUnit is 
working but the fop.jar stops getting updated if you have the JUnit and just 
comment out this one line.

package org.apache.fop.render;
...
public abstract class PrintRenderer extends AbstractRenderer
...
public void setupFontInfo(FontInfo inFontInfo) throws FOPException {
this.fontInfo = inFontInfo;
FontManager fontManager = userAgent.getFactory().getFontManager();
FontCollection[] fontCollections = new FontCollection[] {
//new 
Base14FontCollection(fontManager.isBase14KerningEnabled()),
new CustomFontCollection(getFontResolver(), getFontList())
};
fontManager.setup(getFontInfo(), fontCollections);
}

For my purpose I shouldn't need any code referencing the base 14 fonts.  I'm 
passing in custom fonts.  I assume CustomFontCollection here will handle that.

-Original Message-
From: Pascal Sancho [mailto:pascal.san...@takoma.fr] 
Sent: Thursday, December 09, 2010 8:28 AM
To: fop-dev@xmlgraphics.apache.org
Subject: Re: FOP build

Hi,
Junit tests are for pre-commit purpose.
You can easily avoid them by running the right ant option:
 ant package.

see [1] for further info on running ant with fop.

[1] http://xmlgraphics.apache.org/fop/1.0/compiling.html#env-ant

Le 09/12/2010 14:08, Eric Douglas a écrit :
 Is there a way to simplify FOP?  I have the 1.0 source.  I can run the 
 ant build and it creates a new jar.  Now I tried excluding a font 
 class I don't need, and it failed the build on a junit test.  I tried 
 commenting that test out and it failed a different test.  I excluded a 
 few tests and it succeeded but it didn't create the jar.  It should 
 still be executing that step which creates the jar.  I'm passing in 
 custom fonts so I'd like to be able to save some overhead by removing 
 all of those base 14 fonts.
 

--
pascal