[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #14 from Glenn Adams gad...@apache.org ---
(In reply to comment #13)
 (In reply to comment #10)
  (In reply to comment #6)
   The first 3 lines of generated PDF from you give a near correct look.
   The problem is at character 26, Mai-Ek.
   It ship too far to the left.
  
  I understand. I will investigate this further.
  
   I have few questions regarding to your output.
   I changed my fo:block element removing all attribute except font-family.
   My result is different from what you got.
   It is look similar to the second line in first jpg attachment.
   Why the different ?
  
  That's hard to say. I am using FOP1.1rc1 and Version 5.0 of the AngsanaUPC
  font (from Windows 7). If you are using different versions, then that could
  cause the difference.
  
 I'm using AngsanaUPC 5.0 from Windows 7 SP1 64 bits [Version 6.1.7601]
 I uses FOP from SVN trunk, checked out today.

Hmmm. Strange. Here is the config I am using (fop.xconf):

?xml version=1.0?
fop version=1.0
  use-cachefalse/use-cache
  base.//base
  strict-configurationtrue/strict-configuration
  renderers
renderer mime=application/pdf
  filterList
valueflate/value
  /filterList
  fonts
directory./fonts/directory
  /fonts
/renderer
  /renderers
/fop

I placed the angsanu.ttf file in a fonts directory in the directory that
contains this config. I turned of the font-cache to make sure it is using that
font.

Perhaps you might try this also?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #15 from na...@th.ibm.com ---
(In reply to comment #14)
 (In reply to comment #13)
  (In reply to comment #10)
   (In reply to comment #6)
The first 3 lines of generated PDF from you give a near correct look.
The problem is at character 26, Mai-Ek.
It ship too far to the left.
   
   I understand. I will investigate this further.
   
I have few questions regarding to your output.
I changed my fo:block element removing all attribute except font-family.
My result is different from what you got.
It is look similar to the second line in first jpg attachment.
Why the different ?
   
   That's hard to say. I am using FOP1.1rc1 and Version 5.0 of the AngsanaUPC
   font (from Windows 7). If you are using different versions, then that 
   could
   cause the difference.
   
  I'm using AngsanaUPC 5.0 from Windows 7 SP1 64 bits [Version 6.1.7601]
  I uses FOP from SVN trunk, checked out today.
 
 Hmmm. Strange. Here is the config I am using (fop.xconf):
 
 ?xml version=1.0?
 fop version=1.0
   use-cachefalse/use-cache
   base.//base
   strict-configurationtrue/strict-configuration
   renderers
 renderer mime=application/pdf
   filterList
   valueflate/value
   /filterList
   fonts
   directory./fonts/directory
   /fonts
 /renderer
   /renderers
 /fop
 
 I placed the angsanu.ttf file in a fonts directory in the directory that
 contains this config. I turned of the font-cache to make sure it is using
 that font.
 
 Perhaps you might try this also?

Tried it. Nothing change. I might forget to mention you that i embed FOP into
java application. I copied fop.xconf from FOP 1.0 directory and put it right
into my java project. The only section i changed is all those you mention
above.
Do i have to set anything other than that for embedded use ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51962] [PATCH] last simple-page-master not chosen when force-page-count=odd

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51962

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 CC|pascal.san...@takoma.fr |

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 48764] Wrong master when force-page-count is used

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48764

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #3 from Pascal Sancho psancho@gmail.com ---
well spotted, Matthias.
attached test case is now rendered as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53586] New: NPE being thrown when hyphenation is used

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53586

  Priority: P2
Bug ID: 53586
  Assignee: fop-dev@xmlgraphics.apache.org
   Summary: NPE being thrown when hyphenation is used
  Severity: normal
Classification: Unclassified
OS: Linux
  Reporter: med1...@gmail.com
  Hardware: PC
Status: NEW
   Version: 1.1dev
 Component: page-master/layout
   Product: Fop

Created attachment 29098
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29098action=edit
hyphenation NPE test case

An NPE is being thrown somewhere in the layout engine, a simplified FO has been
attached. This bug seems to be related to hyphenation being enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.


Re: svn commit: r1364567 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/ layoutmgr/inline/ pdf/ render/ render/intermediate/ render/ps/ util/

2012-07-23 Thread mehdi houshmand
Glenn,

Is it worth porting these javadoc amendments to the 1.1 branch? I don't
mind doing it if you'd like them in 1.1.

Mehdi

On 23 July 2012 11:21, me...@apache.org wrote:

 Author: mehdi
 Date: Mon Jul 23 10:21:23 2012
 New Revision: 1364567

 URL: http://svn.apache.org/viewvc?rev=1364567view=rev
 Log:
 Fixed all javadoc issues, ant javadocs now works without errors

 Modified:

 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/DefaultFontConfigurator.java
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontCache.java
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontManager.java

 xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java

 xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/StreamCacheFactory.java

 xmlgraphics/fop/trunk/src/java/org/apache/fop/render/AbstractRendererMaker.java

 xmlgraphics/fop/trunk/src/java/org/apache/fop/render/intermediate/IFDocumentHandlerConfigurator.java

 xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRendererOption.java
 xmlgraphics/fop/trunk/src/java/org/apache/fop/util/ColorSpaceCache.java

 Modified:
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/DefaultFontConfigurator.java
 URL:
 http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/DefaultFontConfigurator.java?rev=1364567r1=1364566r2=1364567view=diff

 ==
 ---
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/DefaultFontConfigurator.java
 (original)
 +++
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/DefaultFontConfigurator.java
 Mon Jul 23 10:21:23 2012
 @@ -52,7 +52,6 @@ public class DefaultFontConfigurator imp

  /**
   * Main constructor
 - * @param fontInfoConfig the configuration object
   * @param fontManager the font manager
   * @param listener the font event listener
   * @param strict true if an Exception should be thrown if an error is
 found.

 Modified:
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontCache.java
 URL:
 http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontCache.java?rev=1364567r1=1364566r2=1364567view=diff

 ==
 --- xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontCache.java
 (original)
 +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontCache.java Mon
 Jul 23 10:21:23 2012
 @@ -462,10 +462,9 @@ public final class FontCache implements
  }

  /**
 - * Retrieve the last modified date/time of a URL.
 + * Retrieve the last modified date/time of a URI.
   *
 - * @param url
 - *the URL
 + * @param uri the URI
   * @return the last modified date/time
   */
  public static long getLastModified(URI uri) {

 Modified:
 xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontManager.java
 URL:
 http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontManager.java?rev=1364567r1=1364566r2=1364567view=diff

 ==
 --- xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontManager.java
 (original)
 +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/FontManager.java
 Mon Jul 23 10:21:23 2012
 @@ -138,7 +138,6 @@ public class FontManager {

  /**
   * Whether or not to cache results of font triplet
 detection/auto-config
 - * @param useCache use cache or not
   */
  public void disableFontCache() {
  fontCacheManager = FontCacheManagerFactory.createDisabled();
 @@ -163,8 +162,7 @@ public class FontManager {

  /**
   * Deletes the current FontCache file
 - * @return Returns true if the font cache file was successfully
 deleted.
 - * @throws FOPException -
 + * @throws FOPException if an error was thrown while deleting the
 cache
   */
  public void deleteCache() throws FOPException {
  fontCacheManager.delete(getCacheFile(true));

 Modified:
 xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java
 URL:
 http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java?rev=1364567r1=1364566r2=1364567view=diff

 ==
 ---
 xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java
 (original)
 +++
 xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java
 Mon Jul 23 10:21:23 2012
 @@ -136,7 +136,7 @@ public abstract class AbstractPageNumber

  /**
   * @return {@link
 org.apache.fop.area.inline.UnresolvedPageNumber#FIRST} or
 - * {@linkorg.apache.fop.area.inline.UnresolvedPageNumber#LAST}
 + * {@link 

[Bug 48765] java.lang.NullPointerException: org.apache.fop.layoutmgr.inline.InlineStackingLayoutManager.getChangedKnuthElements(InlineStackingLayoutManager.java:375)

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48765

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 CC||med1...@gmail.com

--- Comment #9 from Pascal Sancho psancho@gmail.com ---
*** Bug 53586 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53586] NPE being thrown when hyphenation is used

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53586

Pascal Sancho psancho@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Pascal Sancho psancho@gmail.com ---
very similar to bug #48765, witch seems to be related to bug #46386 (read in
VH's comment)

*** This bug has been marked as a duplicate of bug 48765 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53580] [PATCH] force-page-count 'end-on-fourth' extension

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53580

Matthias Reischenbacher matthias8...@gmx.at changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Matthias Reischenbacher matthias8...@gmx.at ---
I just checked how Antenna House handles this use case. The extended property
values used by AH are:
* doubly-even
* end-on-doubly-even
* doubly-even-document

See also:
http://www.antennahouse.com/xslfo/extension.htm#force-page-count

I will rework my patch a bit in order to comply with AH. Does anybody know if
RenderX provides a similar functionality?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53580] [PATCH] force-page-count 'end-on-fourth' extension

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53580

Matthias Reischenbacher matthias8...@gmx.at changed:

   What|Removed |Added

  Attachment #29092|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.


next stable version for FOP?

2012-07-23 Thread Danut Clapa

Hello,
I seen that the latest version of the FOP is 1.1rc. Taking in consideration 
that is an release candidate. Do you have any information when will be next 
stable release after 1.1rc?

Thank you,



Danut Clapa
Senior Java Developer
TIC
Phone 0314138592
danut.cl...@uti.ro
Sos. Oltenitei, nr 107 A, corp C1, Etaj 5
107-111A Oltenitei
RO-041393 Bucuresti 4
Romania
www.uti.eu.com http://www.uti.eu.com%20/






[Bug 53580] [PATCH] force-page-count 'end-on-fourth' extension

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53580

--- Comment #2 from Alex Giotis alex.gio...@gmail.com ---
I have not used it, but RenderX seems to support it too. See footnote [1] in
XEP User Guide - Appendix A. XSL-FO Conformance

[1] http://www.renderx.com/reference.html#ftn.d0e11055

-- 
You are receiving this mail because:
You are the assignee for the bug.


Re: next stable version for FOP?

2012-07-23 Thread Chris Bowditch

On 23/07/2012 14:59, Danut Clapa wrote:

Hello,


Hi Danut,


I seen that the latest version of the FOP is 1.1rc. Taking in consideration 
that is an release candidate. Do you have any information when will be next 
stable release after 1.1rc?


You don't need to cross post your question to multiple lists. Please 
avoid doing so in future. Thanks.


To answer your question; the plan is to release FOP 1.1 a few weeks 
after 1.1rc1 when we've had sufficient feedback to be sure the release 
is sufficiently stable.


Thanks,

Chris



Thank you,



Danut Clapa
Senior Java Developer
TIC
Phone 0314138592
danut.cl...@uti.ro
Sos. Oltenitei, nr 107 A, corp C1, Etaj 5
107-111A Oltenitei
RO-041393 Bucuresti 4
Romania
www.uti.eu.com http://www.uti.eu.com%20/









[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #16 from Glenn Adams gad...@apache.org ---
(In reply to comment #15)
 (In reply to comment #14)
  (In reply to comment #13)
   (In reply to comment #10)
(In reply to comment #6)
 The first 3 lines of generated PDF from you give a near correct look.
 The problem is at character 26, Mai-Ek.
 It ship too far to the left.

I understand. I will investigate this further.

 I have few questions regarding to your output.
 I changed my fo:block element removing all attribute except 
 font-family.
 My result is different from what you got.
 It is look similar to the second line in first jpg attachment.
 Why the different ?

That's hard to say. I am using FOP1.1rc1 and Version 5.0 of the 
AngsanaUPC
font (from Windows 7). If you are using different versions, then that 
could
cause the difference.

   I'm using AngsanaUPC 5.0 from Windows 7 SP1 64 bits [Version 6.1.7601]
   I uses FOP from SVN trunk, checked out today.
  
  Hmmm. Strange. Here is the config I am using (fop.xconf):
  
  ?xml version=1.0?
  fop version=1.0
use-cachefalse/use-cache
base.//base
strict-configurationtrue/strict-configuration
renderers
  renderer mime=application/pdf
filterList
  valueflate/value
/filterList
fonts
  directory./fonts/directory
/fonts
  /renderer
/renderers
  /fop
  
  I placed the angsanu.ttf file in a fonts directory in the directory that
  contains this config. I turned of the font-cache to make sure it is using
  that font.
  
  Perhaps you might try this also?
 
 Tried it. Nothing change. I might forget to mention you that i embed FOP
 into java application. I copied fop.xconf from FOP 1.0 directory and put it
 right into my java project. The only section i changed is all those you
 mention above.
 Do i have to set anything other than that for embedded use ?

What results do you get when running FOP directly from command line using fop
script or directly from Java command?

Here is a debug output from my invocation (I'm using Ant to invoke java
directly):

 [java] Executing
'/System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/bin/java'
with arguments:
 [java] '-Xms512m'
 [java] '-Xmx2048m'
 [java] '-Djava.awt.headless=true'
 [java] '-Djava.util.logging.config.file=logging.properties'
 [java] '-ea:org.apache.fop...'
 [java] '-classpath'
 [java]
'/Users/glenn/work/fop/build/fop.jar:/Users/glenn/work/fop/lib/avalon-framework-4.2.0.jar:/Users/glenn/work/fop/lib/batik-all-1.7.jar:/Users/glenn/work/fop/lib/commons-io-1.3.1.jar:/Users/gl\
enn/work/fop/lib/commons-logging-1.0.4.jar:/Users/glenn/work/fop/lib/fop-hyph.jar:/Users/glenn/work/fop/lib/serializer-2.7.0.jar:/Users/glenn/work/fop/lib/servlet-2.2.jar:/Users/glenn/work/fop/lib/xalan\
-2.7.0-sources.jar:/Users/glenn/work/fop/lib/xalan-2.7.0.jar:/Users/glenn/work/fop/lib/xercesImpl-2.7.1.jar:/Users/glenn/work/fop/lib/xml-apis-1.3.04.jar:/Users/glenn/work/fop/lib/xml-apis-ext-1.3.04.ja\
r:/Users/glenn/work/fop/lib/xmlgraphics-commons-1.5svn.jar'
 [java] 'org.apache.fop.cli.Main'
 [java] '-q'
 [java] '-c'
 [java] 'fop.xconf'
 [java] '-fo'
 [java] './test.fo.xml'
 [java] '-pdf'
 [java] './test.pdf'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51962] [PATCH] last simple-page-master not chosen when force-page-count=odd

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51962

Matthias Reischenbacher matthias8...@gmx.at changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

--- Comment #6 from Matthias Reischenbacher matthias8...@gmx.at ---
Hi Mehdi, Peter,

I believe that there is a small bug inside the new
PageSequenceLayoutManager.getForcedLastPageNum() method:

You're handling even and end-on-even the same way. I think that this is not
entirely correct, because even only forces an even number of pages inside the
current page-sequence, but not for the whole document. Since lastPageNum refers
to the total amount of pages, the mod check should be done like that:

(lastPageNum - startPageNum + 1) % 2 != 0

The same applies to odd and end-on-odd.

Could you please check that?

Thanks
Matthias

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53580] [PATCH] force-page-count 'end-on-fourth' extension

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53580

--- Comment #3 from Matthias Reischenbacher matthias8...@gmx.at ---
Alex, thanks for the pointer. I went with the AntennaHouse approach because it
also takes into account the number of pages of the page-sequence and not only
the total amount of pages.
For now I didn't add support for a more flexible configuration of a page
number, but I might in the future if it becomes an requirement. Updated patch
coming shortly

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53580] [PATCH] force-page-count 'end-on-fourth' extension

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53580

--- Comment #4 from Matthias Reischenbacher matthias8...@gmx.at ---
Created attachment 29101
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29101action=edit
Patch

New patch which implements the following two force-page-count property values:

* doubly-even
-- forces a doubly even amount of pages in the current page-sequence (e.g.
page-sequence has pages 4-8 or 5-13 etc.)

* end-on-doubly-even
-- forces to end the current page-sequence on a doubly-even number of pages
(e.g. last page must be page nr 4 or 8 etc.)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53580] [PATCH] force-page-count 'doubly-even' and 'end-on-doubly-even' extension

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53580

Matthias Reischenbacher matthias8...@gmx.at changed:

   What|Removed |Added

Summary|[PATCH] force-page-count|[PATCH] force-page-count
   |'end-on-fourth' extension   |'doubly-even' and
   ||'end-on-doubly-even'
   ||extension

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #17 from na...@th.ibm.com ---
Created attachment 29102
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29102action=edit
The debug mode output from fop.bat

The result of using fop.bat execution is the same as previously upload PDF
file.
I suspect there must be some configuration different or my trunk version is
different from yours.
BTW, i tried fop.bat -version and it return 1.0beta2.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 53573] Fop invalid position combining mark for Thai text (CTL)

2012-07-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53573

--- Comment #18 from Glenn Adams gad...@apache.org ---
(In reply to comment #17)
 Created attachment 29102 [details]
 The debug mode output from fop.bat
 
 The result of using fop.bat execution is the same as previously upload PDF
 file.
 I suspect there must be some configuration different or my trunk version is
 different from yours.
 BTW, i tried fop.bat -version and it return 1.0beta2.

I can tell already that you aren't using the trunk version, since you should
not get 1.0beta2.

Please do the following (or equivalent) from the root level of what you think
is the current trunk HEAD and post a reply here:

$ svn info
Path: .
Working Copy Root Path: /Users/glenn/work/xmlgraphics/fop/trunk
URL: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk
Repository Root: https://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 1364879
Node Kind: directory
Schedule: normal
Last Changed Author: mehdi
Last Changed Rev: 1364567
Last Changed Date: 2012-07-23 04:21:23 -0600 (Mon, 23 Jul 2012)

$ java -version
java version 1.6.0_33
Java(TM) SE Runtime Environment (build 1.6.0_33-b03-424-11M3720)
Java HotSpot(TM) 64-Bit Server VM (build 20.8-b03-424, mixed mode)

$ java -jar build/fop.jar -version
FOP Version svn-trunk

$ md5 fonts/angsau.ttf  
MD5 (fonts/angsau.ttf) = 070f54e1790ee0a495de46729b974b57

-- 
You are receiving this mail because:
You are the assignee for the bug.