[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation

2015-07-19 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Tošovský updated FOP-1760:
--
Attachment: patch_against_rev_1690781_2015-07-19.patch

Patch derived from Stephan work, covering several corner cases:
+ fixing change bars rendering in multi-column layouts
+ handling overlapping change bars
+ change bar support for entire table cells
+ fixing y-offset for table change bars
(+ providing set of layout tests)
(+ renaming variables and methods)

While placement of change bars is ready for both LR/RL directions, as the 
actual value is unknown inside AbstractRenderer.renderMainReference() method, 
it is currently hardcoded to LR one. 

Depends on FOP-2501 and FOP-2502

Known issue: When drawing change bars for consecutive lines, the change bars 
are drawn with the same height as the line area, causing gaps between the 
change bars (as lines are offset).

> [PATCH] FOP doesn't support change bar generation
> -
>
> Key: FOP-1760
> URL: https://issues.apache.org/jira/browse/FOP-1760
> Project: FOP
>  Issue Type: Bug
>  Components: unqualified
>Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
>Reporter: Stephan Thesing
> Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, 
> changebar_20110308.diff, changebars.fo, changebars.pdf, 
> changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, 
> fop_20120507.diff, fop_changebars_20120506.diff, 
> patch_against_rev_1686494_2015-06-19.patch, 
> patch_against_rev_1690781_2015-07-19.patch, test.fo, test.pdf
>
>
> In order to produce change bars along the columns for changed contents,
> FO supports the fo:change-bar-begin and fo:change-bar-end elements.
> These are not supported by FOP.
> Support for change bars should be added.
> Effort needed
>  - add parsing and validation of fo: elements
>  - determine fo elements under influence of one or more change bars
>  - when creating areas from such affected fo elements, create additional areas
> representing the change bars as defined in the FO standard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


RE: Re: Change bars status

2015-07-19 Thread Jan Tosovsky
Hi Stephan,

On 2015-07-18 Stephan Thesing wrote:
> I have a local patch without respecting writing direction that also
> produces correct results for the example fo sent earlier in this thread

I like your update as it doesn't touch FOUserAgent (change bars are stacked in 
PageSequence) and it doesn't pollute various area classes with that BiDi 
handling.

I've incorporated these changes into my clone. For LR writing direction it 
still passes all my tests.

I'll submit it together with further details to the original JIRA issue.

Thanks a lot for moving this further!

Jan