[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 Luis Bernardo lmpmberna...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #31 from Luis Bernardo lmpmberna...@gmail.com --- applied patch 29132 with changes: http://svn.apache.org/viewvc?view=revisionrevision=1400536 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 Ognjen Blagojevic ognjen.d.blagoje...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #30 from Ognjen Blagojevic ognjen.d.blagoje...@gmail.com --- Although file size increase is now solved, I am reopening this issue as a reminder to apply patches starting with attachment 29132. Those new patches perform better, and they also solve issue 51149. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #25 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 29132 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29132action=edit support for sRGB and iCCP chunks this new patch improves the previous one and adds support to color spaces to the PDFImageHandlerRawPNG. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #26 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 29133 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29133action=edit example with ICC profiles -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #27 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 29134 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29134action=edit example images with ICC profiles -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #28 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 29135 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29135action=edit example with sRGB profile (sRGB chunk) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #29 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 29136 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29136action=edit example images with sRGB chunk -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #18 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 28988 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28988action=edit patch to disallow multiple image filters Adobe Reader fails to display the submitted examples when the raw png image loader is used, even though they seem valid according to the spec, and are correctly displayed by evince, ghostscript and Preview (Mac OS X PDF viewer). The Adobe Reader issue only happens if the filter flate is turned on and seems to be due to the fact that Adobe Reader may not like more than one filter applied to an image. Multiple filters applied to a stream are valid, but are also used by PDF malware exploits (like zip bombs). I suspect this is the reason why Adobe Reader does not like them. The patch fixes this problem by only using one image filter even when the default flate filter is turned on. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 Luis Bernardo lmpmberna...@gmail.com changed: What|Removed |Added Attachment #28930|0 |1 is obsolete|| --- Comment #19 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 28989 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28989action=edit update to previous test examples -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 Luis Bernardo lmpmberna...@gmail.com changed: What|Removed |Added Attachment #28932|0 |1 is obsolete|| --- Comment #20 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 28990 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28990action=edit update to previous example -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #21 from Glenn Adams gad...@apache.org --- (In reply to comment #18) Created attachment 28988 [details] patch to disallow multiple image filters Adobe Reader fails to display the submitted examples when the raw png image loader is used, even though they seem valid according to the spec, and are correctly displayed by evince, ghostscript and Preview (Mac OS X PDF viewer). The Adobe Reader issue only happens if the filter flate is turned on and seems to be due to the fact that Adobe Reader may not like more than one filter applied to an image. Multiple filters applied to a stream are valid, but are also used by PDF malware exploits (like zip bombs). I suspect this is the reason why Adobe Reader does not like them. The patch fixes this problem by only using one image filter even when the default flate filter is turned on. patch applied at http://svn.apache.org/viewvc?rev=1353303view=rev thanks luis! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #22 from Glenn Adams gad...@apache.org --- (In reply to comment #19) Created attachment 28989 [details] update to previous test examples not sure what to do with these... do you wish to commit to trunk somewhere? if so, you need to organize into standard test cases, etc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #23 from Luis Bernardo lmpmberna...@gmail.com --- no, the idea was never to make these part of the source. they are just provided to show what type of png images are currently supported by the new png image loader, and that the resulting output files are smaller. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #24 from Glenn Adams gad...@apache.org --- (In reply to comment #23) no, the idea was never to make these part of the source. they are just provided to show what type of png images are currently supported by the new png image loader, and that the resulting output files are smaller. ok, if you don't think any additional test cases are useful for this bug, then please close this when you're ready -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #17 from Glenn Adams gad...@apache.org --- (In reply to comment #16) Created attachment 28950 [details] patch for documentation I was not aware the web pages content was part of the source too... The patch updates the documentation. Applied final docs patch at http://svn.apache.org/viewvc?rev=1351540view=rev. Thanks luis! Please close this bug when you finish review. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #16 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 28950 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28950action=edit patch for documentation I was not aware the web pages content was part of the source too... The patch updates the documentation. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #12 from Luis Bernardo lmpmberna...@gmail.com --- Created attachment 28944 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28944action=edit patch for findbugs fixes/ignores findbugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #13 from Luis Bernardo lmpmberna...@gmail.com --- Wiki updated: http://wiki.apache.org/xmlgraphics-fop/HowTo/ImageLoaderRawPNG -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 Glenn Adams gad...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #14 from Glenn Adams gad...@apache.org --- findbugs fix patch applied at http://svn.apache.org/viewvc?rev=1350790view=rev thanks luis! please review and close if satisfied -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 --- Comment #15 from Glenn Adams gad...@apache.org --- (In reply to comment #13) Wiki updated: http://wiki.apache.org/xmlgraphics-fop/HowTo/ImageLoaderRawPNG you may also want to update [1] and [2] [1] http://xmlgraphics.apache.org/fop/trunk/graphics.html#png [2] http://xmlgraphics.apache.org/fop/trunk/configuration.html#image-loading for example, adding info to [1] about the new codecs, and adding info to [2] about negative penalties -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40676] [PATCH] png graphics are expanded/uncompressed in pdf causing massive file size increase
https://issues.apache.org/bugzilla/show_bug.cgi?id=40676 Glenn Adams gad...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO Depends on||53408 Summary|png graphics are|[PATCH] png graphics are |expanded/uncompressed in|expanded/uncompressed in |pdf causing massive file|pdf causing massive file |size increase |size increase --- Comment #11 from Glenn Adams gad...@apache.org --- patch applied at http://svn.apache.org/viewvc?rev=1350455view=rev thanks luis and matthias! luis, please provide an additional patch (against this rev) that fixes the 13 findbugs warnings you introduced (I fixed the 2 checkstyle warnings introduced); also update the relevant documentation to describe the configuration/use of these features in the mean time, I will transition this bug to NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
