[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357142#comment-14357142 ] simon steiner commented on FOP-2406: I made that change for another reason not related to linearization, i dont think i should have committed it. Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358329#comment-14358329 ] simon steiner commented on FOP-2406: Fix http://svn.apache.org/viewvc?view=revisionrevision=1666099 Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[
https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357007#comment-14357007
]
simon steiner commented on FOP-2406:
--- src/java/org/apache/fop/pdf/PDFFactory.java (revision 1665890)
+++ src/java/org/apache/fop/pdf/PDFFactory.java (working copy)
@@ -198,9 +198,7 @@
* resources, contents and dimensions
*/
PDFResources res = getDocument().getFactory().makeResources();
-if (getDocument().isLinearizationEnabled()) {
getDocument().trailerObjects.remove(resources);
-}
You can fix by doing but there were some problems remaining.
Error when image next to pdf
Key: FOP-2406
URL: https://issues.apache.org/jira/browse/FOP-2406
Project: Fop
Issue Type: Bug
Reporter: simon steiner
Attachments: img.pdf, test.fo, test.png
JPG and PDF on same page gives adobe reader error due to pdf resource not
being merged
fop test.fo out.pdf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[
https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357124#comment-14357124
]
Seifeddine Dridi commented on FOP-2406:
---
This fixed the problem:
--- src/java/org/apache/fop/pdf/PDFFactory.java (revision 1665413)
+++ src/java/org/apache/fop/pdf/PDFFactory.java (working copy)
@@ -197,15 +197,8 @@
-PDFResources res = getDocument().getFactory().makeResources();
-if (getDocument().isLinearizationEnabled()) {
-getDocument().trailerObjects.remove(resources);
-}
-res.setParentResources(resources);
+PDFPage page = new PDFPage(resources, pageIndex, mediaBox, cropBox,
bleedBox, trimBox);
-PDFPage page = new PDFPage(res, pageIndex, mediaBox, cropBox,
bleedBox, trimBox);
-res.setParent(page);
-
Does this change break the PDF linearization feature?
Error when image next to pdf
Key: FOP-2406
URL: https://issues.apache.org/jira/browse/FOP-2406
Project: Fop
Issue Type: Bug
Reporter: simon steiner
Attachments: img.pdf, test.fo, test.png
JPG and PDF on same page gives adobe reader error due to pdf resource not
being merged
fop test.fo out.pdf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357135#comment-14357135 ] simon steiner commented on FOP-2406: We use to have 1 PDFResources for whole document, when i made changes to remove xobject for pdf in pdf, we need to have PDFResources per page to avoid conflicts, we used to have PDF in PDF resource referenced from xobject. The size increase comes from document PDFResources being there but not referenced anymore. Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357090#comment-14357090 ] Seifeddine Dridi commented on FOP-2406: --- Your patch does not change anything with regard to the size of the output PDF document. Could you please be more specific about the other remaining problems? Thanks Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356695#comment-14356695 ] Seifeddine Dridi commented on FOP-2406: --- Hi Simon, Is it normal that your fix increases the size of PDF documents even in simple cases where there is only text? Thanks Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106804#comment-14106804 ] simon steiner commented on FOP-2406: Test http://svn.apache.org/viewvc?view=revisionrevision=1619791 Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (FOP-2406) Error when image next to pdf
[ https://issues.apache.org/jira/browse/FOP-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103997#comment-14103997 ] simon steiner commented on FOP-2406: Added http://svn.apache.org/viewvc?view=revisionrevision=1618887 http://svn.apache.org/viewvc?view=revisionrevision=1618885 Error when image next to pdf Key: FOP-2406 URL: https://issues.apache.org/jira/browse/FOP-2406 Project: Fop Issue Type: Bug Reporter: simon steiner Attachments: img.pdf, test.fo, test.png JPG and PDF on same page gives adobe reader error due to pdf resource not being merged fop test.fo out.pdf -- This message was sent by Atlassian JIRA (v6.2#6252)
