[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: patch_against_rev_1832958_2018-06-05.patch > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1832958_2018-06-05.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: (was: patch_against_rev_1690781_2015-07-19.patch) > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: (was: patch_against_rev_1686494_2015-06-19.patch) > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: (was: patch_against_rev_1755460_2016-08-07.patch) > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: (was: patch_against_rev_1776640_2016-12-30.patch) > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glenn Adams updated FOP-1760: - Priority: Blocker Issue Type: New Feature (was: Bug) Changing from "bug" to "new feature". Note that this patch is not a fix, but a proposal for a new feature outside the scope of XSL-FO. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: New Feature > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing >Priority: Blocker > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, > patch_against_rev_1755460_2016-08-07.patch, > patch_against_rev_1776640_2016-12-30.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: patch_against_rev_1776640_2016-12-30.patch Addressing two remaining issues: (1) change bar height for inlines now matches the actual line height (this height is determined when entering change-bar-start element and stored directly in the change bar object so it can be accessed when rendering the bar) (2) change bar placement now follows the actual writing mode. It is passed to the rendering stage via Traits (BLOCK_PROGRESSION_DIRECTION, INLINE_PROGRESSION_DIRECTION). All the stuff has been updated to the current trunk revision. In total there are 8 new layout engine test cases. All those with all standard tests are passing. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: Bug > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, > patch_against_rev_1755460_2016-08-07.patch, > patch_against_rev_1776640_2016-12-30.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: patch_against_rev_1755460_2016-08-07.patch Updating patch to the current trunk (maven based). Incorporating fix for failing tests. > [PATCH] FOP doesn't support change bar generation > - > > Key: FOP-1760 > URL: https://issues.apache.org/jira/browse/FOP-1760 > Project: FOP > Issue Type: Bug > Components: unqualified >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: Stephan Thesing > Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, > changebar_20110308.diff, changebars.fo, changebars.pdf, > changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, > fop_20120507.diff, fop_changebars_20120506.diff, > patch_against_rev_1686494_2015-06-19.patch, > patch_against_rev_1690781_2015-07-19.patch, > patch_against_rev_1755460_2016-08-07.patch, test.fo, test.pdf > > > In order to produce change bars along the columns for changed contents, > FO supports the fo:change-bar-begin and fo:change-bar-end elements. > These are not supported by FOP. > Support for change bars should be added. > Effort needed > - add parsing and validation of fo: elements > - determine fo elements under influence of one or more change bars > - when creating areas from such affected fo elements, create additional areas > representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: patch_against_rev_1690781_2015-07-19.patch Patch derived from Stephan work, covering several corner cases: + fixing change bars rendering in multi-column layouts + handling overlapping change bars + change bar support for entire table cells + fixing y-offset for table change bars (+ providing set of layout tests) (+ renaming variables and methods) While placement of change bars is ready for both LR/RL directions, as the actual value is unknown inside AbstractRenderer.renderMainReference() method, it is currently hardcoded to LR one. Depends on FOP-2501 and FOP-2502 Known issue: When drawing change bars for consecutive lines, the change bars are drawn with the same height as the line area, causing gaps between the change bars (as lines are offset). [PATCH] FOP doesn't support change bar generation - Key: FOP-1760 URL: https://issues.apache.org/jira/browse/FOP-1760 Project: FOP Issue Type: Bug Components: unqualified Affects Versions: trunk Environment: Operating System: All Platform: All Reporter: Stephan Thesing Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, changebar_20110308.diff, changebars.fo, changebars.pdf, changebars_20110512.diff, diff_1691612.diff, diff_2010_03_06.txt, fop_20120507.diff, fop_changebars_20120506.diff, patch_against_rev_1686494_2015-06-19.patch, patch_against_rev_1690781_2015-07-19.patch, test.fo, test.pdf In order to produce change bars along the columns for changed contents, FO supports the fo:change-bar-begin and fo:change-bar-end elements. These are not supported by FOP. Support for change bars should be added. Effort needed - add parsing and validation of fo: elements - determine fo elements under influence of one or more change bars - when creating areas from such affected fo elements, create additional areas representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
[ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Tošovský updated FOP-1760: -- Attachment: patch_against_rev_1686494_2015-06-19.patch changebars.pdf changebars.fo Updated patch with a test document. Please note some examples in FO file are commented (see the reason below). The original patch solves IMO majority of real cases. There is a room for further improvements, but hard to say how much effort is needed: Issues: (1) When dotted or dashed bars are used, change bars are drawn, but the text after change-bar-begin tag disappear (and no error is shown). Surprisingly it works for more obscure styles like ridge or groove. (2) Overlapping bars are not supported. I would at least expect a warning (not supported yet) instead of exception. (3) change-bar-placement inside/outside renders bars IMO shifted. I would expect them in the position start/end. (4) Surrounding fo:table-cell by change bars seems to be unsupported (Class Cast Exception). Surrounding fo:table-row and surprisingly also entire fo:table-header/body/footer works fine. (5) clone method in BodyArea class looks suspicious to me ;-) [PATCH] FOP doesn't support change bar generation - Key: FOP-1760 URL: https://issues.apache.org/jira/browse/FOP-1760 Project: FOP Issue Type: Bug Components: unqualified Affects Versions: trunk Environment: Operating System: All Platform: All Reporter: Stephan Thesing Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, changebar_20110308.diff, changebars.fo, changebars.pdf, changebars_20110512.diff, diff_2010_03_06.txt, fop_20120507.diff, fop_changebars_20120506.diff, patch_against_rev_1686494_2015-06-19.patch In order to produce change bars along the columns for changed contents, FO supports the fo:change-bar-begin and fo:change-bar-end elements. These are not supported by FOP. Support for change bars should be added. Effort needed - add parsing and validation of fo: elements - determine fo elements under influence of one or more change bars - when creating areas from such affected fo elements, create additional areas representing the change bars as defined in the FO standard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
