Re: A nit: visibility of FObj.bind()?

2006-12-21 Thread Simon Pepping 
On Wed, Dec 20, 2006 at 07:55:26PM +0100, Andreas L Delmelle wrote:
 
 Hi all,
 
 Just bumped into this and started wondering: currently FObj.bind()  
 has public visibility, but it seems that protected would suffice. The  
 method is only accessed by processNode() (which is already a  
 protected method), but since it needs to be overridden by subclasses,  
 it cannot be made private.
 
 Simply wondering whether it would not be 'cleaner' to restrict the  
 visibility to protected... unless it is really necessary for some  
 reason to expose it as part of the public API of FObj?

I guess it needs to be invoked after creating an FObj, so it should
have the same visibility as the creator method.

Simon

-- 
Simon Pepping
home page: http://www.leverkruid.eu

A nit: visibility of FObj.bind()?

2006-12-20 Thread Andreas L Delmelle 


Hi all,

Just bumped into this and started wondering: currently FObj.bind()  
has public visibility, but it seems that protected would suffice. The  
method is only accessed by processNode() (which is already a  
protected method), but since it needs to be overridden by subclasses,  
it cannot be made private.


Simply wondering whether it would not be 'cleaner' to restrict the  
visibility to protected... unless it is really necessary for some  
reason to expose it as part of the public API of FObj?



Cheers,

Andreas