DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2012-03-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

Glenn Adams  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #8 from Glenn Adams  2012-04-01 06:16:51 UTC ---
batch transition to closed; if someone wishes to restore one of these to
resolved in order to perform a verification step, then feel free to do so

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2012-01-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

Mathieu Malaterre  changed:

   What|Removed |Added

 CC||mathieu.malate...@gmail.com

--- Comment #7 from Mathieu Malaterre  2012-01-03 
09:49:44 UTC ---
*** Bug 52411 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

Matthias Reischenbacher  changed:

   What|Removed |Added

 CC||ken_...@y7mail.com

--- Comment #6 from Matthias Reischenbacher  2010-12-19 
09:27:37 EST ---
*** Bug 47611 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

Matthias Reischenbacher  changed:

   What|Removed |Added

 CC||guillaume.levr...@free.fr

--- Comment #5 from Matthias Reischenbacher  2010-12-19 
09:11:09 EST ---
*** Bug 47638 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

--- Comment #4 from Matthias Reischenbacher  2010-12-10 
07:20:46 EST ---
(In reply to comment #3)
> (In reply to comment #0)
> > Apparently the KnuthElement's position is null (oldElement.getPosition()). I
> > attached a patch which adds an additional check in order to avoid the
> > exception. This might not be a real solution, because I'm not sure if it's
> > valid that the position is null.
> 
> I spent some more time on the validity of a null position. Auxiliary positions
> have null subposition, see InlineLayoutManager.getAuxiliaryPosition(), line:
> 597.
> 
> If a position is unwrapped often enough, this null position is reached. The
> chosen solution, i.e. not unwrapping if the null position is reached, adds a
> layer of wrapping around the null position, because later in the method all
> positions are wrapped again. Apparently that is not a problem.

Simon,

thanks for looking into this. I also had a further look at the code and I think
there is still a problem when unwrapping and wrapping positions which is
causing Bug 49870 [1]. When the InlineLayoutManager adds NonLeafPositions for
border-left and border-right it sets the sub positions to null. Unwrapping the
position causes the NonLeafPosition to get lost:
oldElement.setPosition(oldElement.getPosition().getPosition());

I'm unsure if the problem should be fixed when adding the border
NonLeafPositions in the first place or we add an additional check in the
applyChanges() method. What do you think?

Regards,
Matthias Reischenbacher

[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=49870

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

--- Comment #3 from Simon Pepping  2010-12-09 07:01:32 EST 
---
(In reply to comment #0)
> Apparently the KnuthElement's position is null (oldElement.getPosition()). I
> attached a patch which adds an additional check in order to avoid the
> exception. This might not be a real solution, because I'm not sure if it's
> valid that the position is null.

I spent some more time on the validity of a null position. Auxiliary positions
have null subposition, see InlineLayoutManager.getAuxiliaryPosition(), line:
597.

If a position is unwrapped often enough, this null position is reached. The
chosen solution, i.e. not unwrapping if the null position is reached, adds a
layer of wrapping around the null position, because later in the method all
positions are wrapped again. Apparently that is not a problem.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-12-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

Simon Pepping  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
 OS/Version||All

--- Comment #2 from Simon Pepping  2010-12-09 04:01:53 EST 
---
Resolved in revision 1043871.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50276] NPE when using padding-left on fo:inline element and hyphenation is activated

2010-11-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50276

--- Comment #1 from Matthias Reischenbacher  2010-11-15 
15:37:17 EST ---
Created an attachment (id=26300)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26300)
Patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.