Re: LayoutEngineTestSuite: disabled and start-with properties

2007-04-17 Thread Vincent Hennebert 
Vincent Hennebert a écrit :
> Guys,
> 
> When running the layoutengine testsuite, it is possible to use several
> properties to select the testcases you want to run. As a reminder
> everything is explained here:
> http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests
> 
> You can exclude the disabled testcases to be run by using the
> fop.layoutengine.disabled property. But this property can't currently be
> used together with the fop.layoutengine.starts-with property.
> 
> I think this should be the case, as I recently felt that need. The
> modification is very simple (attached diff) and wouldn't prevent the
> current behavior to occur (you just have to not specify the disabled
> property).
> 
> Anyone against me doing the change?

Based on lazy consensus I applied the change.

Vincent

LayoutEngineTestSuite: disabled and start-with properties

2007-03-30 Thread Vincent Hennebert 
Guys,

When running the layoutengine testsuite, it is possible to use several
properties to select the testcases you want to run. As a reminder
everything is explained here:
http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests

You can exclude the disabled testcases to be run by using the
fop.layoutengine.disabled property. But this property can't currently be
used together with the fop.layoutengine.starts-with property.

I think this should be the case, as I recently felt that need. The
modification is very simple (attached diff) and wouldn't prevent the
current behavior to occur (you just have to not specify the disabled
property).

Anyone against me doing the change?

BTW, I know I already told it, but I'm falling in love with that
testsuite...

Vincent
Index: test/java/org/apache/fop/layoutengine/LayoutEngineTestSuite.java
===
--- test/java/org/apache/fop/layoutengine/LayoutEngineTestSuite.java	(révision 522536)
+++ test/java/org/apache/fop/layoutengine/LayoutEngineTestSuite.java	(copie de travail)
@@ -140,6 +140,7 @@
 } else if (startsWith != null) {
 filter = new PrefixFileFilter(startsWith);
 filter = new AndFileFilter(filter, new SuffixFileFilter(".xml"));
+filter = decorateWithDisabledList(filter);
 } else {
 filter = new SuffixFileFilter(".xml");
 filter = decorateWithDisabledList(filter);