Re: svn commit: r629902 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/cli/InputHandler.java status.xml

[Max Berger]

Jeremias,

give me two days... If i haven't found a java 1.4 compatible version on
sunday feel free to revert the patch. Afaik setting some properties on
the SAXparser should have the same effect.

Max


On Fre, 2008-02-22 at 14:37 +0100, Jeremias Maerki wrote:
 Hmm. Now this is one of those cases where we have to be careful. With
 this change FOP doesn't compile on Java 1.4 without putting a JAXP 1.3
 in jre/lib/endorsed directory or using the -Xbootclasspath argument.
 And those running it will have the same problem. If we really want to do
 this, putting the XML JARs (including xml-apis(-ext).jar) into
 fop/lib/endorsed will make things easier. And maybe we should dedicate
 a special page in our docs on this topic.
 
 On 21.02.2008 19:22:23 maxberger wrote:
  Author: maxberger
  Date: Thu Feb 21 10:22:22 2008
  New Revision: 629902
  
  URL: http://svn.apache.org/viewvc?rev=629902view=rev
  Log:
  Turned on XInclude processing for the main source given on the command line.
  
  Modified:
  xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
  xmlgraphics/fop/trunk/status.xml
  
  Modified: 
  xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
  URL: 
  http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java?rev=629902r1=629901r2=629902view=diff
  ==
  --- xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java 
  (original)
  +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java Thu 
  Feb 21 10:22:22 2008
 snip/
  +Source result;
  +try {
  +InputSource is = new InputSource(new FileInputStream(
  +this.sourcefile));
  +SAXParserFactory spf = SAXParserFactory.newInstance();
  +spf.setNamespaceAware(true);
  +spf.setXIncludeAware(true);
  +XMLReader xr = spf.newSAXParser().getXMLReader();
  +result = new SAXSource(xr, is);
  +} catch (SAXException e) {
  +result = new StreamSource(this.sourcefile);
  +} catch (IOException e) {
  +result = new StreamSource(this.sourcefile);
  +} catch (ParserConfigurationException e) {
  +result = new StreamSource(this.sourcefile);
  +}
  +return result;
 snip/
 
 
 
 Jeremias Maerki
 
mfG

Max Berger
e-mail: [EMAIL PROTECTED]

-- 
OpenPG ID: E81592BC   Print: F489F8759D4132923EC4 BC7E072AB73AE81592BC
For information about me and my work please see http://max.berger.name



signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Re: svn commit: r629902 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/cli/InputHandler.java status.xml

[Jeremias Maerki]

setFeature may not work in this case as there's no feature ID defined by
the SAX project for XInclude. The feature ID would be parser specific.

As an alternative, we could use Reflection to enable the feature if a
JAXP 1.3 implementation is available.

On 22.02.2008 15:05:34 Max Berger wrote:
 Jeremias,
 
 give me two days... If i haven't found a java 1.4 compatible version on
 sunday feel free to revert the patch. Afaik setting some properties on
 the SAXparser should have the same effect.
 
 Max
 
 
 On Fre, 2008-02-22 at 14:37 +0100, Jeremias Maerki wrote:
  Hmm. Now this is one of those cases where we have to be careful. With
  this change FOP doesn't compile on Java 1.4 without putting a JAXP 1.3
  in jre/lib/endorsed directory or using the -Xbootclasspath argument.
  And those running it will have the same problem. If we really want to do
  this, putting the XML JARs (including xml-apis(-ext).jar) into
  fop/lib/endorsed will make things easier. And maybe we should dedicate
  a special page in our docs on this topic.
  
  On 21.02.2008 19:22:23 maxberger wrote:
   Author: maxberger
   Date: Thu Feb 21 10:22:22 2008
   New Revision: 629902
   
   URL: http://svn.apache.org/viewvc?rev=629902view=rev
   Log:
   Turned on XInclude processing for the main source given on the command 
   line.
   
   Modified:
   xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
   xmlgraphics/fop/trunk/status.xml
   
   Modified: 
   xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
   URL: 
   http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java?rev=629902r1=629901r2=629902view=diff
   ==
   --- xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java 
   (original)
   +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java 
   Thu Feb 21 10:22:22 2008
  snip/
   +Source result;
   +try {
   +InputSource is = new InputSource(new FileInputStream(
   +this.sourcefile));
   +SAXParserFactory spf = SAXParserFactory.newInstance();
   +spf.setNamespaceAware(true);
   +spf.setXIncludeAware(true);
   +XMLReader xr = spf.newSAXParser().getXMLReader();
   +result = new SAXSource(xr, is);
   +} catch (SAXException e) {
   +result = new StreamSource(this.sourcefile);
   +} catch (IOException e) {
   +result = new StreamSource(this.sourcefile);
   +} catch (ParserConfigurationException e) {
   +result = new StreamSource(this.sourcefile);
   +}
   +return result;
  snip/
  
  
  
  Jeremias Maerki
  
 mfG
 
 Max Berger
 e-mail: [EMAIL PROTECTED]
 
 -- 
 OpenPG ID: E81592BC   Print: F489F8759D4132923EC4 BC7E072AB73AE81592BC
 For information about me and my work please see http://max.berger.name
 




Jeremias Maerki