Re: [foreman-dev] Re: forklift error: Parameter katello-devel-github-username invalid
If someone can point me in the direction for how to make this optional, I can give that a try. If it's intentional that it's required, probably a PR to the README is appropriate. On Fri, Jun 3, 2016 at 2:14 PM, Andrew Kofink wrote: > You are required to set github-username. Here's my boxes.yaml: > > dev-koji: > box: centos7-devel > options: --scenario=katello-devel --koji-repos > installer: '-v --katello-devel-github-username akofink > --katello-devel-upstream-remote-name upstream > --katello-devel-fork-remote-name origin' > > Andrew Kofink > > Software Engineering Intern > Red Hat Satellite 6 > akof...@redhat.com > > On Fri, Jun 3, 2016 at 9:36 AM, Tom McKay wrote: > >> I see this is an installer option. >> >> On Fri, Jun 3, 2016 at 9:04 AM, Tom McKay wrote: >> >>> ==> katello: Running shell command: foreman-installer --scenario >>> katello-devel --scenario katello-devel --katello-devel-use-rvm false >>> ==> katello: stty: standard input: Inappropriate ioctl for device >>> ==> katello: Parameter katello-devel-github-username invalid >>> ==> katello: >>> ==> katello: Error during configuration, exiting >>> >>> Fresh checkout of forklift then vagrant up katello with this boxes.yaml >>> >>> katello: >>> box: centos7-devel >>> installer: '--scenario katello-devel --katello-devel-use-rvm false' >>> options: '--disable-selinux --koji-repos' >>> memory: 4096 >>> cpus: 2 >>> hostname: katello.example.com >>> networks: >>> - type: 'private_network' >>> options: >>> ip: 192.168.111.159 >>> libvirt__network_name: provisioning >>> libvirt__iface_name: virbr2 >>> >>> >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Re: forklift error: Parameter katello-devel-github-username invalid
You are required to set github-username. Here's my boxes.yaml: dev-koji: box: centos7-devel options: --scenario=katello-devel --koji-repos installer: '-v --katello-devel-github-username akofink --katello-devel-upstream-remote-name upstream --katello-devel-fork-remote-name origin' Andrew Kofink Software Engineering Intern Red Hat Satellite 6 akof...@redhat.com On Fri, Jun 3, 2016 at 9:36 AM, Tom McKay wrote: > I see this is an installer option. > > On Fri, Jun 3, 2016 at 9:04 AM, Tom McKay wrote: > >> ==> katello: Running shell command: foreman-installer --scenario >> katello-devel --scenario katello-devel --katello-devel-use-rvm false >> ==> katello: stty: standard input: Inappropriate ioctl for device >> ==> katello: Parameter katello-devel-github-username invalid >> ==> katello: >> ==> katello: Error during configuration, exiting >> >> Fresh checkout of forklift then vagrant up katello with this boxes.yaml >> >> katello: >> box: centos7-devel >> installer: '--scenario katello-devel --katello-devel-use-rvm false' >> options: '--disable-selinux --koji-repos' >> memory: 4096 >> cpus: 2 >> hostname: katello.example.com >> networks: >> - type: 'private_network' >> options: >> ip: 192.168.111.159 >> libvirt__network_name: provisioning >> libvirt__iface_name: virbr2 >> >> >> > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] [Katello] weekly issue triage meetings?
On 06/01/2016 07:19 PM, Justin Sherrill wrote: > Was thinking lately that the issue triaging process is currently: > > 1. User files issue > 2. Eric triages the issue to either a release or a backlog > 3. Release nanny for a particular release fixes bug, asks someone else > to fix the bug or is just sits there > > In the case of 'it just sitting there' a lot of user issues come in that > are mostly ignored due to the release nanny's other responsibilities. > > I would like to get more eyes on the issues and spread the effort to not > just Eric and the release nanny for a given release. > > Any thoughts on a weekly triage meeting? The goals would be: > > * assign issues to a given release or the 'backlog' > * assign issues to be fixed to developers (for current releases) > * Assign user reported issues to be determined if they are actually bugs > or environment issues. > > This would spread the fixing of bugs to other people and hopefully get > user issues solved more quickly. > > Initially I would likely just have an open invite to anyone that wants > to come and may pare it down to some sort of rotation depending on the > number of people that join. We would probably limit it to 1 hour per week. > > Thoughts? > > -Justin > There seems to have been some interest, so I've gone ahead and setup a time on Wednesdays at 5:00 pm UTC (1:00 pm EDT). We're going to try bluejeans for our triages: https://bluejeans.com/942337177/ I will add it to the foreman community calendar as well. -Justin -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Re: forklift error: Parameter katello-devel-github-username invalid
I see this is an installer option. On Fri, Jun 3, 2016 at 9:04 AM, Tom McKay wrote: > ==> katello: Running shell command: foreman-installer --scenario > katello-devel --scenario katello-devel --katello-devel-use-rvm false > ==> katello: stty: standard input: Inappropriate ioctl for device > ==> katello: Parameter katello-devel-github-username invalid > ==> katello: > ==> katello: Error during configuration, exiting > > Fresh checkout of forklift then vagrant up katello with this boxes.yaml > > katello: > box: centos7-devel > installer: '--scenario katello-devel --katello-devel-use-rvm false' > options: '--disable-selinux --koji-repos' > memory: 4096 > cpus: 2 > hostname: katello.example.com > networks: > - type: 'private_network' > options: > ip: 192.168.111.159 > libvirt__network_name: provisioning > libvirt__iface_name: virbr2 > > > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] forklift error: Parameter katello-devel-github-username invalid
==> katello: Running shell command: foreman-installer --scenario katello-devel --scenario katello-devel --katello-devel-use-rvm false ==> katello: stty: standard input: Inappropriate ioctl for device ==> katello: Parameter katello-devel-github-username invalid ==> katello: ==> katello: Error during configuration, exiting Fresh checkout of forklift then vagrant up katello with this boxes.yaml katello: box: centos7-devel installer: '--scenario katello-devel --katello-devel-use-rvm false' options: '--disable-selinux --koji-repos' memory: 4096 cpus: 2 hostname: katello.example.com networks: - type: 'private_network' options: ip: 192.168.111.159 libvirt__network_name: provisioning libvirt__iface_name: virbr2 -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Nominating Timo Goebel for theforeman/foreman commit access
> Objections or comments in private are welcome, but public replies to this > thread are preferred :) Welcome to the core team! ;-) -- Later, Lukas #lzap Zapletal -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] CodeClimate on Foreman core PRs
On 03/06/16 11:40, Daniel Lobato Garcia wrote: > On 06/02, Dominic Cleal wrote: >> On 02/06/16 15:54, Daniel Lobato Garcia wrote: >>> Hi devs, >>> >>> We activated CodeClimate analysis on our project some time ago - >>> https://codeclimate.com/github/theforeman/foreman >>> >>> It's an useful tool to see how coupled, well coded, etc.. your >>> application is. A while ago it used to be 2.9 IIRC, and it's became >>> worse over time. >>> >>> I found it useful to run it on certain PRs manually to detect areas that >>> can be improved, but it's a bit of a PITA to do it manually. They have a >>> free open source plan and it can show this information directly on the >>> PR. >>> >>> I think it would make sense for Foreman core and other Ruby projects >>> to use this tool to see how our code quality* improves/gets worse on >>> each PR. Integrating it is easy and I did it with foreman_cockpit and >>> foreman_ansible already. I don't have the rights to do it on Foreman >>> core but even if I did I want others' opinions on it. >> >> I'm in favour of adding it, it seems useful. It is reflecting the >> rubocop/brakeman checks we already have, but of course many are actually >> disabled or not being checked because we've not enabled them. This gives >> us a way of ensuring the overall style gets better (according to these >> metrics) gradually with new code, which is nice. Hopefully this means >> some cops can later be enabled with less work. >> >>> http://docs.codeclimate.com/article/213-github-pull-request-integration >> >> This URL is a 404 for me, >> http://docs.classic.codeclimate.com/article/213-github-pull-request-integration >> seems to work. > > Awesome, I think it's yours or Ohad's call then as nobody else has > permission to change settings on core. It took me like 10m to do it on > the repos I mentioned before :) Sure, I can do it next week if there's no other feedback. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
Re: Re: [foreman-dev] CodeClimate on Foreman core PRs
On 06/02, Dominic Cleal wrote: > On 02/06/16 15:54, Daniel Lobato Garcia wrote: > > Hi devs, > > > > We activated CodeClimate analysis on our project some time ago - > > https://codeclimate.com/github/theforeman/foreman > > > > It's an useful tool to see how coupled, well coded, etc.. your > > application is. A while ago it used to be 2.9 IIRC, and it's became > > worse over time. > > > > I found it useful to run it on certain PRs manually to detect areas that > > can be improved, but it's a bit of a PITA to do it manually. They have a > > free open source plan and it can show this information directly on the > > PR. > > > > I think it would make sense for Foreman core and other Ruby projects > > to use this tool to see how our code quality* improves/gets worse on > > each PR. Integrating it is easy and I did it with foreman_cockpit and > > foreman_ansible already. I don't have the rights to do it on Foreman > > core but even if I did I want others' opinions on it. > > I'm in favour of adding it, it seems useful. It is reflecting the > rubocop/brakeman checks we already have, but of course many are actually > disabled or not being checked because we've not enabled them. This gives > us a way of ensuring the overall style gets better (according to these > metrics) gradually with new code, which is nice. Hopefully this means > some cops can later be enabled with less work. > > > http://docs.codeclimate.com/article/213-github-pull-request-integration > > This URL is a 404 for me, > http://docs.classic.codeclimate.com/article/213-github-pull-request-integration > seems to work. Awesome, I think it's yours or Ohad's call then as nobody else has permission to change settings on core. It took me like 10m to do it on the repos I mentioned before :) -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [foreman-dev] Nominating Timo Goebel for theforeman/foreman commit access
Big +1 from me. Thanks Daniel for bringing this up. -- Ivan On Thu, Jun 2, 2016 at 4:57 PM, Dominic Cleal wrote: > On 02/06/16 15:47, Daniel Lobato Garcia wrote: > > Hi devs, > > > > I'd like to nominate Timo Goebel (timogoebel on Github & IRC) for commit > > access to theforeman/foreman repo. > > > > He's been contributing to the puppet modules, community-templates, > bootdisk > > and Foreman for some time, particularly on the VMWare/vsphere side of > things. > > He's been running Foreman on production for years already and gave > > local talks about it.( > www.meetup.com/AWS-Meetup-Karlsruhe/events/229036956/) > > > > Most importantly and the reason why I thought of him as a person that > > could become a committer is his involvement on ipv6 support lately, > > where he's been submitting consistently good code. > > > > I think he understands very well the problem domain, and he will be > > committed to maintain and improve the code quality of the project, as > > well as providing good feedback from a production installations. > > > > Some examples of his contributions: > > > > https://github.com/theforeman/foreman/pull/3420 > > https://github.com/theforeman/foreman/pull/3424 > > https://github.com/theforeman/foreman/pull/3498 > > https://github.com/theforeman/foreman/pull/3499 > > > https://github.com/theforeman/foreman/commit/5131edbfab258c0862c987f238049ee81a1cd13f > > > https://github.com/theforeman/foreman/commit/8ca6c6bbc5242c29a8039d1e6a1d09d1a454164c > > > https://github.com/theforeman/foreman/commit/2328beb569d3f0e51043202d3a00a3b30879d244 > > https://github.com/theforeman/puppet-puppet/pull/389 > > https://github.com/theforeman/foreman_bootdisk/pull/19 > > > > Lastly I'd encourage him to start reviewing already! > > > > Objections or comments in private are welcome, but public replies to this > > thread are preferred :) > > Yep, I definitely agree. Please let me know in a week what the outcome is. > > -- > Dominic Cleal > domi...@cleal.org > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
