Re: [foreman-dev] Use mention-bot to increase reviews?

2016-10-12 Thread Greg Sutcliffe
On 12 October 2016 at 16:29, Lukas Zapletal  wrote:

> > Sounds positive so far - which repos should we try it on? I'm thinking
> > core, proxy, katello and the website for now? We can put it everywhere if
> > that goes well.
>
> I love this bot, I already know that in advance.
>
> I'd scratch the website tho, the three would be a good start.
>

I put the website because quite a few new contributors start there, with
small doc fixes - thus it has a higher number of people for the bot to
ping. Might be interesting to see it's heuristics in action. But I don't
mind either way :)

Greg

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Use mention-bot to increase reviews?

2016-10-12 Thread Lukas Zapletal
> Sounds positive so far - which repos should we try it on? I'm thinking
> core, proxy, katello and the website for now? We can put it everywhere if
> that goes well.

I love this bot, I already know that in advance.

I'd scratch the website tho, the three would be a good start.

-- 
Later,
 Lukas #lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Use mention-bot to increase reviews?

2016-10-12 Thread Eric D Helms
I'll enable on Katello tomorrow so devs have at least a days notice that it
will be turned on.

On Wed, Oct 12, 2016 at 10:09 AM, Greg Sutcliffe 
wrote:

> Sounds positive so far - which repos should we try it on? I'm thinking
> core, proxy, katello and the website for now? We can put it everywhere if
> that goes well.
>
> I don't think I have the rights to enable it though, so I'll need someone
> to volunteer to do that :)
>
> Cheers
> Greg
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [foreman-dev] Use mention-bot to increase reviews?

2016-10-12 Thread Daniel Lobato Garcia
On 10/11, Greg Sutcliffe wrote:
> We've spoken before about increasing the pool of reviewers, and one issue
> is the increasingly large amount of notification email (especially if you
> subscribe to a lot of our repos).
>
> So I was browsing some other repos today and stumbled upon this:
>
> https://github.com/facebook/mention-bot
>
> It's basically a tool to figure out who might be good reviewers for a pull
> request, and mention them by name so that they get a notification. This
> allows people to get a heads-up on repos they're not subscribed to, but
> have contributed to.
>
> Worth enabling on a few repos and giving it a try?

+1 from me - there's always time to shut it down if it doesn't help

>
> Cheers
> --
> Greg
> IRC: gwmngilfen
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

--
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature


Re: [foreman-dev] Remote_working_dir ignored?

2016-10-12 Thread Ivan Necas
Duncan Innes  writes:

> I've seen some tickets about 
> the --foreman-proxy-plugin-remote-execution-ssh-remote-working-dir 
> operative being ignored, but thought that they had been fixed.
>
> I'm running Foreman 1.13 final (through a Katellite 3.2 RC install) from 
> the following install command today:
>
> foreman-installer --scenario katello --enable-capsule 
> --foreman-initial-organization Innes --foreman-initial-location Laptop 
> --enable-foreman-proxy-plugin-remote-execution-ssh 
> --enable-foreman-plugin-remote-execution 
> --foreman-proxy-plugin-remote-execution-ssh-remote-working-dir 
> /opt/foreman-scripts
>
> but am still seeing remote commands pushed to the /var/tmp folder on my 
> clients.
>
> Have I missed something?

Hi,

No, it seems we've missed the change in puppet modules in 1.13. I've
opened an issue request to cherry-pick the change to 1.13.1 here
http://projects.theforeman.org/issues/16886

Thanks for the report

-- Ivan

>
> Cheers
>
> D
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.