Re: [foreman-dev] request for write-access to katello-packaging

[Eric D Helms]

+1 from me as well

On Fri, Sep 22, 2017 at 3:57 AM, Lukas Zapletal  wrote:

> +1 thanks for all the help there.
>
> On Thu, Sep 21, 2017 at 6:47 PM, John Mitsch  wrote:
> > +1 from me, you've been a great help at reviewing the katello scripts!
> >
> > -John
> >
> > John Mitsch
> > Red Hat Engineering
> > (860)-967-7285
> > irc: jomitsch
> >
> > On Thu, Sep 21, 2017 at 12:00 PM, Evgeni Golov 
> wrote:
> >>
> >> Ohai,
> >>
> >> I would like to request write access to katello-packaging.
> >>
> >> I have 14 merged PRs [1] resulting in 14 commits [2].
> >> If I count it right, I also somehow reviewed 19 PRs [3].
> >>
> >> TIA
> >> Evgeni
> >>
> >> [1]
> >> https://github.com/Katello/katello-packaging/pulls?page=
> 1=is%3Apr+author%3Aevgeni=%E2%9C%93
> >> [2] https://github.com/Katello/katello-packaging/commits?author=evgeni
> >> [3]
> >> https://github.com/Katello/katello-packaging/pulls?utf8=%
> E2%9C%93=involves%3Aevgeni%20is%3Apr%20
> >>
> >>
> >> --
> >> Beste Grüße/Kind regards,
> >>
> >> Evgeni Golov
> >> Software Engineer
> >> 
> 
> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
> >> Commercial register: Amtsgericht Muenchen, HRB 153243,
> >> Managing Directors: Charles Cachera, Michael Cunningham, Michael
> >> O'Neill, Eric Shander
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> Groups
> >> "foreman-dev" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an
> >> email to foreman-dev+unsubscr...@googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to foreman-dev+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Later,
>   Lukas @lzap Zapletal
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Database and Service Actions in RPM Post Scripts

[Christopher Duryee]

On Fri, Sep 22, 2017 at 4:19 PM, Eric D Helms  wrote:

> Howdy,
>
> There have been recent conversations that have popped up on PRs, for
> example [1], and IRC conversations around whether or not our RPM packages
> should be performing database actions and restarting services. This thread
> is intended to gather feedback and view points to arrive a community
> decision on whether or not we should continue this behavior, alter it with
> limitation or out right get rid of it.
>
> This mostly happens within Foreman and some plugins, and the actions
> performed today:
>
>  * database migrations
>  * database seeds
>  * apipie cache
>  * httpd restart
>  * foreman-tasks restart
>
> There may be others, these are the ones I am aware of. The history of
> these actions, as I understand it, is so that in theory you can yum install
> a plugin and, without further action, the Foreman server continue to run
> now with your plugin.
>
> Now, for my personal view point. Our application stack is fairly complex,
> and there are a decently large number high percentage install plugins and
> ecosystem of plugins in general. Plugins performing these sorta actions as
> part of yum install has the potential to create unintended consequences. We
> have created an idempotent installer to manage our server installations for
> a reason, to help orchestrate changes, provide a framework for known and
> coordinated change. And that these types of actions should be strictly
> relegated to it.
>

I would like if the only code in the RPM scripts was to land the bits on
the system's disk and nothing more. If the RPM scripts break, it is
difficult to find out what happened, and we already provide
foreman-installer to handle updating the system. The RPM scripts doing
things like db:seed and restarts can cause confusion when the application
starts up in a half-ready state during a maintenance window. Many users are
not aware that these types of things can even happen via %post, and are
surprised by it. They are also surprised if application error messages or
unusual return codes appear during RPM install.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Database and Service Actions in RPM Post Scripts

[Eric D Helms]

Howdy,

There have been recent conversations that have popped up on PRs, for
example [1], and IRC conversations around whether or not our RPM packages
should be performing database actions and restarting services. This thread
is intended to gather feedback and view points to arrive a community
decision on whether or not we should continue this behavior, alter it with
limitation or out right get rid of it.

This mostly happens within Foreman and some plugins, and the actions
performed today:

 * database migrations
 * database seeds
 * apipie cache
 * httpd restart
 * foreman-tasks restart

There may be others, these are the ones I am aware of. The history of these
actions, as I understand it, is so that in theory you can yum install a
plugin and, without further action, the Foreman server continue to run now
with your plugin.

Now, for my personal view point. Our application stack is fairly complex,
and there are a decently large number high percentage install plugins and
ecosystem of plugins in general. Plugins performing these sorta actions as
part of yum install has the potential to create unintended consequences. We
have created an idempotent installer to manage our server installations for
a reason, to help orchestrate changes, provide a framework for known and
coordinated change. And that these types of actions should be strictly
relegated to it.

I encourage all Foreman and plugin developers to please weigh in so that we
may reach consensus.

Thanks for your time and consideration.


[1] https://github.com/theforeman/foreman-packaging/pull/1761

-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] request for write-access to katello-packaging

[Lukas Zapletal]

+1 thanks for all the help there.

On Thu, Sep 21, 2017 at 6:47 PM, John Mitsch  wrote:
> +1 from me, you've been a great help at reviewing the katello scripts!
>
> -John
>
> John Mitsch
> Red Hat Engineering
> (860)-967-7285
> irc: jomitsch
>
> On Thu, Sep 21, 2017 at 12:00 PM, Evgeni Golov  wrote:
>>
>> Ohai,
>>
>> I would like to request write access to katello-packaging.
>>
>> I have 14 merged PRs [1] resulting in 14 commits [2].
>> If I count it right, I also somehow reviewed 19 PRs [3].
>>
>> TIA
>> Evgeni
>>
>> [1]
>> https://github.com/Katello/katello-packaging/pulls?page=1=is%3Apr+author%3Aevgeni=%E2%9C%93
>> [2] https://github.com/Katello/katello-packaging/commits?author=evgeni
>> [3]
>> https://github.com/Katello/katello-packaging/pulls?utf8=%E2%9C%93=involves%3Aevgeni%20is%3Apr%20
>>
>>
>> --
>> Beste Grüße/Kind regards,
>>
>> Evgeni Golov
>> Software Engineer
>> 
>> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
>> Commercial register: Amtsgericht Muenchen, HRB 153243,
>> Managing Directors: Charles Cachera, Michael Cunningham, Michael
>> O'Neill, Eric Shander
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.