Re: updating extundelete
Le lundi 13 juin 2011 à 01:07:49 (+0200 CEST), Elías Alejandro a écrit : [...] Also, I have noticed the comments in src/extundelete.cc state the program is distributed under GPL-2 and not GPL-2+. I've Added this copyright/license. You have forgotten to change the License field for 'Files: *' accordingly. The rest seems now OK. Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 ___ forensics-devel mailing list forensics-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
Re: updating extundelete
Hi Elías, Le dimanche 12 juin 2011 à 00:46:24 (+0200 CEST), Elías Alejandro a écrit : Hi Julien, First all, thanks for your help and advices. Here some answers Thanks for *your* work on this package. On Mon, Jun 06, 2011 at 08:55:37PM +0200, Julien Valroff wrote: [...] * debhelper compatibility should be bumped to 8 given you build-depend on = 8.0.0 Done. Actually, not yet fixed: `echo 8 debian/compat' will fix this (or reduce debhelper version to 7 in the build-dependencies if you prefer). Also, I have noticed the comments in src/extundelete.cc state the program is distributed under GPL-2 and not GPL-2+. Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 ___ forensics-devel mailing list forensics-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
Re: updating extundelete
Hi Julien, On Sun, Jun 12, 2011 at 03:33:08PM +0200, Julien Valroff wrote: Thanks for *your* work on this package. No problem at all ;) Actually, not yet fixed: `echo 8 debian/compat' will fix this (or reduce debhelper version to 7 in the build-dependencies if you prefer). Now it seems ok. Also, I have noticed the comments in src/extundelete.cc state the program is distributed under GPL-2 and not GPL-2+. I've Added this copyright/license. Also I've tested with pbuilder and piuparts and it seems works fine. Best regards, -- Elías Alejandro ___ forensics-devel mailing list forensics-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
Re: updating extundelete
Hi Julien, First all, thanks for your help and advices. Here some answers On Mon, Jun 06, 2011 at 08:55:37PM +0200, Julien Valroff wrote: * Remove useless comments from debian/rules Done. * You don't need to refer to your patch in the changelog, it's a new package. The README.Debian also seems useless. Both things can easily be replaced by using DEP-3 formatted headers in the patch file itself. Done. * Again about this patch: have you forwarded it to upstream developers? If so, have they accepted it? I think it is a good idea to try and keep the Debian package as close as possible to the upstream tarball, and hence avoid unnecessary patches. I've forwarded since last year and recently last week, but no upstream answers so far. This patch allow flexibility to recover files in anywhere place and not just in the current directory as default behaviour. * Have you also forwarded the manpage you have written? I guess this can * be useful for upstream to include it in their tarball. Yes, but the same patch's story no answers so far. * You should use a standalone license paragraph for (at least) GPL-2+ (see DEP-5 for details) I think now is a little bit more improved. * debhelper compatibility should be bumped to 8 given you build-depend on = 8.0.0 Done. Please let me know any news and I will work in about it. Best regards, -- Elías Alejandro ___ forensics-devel mailing list forensics-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
Re: updating extundelete
Hi Elías, Le dimanche 05 juin 2011 à 22:50:02 (+0200 CEST), Elías Alejandro a écrit : Hi I've just updated extundelete[1]. Any member willing to review it?. Thanks for your good work. I think todo is: - Add Christophe Monniez copyright. - Sync date under debian/changelog to be agree with Debian Policy 3.9.2 (if not lintian warning). I had a quick look at the package, and it looks mainly ok, though here are some tiny improvement suggestions beside the above points: * Remove useless comments from debian/rules * You don't need to refer to your patch in the changelog, it's a new package. The README.Debian also seems useless. Both things can easily be replaced by using DEP-3 formatted headers in the patch file itself. * Again about this patch: have you forwarded it to upstream developers? If so, have they accepted it? I think it is a good idea to try and keep the Debian package as close as possible to the upstream tarball, and hence avoid unnecessary patches. * Have you also forwarded the manpage you have written? I guess this can * be useful for upstream to include it in their tarball. * You should use a standalone license paragraph for (at least) GPL-2+ (see DEP-5 for details) * debhelper compatibility should be bumped to 8 given you build-depend on = 8.0.0 - Someone willing DD under uploader field, to finally upload it. I'd be happy to upload this package for you once these points are fixed. Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 ___ forensics-devel mailing list forensics-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
updating extundelete
Hi I've just updated extundelete[1]. Any member willing to review it?. I think todo is: - Add Christophe Monniez copyright. - Sync date under debian/changelog to be agree with Debian Policy 3.9.2 (if not lintian warning). - Someone willing DD under uploader field, to finally upload it. [1] http://anonscm.debian.org/gitweb/?p=forensics/extundelete.git;a=summary Best regards, -- Elías Alejandro ___ forensics-devel mailing list forensics-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
