Re: [fossil-dev] Check-in etiquette

[Baruch Burstein]

On Thu, Aug 27, 2015 at 11:15 AM, Jan Nijtmans jan.nijtm...@gmail.com
wrote:


 Joe already correct that:
 http://www.fossil-scm.org/index.html/info/e947fce957171e44


I saw that (thanks from me too).I was wondering for future times.

The only potential problem: people might wonder how you tested
 the change.


I made the change locally in my makefile and used it. I then made the same
change in the tcl script and committed that one.
I guess I could have just committed my hand-changed makefile.

-- 
˙uʍop-ǝpısdn sı ɹoʇıuoɯ ɹnoʎ 'sıɥʇ pɐǝɹ uɐɔ noʎ ɟı
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Re: [fossil-dev] Check-in etiquette

[Jan Nijtmans]

2015-08-27 9:33 GMT+02:00 Baruch Burstein bmburst...@gmail.com:
 Hi,

 I know that when making changes to makemake.tcl, I am expected to run the
 script to generate the new makefiles and check them in as well. However, I
 am on a computer where I cannot easily install TCL (company policy). I
 committed the changes to makemake.tcl without regenerating the makefiles,
 leaving that to someone else. Is this acceptable?

Joe already correct that:
http://www.fossil-scm.org/index.html/info/e947fce957171e44

Thanks!

The only potential problem: people might wonder how you tested
the change. In this case, your change works fine and looks good to me.
Joe apparently agreed with this change, I agree as well. Well done!

Regards,
   Jan Nijtmans
___
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev