Re: [fpc-devel] Important: Call for testing.
On Sat, 29 Mar 2008, Martin Schreiber wrote: > On Saturday 29 March 2008 21.52:51 Michael Van Canneyt wrote: > > > > Jesus just told me that it is fixed in r10587. > > > > Great, I set the bug to resolved. > > > > Seems like the most obvious bugs are fixed. > > Now I wait for the subtle ones to appear ;-) > > > Here it is the first one: > http://bugs.freepascal.org/view.php?id=11067 > (Wrong ancestor value in defineproperties). Seems fixed now. I hope I have done it correct (your test program runs fine) and didn't break anything else... :( Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
On Saturday 29 March 2008 21.52:51 Michael Van Canneyt wrote: > > Jesus just told me that it is fixed in r10587. > > Great, I set the bug to resolved. > > Seems like the most obvious bugs are fixed. > Now I wait for the subtle ones to appear ;-) > Here it is the first one: http://bugs.freepascal.org/view.php?id=11067 (Wrong ancestor value in defineproperties). 11060 seems to be fixed for MSEide too, thanks a lot. Martin ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
On Sat, 29 Mar 2008, Vincent Snijders wrote: > Jesus Reyes A. schreef: > > > > - Original Message - From: "C Western" <[EMAIL PROTECTED]> > > To: "FPC developers' list" > > Sent: Saturday, March 29, 2008 11:04 AM > > Subject: Re: [fpc-devel] Important: Call for testing. > > > > > > > There also seems to be a problem with fixing up references to other > > > components while reading - TLabel.FocusControl seems to be one of the > > > things that is tripping this up. Local unresolved references are being > > > silently discarded, but I think should be added to the global list. The > > > attached patch fixes it for my application, but might not be the best > > > general fix. > > > > > > Colin > > > > > This patch fixes issue 11060, however, while trying to open project's > > compiler options dialog I get this: > > > > > > > > Other dialogs seems to be fine though. > > > > Jesus just told me that it is fixed in r10587. Great, I set the bug to resolved. Seems like the most obvious bugs are fixed. Now I wait for the subtle ones to appear ;-) Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
Jesus Reyes A. schreef: - Original Message - From: "C Western" <[EMAIL PROTECTED]> To: "FPC developers' list" Sent: Saturday, March 29, 2008 11:04 AM Subject: Re: [fpc-devel] Important: Call for testing. There also seems to be a problem with fixing up references to other components while reading - TLabel.FocusControl seems to be one of the things that is tripping this up. Local unresolved references are being silently discarded, but I think should be added to the global list. The attached patch fixes it for my application, but might not be the best general fix. Colin This patch fixes issue 11060, however, while trying to open project's compiler options dialog I get this: Other dialogs seems to be fine though. Jesus just told me that it is fixed in r10587. Vincent ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
On Sat, 29 Mar 2008, C Western wrote: > There also seems to be a problem with fixing up references to other components > while reading - TLabel.FocusControl seems to be one of the things that is > tripping this up. Local unresolved references are being silently discarded, > but I think should be added to the global list. The attached patch fixes it > for my application, but might not be the best general fix. Indeed. It completely short-circuits the idea of trying to locally resolve references before trying globally :) Anyway, your hint gave me the idea where to look. I fixed the issue properly. The error was in another routine altogether. Hopefully now 11060 is really fixed. Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
- Original Message - From: "C Western" <[EMAIL PROTECTED]> To: "FPC developers' list" Sent: Saturday, March 29, 2008 11:04 AM Subject: Re: [fpc-devel] Important: Call for testing. There also seems to be a problem with fixing up references to other components while reading - TLabel.FocusControl seems to be one of the things that is tripping this up. Local unresolved references are being silently discarded, but I think should be added to the global list. The attached patch fixes it for my application, but might not be the best general fix. Colin This patch fixes issue 11060, however, while trying to open project's compiler options dialog I get this: TApplication.HandleException Cannot focus a disabled or invisible window Stack trace: $0041910F TCUSTOMFORM__SETACTIVECONTROL, line 1264 of ../include/customform.i nc $004843DB SETORDPROP, line 938 of E:/fpcsvn/fpcmirror/rtl/objpas/typinfo.pp $00484754 SETOBJECTPROP, line 1096 of E:/fpcsvn/fpcmirror/rtl/objpas/typinfo ..pp $004657BE TUNRESOLVEDREFERENCE__RESOLVE, line 233 of E:/fpcsvn/fpcmirror/rtl /objpas/classes/resref.inc $0046596A TUNRESOLVEDINSTANCE__RESOLVEREFERENCES, line 287 of E:/fpcsvn/fpcm irror/rtl/objpas/classes/resref.inc $00465DD4 TRESOLVEREFERENCEVISITOR__VISIT, line 453 of E:/fpcsvn/fpcmirror/r tl/objpas/classes/resref.inc $00465416 TLINKEDLIST__FOREACH, line 92 of E:/fpcsvn/fpcmirror/rtl/objpas/cl asses/sllist.inc $00465654 VISITRESOLVELIST, line 131 of E:/fpcsvn/fpcmirror/rtl/objpas/class es/resref.inc $004656DD GLOBALFIXUPREFERENCES, line 151 of E:/fpcsvn/fpcmirror/rtl/objpas/ classes/resref.inc $0046C6DA TREADER__READROOTCOMPONENT, line 1299 of E:/fpcsvn/fpcmirror/rtl/o bjpas/classes/reader.inc $004BDCAD INITCOMPONENT, line 2746 of lresources.pp $004BDB0F INITLAZRESOURCECOMPONENT, line 2766 of lresources.pp $004B8DF7 INITRESOURCECOMPONENT, line 542 of lresources.pp $0041957D TCUSTOMFORM__CREATE, line 1377 of ./include/customform.inc $0041AE26 TFORM__CREATE, line 2115 of ./include/customform.inc $007668BA TFRMCOMPILEROPTIONS__CREATE, line 294 of compileroptionsdlg.pp $0042F612 TMAINIDE__MNUPROJECTCOMPILERSETTINGSCLICKED, line 3516 of main.pp Other dialogs seems to be fine though. Jesus Reyes A. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] xlib patch
On Sat, 29 Mar 2008, C Western wrote: > The recent xlib change seems to contain an infinite loop - the attached patch > fixes it for me Applied, thanks ! Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] xlib patch
On Sat, 29 Mar 2008, C Western wrote: > The recent xlib change seems to contain an infinite loop - the attached patch > fixes it for me Thanks, applied ! Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] xlib patch
The recent xlib change seems to contain an infinite loop - the attached patch fixes it for me Colin diff -uNr --exclude=.svn --exclude='*.rst' trunk/fpcsrc/packages/x11/src/xlib.pp trunk.w/fpcsrc/packages/x11/src/xlib.pp --- trunk/fpcsrc/packages/x11/src/xlib.pp 2008-03-29 12:07:09.0 + +++ trunk.w/fpcsrc/packages/x11/src/xlib.pp 2008-03-29 16:57:37.0 + @@ -2097,7 +2097,7 @@ function XInternAtom(para1:PDisplay; para2:Pchar; para3:Boolean):TAtom; begin - Result:=XInternAtom(para1,para2,para3); + Result:=XInternAtom(para1,para2,Ord(para3)); end; function XInternAtoms(para1:PDisplay; para2:PPchar; para3:cint; para4:Boolean; para5:PAtom):TStatus; ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
There also seems to be a problem with fixing up references to other
components while reading - TLabel.FocusControl seems to be one of the
things that is tripping this up. Local unresolved references are being
silently discarded, but I think should be added to the global list. The
attached patch fixes it for my application, but might not be the best
general fix.
Colin
diff -uNr --exclude=.svn --exclude='*.rst' trunk/fpcsrc/rtl/objpas/classes/reader.inc trunk.w/fpcsrc/rtl/objpas/classes/reader.inc
--- trunk/fpcsrc/rtl/objpas/classes/reader.inc 2008-03-29 16:56:06.0 +
+++ trunk.w/fpcsrc/rtl/objpas/classes/reader.inc 2008-03-29 16:57:37.0 +
@@ -630,7 +630,7 @@
procedure TReader.DoFixupReferences;
Var
- R,RN : TLocalUnresolvedReference;
+ R : TLocalUnresolvedReference;
G : TUnresolvedInstance;
Ref : String;
C : TComponent;
@@ -644,7 +644,6 @@
R:=TLocalUnresolvedReference(L.Root);
While (R<>Nil) do
begin
- RN:=TLocalUnresolvedReference(R.Next);
Ref:=R.FRelative;
If Assigned(FOnReferenceName) then
FOnReferenceName(Self,Ref);
@@ -654,14 +653,10 @@
else
begin
P:=Pos('.',R.FRelative);
-If (P<>0) then
- begin
- G:=AddToResolveList(R.FInstance);
- G.Addreference(R.FRoot,R.FPropInfo,Copy(R.FRelative,1,P-1),Copy(R.FRelative,P+1,Length(R.FRelative)-P));
- end;
+G:=AddToResolveList(R.FInstance);
+G.Addreference(R.FRoot,R.FPropInfo,Copy(R.FRelative,1,P-1),Copy(R.FRelative,P+1,Length(R.FRelative)-P));
end;
- L.RemoveItem(R,True);
- R:=RN;
+ R:=TLocalUnresolvedReference(R.Next);
end;
FreeAndNil(FFixups);
end;
diff -uNr --exclude=.svn --exclude='*.rst' trunk/fpcsrc/rtl/objpas/classes/resref.inc trunk.w/fpcsrc/rtl/objpas/classes/resref.inc
--- trunk/fpcsrc/rtl/objpas/classes/resref.inc 2008-03-28 09:19:50.0 +
+++ trunk.w/fpcsrc/rtl/objpas/classes/resref.inc 2008-03-29 16:57:37.0 +
@@ -220,7 +220,10 @@
C : TComponent;
begin
- C:=FindGlobalComponent(FGlobal);
+ if FGlobal <> '' then
+C:=FindGlobalComponent(FGlobal)
+ else
+C:=FRoot;
Result:=(C<>Nil);
If Result then
begin
@@ -229,7 +232,7 @@
If Result then
SetObjectProp(Instance, FPropInfo,C);
end;
-end;
+end;
Function TUnresolvedReference.RootMatches(ARoot : TComponent) : Boolean; Inline;
___
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] OS/2- make: Entering an unknown directory
On 29 Mar 2008, at 16:34, Tomas Hajny wrote: On Sat, March 29, 2008 16:05, Jonas Maebe wrote: On 29 Mar 2008, at 15:47, Tomas Hajny wrote: As of now, the dependencies are the same for the whole directory gtk1 and I'm afraid that there's no way for making the dependency only valid for some targets and not others You can specify separate dependencies for a particular targets in Makefile.fpc, search e.g. for fcl-db_all in packages/Makefile.fpc If I understand you correctly, you refer to dependencies listed in the rules part of packages/Makefile.fpc (where the dependency of gtk1 on opengl is listed too, but it's conditional there). However, if you look at packages/gtk1/Makefile.fpc, you can see the reference to opengl in section [require]. This one is the the real issue for me and I'm not sure if your recommendation can solve that. The only effect of [require] sections is that -Fu/path/to/required/ dependency/units/$fpctarget is added when compiling. So those sections don't really matter (as long as you disable the compilation of gtkglarea for OS/2). Jonas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] OS/2- make: Entering an unknown directory
On Sat, March 29, 2008 16:05, Jonas Maebe wrote: > > On 29 Mar 2008, at 15:47, Tomas Hajny wrote: >> As of now, the dependencies are the same for the whole >> directory gtk1 and I'm afraid that there's no way for making the >> dependency only valid for some targets and not others > > You can specify separate dependencies for a particular targets in > Makefile.fpc, search e.g. for fcl-db_all in packages/Makefile.fpc If I understand you correctly, you refer to dependencies listed in the rules part of packages/Makefile.fpc (where the dependency of gtk1 on opengl is listed too, but it's conditional there). However, if you look at packages/gtk1/Makefile.fpc, you can see the reference to opengl in section [require]. This one is the the real issue for me and I'm not sure if your recommendation can solve that. Tomas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] OS/2- make: Entering an unknown directory
On 29 Mar 2008, at 15:47, Tomas Hajny wrote: As of now, the dependencies are the same for the whole directory gtk1 and I'm afraid that there's no way for making the dependency only valid for some targets and not others You can specify separate dependencies for a particular targets in Makefile.fpc, search e.g. for fcl-db_all in packages/Makefile.fpc Jonas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] OS/2- make: Entering an unknown directory
On Sat, March 29, 2008 09:39, Dave Parsons wrote: Hi Dave, > I've just updated from SVN and rebuilt the compiler again. > The problem I reported last time appears to be fixed now, > thanks. > 'Free Pascal Compiler version 2.3.1 [2008/03/29] for i386' > > However, the problem I mentioned last time, but forgot to > detail (sorry), is still there. > > It seems to be a configuration problem but I'm not sure > where so I'll just post the last few lines from the log. It's a problem in makefiles. Unfortunately, several makefiles got broken for OS/2 platform during recent restructuring of the packages. There are two problems there: 1) Packages were transformed to a uniform structure, i.e. all packages directories have the same subdirectories now (which is obviously good). However, insufficient attention was paid to changing references to previously existing directories which were renamed to something else now. This is specifically the case with packages only compiled on targets not used by many FPC core developers (like OS/2 only used by me out of the core team). This is the issue you encountered here - original subdirectory called "test" (under "rexx") was renamed to "examples", but Makefile.fpc and Makefile weren't adapted. This is quite easy to fix, it's just happening at several places. 2) While changing the structure, some of the dependencies were changed in order to simplify them. Unfortunately, some assumptions made during this simplification are not valid under OS/2. Fixing this is more complicated for two reasons. First, one only finds it one after another (i.e. after you encounter it, you try make again, it fails on another spot, etc.), so it takes more time. Second, sometimes it isn't that easy to find working rules in Makefile without reverting everything to the previous structure. An example of this is package "gtk1" which now assumes dependency on opengl whereas opengl package is not available for OS/2 at the moment (I guess that it would be possible to adapt it to OS/2 too, possibly using the IBM OpenGL implementation, but nobody has done that so far). In any case, this dependency on opengl is only valid for unit gtkglarea residing in standalone subdirectory gtkgl. Previously, this subdirectory had its own Makefile, so it was simply built only for targets fulfilling all prerequisites. As of now, the dependencies are the same for the whole directory gtk1 and I'm afraid that there's no way for making the dependency only valid for some targets and not others (it isn't a problem to skip building gtkglarea on certain targets, but that is not enough here). I'm afraid that I'll have to disable building gtk1 units under OS/2 altogether (alternatively, I could make a new standalone package from gtkglarea, but I'm not sure if this solution is appreciated by others). Tomas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
On Sat, 29 Mar 2008, C Western wrote: > There seems to be a problem in TReader.FindComponentClass - the search in > FindInFieldTable does not properly include ancestors. Great, I applied the patch. This should probably fix issue 11060 ! Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
There seems to be a problem in TReader.FindComponentClass - the search in FindInFieldTable does not properly include ancestors. See attached patch Colin diff -uNr --exclude=.svn --exclude='*.rst' trunk/fpcsrc/rtl/objpas/classes/reader.inc trunk.w/fpcsrc/rtl/objpas/classes/reader.inc --- trunk/fpcsrc/rtl/objpas/classes/reader.inc 2008-03-28 09:19:50.0 + +++ trunk.w/fpcsrc/rtl/objpas/classes/reader.inc 2008-03-29 13:38:54.0 + @@ -1470,7 +1470,7 @@ // descendants of TComponent while ComponentClassType<>TComponent do begin FieldClassTable := -PFieldTable((Pointer(RootComponent.ClassType)+vmtFieldTable)^)^.ClassTable; +PFieldTable((Pointer(ComponentClassType)+vmtFieldTable)^)^.ClassTable; if assigned(FieldClassTable) then begin for i := 0 to FieldClassTable^.Count -1 do begin Entry := FieldClassTable^.Entries[i]; ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
Vincent Snijders schreef: Michael Van Canneyt schreef: There still is a memleak in the reader, when starting and stopping Lazarus: 333861 memory blocks allocated : 48899445/49814032 333803 memory blocks freed : 48898000/49812384 58 unfreed memory blocks : 1445 I think I plugged that one (Vincent: we had it in the tests too, if you recall). Can you test please ? If it persists, please send me the heaptrc output, that will make searching easier. It is not yet fixed. I sent heaptrc to you privately. Fixed in 10583: Heap dump by heaptrc unit 338700 memory blocks allocated : 45274460/46194864 338700 memory blocks freed : 45274460/46194864 0 unfreed memory blocks : 0 Vincent ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
Michael Van Canneyt schreef: There still is a memleak in the reader, when starting and stopping Lazarus: 333861 memory blocks allocated : 48899445/49814032 333803 memory blocks freed : 48898000/49812384 58 unfreed memory blocks : 1445 I think I plugged that one (Vincent: we had it in the tests too, if you recall). Can you test please ? If it persists, please send me the heaptrc output, that will make searching easier. It is not yet fixed. I sent heaptrc to you privately. Vincent ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Important: Call for testing.
On Fri, 28 Mar 2008, Vincent Snijders wrote: > Martin Schreiber schreef: > > On Thursday 27 March 2008 21.50:33 Michael Van Canneyt wrote: > > > While extensive testing has been done (using the FPCunit testing > > > framework), and the working of Lazarus with this new code was verified, it > > > is possible that bugs remain. We would therefor very much appreciate that > > > if you have code that uses some of the routines below, that you test your > > > code with the latest FPC from subversion (revision 10572 or above) and > > > report any bugs that you may encounter. If you do, please submit a > > > bugreport in mantis: > > > > > > http://bugs.freepascal.org/ > > > > > http://bugs.freepascal.org/view.php?id=11059 > > Does this cause no problems for Lazarus? > > 11059 should be fixed. > > I added this and 11060 to the cleanroom page. > http://wiki.lazarus.freepascal.org/FPC_Cleanroom#Bug_reports > > There still is a memleak in the reader, when starting and stopping Lazarus: > 333861 memory blocks allocated : 48899445/49814032 > 333803 memory blocks freed : 48898000/49812384 > 58 unfreed memory blocks : 1445 I think I plugged that one (Vincent: we had it in the tests too, if you recall). Can you test please ? If it persists, please send me the heaptrc output, that will make searching easier. 11060 is a harder nut to crack, though. Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] OS/2- make: Entering an unknown directory
Hi, I've just updated from SVN and rebuilt the compiler again. The problem I reported last time appears to be fixed now, thanks. 'Free Pascal Compiler version 2.3.1 [2008/03/29] for i386' However, the problem I mentioned last time, but forgot to detail (sorry), is still there. It seems to be a configuration problem but I'm not sure where so I'll just post the last few lines from the log. Cheers, Dave -- make[4]: Leaving directory `F:/fpc/fpcbuild/fpcsrc/packages/fpgtk' make -C rexx clean make[4]: Entering directory `F:/fpc/fpcbuild/fpcsrc/packages/rexx' F:/EMX/BIN/rm.exe -f units/os2/rexxsaa.ppu F:/EMX/BIN/rm.exe -f fpcmade.os2 Package.fpc ppas.cmd script.res link.res F:/EMX/BIN/rm.exe -f *.s *_ppas.cmd make -C test clean make: Entering an unknown directory make: *** test: No such file or directory. Stop. make: Leaving an unknown directory make[4]: *** [test_clean] Error 2 make[4]: Leaving directory `F:/fpc/fpcbuild/fpcsrc/packages/rexx' make[3]: *** [rexx_clean] Error 2 make[3]: Leaving directory `F:/fpc/fpcbuild/fpcsrc/packages' make[2]: *** [packages_clean] Error 2 make[2]: Leaving directory `F:/fpc/fpcbuild/fpcsrc' make[1]: *** [build-stamp.i386-os2] Error 2 make[1]: Leaving directory `F:/fpc/fpcbuild/fpcsrc' make: *** [fpcsrc/build-stamp.i386-os2] Error 2 ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
