Re: [fpc-devel] Regressions on i386-win32 and x86_64-win64

2019-03-02 Thread J. Gareth Moreton
 Hi Nikolai,
 I don't even know the testsuite URL myself - I just run the regression
tests as found under "fpc/tests", which is fairly public given there's a
readme file there explaining how to run them.
 I guess I'm a little confused because when I try to compile the tests
manually from the command line, they're successful, and they're also
successful when they shouldn't with my XML node dump patch applied
(#35017), but there's absolutely nothing I've changed that should cause
that compilation to be successful.  It does fail if I run the whole test
suite too, so ultimately I'm a little confused.  Unless I'm missing
something, all the results should be the same.

 Gareth aka. Kit

 On Sat 02/03/19 19:57 , Nikolai Zhubr n-a-zh...@yandex.ru sent:
 Hi, 

 02.03.2019 19:59, J. Gareth Moreton: 
 > It might need double-checking, but I'm getting a couple of regressions 
 > on the trunk for i386-win32 and x86_64-win64: 
 > 
 > Failed, compilation successful webtbf/tw4893d.pp 2018/12/06 07:01:14 
 > Failed, compilation successful webtbf/tw4893e.pp 2018/12/06 07:01:14 
 > 
 > Both these tests seem to be label/goto tests for {$mode fpc} and {$mode 
 > objfpc) - can anyone confirm, or do I have a faulty set-up? 

 Testsuite buildbots do not seem to list them as faulty currently, so if 
 you really meant the results against current svn repository then the 
 answer is probably the latter. You can check it yourself anytime, 
 although I'd refrain from advertising the URL of testsuite database 
 publicly (Instead, please ask Florian or some core developer to tell you 
 in private). 

 Regards, 
 Nikolai 

 > Gareth aka. Kit 
 > 
 > 
 > 
 > ___ 
 > fpc-devel maillist - fpc-devel@lists.freepascal.org [1] 
 > http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
[2]">http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel 

 ___ 
 fpc-devel maillist - fpc-devel@lists.freepascal.org [3] 
 http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
[4]">http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel 

 

Links:
--
[1] mailto:fpc-devel@lists.freepascal.org
[2] http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
[3] mailto:fpc-devel@lists.freepascal.org
[4] http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Getting built-in string type

2019-03-02 Thread Ryan Joseph
I’ve looked into this more today and I don’t see how we can get around needing 
a typesym for specializations.


For example:

generic procedure DoThis(msg: T);
begin
end;

var
a: array of char;
begin
DoThis(a);


Is going to specialize as DoThis(a). “array of char” is (for 
lack of the proper term) an anonymous dynamic array and would be not a valid 
specialization unless an explicit type was declared.

For strings I figured out I could use the built-in system type 
“cshortstringtype” if is_chararray() return true (for specializing string 
constants like in my initial question) but that is specific to string constants.

For normal function calls this isn’t a problem because the type is always 
specified but for implicit specializations the type may need to be declared in 
order for the specialization to be possible.

Regards,
Ryan Joseph

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Regressions on i386-win32 and x86_64-win64

2019-03-02 Thread Nikolai Zhubr

Hi,

02.03.2019 19:59, J. Gareth Moreton:

It might need double-checking, but I'm getting a couple of regressions
on the trunk for i386-win32 and x86_64-win64:

Failed, compilation successful webtbf/tw4893d.pp 2018/12/06 07:01:14
Failed, compilation successful webtbf/tw4893e.pp 2018/12/06 07:01:14

Both these tests seem to be label/goto tests for {$mode fpc} and {$mode
objfpc) - can anyone confirm, or do I have a faulty set-up?


Testsuite buildbots do not seem to list them as faulty currently, so if 
you really meant the results against current svn repository then the 
answer is probably the latter. You can check it yourself anytime, 
although I'd refrain from advertising the URL of testsuite database 
publicly (Instead, please ask Florian or some core developer to tell you 
in private).



Regards,
Nikolai



Gareth aka. Kit



___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


[fpc-devel] Regressions on i386-win32 and x86_64-win64

2019-03-02 Thread J. Gareth Moreton
 It might need double-checking, but I'm getting a couple of regressions on
the trunk for i386-win32 and x86_64-win64:

 Failed, compilation successful webtbf/tw4893d.pp 2018/12/06 07:01:14
 Failed, compilation successful webtbf/tw4893e.pp 2018/12/06 07:01:14

 Both these tests seem to be label/goto tests for {$mode fpc} and {$mode
objfpc) - can anyone confirm, or do I have a faulty set-up?

 Gareth aka. Kit
 ___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] TRegistry and Unicode

2019-03-02 Thread Bart
On Sat, Mar 2, 2019 at 5:53 PM Bart  wrote:

> As a side note: I now have several patches for the registry in the
> bugtracker, and it gets increasingly difficult to make new patches for
> each issue if the "previous" (as in: the ones I made earlier) don't
> get applied.

Applying the patch for this should if possible be done after applying
the patch from https://bugs.freepascal.org/view.php?id=35022 (that
patch references a line with Utf8Encode still in it, so it possibly
can't be applied anymore if that line no longer exists).

-- 
Bart
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] TRegistry and Unicode

2019-03-02 Thread Bart
On Sat, Mar 2, 2019 at 3:48 PM Joost van der Sluis  wrote:

> The utf8encode should go, just like the utf8decode's that we fixed already.

Shall I post a patch in the bugtracker?
If so: instead of
SomeAnsiString := UTf8Encode(SomeUnicodeString) do I make it an
implicit conversion (SomeAnsiString := SomeUnicodeString), or an
explicit typecast (suppressing warnings: SomeAnsiString =
String(SomeUnicodeString))?

As a side note: I now have several patches for the registry in the
bugtracker, and it gets increasingly difficult to make new patches for
each issue if the "previous" (as in: the ones I made earlier) don't
get applied.

Bart
-- 
Bart
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] TRegistry and Unicode

2019-03-02 Thread Joost van der Sluis

Op 01-03-19 om 22:19 schreef Bart:

On Tue, Feb 26, 2019 at 10:49 AM Marco van de Voort
 wrote:


If I look into e.g. registry.pp, the only use of utf8encode there is
like this:

var  s : string;

 u:unicodestring;

s:=utf8encode(u);

which, IF lazarus is used in the default utf8 mode is equivalent to


s:=u;

   So currently this utf8encode only frustrates the situation for people
that don't set the default codepage to utf8?


Exactly.
It also breaks backwards compatibility.
Strings returned were encode in the systems codepage up to 3.0.4, now
thy are not.


The utf8encode should go, just like the utf8decode's that we fixed already.

Regards,

Joost.
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel