Re: [fpc-devel] Implicit function specialization precedence

2021-04-15 Thread Ryan Joseph via fpc-devel


> On Apr 14, 2021, at 3:49 PM, Ryan Joseph  wrote:
> 
> It works but it thinks this array is array of const also so it's too strict I 
> believe.
> 
> ['aaa', 'bbb'];

About this, shouldn't we just be doing this? Any array constructor that has 
elements which are which are incompatible is "array of const"? from 
tarrayconstructornode.pass_typecheck:

 if eq=te_incompatible then
   diff:=true;

Regards,
Ryan Joseph

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


Re: [fpc-devel] Implicit function specialization precedence

2021-04-15 Thread Ryan Joseph via fpc-devel


> On Apr 14, 2021, at 11:39 PM, Sven Barth  wrote:
> 
> Well, then I'll have to improve the check. But for now you can continue, 
> right?

I can continue but if I include the check some tests will fail. Currently I've 
only made some changes in create_unamed_typesym and now this check to reject 
array of const. Everything else is done AKAIK unless we discover more bugs in 
the tests (which I've uploaded on the bug tracker).

Regards,
Ryan Joseph

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel