Re: [fpc-pascal] Pull request for fphttpclient.pp in git mirror repo

2021-03-16 Thread Michael Van Canneyt via fpc-pascal



On Tue, 16 Mar 2021, Graeme Geldenhuys via fpc-pascal wrote:



On 16/03/2021 9:29 pm, Martin Frb via fpc-pascal wrote:

For none git users, githup offers patch/diff



Ah yes, I forgot to mention that. Thanks Martin.


Applied in Rev. 48992, so you can close it.

And thank the original contributer from me, please.

Michael.
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Pull request for fphttpclient.pp in git mirror repo

2021-03-16 Thread Graeme Geldenhuys via fpc-pascal

On 16/03/2021 9:29 pm, Martin Frb via fpc-pascal wrote:
> For none git users, githup offers patch/diff


Ah yes, I forgot to mention that. Thanks Martin.

G.
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Pull request for fphttpclient.pp in git mirror repo

2021-03-16 Thread Martin Frb via fpc-pascal

On 16/03/2021 22:21, Graeme Geldenhuys via fpc-pascal wrote:


   https://github.com/graemeg/freepascal/pull/18


Review instructions:


For none git users, githup offers patch/diff

https://github.com/graemeg/freepascal/compare/master...billyeatcookies:patch-1.diff
https://github.com/graemeg/freepascal/compare/master...billyeatcookies:patch-1.patch
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal


[fpc-pascal] Pull request for fphttpclient.pp in git mirror repo

2021-03-16 Thread Graeme Geldenhuys via fpc-pascal
Hi,

I just received a notification that somebody created a pull request for
FPC in my git mirror repository.

I will notify the person that it's a read-only repository, but if anybody
wanted to review and apply the changes directly, here is the link:

  https://github.com/graemeg/freepascal/pull/18


Review instructions: From your project repository, check out a new branch
and test the changes.

  git checkout -b billyeatcookies-patch-1 master
  git pull https://github.com/billyeatcookies/freepascal.git patch-1


Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal