Re: [Framework-Team] Re: Re: PLIP 212 ready for review

2008-02-15 Thread Tom Lazar

On Feb 14, 2008, at 1:57 PM, Florian Schulze wrote:

On Wed, 13 Feb 2008 20:20:40 +0100, Tom Lazar [EMAIL PROTECTED]  
wrote:



On 12.02.2008, at 23:41, Florian Schulze wrote:


instead i got the following error in jquery.js (via firebug)

   a is not a function
   [Break on this error] eval(function(p,a,c,k,e,r){e=function(c) 
{return(ca?'':e(parseInt(c/a)))+((c=c%a...


Note: this error remained, even after replacing the shipping  
jquery version 1.2.2 with the meanwhile current version 1.2.3


This looks like a syntax error in that file. I will look into it.


well, since it's the jquery.js file itself, i kind of doubt it  
(which also prompted me to try out the 1.2.3 version) but hey!  
you're the expert ;-)


This is either another syntax error, or some issue with the KSS  
interaction.


you tell me ;-)


I can't reproduce any of these issues. I tried my exisiting buildout  
and I made a fresh co of the buildout and ran buildout with the  
option to get the newest version of everything.


well, given the fact that i indeed *can* reproduce these, chances are,  
others will, too.


watching the process of publishing or retracting a page shows clearly,  
that the entire page is reloaded. i can see for an instance that a  
ressource named content_status_modify is called but immediately after  
that the whole page is reloaded.


as for item actions, for instance using the copy command indeed does  
*not* reload the entire page and works as advertised (not sure why i  
didn't catch that the first time round, i could have sworn it reloaded  
the page, too), but upon execution i get the following two JS errors:


Unhandled error during command execution: ReferenceError:  
initializeMenus is not defined++resource++kukit... (line 144)

initializeMenus is not defined
(no name)(Object node=ul#contentActionMenus parms=Object)++resource+ 
+kukit... (line 7793)

executeClientAction(bindActionMenus)++resource++kukit... (line 866)
execute(Object node=ul#contentActionMenus parms=Object)++resource+ 
+kukit... (line 2568)
execute(Object node=ul#contentActionMenus parms=Object)++resource+ 
+kukit... (line 2389)
EventBinder_triggerEvent(load, Object node=ul#contentActionMenus  
parms=Object)++resource++kukit... (line 3897)

func_to_bind(undefined)++resource++kukit... (line 981)
execute()++resource++kukit... (line 516)
addPre(function(), Setup of events for nodes subtrees [ul], [dt],  
[dd])++resource++kukit... (line 497)
doSetupEvents([\n, ul#contentActionMenus, dt, 1 more...])++resource+ 
+kukit... (line 1271)

finishSetupEventsCollection()++resource++kukit... (line 1241)
executeCommands(Object node=a#copy.actionicon-object_buttons-copy)+ 
+resource++kukit... (line 5833)
processResult(XMLHttpRequest channel=[xpconnect wrapped nsIChannel])+ 
+resource++kukit... (line 5306)
notifyServer_done(XMLHttpRequest channel=[xpconnect wrapped  
nsIChannel])++resource++kukit... (line 5217)

notifyServer_done()++resource++kukit... (line 5172)
[Break on this error] initializeMenus();

i'd still like to see this fixed before giving my thumbs up... (and  
i'd really love to see 3.1 to ship with jquery... if there's anything  
else i can do to help get this baby on the road, let me know!)


cheers,

tom





The only thing I could reproduce was the searchterm highlight thing  
which I will look into.


Regards,
Florian Schulze


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team




___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] Re: Re: PLIP 212 ready for review

2008-02-15 Thread Tom Lazar
i'm happy to report that all remaining issues have been fixed by  
florian today. the reason that my findings were not immediately  
reproducible, turned out to be because they were triggered by KSS  
interactions, i.e. only if you previously had, for instance, performed  
a copy operation andthen a workflow step. once fschulze found that out  
he claims to have fixed several other issues of the same nature.


i've assigned the ticket to witsch, for lack of knowing anything  
better. given that raphael has also looked at the plip i'd like to  
suggest to 'officially' include 212 for 3.1: how are we going to go  
about this? will we collect explicit votes from andi, martijn and danny?


On 15.02.2008, at 13:41, Raphael Ritz wrote:


Wichert Akkerman wrote:

Previously Tom Lazar wrote:


On Feb 14, 2008, at 1:57 PM, Florian Schulze wrote:

I can't reproduce any of these issues. I tried my exisiting  
buildout  and I made a fresh co of the buildout and ran buildout  
with the  option to get the newest version of everything.


well, given the fact that i indeed *can* reproduce these, chances  
are,  others will, too.




That's worrying. I would like to seem some succes/failure stories
from others -



FWIW: I just did a fresh buildout for 212 and tested a few
things in firefox (inline editing, calendar pagination, display
changes, workflow transitions, folder reordering, and  running
the tests from test_ecmascripts ).

The only issue I've encountered  is this one:
opera_is_broken is not defined
KupuSelectionTestCase()test_kupuhelpers (line 265)
registerTestCase(KupuSelectionTestCase(),  
kupu)unittestUtilities... (line 9)

opera_is_broken(this, 'testParentElementImg');


which Tom reported already.

Raphael



at the moment this feels like a big risk to me. Tom, can
you write a short step-by-step guide for reproducing the problems you
are seeing?

Wichert.





___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team




___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] Re: Re: PLIP 212 ready for review

2008-02-15 Thread Tom Lazar

On 15.02.2008, at 11:56, Wichert Akkerman wrote:


Previously Tom Lazar wrote:

On Feb 14, 2008, at 1:57 PM, Florian Schulze wrote:

I can't reproduce any of these issues. I tried my exisiting buildout
and I made a fresh co of the buildout and ran buildout with the
option to get the newest version of everything.


well, given the fact that i indeed *can* reproduce these, chances  
are,

others will, too.


That's worrying. I would like to seem some succes/failure stories
from others - at the moment this feels like a big risk to me. Tom, can
you write a short step-by-step guide for reproducing the problems you
are seeing?


for the record: florian has been able to reproduce the issues, fixed  
them and i was able to confirm it.





Wichert.

--
Wichert Akkerman [EMAIL PROTECTED]It is simple to make things.
http://www.wiggy.net/   It is hard to make things  
simple.





___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team