[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: closed Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: fixed Keywords: | -+-- Changes (by esteele): * status: assigned = closed * resolution: = fixed -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:51 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by esteele): This PLIP has been accepted for merging into Plone 4.0 The final vote was: Alec Mitchell +1 David Glick +1 Erik Rose +1 Laurence Rowe +1 Matthew Wilkes -1 Ross Patterson +1 Please merge your branches into the Plone 4.0 head by end-of-day Friday Oct 16. If you need assistance with merging, please contact me. We'll be assigning a documentation ticket to this PLIP shortly. Please assist the docs team in documenting the changes and new features that this PLIP introduces. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:47 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by esteele): Please assist the doc team in creating/updating documentation relating to this PLIP. See #9617. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:48 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by rossp): Everyting works for me, can't reproduce MatthewWilkes's error. Still +1 for merge. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:39 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by erikrose): New error: check, say, the Reviewers box when adding a user, forget to fill out a username, submit the form, and the Reviewers box is no longer checked. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:41 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by erikrose): (In [30255]) Changed a has_key (which is deprecated--use x in y instead) plus an if to a get for fewer code paths. No behavior changes. Refs #9330. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:43 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by rossp): (In [30257]) Add postback support so that selected groups are preserved when validation errors occur. Refs #9330 comment 41. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:44 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by rossp): Having just looked at #9310 and #9330 again, I realized that merging these two PLIPs will mean mostly re-implementing #9330 since #9310 uses formlib and #9330 makes changes to the old form controller template. Since #9310 preserves the old form controller template, we could still merge #9330 but it would be unused by default. If the implementer is up to it, however, it should be possible to add a field and widget to the #9310 formlib form. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:45 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by MatthewWilkes): Adding a user without any groups causes a KeyError. This is true for any self-registrations and many admin-registrations. FWT vote: -1 on merging -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:37 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [30238]) A simple fix, I hope. Refs #9330. +1 Matthew Wilkes, +1! :-) -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:38 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [29852]) Move getGroupIds call inside block protected by 'Manage users' permission (and change permission from 'Manage portal' to 'Manage users'). This makes self registration work again. refs #9330 -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:31 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [29853]) Do not allow user to select groups if 'Many groups' is checked in the usergroup control panel. refs #9330 -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:32 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [29854]) Use group title instead of id; re-position ignore definition closer to the block it is used in. (Next, make it call PAS for list of auto-groups.) refs #9330 -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:33 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [29057]) Errr, what I mean to say is, first cut adding group selection to join form, refs #9330, wherein we protect the field by checking for manager role (so only managers get the choice) as well as populate the vocab via context/portal_groups/getGroupIds and select 'AuthenticatedUsers' as the default. Next up: make it work. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:26 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [29069]) Make input name something we can look for in the request, e.g. group.Administrators, group.Reviewers (refs #9330). -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:28 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9330: Add ability to choose group when adding new site members
#9330: Add ability to choose group when adding new site members -+-- Reporter: aclark |Owner: aclark Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by aclark): (In [29070]) W00t, first working cut, refs #9330. -- Ticket URL: http://dev.plone.org/plone/ticket/9330#comment:29 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
