Re: Fix cp not to give chflags error on NFS
+freebsd-standards for folks that know more than I do
On 1 April 2017 at 08:54, Lewis Donzis <l...@perftech.com> wrote:
> It's fairly annoying that cp has no way to suppress the chflags error when
> the destination file is on an NFS mount. A bigger problem than the error
> message is that it returns exit status 1, which causes things like make to
> fail when there really was no error.
>
> What do you think about the following change to /usr/src/bin/cp/utils.c:
>
> 398c398
> < if (fdval ?
> ---
>> if ((fdval ?
> 401c401
> < chflags(to.p_path, fs->st_flags))) {
> ---
>> chflags(to.p_path, fs->st_flags))) && errno != ENOTSUP) {
>
> which simply ignores the error if the destination filesystem doesn't support
> chflags?
I believe POSIX requires this error:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html
===
The file permission bits and the S_ISUID and S_ISGID bits. Other,
implementation-defined, bits may be duplicated as well. If this
duplication fails for any reason, cp shall write a diagnostic message
to standard error.
===
We can possibly define "implementation defined bits" to not include
other flags if the flags are unsupported on the destination filesystem
but this seems weird to me.
--
Eitan Adler
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: Adding FreedomSponsors plugin to bugzilla?
On 20 June 2014 19:36, Bruce Cran bruce.c...@gmail.com wrote: I noticed that the Jenkins bug-tracking system has a Sponsor this button for each issue (e.g. https://issues.jenkins-ci.org/browse/JENKINS-23524). I'm okay with trying it out. Does it work with bugzilla 4.4? I was wondering if we might want to do the same thing for bugs.freebsd.org using the Bugzilla plugin from https://github.com/freedomsponsors/freedomsponsors-bugzilla-plugin ? Please file a bug. It will depend on the customtemplates bug. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: [Bug 129052] ps(1) %cpu column reports misleading data for threaded programs
On 5 June 2014 11:17, bz-nore...@freebsd.org wrote: I was testing something. ignore that. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/188745: FreeBSD base OpenSSL puts private keys to RNG seeds
The following reply was made to PR bin/188745; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: Kenji Rikitake ke...@k2r.org Cc: bug-followup bug-follo...@freebsd.org Subject: Re: bin/188745: FreeBSD base OpenSSL puts private keys to RNG seeds Date: Fri, 18 Apr 2014 14:58:17 -0700 On 17 April 2014 20:51, Kenji Rikitake ke...@k2r.org wrote: Environment: FreeBSD minimax.priv.k2r.org 10.0-STABLE FreeBSD 10.0-STABLE #33 r264285: Wed Apr 9 09:25:02 JST 2014 r...@minimax.priv.k2r.org:/usr/obj/usr/src/sys/K2RKERNEL amd64 Description: OpenBSD devs report OpenSSL puts RSA private keys as they are for seeding the PRNG. See http://freshbsd.org/commit/openbsd/e5136d69ece4682e6167c8f4a8122270236898bf for the details. On 10.0-STABLE, I've found the same practice under /usr/src/crypto/openssl/crypto at: Please see: http://blog.ngas.ch/archives/2014/04/17/what_is_this_private_key_doing_in_my_random_pool/index.html In particular: So the patch which was committed by the OpenBSD people actually has the potential to weaken the entropy of the OpenSSL random pool, but it was never a security or privacy concern, -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/184648: Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4
The following reply was made to PR bin/184648; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: Julian H. Stacey j...@berklix.com, Diane Bruce d...@db.net Cc: freebsd-gnats-sub...@freebsd.org Subject: Re: bin/184648: Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4 Date: Mon, 9 Dec 2013 20:08:08 -0500 On Mon, Dec 9, 2013 at 7:54 PM, Julian H. Stacey j...@berklix.com wrote: ... I assume it's yet another problem from changing the compiler thus cpp. This assumption is wrong. It likely originates from the addition of cpp like behavior to calendar itself. db@, can you please have a look? -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/184595: converters/php5-iconv: iconv transliteration support broken
On Sun, Dec 8, 2013 at 11:20 AM, Michael Gmelin free...@grem.de wrote: The following reply was made to PR misc/184595; it has been noted by GNATS. From: Michael Gmelin free...@grem.de To: bug-follo...@freebsd.org Cc: Subject: Re: misc/184595: converters/php5-iconv: iconv transliteration support broken Date: Sun, 8 Dec 2013 17:11:45 +0100 Please change category to ports. Done -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/170631: [PATCH] Add roaming support to wpa_supplicant(8)
On Fri, Jun 14, 2013 at 11:22 AM, Daan Vreeken d...@vitsch.nl wrote: Thanks a lot! I see that the miss-spelling of 'dBm' as 'dbM' is still present in ieee80211_var.h . Was this intentional? I intended to commit this separately and then forgot about it. It is committed in HEAD now. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/174711: [fdc] Floppy drive 5.25 360Kb bug.
The following reply was made to PR bin/174711; it has been noted by GNATS.
From: Eitan Adler li...@eitanadler.com
To: bug-followup bug-follo...@freebsd.org
Cc:
Subject: Re: bin/174711: [fdc] Floppy drive 5.25 360Kb bug.
Date: Wed, 8 May 2013 21:54:47 -0400
-- Forwarded message --
From: Emil Mamedov emil80...@yahoo.com
Date: 7 May 2013 11:30
Subject: Re: bin/174711: [fdc] Floppy drive 5.25 360Kb bug.
To: freebsd-bugs@freebsd.org
The following reply was made to PR bin/174711; it has been noted by GNATS.
From: Emil Mamedov emil80...@yahoo.com
To: freebsd-gnats-sub...@freebsd.org, freebsd-i...@freebsd.org
Cc:
Subject: Re: bin/174711: [fdc] Floppy drive 5.25 360Kb bug.
Date: Tue, 7 May 2013 08:26:57 -0700 (PDT)
My previous tarball has been corrupted and I've attached
floppy-diff files to message body:
--- fdc.c.org 2012-03-03 06:15:13.0 +
+++ fdc.c 2013-01-21 23:18:14.0 +
@@ -136,33 +136,35 @@
*/
static struct fd_type fd_searchlist_360k[] = {
- { FDF_5_360 },
+ { FDD_5_360 | FL_AUTO},
+ { FDD_5_180 | FL_AUTO},
{ 0 }
};
static struct fd_type fd_searchlist_12m[] = {
- { FDF_5_1200 | FL_AUTO },
- { FDF_5_360 | FL_2STEP | FL_AUTO},
+ { FHD_5_1200 | FL_AUTO },
+ { FHD_5_360 | FL_2STEP | FL_AUTO},
+ { FHD_5_180 | FL_2STEP | FL_AUTO},
{ 0 }
};
static struct fd_type fd_searchlist_720k[] = {
- { FDF_3_720 },
+ { FHD_3_720 },
{ 0 }
};
static struct fd_type fd_searchlist_144m[] = {
- { FDF_3_1440 | FL_AUTO},
- { FDF_3_720 | FL_AUTO},
+ { FHD_3_1440 | FL_AUTO},
+ { FHD_3_720 | FL_AUTO},
{ 0 }
};
static struct fd_type fd_searchlist_288m[] = {
- { FDF_3_1440 | FL_AUTO },
+ { FHD_3_1440 | FL_AUTO },
#if 0
- { FDF_3_2880 | FL_AUTO }, /* XXX: probably doesn't work */
+ { FHD_3_2880 | FL_AUTO }, /* XXX: probably doesn't work */
#endif
- { FDF_3_720 | FL_AUTO},
+ { FHD_3_720 | FL_AUTO},
{ 0 }
};
@@ -297,7 +299,7 @@
fdprinttype(struct fd_type *ft)
{
- printf((%d,%d,%d,%d,%d,%d,%d,%d,%d,%d,%d,0x%x),
+ printf((%d,%d,0x%x,0x%x,%d,%d,%d,%d,0x%x,%d,%d,0x%x)\n,
ft-sectrac, ft-secsize, ft-datalen, ft-gap, ft-tracks,
ft-size, ft-trans, ft-heads, ft-f_gap, ft-f_inter,
ft-offset_side2, ft-flags);
@@ -856,7 +858,8 @@
return (fdc_biodone(fdc, ENXIO));
/* Check if we lost our media */
- if (fdin_rd(fdc) FDI_DCHG) {
+ if ((fdin_rd(fdc) FDI_DCHG)
+ !(device_get_flags(fd-dev) FD_NO_CHLINE)) {
if (debugflags 0x40)
printf(Lost disk\n);
mtx_lock(fdc-fdc_mtx);
@@ -884,7 +887,7 @@
mfm = (fd-ft-flags FL_MFM)? NE7CMD_MFM: 0;
steptrac = (fd-ft-flags FL_2STEP)? 2: 1;
- i = fd-ft-sectrac * fd-ft-heads;
+ i = fd-ft-sectrac * fd-ft-heads; //sectors per cyl
cylinder = bp-bio_pblkno / i;
descyl = cylinder * steptrac;
sec = bp-bio_pblkno % i;
@@ -928,6 +931,22 @@
* Enhanced controllers do implied seeks for readwrite as long as
* we do not need multiple steps per track.
*/
+ /* But if DD diskette in HD FDD then disable do implied seek */
+ if (fdc-fdct == FDC_ENHANCED) {
+ int imp_seek;
+ if (fd-ft-flags FL_2STEP) imp_seek = 0x00;
+ else imp_seek = 0x40;
+ if (fdc_cmd(fdc, 4,
+ I8207X_CONFIG,
+ 0,
+ imp_seek | /* Disable/Enable Implied Seek */
+ 0x10 | /* Polling disabled */
+ (fifo_threshold - 1), /* Fifo threshold */
+ 0x00, /* Precomp track */
+ 0))
+ device_printf(fdc-fdc_dev,
+ CONFIGURE failed\n);
+ }
if (cylinder != fd-track (
fdc-fdct != FDC_ENHANCED ||
descyl != cylinder ||
@@ -1229,7 +1248,9 @@
if (fdc_sense_int(fdc, st0, cyl) == FD_NOT_VALID)
goto done; /* XXX */
*recal |= (1 fd-fdsu);
- if (fdin_rd(fdc) FDI_DCHG) {
+
+ if ((fdin_rd(fdc) FDI_DCHG)
+ !(device_get_flags(fd-dev) FD_NO_CHLINE)) {
if (debugflags 0x40)
printf(Empty in probe\n);
mtx_lock(fdc-fdc_mtx);
@@ -1238,8 +1259,8 @@
} else {
if (fdc_sense_drive(fdc, st3) != 0)
goto done;
- if (debugflags 0x40)
- printf(Got disk in probe\n);
+//if (debugflags 0x40)
+//printf(Got disk in probe\n
misc/178381: remove CVS and csup from Makefile
Number: 178381
Category: misc
Synopsis: remove CVS and csup from Makefile
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Tue May 07 01:30:02 UTC 2013
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
Makefile and various b.*.m files still reference CVS.
Note: I only tested svn update w.r.t. the Makefile change
How-To-Repeat:
Fix:
Patch attached with submission follows:
Index: Makefile
===
--- Makefile(revision 316637)
+++ Makefile(working copy)
@@ -122,13 +122,12 @@ ${INDEXDIR}/${INDEXFILE}:
echo Before reporting this error, verify that you are
running a supported; \
echo version of FreeBSD (see
http://www.FreeBSD.org/ports/) and that you; \
echo have a complete and up-to-date ports collection.
(INDEX builds are; \
- echo not supported with partial or out-of-date ports
collections -- in; \
- echo particular, if you are using cvsup, you must
cvsup the \ports-all\; \
- echo collection, and have no \refuse\ files.) If
that is the case, then; \
+ echo not supported with partial or out-of-date ports
collections.; \
+ echo If that is the case, then; \
echo report the failure to po...@freebsd.org together
with relevant; \
echo details of your ports configuration (including
FreeBSD version,; \
echo your architecture, your environment, and your
/etc/make.conf; \
- echo settings, especially compiler flags and
WITH/WITHOUT settings).; \
+ echo settings, especially compiler flags and
OPTIONS_SET/UNSET settings).; \
echo; \
echo Note: the latest pre-generated version of INDEX
may be fetched; \
echo automatically with \make fetchindex\.; \
@@ -151,29 +150,14 @@ ${INDEXDIR}/${INDEXFILE}:
print-index: ${INDEXDIR}/${INDEXFILE}
@awk -F\| '{
printf(Port:\t%s\nPath:\t%s\nInfo:\t%s\nMaint:\t%s\nIndex:\t%s\nB-deps:\t%s\nR-deps:\t%s\nE-deps:\t%s\nP-deps:\t%s\nF-deps:\t%s\nWWW:\t%s\n\n,
$$1, $$2, $$4, $$6, $$7, $$8, $$9, $$11, $$12, $$13, $$10); }'
${INDEXDIR}/${INDEXFILE}
-CVS?= cvs
GIT?= git
SVN?= svn
-SUP?= csup
PORTSNAP?= portsnap
PORTSNAP_FLAGS?= -p ${.CURDIR}
-.if defined(SUPHOST)
-SUPFLAGS+= -h ${SUPHOST}
-.endif
.if !target(update)
update:
-.if defined(SUP_UPDATE) defined(PORTSSUPFILE)
+.if exists(${.CURDIR}/.svn)
@echo --
- @echo Running ${SUP}
- @echo --
- @${SUP} ${SUPFLAGS} ${PORTSSUPFILE}
-.elif defined(CVS_UPDATE)
- @echo --
- @echo Updating ${.CURDIR} from CVS repository ${CVSROOT}
- @echo --
- cd ${.CURDIR}; ${CVS} -R -q update -A -P -d -I!
-.elif exists(${.CURDIR}/.svn)
- @echo --
@echo Updating ${.CURDIR} using Subversion
@echo --
cd ${.CURDIR}; ${SVN} update
@@ -190,8 +174,6 @@ update:
@echo Error: 'make update' uses portsnap(8) by default and
@echo needs ${PORTSDIR} to be created by portsnap on its first run.
@echo Please run 'portsnap fetch extract' first.
- @echo You can also define SUP_UPDATE and PORTSSUPFILE to use csup(1)
- @echo or CVS_UPDATE to use cvs(1) for updating.
.else
@${PORTSNAP} ${PORTSNAP_FLAGS} fetch
@${PORTSNAP} ${PORTSNAP_FLAGS} update
Index: Mk/bsd.drupal.mk
===
--- Mk/bsd.drupal.mk(revision 316637)
+++ Mk/bsd.drupal.mk(working copy)
@@ -7,7 +7,7 @@
#
# For FreeBSD committers:
# Please send all suggested changes to the maintainer instead of committing
-# them to CVS yourself.
+# them to SVN yourself.
bsd_drupal_mk_MAINTAINER= m...@freebsd.org
Index: Mk/bsd.fpc.mk
===
--- Mk/bsd.fpc.mk (revision 316637)
+++ Mk/bsd.fpc.mk (working copy)
@@ -7,7 +7,7 @@
#
# For FreeBSD committers:
# Please send all suggested changes to the maintainer instead of committing
-# them to CVS yourself.
+# them to SVN yourself.
#
# USE_FPC - If you set this to yes, this automatically will
install
Re: bin/174711: [fdc] Floppy drive 5.25 360Kb bug.
The following reply was made to PR bin/174711; it has been noted by GNATS.
From: Eitan Adler li...@eitanadler.com
To: Emil Mamedov emil80...@yahoo.com
Cc: freebsd-gnats-sub...@freebsd.org
Subject: Re: bin/174711: [fdc] Floppy drive 5.25 360Kb bug.
Date: Sun, 5 May 2013 11:42:09 -0400
Can you please email me the files or even better, a diff(1) of the
files? The attachment got list
On 5 May 2013 10:54, Emil Mamedov emil80...@yahoo.com wrote:
Dear reader!
I've seen my old bug report about 5.25 DD floppy disk. During last months,
I've fixed numerious bugs in the standart FreeBSD 8.3 floppy driver (fdc.c)
and floppy utilites.
First.
The file fdcio.c set has #define for DD disk in HD drive, but #define for
DD disk in DD drive has missed. I changed transfer rate from 300kbps to
250kbps
and also sector gap from 0x23 to 0x2A. However DD disks in HD drives
need to speed 300kbps and sector gap 0x23.
Second.
I've found that my DD floppy drive has Ready signal (pin 34)
instead Disk Change. I've opened RY jumper and was able to mount diskette.
I set fd.0.flags=0x10(drive doesn't support changeline),
but this flag hasn't effect. In the case of RY jumper is installed,
I can not mount DD floppy. Flag FD_NO_CHLINE doesn't work properly.
Third.
System doesn't detect absence disk in the DD FDD and too long
positions floppy drive heads during boot process.
Fourth.
System anomally long unmount diskettes (previously mount with:
mount_msdos -o rw
even if I did not made writing files to diskette! I really don't sure
that is a bag, maybe it is the feature of file systems' driver?
Fifth.
Autoselect floppy works properly in the case DD floppy disk in a 1.2Mb(HD)
FDD,
flag FL_2STEP set properly. But I can read cylinder 0 only (first 18
sectors).
Under MS-DOS DD disk in HD drive is read/wrote properly. I seem that code
appropriating FL_2STEP flag doesn't works properly.
Sixth.
When I run fdformat utility question y/n appears.
But if I print n system long positions heads and only after
this returns to command prompt. I think, system must be returning
to command prompt immediately after n.
My modifications.
I've added code which recognize FD_NO_CHLINE flag, changed function
fdautoselect
(for found sectors per track), corrected and renamed #define variables in
fdcio.h
I've found that implied seek (on enhanced fdc) make 2step operations
impossible. I've added code by disabling implied seek when FL_2STEP
flag is enable. Also, I've made many small changes.
In the fdcontrol utility I've exluded unnecesarry flag [-a].
I've found flag [-d dbg] in the fdcontrol usage, but this flag
doesn't appropriating code. I've deleted [-d] flag from usage.
I've deleted string return(0) from if (showfmt)...{} operator.
Also, I've made some small changes.
In the fdformat utility I've exluded y/n request.
Also, I've edited the file fdutil.c and made small changed in the fdcontrol
and fdformat man pages.
The file fdcio.h has in the 2 location: /usr/include/sys and
/usr/sys/sys.
All my changes in the attachment tarball floppy.tgz.
I hope for you authority comments.
With kindest regards, Emil.
--- On Tue, 12/25/12, freebsd-gnats-sub...@freebsd.org
freebsd-gnats-sub...@freebsd.org wrote:
From: freebsd-gnats-sub...@freebsd.org freebsd-gnats-sub...@freebsd.org
Subject: Re: i386/174711: Floppy drive 5.25 360Kb bug.
To: Emil Mamedov emil80...@yahoo.com
Date: Tuesday, December 25, 2012, 11:40 PM
Thank you very much for your problem report.
It has the internal identification `i386/174711'.
The individual assigned to look at your
report is: freebsd-i386.
You can access the state of your problem report at any time
via this link:
http://www.freebsd.org/cgi/query-pr.cgi?pr=174711
Category: i386
Responsible:freebsd-i386
Synopsis: Floppy drive 5.25 360Kb bug.
Arrival-Date: Wed Dec 26 07:40:00 UTC 2012
___
freebsd-i...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-i386
To unsubscribe, send any mail to freebsd-i386-unsubscr...@freebsd.org
--
Eitan Adler
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/61355: login(1) does not restore terminal ownership on exit
The following reply was made to PR bin/61355; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-followup bug-follo...@freebsd.org Cc: Subject: Re: bin/61355: login(1) does not restore terminal ownership on exit Date: Sun, 28 Apr 2013 17:44:34 -0400 -- Forwarded message -- From: Jilles Tjoelker jil...@stack.nl Date: 28 April 2013 17:30 Subject: Re: bin/61355: login(1) does not restore terminal ownership on exit To: freebsd-bugs@freebsd.org The following reply was made to PR bin/61355; it has been noted by GNATS. From: Jilles Tjoelker jil...@stack.nl To: bug-follo...@freebsd.org, eu...@kuzbass.ru Cc: Subject: Re: bin/61355: login(1) does not restore terminal ownership on exit Date: Sun, 28 Apr 2013 23:23:05 +0200 [nested login(1) does not restore tty ownership] If it didn't break anything, I would like to solve this problem by removing /usr/bin/login's setuid bit. You can use su (or sudo from ports) to become another user temporarily. With utmpx, I think the corruption of those files is solved. The utmpx code can handle overlapping sessions on the same tty. The tty ownership is normally reset to root:wheel by the new getty (for ttys managed via /etc/ttys) or by the destruction of the tty (for pseudo terminals). So it is probably safe to remember the old uid/gid and restore it later. Even with that, there is no isolation between the two users. Since there is no new session or revocation (and there cannot be), the nested user can continue to access the tty after the logout. For the same reason, the setlogin() call affects both the old and the new user's processes; this is not undone afterwards either. -- Jilles Tjoelker ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/177624: Swapcontext can get compiled incorrectly
The following reply was made to PR misc/177624; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-followup bug-follo...@freebsd.org Cc: Subject: Re: misc/177624: Swapcontext can get compiled incorrectly Date: Thu, 4 Apr 2013 08:11:34 -0400 -- Forwarded message -- From: Brian Demsky bdem...@uci.edu Date: 4 April 2013 01:25 Subject: Re: misc/177624: Swapcontext can get compiled incorrectly To: Eitan Adler li...@eitanadler.com Cc: freebsd-bugs@freebsd.org The analysis is a little wrong about the problem. Ultimately, the tail c= all to set context trashes the copies of bx and r14 on the stack=E2=80=A6. On Apr 3, 2013, at 10:03 PM, Eitan Adler wrote: On 3 April 2013 23:10, Brian Demsky bdem...@uci.edu wrote: The following reply was made to PR misc/177624; it has been noted by GNA= TS. From: Brian Demsky bdem...@uci.edu To: bug-follo...@freebsd.org Cc: Subject: Re: misc/177624: Swapcontext can get compiled incorrectly Date: Wed, 03 Apr 2013 20:01:14 -0700 QSBxdWljayBub3RlIHRoYXQgdGhlIHRhaWwgY2FsbCB0byBzZXQgY29udGV4dCBpcyB3aGF0= IGFj dHVhbGx5IHRyYXNoZXMgdGhlIGNvcGllcyBvZiByYnggYW5kIHIxNCBvbiB0aGUgc3RhY2su Something is weird with this submission. Please resend? -- Eitan Adler --=20 Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/177624: Swapcontext can get compiled incorrectly
On 3 April 2013 23:10, Brian Demsky bdem...@uci.edu wrote: The following reply was made to PR misc/177624; it has been noted by GNATS. From: Brian Demsky bdem...@uci.edu To: bug-follo...@freebsd.org Cc: Subject: Re: misc/177624: Swapcontext can get compiled incorrectly Date: Wed, 03 Apr 2013 20:01:14 -0700 QSBxdWljayBub3RlIHRoYXQgdGhlIHRhaWwgY2FsbCB0byBzZXQgY29udGV4dCBpcyB3aGF0IGFj dHVhbGx5IHRyYXNoZXMgdGhlIGNvcGllcyBvZiByYnggYW5kIHIxNCBvbiB0aGUgc3RhY2su Something is weird with this submission. Please resend? -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: gnu/175985: [PATCH] Improve send-pr
The following reply was made to PR gnu/175985; it has been noted by GNATS. From: Eitan Adler ead...@freebsd.org To: Christoph Mallon christoph.mal...@gmx.de Cc: bug-followup bug-follo...@freebsd.org Subject: Re: gnu/175985: [PATCH] Improve send-pr Date: Fri, 15 Feb 2013 13:25:30 -0500 On 9 February 2013 08:50, Christoph Mallon christoph.mal...@gmx.de wrote: I have not yet looked at the code. Description: - Do not delete lines starting with Subject:. They are most probably part of a attached git patch. This is probably fine, but I am curious why they were removed in the past. How does GNATS actually treat the subject line? - Recognize an empty file as a not filled out PR, too. This is fine with me. - Allow attaching files via -- followed by file names. This is fine with me. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call
On 3 February 2013 16:00, Giorgos Keramidas keram...@freebsd.org wrote: The following reply was made to PR kern/175674; it has been noted by GNATS. The best way to fix this is in kern_openat() in the kernel but this might cause compatibility issues. Not sure if there would be serious compatibility problems if open() would automatically restart instead of returning EINTR. It definitely seems a rather intrusive change though. I can not see major application breakage should open(3) be changed. That said, I am confused by jilles' comment: http://pubs.opengroup.org/onlinepubs/95399/functions/open.html open(3) is permitted to return EINTR. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call
The following reply was made to PR kern/175674; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-followup bug-follo...@freebsd.org Cc: Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call Date: Sun, 3 Feb 2013 21:30:28 -0500 -- Forwarded message -- From: Eitan Adler li...@eitanadler.com Date: 3 February 2013 20:52 Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call To: Giorgos Keramidas keram...@freebsd.org, Jilles Tjoelker jil...@stack.nl Cc: freebsd-bugs@freebsd.org On 3 February 2013 16:00, Giorgos Keramidas keram...@freebsd.org wrote: The following reply was made to PR kern/175674; it has been noted by GNATS. The best way to fix this is in kern_openat() in the kernel but this might cause compatibility issues. Not sure if there would be serious compatibility problems if open() would automatically restart instead of returning EINTR. It definitely seems a rather intrusive change though. I can not see major application breakage should open(3) be changed. That said, I am confused by jilles' comment: http://pubs.opengroup.org/onlinepubs/95399/functions/open.html open(3) is permitted to return EINTR. -- Eitan Adler -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call
On 3 February 2013 00:30, Giorgos Keramidas keram...@freebsd.org wrote: Jilles and David, do you think this patch looks ok for libc? Why bother keeping the contents of the #if 0? Remove it. Then it looks good to me. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call
The following reply was made to PR kern/175674; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: Giorgos Keramidas keram...@freebsd.org Cc: freebsd-bugs@freebsd.org, bug-followup bug-follo...@freebsd.org Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call Date: Sun, 3 Feb 2013 01:18:17 -0500 On 3 February 2013 00:30, Giorgos Keramidas keram...@freebsd.org wrote: Jilles and David, do you think this patch looks ok for libc? Why bother keeping the contents of the #if 0? Remove it. Then it looks good to me. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/105614: [patch] setkey(8): Creating NULL encryption ESP SAs with setkey fails
The following reply was made to PR bin/105614; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: John W. O'Brien j...@saltant.com Cc: bug-follo...@freebsd.org, freebsd-...@freebsd.org Subject: Re: bin/105614: [patch] setkey(8): Creating NULL encryption ESP SAs with setkey fails Date: Wed, 30 Jan 2013 23:31:33 -0500 On 30 January 2013 19:42, John W. O'Brien j...@saltant.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I found today that this bug still exists in 9.1-STABLE r245089, and that the suggested patch appears to fix it. If any further testing or analysis is needed prior to committing a fix, I would be glad to help. CC: freebsd-net@ in the hopes of being noticed and adopted The patch is maleformed in the PR. Perhaps you could attach and resend? -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/174933
The following reply was made to PR kern/174933; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-followup bug-follo...@freebsd.org Cc: Subject: Re: kern/174933 Date: Fri, 4 Jan 2013 13:04:31 -0500 -- Forwarded message -- From: Martin Laabs i...@martinlaabs.de Date: 4 January 2013 12:40 Subject: Bug analyzed - how to fix it? To: freebsd-emulat...@freebsd.org Hi, I'm (hopefully) done with the bug analyses of http://www.freebsd.org/cgi/query-pr.cgi?pr=174933;. The bug in one sentences: if_nameindex (resided in the libc) fails if called out of a linux binary. The cause is that the if_nameindex calls a function named __opensock that return a socket. This socket is used to call an ioctl(SIOCGIFCONF ...). This ioctl call is actually implemented in the linuxulator. Unfortunately the __opensock function tries to create the following socket: socket(PF_NETLINK, SOCK_RAW, 0) in decimal: socket(16,3,0) This type of socket type however is not supported by the linuxulator and IMHO in freebsd at all. However - maybe it just has another name in FreeBSD. So - for me there seem to be two solutions: 1. Write a dirty patch that returns a PF_INET instead of the PF_NETLINK socket if called with the arguments above. This should be OK since I assume that SIOCGIFCONF ioctl works also fine with PF_INET sockets. (I'll test this to verify whether this is true) This however would be somewhat dirty since PF_NETLINK sockets are not really supported and if another application tries to open a real PF_NETLINK socket it will get a false positive result. 2. Patch the glibc to not create a PF_NETLINK socket in __opensock but create a PF_INET socket instead. The problem is that I do not know about the side effects since the __opensock function is used elsewhere in the libc also. The second drawback is that this would lead to a customized libc for the linuxulator. As far as I know the current libc(s) are just bare copies out of linux systems. So this solution would also increase maintenance effort. Do you have an other idea how to fix the problem? Thank you, Martin ___ freebsd-emulat...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to freebsd-emulation-unsubscr...@freebsd.org -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/174398: [PATCH] fstab(5): add support for spaces and tabs
On 12 December 2012 10:40, William Grzybowski willia...@gmail.com wrote: The following reply was made to PR kern/174398; it has been noted by GNATS. From: William Grzybowski willia...@gmail.com To: bug-follo...@freebsd.org, willia...@gmail.com Cc: Subject: Re: bin/174398: [PATCH] fstab(5): add support for spaces and tabs Date: Wed, 12 Dec 2012 13:37:32 -0200 --002354470728b4ae5904d0a99348 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Looks like a fix has already been committed to the other PRs but they were not closed. h - that isn't good. I guess this can be closed. Okay. Can I ask you a quick favor - which other PRs need to be closed? Are conf/37569, bin/55539, bin/117687 and bin/174398 (this one) all fixed by the same commit? Are there any others I havn't looked at them yet. I will do so soon. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/174398: [PATCH] fstab(5): add support for spaces and tabs
On 12 December 2012 19:51, Eitan Adler li...@eitanadler.com wrote: On 12 December 2012 10:40, William Grzybowski willia...@gmail.com wrote: The following reply was made to PR kern/174398; it has been noted by GNATS. From: William Grzybowski willia...@gmail.com To: bug-follo...@freebsd.org, willia...@gmail.com Cc: Subject: Re: bin/174398: [PATCH] fstab(5): add support for spaces and tabs Date: Wed, 12 Dec 2012 13:37:32 -0200 --002354470728b4ae5904d0a99348 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Looks like a fix has already been committed to the other PRs but they were not closed. h - that isn't good. I guess this can be closed. Okay. Can I ask you a quick favor - which other PRs need to be closed? Are conf/37569, bin/55539, bin/117687 and bin/174398 (this one) all fixed by the same commit? Are there any others I havn't looked at them yet. I will do so soon. I looked - and closed this PR. Thanks for making FreeBSD better! -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: Is INDEXFILE out of date?
On 11 December 2012 03:40, Alex tomef...@list.ru wrote: Today I have fetched new ports index file and found different dovecot2 version in ports and index. The same problem with phpmyadmin and other ports. Yes, the generated INDEX file is out of date to the recent security issue. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/174236: kldunload ipdivert corrupts kernel
On 7 December 2012 09:50, Lutz Donnerhacke l...@donnerhacke.de wrote:
The following reply was made to PR kern/174236; it has been noted by GNATS.
From: Lutz Donnerhacke l...@donnerhacke.de
To: bug-follo...@freebsd.org
Cc:
Subject: Re: kern/174236: kldunload ipdivert corrupts kernel
Date: Fri, 7 Dec 2012 15:45:00 +0100
Any module which returns an error on unload will cause the problem.
It's not specific to ipdivert.ko or ipfw.ko or anything else.
Relevant code section is:
static int
div_modevent(module_t mod, int type, void *unused)
{
int err = 0;
switch (type) {
[...]
case MOD_QUIESCE:
err = EPERM;
break;
[...]
}
return err;
}
Please note: Forced unload of ipdivert.ko works fine.
If you are able and willing to debug:
avg I'd recommend him to enter debugger and run ps there
avg and get backtraces of the hanging threads
dwhite- it sounds like a leaked lock in the error case
If not, just leaving this here for the record ;)
--
Eitan Adler
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/174236: kldunload ipdivert corrupts kernel
The following reply was made to PR kern/174236; it has been noted by GNATS.
From: Eitan Adler li...@eitanadler.com
To: Lutz Donnerhacke l...@donnerhacke.de
Cc: freebsd-bugs@freebsd.org, bug-followup bug-follo...@freebsd.org
Subject: Re: kern/174236: kldunload ipdivert corrupts kernel
Date: Fri, 7 Dec 2012 13:42:29 -0500
On 7 December 2012 09:50, Lutz Donnerhacke l...@donnerhacke.de wrote:
The following reply was made to PR kern/174236; it has been noted by GNATS.
From: Lutz Donnerhacke l...@donnerhacke.de
To: bug-follo...@freebsd.org
Cc:
Subject: Re: kern/174236: kldunload ipdivert corrupts kernel
Date: Fri, 7 Dec 2012 15:45:00 +0100
Any module which returns an error on unload will cause the problem.
It's not specific to ipdivert.ko or ipfw.ko or anything else.
Relevant code section is:
static int
div_modevent(module_t mod, int type, void *unused)
{
int err = 0;
switch (type) {
[...]
case MOD_QUIESCE:
err = EPERM;
break;
[...]
}
return err;
}
Please note: Forced unload of ipdivert.ko works fine.
If you are able and willing to debug:
avg I'd recommend him to enter debugger and run ps there
avg and get backtraces of the hanging threads
dwhite- it sounds like a leaked lock in the error case
If not, just leaving this here for the record ;)
--
Eitan Adler
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/138681: [pmap] [panic] repeatable kernel panic in pmap_remove_all()
On 6 December 2012 10:03, Brian Ellis b...@zellis.com wrote: Hi Jh, Thanks for the follow-up. This kernel panic was eventually tracked down to a failing CPU, so not caused by FreeBSD. This took a while to figure out. The bug report can be closed. Heh, wow. Failing hardware bugs (especially CPU) are absurd. Thanks for the follow up. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: docs/173598: torrents.freebsd.org seems to be down
On 5 December 2012 22:53, Glen Barber g...@freebsd.org wrote: On Wed, Dec 05, 2012 at 10:31:13PM -0500, kpn...@pobox.com wrote: But the torrent files _were_ provided directly by the Project. Those torrents contain hashes of the real files. This means files can be downloaded from anyone and the authenticity of them could still be verified. FWIW, I agree this was a very useful service and am sad to see this go. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/173977: pw(8) does not do range-checking on UIDs/GUIs from user's input, passwd DB becomes inconsistent
On 28 November 2012 13:41, Nikos Vassiliadis nv...@gmx.com wrote:
Index: usr.sbin/pw/pw_group.c
===
--- usr.sbin/pw/pw_group.c (revision 243652)
+++ usr.sbin/pw/pw_group.c (working copy)
@@ -350,6 +350,8 @@
*/
if (a_gid != NULL) {
gid = (gid_t) atol(a_gid-val);
atoi overflow is considered undefined behavior so the error can not be
meaningfully be checked. In particular the compiler may assume the
error will never occur and elide the check. Ideally this call is
replaced with one of the stro* functions.
+ if (errno == ERANGE || errno == EINVAL)
+ errx(EX_DATAERR, gid %s is invalid, a_gid-val);
--
Eitan Adler
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/21463: [linux] Linux compatability mode should not allow setuid programs
The following reply was made to PR kern/21463; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-follo...@freebsd.org Cc: Subject: Re: kern/21463: [linux] Linux compatability mode should not allow setuid programs Date: Mon, 26 Nov 2012 18:24:10 -0500 -- Forwarded message -- From: Marcin Cieslak sa...@saper.info Date: 26 November 2012 16:24 Subject: Re: kern/21463: [linux] Linux compatability mode should not allow setuid programs To: freebsd-emulat...@freebsd.org We implement AT_UID and AT_GID process auxillary vector (procstat -x) elements so at least userland library (such as glibc) has a possibility to enter secure mode on startup. Not sure if there is anything we can do more (except for disabling the feature altogether) to tell userland to be careful. //Marcin ___ freebsd-emulat...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-emulation To unsubscribe, send any mail to freebsd-emulation-unsubscr...@freebsd.org -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/21463: [linux] Linux compatability mode should not allow setuid programs
The following reply was made to PR kern/21463; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-follo...@freebsd.org Cc: Subject: Re: kern/21463: [linux] Linux compatability mode should not allow setuid programs Date: Mon, 26 Nov 2012 20:44:53 -0500 -- Forwarded message -- From: Mateusz Guzik mjgu...@gmail.com Date: 26 November 2012 20:42 Subject: Re: kern/21463: [linux] Linux compatability mode should not allow setuid programs To: freebsd-bugs@freebsd.org Hi, I think we should go a step futher and get per-jail support for enabling/disabling Linux compatibility support, possibly along with the ability to control sugid programs. I don't have time to work on this at the moment though. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/173672: VirtualBox and bridge problem.
The following reply was made to PR misc/173672; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: Huryn Adrian ahu...@i-pi.pl Cc: freebsd-gnats-sub...@freebsd.org, freebsd-bugs@freebsd.org, Adrian Huryn a...@i-pi.pl Subject: Re: misc/173672: VirtualBox and bridge problem. Date: Mon, 19 Nov 2012 08:47:33 -0500 On 19 November 2012 07:57, Huryn Adrian ahu...@i-pi.pl wrote: Sorry, why that link don't work ? That gnats web interface is a bit behind. The bug report made it through. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/29355: [kernel] [patch] add lchflags support
On 13 November 2012 16:07, Josh Goodall jos...@roughtrade.net wrote: The handling of this PR is the reason I stopped contributing to FreeBSD. That is unfortunate. Could you explain a bit more about what the current state should be? I tried to parse through the history of the PR, and the current status of the issues listed. I'd be happy to reopen it or resolve the issues still present. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/113518: [patch] make(1): Prevent execution when command is a comment
The following reply was made to PR bin/113518; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: Jilles Tjoelker jil...@stack.nl, s...@freebsd.org Cc: bug-follo...@freebsd.org Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a comment Date: Sun, 4 Nov 2012 07:35:01 -0500 On 4 November 2012 07:20, Jilles Tjoelker jil...@stack.nl wrote: The following reply was made to PR bin/113518; it has been noted by GNATS. From: Jilles Tjoelker jil...@stack.nl To: bug-follo...@freebsd.org, e...@fxq.nl Cc: s...@freebsd.org Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a comment Date: Sun, 4 Nov 2012 13:11:58 +0100 In PR bin/113518: [patch to teach make about the shell's comment character] The first thing here is whether there are actually real-life Makefiles containing shell commands consisting only of comments. I only find a few in /usr/ports/Mk: jilles@jaguar /usr/ports/Mk% grep $'^[ \t]\\+#' * bsd.gecko.mk: # XXX: make sure bsdtar(1) corrected symlinks bsd.kde4.mk: # Check that the component is valid. bsd.kde4.mk: # Skip meta-components (e.g., kdeprefix). bsd.kde4.mk:# Check if a dependency type is explicitly requested. bsd.kde4.mk:# If no dependency type is set, default to full dependency. bsd.kde4.mk:# Set real dependencies. [10017 eitan@radar /usr/ports !130!]%find . -name Makefile\*|xargs grep $'^[ \t]\\+#'|wc -l 420 Secondly, I don't think such new features should be added to make(1) when it is planned to replace it with bmake (sjg@ cc'ed). Also, bmake generally knows less about the shell than make(1) does so it does not seem to fit in to add it to bmake. Shall this bug be closed? -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/144531: [patch] cp(1) show percentage complete
On 2 November 2012 22:03, Andy Farkas an...@andyit.com.au wrote: On 11/03/12 06:59, ead...@freebsd.org wrote: Synopsis: [patch] cp(1) show percentage complete My thought was to trigger this action with -vv. That way -v operation is not changed and no new flag is required. I prefer a new flag. Some scripts might be set up to do something like -v$userflags -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/173002: data type size problem in if_spppsubr.c
The following reply was made to PR kern/173002; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-follo...@freebsd.org Cc: Subject: Re: kern/173002: data type size problem in if_spppsubr.c Date: Tue, 23 Oct 2012 18:08:15 -0400 --047d7b2e40bebb1d9404ccc13653 Content-Type: text/plain; charset=UTF-8 -- Forwarded message -- From: Jens Wiatrowski wia...@gmx.net Date: 23 October 2012 16:40 Subject: Re: Re: kern/173002: data type size problem in if_spppsubr.c To: Eitan Adler li...@eitanadler.com Hello Eitan, please send the output of diff -u (unified diff) - this makes it more likely someone will look at the patch Attached. Regards Jens -- Eitan Adler --047d7b2e40bebb1d9404ccc13653 Content-Type: application/x-patch-file; name=if_spppsubr.c.patch Content-Disposition: attachment; filename=if_spppsubr.c.patch Content-Transfer-Encoding: base64 X-Attachment-Id: ce731ba23a9a350e_0.1 LS0tIHN5cy9uZXQvaWZfc3BwcHN1YnIuYy5vcmlnCTIwMTItMTAtMjMgMTg6NTI6MTMuMDAwMDAw MDAwICswMjAwCisrKyBzeXMvbmV0L2lmX3NwcHBzdWJyLmMJMjAxMi0xMC0yMyAxODo1MjoyMy4w MDAwMDAwMDAgKzAyMDAKQEAgLTUxMzAsNyArNTEzMCw3IEBACiAJICogQ2hlY2sgdGhlIGNtZCB3 b3JkIGZpcnN0IGJlZm9yZSBhdHRlbXB0aW5nIHRvIGZldGNoIGFsbCB0aGUKIAkgKiBkYXRhLgog CSAqLwotCWlmICgoc3ViY21kID0gZnV3b3JkKGlmci0+aWZyX2RhdGEpKSA9PSAtMSkgeworCWlm ICgoc3ViY21kID0gZnV3b3JkMzIoaWZyLT5pZnJfZGF0YSkpID09IC0xKSB7CiAJCXJ2ID0gRUZB VUxUOwogCQlnb3RvIHF1aXQ7CiAJfQo= --047d7b2e40bebb1d9404ccc13653-- ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/173005: PW(8) - 'pw usermod' causes Segmentation fault: 11 (core dumped)
The following reply was made to PR bin/173005; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: jb jb.1234a...@gmail.com Cc: bug-follo...@freebsd.org Subject: Re: bin/173005: PW(8) - 'pw usermod' causes Segmentation fault: 11 (core dumped) Date: Tue, 23 Oct 2012 23:17:33 -0400 On 23 October 2012 18:19, jb jb.1234a...@gmail.com wrote: Description: # pw usermod moo4 -g Segmentation fault: 11 (core dumped) note to the person who fixes this: this is reproducible as root on FreeBSD radar 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r239951: Fri Aug 31 10:32:27 PDT 2012 eitan@radar:/usr/obj/more/src/sys/GENERIC amd64 if the user exists. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call
On 7 October 2012 12:14, Marcel Moolenaar mar...@xcllnt.net wrote: Other things we may want to do after we compile a file is generate API/ABI information that we can validate so that we can fail the build when some code change breaks the ABI or API. +1. I would love generate-abi/generate-api and check-abi/check-api targets. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/170651: On 9.0-RELEASE#0 and master sh(1) gobbles high bit at first
On 20 August 2012 07:24, Steffen Daode Nurpmeso sdao...@gmail.com wrote: Hi, Mark Linimon lini...@lonesome.com wrote: |The following reply was made to PR bin/170651; it has been noted by GNATS. | |From: Mark Linimon lini...@lonesome.com |To: bug-follo...@freebsd.org |Cc: |Subject: Re: bin/170651: On 9.0-RELEASE#0 and master sh(1) gobbles high bit | at first |Date: Sun, 19 Aug 2012 15:06:20 -0500 | | - Forwarded message from Steffen \Daode\ Nurpmeso sdao...@gmail.com - If there is anything i can do to release you from that forward burden, please let me know! Thanks, just noticed this: reply to bug-follo...@freebsd.org [not the -bugs mailing list] and make sure the first we characters are Re: category/number -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/166842: bsdgrep(1) inconsistently handles ^ in non-anchoring positions
Some notes: [10010 eitan@radar ~ ]%uname -rms FreeBSD 10.0-CURRENT amd64 [10007 eitan@radar ~ ]%bsdgrep --version bsdgrep (BSD grep) 2.5.1-FreeBSD [10004 eitan@radar ~ ]%printf 'abc def' | bsdgrep -o '^[a-z]' a [10006 eitan@radar ~ ]%gnugrep --version gnugrep (GNU grep) 2.5.1-FreeBSD [10005 eitan@radar ~ ]%printf 'abc def' | gnugrep -o '^[a-z]' a b c [441 eadler1@harvey ~ ]%uname -rms Linux 2.6.38-13-generic-pae i686 [437 eadler1@harvey ~ ]%grep --version GNU grep 2.6.3 [439 eadler1@harvey ~ ]%printf 'abc def' | grep -o '^[a-z]' a -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/131448: Bad display while booting
2012/3/10 Fernando Apesteguía fernando.apesteg...@gmail.com: I can confirm this does not happen in recent versions of FreeBSD. (neither 8.x or 9.0) Good to know the bug got fixed. -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/163748: [patch] document NEW_PCIB option and disable on some legacy platforms
On Wed, Jan 4, 2012 at 9:03 PM, Xin Li delp...@delphij.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/02/12 07:21, ead...@freebsd.org wrote: Synopsis: [patch] document NEW_PCIB option and disable on some legacy platforms Responsible-Changed-From-To: freebsd-bugs-eadler Responsible-Changed-By: eadler Responsible-Changed-When: Mon Jan 2 15:21:15 UTC 2012 Responsible-Changed-Why: I'll take it. Please hold, we will need to test if r228961 fixed the problem. (It fixed part of the problem for me at least, for my D630's ichwd(4) watchdog). Cheers, Will do. Please inform me if and when this should be committed (likely in a shorter form)? Also if the fix does work please let me know so I could close the PR. -- Eitan Adler Ports committer X11, Bugbusting teams ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: kern/105604: [bktr] [patch] add support for Pixelview PlayTV Pro 2 on bktr
On Thu, Dec 8, 2011 at 3:17 AM, Stefan Lambrev che...@freebsd-bg.org wrote: Hi, Unfortunately I do not have the hardware anymore :( :( I'm sorry this PR went so long without anyone looking at it. Unfortunately I am not able to help unless I have access to the hardware. For now I'll close the PR, but feel free to resubmit (or poke me) if it needs to be reopened. -- Eitan Adler Ports committer X11, Bugbusting teams ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
conf/161847: [patch] reaper of the dead: remove ancient devfs example
Number: 161847 Category: conf Synopsis: [patch] reaper of the dead: remove ancient devfs example Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: change-request Submitter-Id: current-users Arrival-Date: Thu Oct 20 23:10:10 UTC 2011 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: Environment: Description: x11@ no longer sees the need to keep vga example in /etc/devfs.conf How-To-Repeat: Fix: Patch attached with submission follows: Index: devfs.conf === --- devfs.conf (revision 226554) +++ devfs.conf (working copy) @@ -31,9 +31,6 @@ # # Examples: -# Historically X depended on this, but version 4.3.0 doesn't seem to anymore -#link ttyv0 vga - # Commonly used by many ports #link acd0cdrom Release-Note: Audit-Trail: Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/160491: [patch] reaper of the dead: remove ancient FAQ entries
Number: 160491 Category: misc Synopsis: [patch] reaper of the dead: remove ancient FAQ entries Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: sw-bug Submitter-Id: current-users Arrival-Date: Mon Sep 05 19:40:01 UTC 2011 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: graveyard Environment: Description: The attached patch is an incomplete mass removal of outdated FAQ questions. I removed whichever questions I knew to be no longer relevant, but left ones I was not 100% certain about about. We need to strip the FAQ to the bare bones and build it back up. How-To-Repeat: Fix: Index: book.sgml === RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/faq/book.sgml,v retrieving revision 1.1140 diff -u -r1.1140 book.sgml --- book.sgml 29 Aug 2011 05:16:37 - 1.1140 +++ book.sgml 5 Sep 2011 19:37:12 - @@ -46,7 +46,6 @@ tm-attrib.ibm; tm-attrib.ieee; tm-attrib.intel; - tm-attrib.iomega; tm-attrib.linux; tm-attrib.microsoft; tm-attrib.mips; @@ -65,7 +64,7 @@ paraThis is the FAQ for os; versions 6.replaceableX/replaceable, 7.replaceableX/replaceable and 8.replaceableX/replaceable. All entries are assumed to be - relevant to os; 6.replaceableX/replaceable and later, + relevant to os; 7.replaceableX/replaceable and later, unless otherwise noted. If you are interested in helping with this project, send email to the a.doc;. The latest version of this document is always available from the ulink @@ -84,8 +83,8 @@ titleIntroduction/title paraWelcome to the os; - 6.replaceableX/replaceable-, 7.replaceableX/replaceable- and - 8.replaceableX/replaceable FAQ!/para + 7.replaceableX/replaceable-, 8.replaceableX/replaceable- and + 9.replaceableX/replaceable FAQ!/para paraAs is usual with Usenet FAQs, this document aims to cover the most frequently asked questions concerning the os; operating @@ -1141,107 +1140,6 @@ titleInstallation/title qandaset - qandaentry - question id=floppy-download - paraWhich file do I download to get os;?/para - /question - - answer - paraYou need three floppy images: - filenamefloppies/boot.flp/filename, - filenamefloppies/kern1.flp/filename, and - filenamefloppies/kern2.flp/filename. These images need - to be copied onto floppies by tools like - commandfdimage/command or man.dd.1;./para - - paraIf you need to download the distributions yourself (for - a DOS file system install, for instance), below are some - recommendations for distributions to grab:/para - - itemizedlist - listitem - parabase//para - /listitem - - listitem - paramanpages//para - /listitem - - listitem - paracompat*//para - /listitem - - listitem - paradoc//para - /listitem - - listitem - parasrc/ssys.*/para - /listitem - /itemizedlist - - paraFull instructions on this procedure and a little bit - more about installation issues in general can be found in - the ulink - url=url.books.handbook;/install.htmlHandbook entry on installing os;/ulink. - /para - /answer - /qandaentry - - qandaentry - question id=floppy-image-too-large - paraWhat do I do if the floppy images does not fit on a - single floppy?/para - /question - - answer - paraA 3.5nbsp;inch (1.44nbsp;MB) floppy can accommodate - 1,474,560nbsp;bytes of data. The boot image is exactly - 1,474,560nbsp;bytes in size./para - - paraCommon mistakes when preparing the boot floppy - are:/para - - itemizedlist - listitem - paraNot downloading the floppy image in - emphasisbinary/emphasis mode when using - acronymFTP/acronym./para - - paraSome FTP clients default their transfer mode to - emphasisascii/emphasis and attempt to change any - end-of-line characters received to match the conventions - used by the client's system. This will almost - invariably corrupt the boot image. Check the size of - the downloaded boot image: if it is not - emphasisexactly/emphasis that on the server, then - the download process is suspect./para - - paraTo workaround: type emphasisbinary/emphasis at - the FTP command prompt after getting
misc/158776: [patch] [bsd.license.db.mk] add support for the copyfree group of licenses
Number: 158776 Category: misc Synopsis: [patch] [bsd.license.db.mk] add support for the copyfree group of licenses Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: change-request Submitter-Id: current-users Arrival-Date: Sun Jul 10 20:40:09 UTC 2011 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: Environment: Description: There are some zealots that want to explicitly be asked about any non-copyfree licenses, and some enterprise companies probably don't want copyleft software, but don't mind copyfree software. This patch adds the group to the license database. More information here: http://copyfree.org/ How-To-Repeat: Fix: Index: bsd.licenses.db.mk === RCS file: /home/ncvs/ports/Mk/bsd.licenses.db.mk,v retrieving revision 1.14 diff -u -r1.14 bsd.licenses.db.mk --- bsd.licenses.db.mk 25 Mar 2011 20:52:48 - 1.14 +++ bsd.licenses.db.mk 10 Jul 2011 20:21:42 - @@ -48,6 +48,8 @@ _LICENSE_NAME_OSI= OSI Approved +_LICENSE_NAME_COPYFREE= Comply with Copyfree Standard Definition. + # Default permissions for licenses here, if not defined _LICENSE_PERMS_DEFAULT=dist-mirror dist-sell pkg-mirror pkg-sell auto-accept @@ -70,13 +72,13 @@ _LICENSE_GROUPS_ART20= FSF GPL OSI _LICENSE_NAME_ASL= Apache License -_LICENSE_GROUPS_ASL= FSF OSI +_LICENSE_GROUPS_ASL= FSF OSI COPYFREE _LICENSE_NAME_BSD= BSD license -_LICENSE_GROUPS_BSD= FSF OSI +_LICENSE_GROUPS_BSD= FSF OSI COPYFREE _LICENSE_NAME_BSL= Boost Software License -_LICENSE_GROUPS_BSL= FSF OSI +_LICENSE_GROUPS_BSL= FSF OSI COPYFREE _LICENSE_NAME_CDDL=Common Development and Distribution License _LICENSE_GROUPS_CDDL= FSF OSI @@ -97,7 +99,7 @@ _LICENSE_GROUPS_GPLv3= FSF GPL OSI _LICENSE_NAME_ISCL=Internet Systems Consortium License -_LICENSE_GROUPS_ISCL= FSF GPL OSI +_LICENSE_GROUPS_ISCL= FSF GPL OSI COPYFREE _LICENSE_NAME_LGPL20= GNU Library General Public License version 2.0 _LICENSE_GROUPS_LGPL20=FSF GPL OSI @@ -137,13 +139,13 @@ _LICENSE_PERMS_LPPL13c=dist-mirror dist-sell _LICENSE_NAME_MIT= MIT license / X11 license -_LICENSE_GROUPS_MIT= FSF GPL OSI +_LICENSE_GROUPS_MIT= FSF GPL OSI COPYFREE _LICENSE_NAME_MPL= Mozilla Public License _LICENSE_GROUPS_MPL= FSF OSI _LICENSE_NAME_OWL= Open Works License (owl.apotheon.org) -_LICENSE_GROUPS_OWL= +_LICENSE_GROUPS_OWL= COPYFREE _LICENSE_NAME_PHP202= PHP License version 2.02 _LICENSE_GROUPS_PHP202=FSF OSI Release-Note: Audit-Trail: Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/156875: [patch] update misc/kbdscan to the latest version
Number: 156875
Category: misc
Synopsis: [patch] update misc/kbdscan to the latest version
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: maintainer-update
Submitter-Id: current-users
Arrival-Date: Sun May 08 02:50:06 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
How-To-Repeat:
Fix:
Index: Makefile
===
RCS file: /home/ncvs/ports/misc/kbdscan/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile9 Sep 2010 08:19:56 - 1.2
+++ Makefile8 May 2011 02:22:11 -
@@ -7,7 +7,7 @@
#
PORTNAME= kbdscan
-PORTVERSION= 20100427
+PORTVERSION= 20110507
CATEGORIES=misc
MASTER_SITES= http://hack.org/mc/hacks/${PORTNAME}/
Index: distinfo
===
RCS file: /home/ncvs/ports/misc/kbdscan/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo19 Mar 2011 12:31:05 - 1.2
+++ distinfo8 May 2011 02:22:11 -
@@ -1,2 +1,2 @@
-SHA256 (kbdscan-20100427.tar.bz2) =
7fde919e2c633e6e21135e0fed7b13ba7d1c11749a9b7fe0abbbe725c348e722
-SIZE (kbdscan-20100427.tar.bz2) = 2434
+SHA256 (kbdscan-20110507.tar.bz2) =
6b63b43e2f8aff44cdc233d5d5cf35f2ff7ac93052af11b151cb44d6b7105ef1
+SIZE (kbdscan-20110507.tar.bz2) = 2428
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/156340: [patch] [bsd.port.mk] reaper of the dead: are three variable defintions needed
Number: 156340
Category: misc
Synopsis: [patch] [bsd.port.mk] reaper of the dead: are three variable
defintions needed
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Tue Apr 12 02:00:22 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
I'm basing this PR entirely on the comment near the definition. I'm able to
build ports with this patch. I think an exp-run would be useful XXX Are these
needed here? DESCR was set wrong for a few years
How-To-Repeat:
Fix:
Index: bsd.port.subdir.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.subdir.mk,v
retrieving revision 1.77
diff -u -r1.77 bsd.port.subdir.mk
--- bsd.port.subdir.mk 20 Dec 2010 12:23:52 - 1.77
+++ bsd.port.subdir.mk 12 Apr 2011 01:38:34 -
@@ -50,11 +50,6 @@
MOVEDDIR?= ${PORTSDIR}
MOVEDFILE?=MOVED
-# XXX Are these needed here? DESCR was set wrong for a few years
-MASTERDIR?= ${.CURDIR}
-PKGDIR?= ${MASTERDIR}
-DESCR?=${PKGDIR}/pkg-descr
-
.include ${PORTSDIR}/Mk/bsd.commands.mk
.MAIN: all
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
conf/155737: [patch] reaper of the dead: remove OBJFORMAT variable in share/mk/sys.mk
Number: 155737
Category: conf
Synopsis: [patch] reaper of the dead: remove OBJFORMAT variable in
share/mk/sys.mk
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: change-request
Submitter-Id: current-users
Arrival-Date: Mon Mar 21 00:40:01 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
There appears to be a variable added by ru@ in r94940 that is no longer used by
source or ports in share/mk/sys.mk
This patch removes said variable.
Filed under conf/ because it affects a .mk file. Feel free to re-categorize.
How-To-Repeat:
Fix:
Index: sys.mk
===
--- sys.mk (revision 219789)
+++ sys.mk (working copy)
@@ -360,10 +360,6 @@
.SHELL: path=${__MAKE_SHELL}
.endif
-# Default executable format
-# XXX hint for bsd.port.mk
-OBJFORMAT?=elf
-
# Toggle on warnings
.WARN: dirsyntax
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
conf/155738: [patch] reaper of the dead: time to BURN_BRIDGES and remove bsd.compat.mk
Number: 155738
Category: conf
Synopsis: [patch] reaper of the dead: time to BURN_BRIDGES and remove
bsd.compat.mk
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: change-request
Submitter-Id: current-users
Arrival-Date: Mon Mar 21 01:20:01 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
I'm a able to build world with the current sources and BURN_BRIDGES set (and
the .warn changed to .error) as well as the with the patch supplied.
The compatibility options described were initially committed by ru@ in r139103
(2004) and last touched in r172831 (2007).
It has been 4 years since these options have been deprecated so I think it
would be a good time to remove these compatibility options.
How-To-Repeat:
Fix:
$svn rm bsd.compat.mk
Index: bsd.own.mk
===
--- bsd.own.mk (revision 219789)
+++ bsd.own.mk (working copy)
@@ -198,80 +198,6 @@
.endfor
#
-# Compat NO_* options (same as above, except their use is deprecated).
-#
-.if !defined(BURN_BRIDGES)
-.for var in \
-ACPI \
-ATM \
-AUDIT \
-AUTHPF \
-BIND \
-BIND_DNSSEC \
-BIND_ETC \
-BIND_LIBS_LWRES \
-BIND_MTREE \
-BIND_NAMED \
-BIND_UTILS \
-BLUETOOTH \
-BOOT \
-CALENDAR \
-CPP \
-CRYPT \
-CVS \
-CXX \
-DICT \
-DYNAMICROOT \
-EXAMPLES \
-FORTH \
-FP_LIBC \
-GAMES \
-GCOV \
-GDB \
-GNU \
-GPIB \
-GROFF \
-HTML \
-INET6 \
-INFO \
-IPFILTER \
-IPX \
-KERBEROS \
-LIB32 \
-LIBPTHREAD \
-LIBTHR \
-LOCALES \
-LPR \
-MAILWRAPPER \
-NETCAT \
-NIS \
-NLS \
-NLS_CATALOGS \
-NS_CACHING \
-OBJC \
-OPENSSH \
-OPENSSL \
-PAM \
-PF \
-RCMDS \
-RCS \
-RESCUE \
-SENDMAIL \
-SETUID_LOGIN \
-SHAREDOCS \
-SYSCONS \
-TCSH \
-TOOLCHAIN \
-USB \
-WPA_SUPPLICANT_EAPOL
-.if defined(NO_${var})
-#.warning NO_${var} is deprecated in favour of WITHOUT_${var}=
-WITHOUT_${var}=
-.endif
-.endfor
-.endif # !defined(BURN_BRIDGES)
-
-#
# Older-style variables that enabled behaviour when set.
#
.if defined(YES_HESIOD)
Index: sys.mk
===
--- sys.mk (revision 219789)
+++ sys.mk (working copy)
@@ -369,5 +369,4 @@
.endif
-.include bsd.compat.mk
.include bsd.cpu.mk
Index: Makefile
===
--- Makefile(revision 219789)
+++ Makefile(working copy)
@@ -3,7 +3,7 @@
FILES= bsd.README
FILES+=bsd.arch.inc.mk
-FILES+=bsd.compat.mk bsd.cpu.mk bsd.dep.mk bsd.doc.mk bsd.dtrace.mk
+FILES+=bsd.cpu.mk bsd.dep.mk bsd.doc.mk bsd.dtrace.mk
FILES+=bsd.endian.mk
FILES+=bsd.files.mk bsd.crunchgen.mk bsd.incs.mk bsd.info.mk
bsd.init.mk
FILES+=bsd.kmod.mk
Index: bsd.init.mk
===
--- bsd.init.mk (revision 219789)
+++ bsd.init.mk (working copy)
@@ -9,7 +9,6 @@
.if exists(${.CURDIR}/../Makefile.inc)
.include ${.CURDIR}/../Makefile.inc
.endif
-.include bsd.compat.mk
.include bsd.own.mk
.MAIN: all
.endif # !target(__bsd.init.mk__)
Index: ObsoleteFiles.inc
===
--- ObsoleteFiles.inc (revision 219789)
+++ ObsoleteFiles.inc (working copy)
@@ -38,6 +38,9 @@
# xargs -n1 | sort | uniq -d;
# done
+# ???: remove old compatability options
+OLD_FILES+=share/mk/bsd.compat.mk
+
# 20110224: sticky.8 - sticky.7
OLD_FILES+=usr/share/man/man8/sticky.8.gz
# 20110220: new clang import which bumps version from 2.8 to 2.9
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/155629: [bsd.port.mk] [patch] remove outdates NOPRECIOUSMAKEVARS checks
Number: 155629
Category: misc
Synopsis: [bsd.port.mk] [patch] remove outdates NOPRECIOUSMAKEVARS checks
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Thu Mar 17 15:20:08 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
NOPRECIOUSSOFTMAKEVARS is always set on all supported releases and is therefore
never undefined. As such code which checks to see if it is defined should be
removed.
How-To-Repeat:
$/usr/obj/usr/src/release/7.1.0/usr.bin/make/make -V MAKE_VERSION
5200408120
$/usr/obj/usr/src/release/7.4.0/usr.bin/make/make -V MAKE_VERSION
5200408120
$/usr/obj/usr/src/stable/8/usr.bin/make/make -V MAKE_VERSION
5200408120
$/usr/obj/usr/src/head/usr.bin/make/make -V MAKE_VERSION
5200408120
$bc 5200408120 - 5200408030
90
Fix:
Index: bsd.port.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.674
diff -u -r1.674 bsd.port.mk
--- bsd.port.mk 7 Mar 2011 07:32:05 - 1.674
+++ bsd.port.mk 17 Mar 2011 14:16:10 -
@@ -1189,12 +1189,6 @@
# Start of options section
.if defined(INOPTIONSMK) || ( !defined(USEOPTIONSMK) !defined(AFTERPORTMK) )
-.if defined(MAKE_VERSION)
-.if ${MAKE_VERSION} = 5200408030 || ${MAKE_VERSION} = 4200408030
${MAKE_VERSION} 50
-NOPRECIOUSSOFTMAKEVARS= yes
-.endif
-.endif
-
# Get the default maintainer
MAINTAINER?= po...@freebsd.org
@@ -6051,24 +6045,6 @@
tags:
.endif
-.if !defined(NOPRECIOUSSOFTMAKEVARS)
-.for softvar in CKSUMFILES _MLINKS
-.if defined(${softvar})
-__softMAKEFLAGS+= '${softvar}+=${${softvar}:S/'/'\''/g}'
-.endif
-.endfor
-.endif
-
-.if !defined(NOPRECIOUSMAKEVARS)
-# These won't change, so we can pass them through the environment
-.MAKEFLAGS: \
- ARCH=${ARCH:S//''/g:S/\$/\$\$/g:S/\\//g} \
- OPSYS=${OPSYS:S//''/g:S/\$/\$\$/g:S/\\//g} \
- OSREL=${OSREL:S//''/g:S/\$/\$\$/g:S/\\//g} \
- OSVERSION=${OSVERSION:S//''/g:S/\$/\$\$/g:S/\\//g} \
- SYSTEMVERSION=${SYSTEMVERSION:S//''/g:S/\$/\$\$/g:S/\\//g}
-.endif
-
.if !target(config)
config:
.if !defined(OPTIONS)
Index: bsd.port.subdir.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.subdir.mk,v
retrieving revision 1.77
diff -u -r1.77 bsd.port.subdir.mk
--- bsd.port.subdir.mk 20 Dec 2010 12:23:52 - 1.77
+++ bsd.port.subdir.mk 17 Mar 2011 14:16:10 -
@@ -67,11 +67,6 @@
# (index build, etc), so it is more efficient to precompute them here and pass
them in
# to child makes explicitly, instead of recomputing them tens of thousands of
times.
-.if !defined(NOPRECIOUSMAKEVARS)
-.if !defined(ARCH)
-ARCH!= ${UNAME} -p
-.endif
-
.if !defined(OSVERSION)
.if exists(/usr/include/sys/param.h)
OSVERSION!=${AWK} '/^\#define[[:blank:]]__FreeBSD_version/ {print $$3}'
/usr/include/sys/param.h
@@ -362,27 +357,6 @@
$@
@${RM} -f $@.tmp $@.tmp2 $@.tmp3 $@.tmp4
-# Pass in the cached invariant variables to child makes.
-# XXX Why are we trying to escape these characters using regexps and not using
':Q'?
-.if !defined(NOPRECIOUSMAKEVARS)
-.MAKEFLAGS: \
- ARCH=${ARCH:S//''/g:S/\$/\$\$/g:S/\\//g} \
- OPSYS=${OPSYS:S//''/g:S/\$/\$\$/g:S/\\//g} \
- OSREL=${OSREL:S//''/g:S/\$/\$\$/g:S/\\//g} \
- OSVERSION=${OSVERSION:S//''/g:S/\$/\$\$/g:S/\\//g} \
- UID=${UID:S//''/g:S/\$/\$\$/g:S/\\//g} \
- PKGINSTALLVER=${PKGINSTALLVER:S//''/g:S/\$/\$\$/g:S/\\//g} \
- HAVE_COMPAT_IA32_KERN=${HAVE_COMPAT_IA32_KERN} \
- CONFIGURE_MAX_CMD_LEN=${CONFIGURE_MAX_CMD_LEN} \
- PYTHON_DEFAULT_VERSION=${PYTHON_DEFAULT_VERSION} \
- PYTHON_DEFAULT_PORTVERSION=${PYTHON_DEFAULT_PORTVERSION} \
- PYTHONBASE=${PYTHONBASE} \
- _JAVA_VERSION_LIST_REGEXP=${_JAVA_VERSION_LIST_REGEXP:Q} \
- _JAVA_VENDOR_LIST_REGEXP=${_JAVA_VENDOR_LIST_REGEXP:Q} \
- _JAVA_OS_LIST_REGEXP=${_JAVA_OS_LIST_REGEXP:Q} \
- _JAVA_PORTS_INSTALLED=${_JAVA_PORTS_INSTALLED}
-.endif
-
PORTSEARCH_DISPLAY_FIELDS?=name,path,info,maint,index,bdeps,rdeps,www
PORTSEARCH_KEYLIM?=0
PORTSEARCH_XKEYLIM?=0
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/153995: [patch] update ROADMAP.txt
Now that the next release has been made: Index: ROADMAP.txt === --- ROADMAP.txt (revision 217412) +++ ROADMAP.txt (working copy) @@ -47,6 +47,7 @@ stable/5/ stable/6/ stable/7/ + stable/8/ Releases: release/2.0/ (branched from head/) @@ -96,6 +97,11 @@ release/6.2.0/ release/6.3.0/ release/7.0.0/ + release/7.1.0/ + release/7.2.0/ + release/7.3.0/ + release/7.4.0/ + release/8.0.0/ + release/8.1.0/ + release/8.2.0/ Release Engineering / Errata branches: releng/ALPHA_2_0 (branched from head/) @@ -121,6 +127,13 @@ releng/6.2 (branched from stable/6/) releng/6.3 (branched from stable/6/) releng/7.0 (branched from stable/7/) + releng/7.1 (branched from stable/7/) + releng/7.2 (branched from stable/7/) + releng/7.3 (branched from stable/7/) + releng/7.4 (branched from stable/7/) + releng/8.0 (branched from stable/8/) + releng/8.1 (branched from stable/8/) + releng/8.2 (branched from stable/8/) Vendor layout: vendor/$vendor - roots for a given vendor import On Fri, Jan 14, 2011 at 2:30 PM, freebsd-gnats-sub...@freebsd.org wrote: Thank you very much for your problem report. It has the internal identification `misc/153995'. The individual assigned to look at your report is: freebsd-bugs. You can access the state of your problem report at any time via this link: http://www.freebsd.org/cgi/query-pr.cgi?pr=153995 Category: misc Responsible: freebsd-bugs Synopsis: [patch] update ROADMAP.txt Arrival-Date: Fri Jan 14 19:30:11 UTC 2011 -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/153995: [patch] update ROADMAP.txt
The following reply was made to PR misc/153995; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: freebsd-gnats-sub...@freebsd.org, freebsd-bugs@freebsd.org Cc: Subject: Re: misc/153995: [patch] update ROADMAP.txt Date: Wed, 16 Mar 2011 21:57:14 -0500 Now that the next release has been made: Index: ROADMAP.txt =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- ROADMAP.txt(revision 217412) +++ ROADMAP.txt(working copy) @@ -47,6 +47,7 @@ stable/5/ stable/6/ stable/7/ + stable/8/ Releases: release/2.0/ (branched from head/) @@ -96,6 +97,11 @@ release/6.2.0/ release/6.3.0/ release/7.0.0/ + release/7.1.0/ + release/7.2.0/ + release/7.3.0/ + release/7.4.0/ + release/8.0.0/ + release/8.1.0/ + release/8.2.0/ Release Engineering / Errata branches: releng/ALPHA_2_0 (branched from head/) @@ -121,6 +127,13 @@ releng/6.2 (branched from stable/6/) releng/6.3 (branched from stable/6/) releng/7.0 (branched from stable/7/) + releng/7.1 (branched from stable/7/) + releng/7.2 (branched from stable/7/) + releng/7.3 (branched from stable/7/) + releng/7.4 (branched from stable/7/) + releng/8.0 (branched from stable/8/) + releng/8.1 (branched from stable/8/) + releng/8.2 (branched from stable/8/) Vendor layout: vendor/$vendor - roots for a given vendor import On Fri, Jan 14, 2011 at 2:30 PM, freebsd-gnats-sub...@freebsd.org wrote: Thank you very much for your problem report. It has the internal identification `misc/153995'. The individual assigned to look at your report is: freebsd-bugs. You can access the state of your problem report at any time via this link: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D153995 Category: =C2=A0 =C2=A0 =C2=A0 misc Responsible: =C2=A0 =C2=A0freebsd-bugs Synopsis: =C2=A0 =C2=A0 =C2=A0 [patch] update ROADMAP.txt Arrival-Date: =C2=A0 Fri Jan 14 19:30:11 UTC 2011 --=20 Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/155503: [patch] remove sanity check for X_WINDOW_SYSTEM
Number: 155503
Category: misc
Synopsis: [patch] remove sanity check for X_WINDOW_SYSTEM
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Sat Mar 12 23:40:11 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
A check to see if X_WINDOW_SYSTEM is defined has been in b.p.m since 2008 when
flz committed it. The variable is not used anywhere in the ports tree now and
the check deserves to be removed.
1.590(flz 07-Mar-08): .if defined(X_WINDOW_SYSTEM)
${X_WINDOW_SYSTEM:L} != xorg
1.590(flz 07-Mar-08): IGNORE= cannot be installed:
bad X_WINDOW_SYSTEM setting; valid value is 'xorg'
1.566(flz 19-May-07): .endif
How-To-Repeat:
Fix:
Index: bsd.port.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.674
diff -u -r1.674 bsd.port.mk
--- bsd.port.mk 7 Mar 2011 07:32:05 - 1.674
+++ bsd.port.mk 12 Mar 2011 23:18:54 -
@@ -1396,10 +1396,6 @@
.include ${PORTSDIR}/Mk/bsd.linux-apps.mk
.endif
-.if defined(X_WINDOW_SYSTEM) ${X_WINDOW_SYSTEM:L} != xorg
-IGNORE=cannot be installed: bad X_WINDOW_SYSTEM setting; valid
value is 'xorg'
-.endif
-
.if ${X11BASE} != ${LOCALBASE}
.BEGIN:
@${ECHO_MSG} X11BASE is now deprecated. Unset X11BASE in make.conf
and try again.
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: gnu/137665: [patch] dialog(1) goes into tight loop on encountering eof
dialog does not go into a tight loop eating all CPU, but it still gets stuck. I believe it should take some action on encountering EOF, instead of waiting for input forever. My patch did that for the old dialog, typically taking the same path as pressing ESC would. I can not reproduce this using the command stated in the PR: $dialog --yesno foo -1 -1 /dev/null $dialog --version Version: 1.1-20100428 -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/155000: make(1) doesn't handle .POSIX: correctly
The following reply was made to PR bin/155000; it has been noted by GNATS. From: Eitan Adler ead...@freebsd.org To: bug-follo...@freebsd.org, cperc...@freebsd.org Cc: Subject: Re: bin/155000: make(1) doesn't handle .POSIX: correctly Date: Fri, 25 Feb 2011 12:27:19 -0500 This is just a pointer to bin/4 filed on a similar issue -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/155017: [patch] remove check for /usr/share/mk/bsd.port.options.mk
Number: 155017
Category: misc
Synopsis: [patch] remove check for /usr/share/mk/bsd.port.options.mk
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Fri Feb 25 02:10:13 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
bsd.port.options.mk exists in 7.1.0 and beyond. There is no reason to include
this check anymore.
How-To-Repeat:
Read bsd.port.mk expecting sanity. Realize this will never happen and just look
for code that is not needed anymore.
Fix:
Index: bsd.port.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.669
diff -u -r1.669 bsd.port.mk
--- bsd.port.mk 16 Feb 2011 10:43:53 - 1.669
+++ bsd.port.mk 24 Feb 2011 21:00:06 -
@@ -2928,24 +2928,6 @@
@${ECHO_CMD} ${MAINTAINER}
.endif
-.if !target(check-makefile)
-check-makefile::
-.if !exists(/usr/share/mk/bsd.port.options.mk)
- @${ECHO_CMD} !!! Detected system without bsd.port.options.mk (probably
old FreeBSD version)
- @${ECHO_CMD} !!! Dropping bsd.port.options.mk into /usr/share/mk
- -@${ECHO_CMD} USEOPTIONSMK= yes /usr/share/mk/bsd.port.options.mk
2/dev/null
- -@${ECHO_CMD} INOPTIONSMK=yes
/usr/share/mk/bsd.port.options.mk 2/dev/null
- -@${ECHO_CMD} .include bsd.port.mk
/usr/share/mk/bsd.port.options.mk 2/dev/null
- -@${ECHO_CMD} .undef INOPTIONSMK /usr/share/mk/bsd.port.options.mk
2/dev/null
-.if exists(/usr/share/mk/bsd.port.options.mk)
- @${ECHO_CMD} !!! Done
-.else
- @${ECHO_CMD} !!! Failed
-.endif
-.endif
- @${DO_NADA}
-.endif
-
.if !defined(CATEGORIES)
check-categories:
@${ECHO_MSG} ${PKGNAME}: Makefile error: CATEGORIES is mandatory.
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/154934: typo fix #2 is is - is
Number: 154934 Category: misc Synopsis: typo fix #2 is is - is Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: sw-bug Submitter-Id: current-users Arrival-Date: Mon Feb 21 13:50:09 UTC 2011 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: Environment: Description: I've been going through the source files with grep to find common typos. While a lot of them only affect code comments some of them affect documentation or fortune files. How-To-Repeat: Fix: Patch attached with submission follows: Index: usr.bin/tip/tip/tip.h === --- usr.bin/tip/tip/tip.h (revision 218912) +++ usr.bin/tip/tip/tip.h (working copy) @@ -259,7 +259,7 @@ intstoprompt; /* for interrupting a prompt session */ inttimedout; /* ~ transfer timedout */ intcumode; /* simulating the cu program */ -intbits8; /* terminal is is 8-bit mode */ +intbits8; /* terminal is 8-bit mode */ #define STRIP_PAR (bits8 ? 0377 : 0177) char fname[PATH_MAX];/* file name buffer for ~ */ Index: sbin/growfs/growfs.c === --- sbin/growfs/growfs.c(revision 218912) +++ sbin/growfs/growfs.c(working copy) @@ -646,7 +646,7 @@ /* * Copy the block back immediately. * -* XXX If src is is from an indirect block we have +* XXX If src is from an indirect block we have * to implement copy on write here in case of * active snapshots. */ Index: share/doc/psd/23.rpc/rpc.prog.ms === --- share/doc/psd/23.rpc/rpc.prog.ms(revision 218912) +++ share/doc/psd/23.rpc/rpc.prog.ms(working copy) @@ -71,7 +71,7 @@ .I The Highest Layer: .IX RPC The Highest Layer The highest layer is totally transparent to the operating system, -machine and network upon which is is run. It's probably best to +machine and network upon which is run. It's probably best to think of this level as a way of .I using RPC, rather than as Index: share/doc/papers/devfs/paper.me === --- share/doc/papers/devfs/paper.me (revision 218912) +++ share/doc/papers/devfs/paper.me (working copy) @@ -779,7 +779,7 @@ structure, removing the need for the devsw[] array and allowing device drivers to use separate entrypoints for various minor numbers. .lp -This is is very convenient for devices which have a ``control'' +This is very convenient for devices which have a ``control'' device for management and tuning. The control device, almost always have entirely separate open/close/ioctl implementations [MD.C]. .lp Index: sys/fs/nullfs/null_vnops.c === --- sys/fs/nullfs/null_vnops.c (revision 218912) +++ sys/fs/nullfs/null_vnops.c (working copy) @@ -672,7 +672,7 @@ * as soon as possible. * * Note, we can't release any resources nor remove vnode from hash before - * appropriate VXLOCK stuff is is done because other process can find this + * appropriate VXLOCK stuff is done because other process can find this * vnode in hash during inactivation and may be sitting in vget() and waiting * for null_inactive to unlock vnode. Thus we will do all those in VOP_RECLAIM. */ Index: sys/net80211/ieee80211_ageq.c === --- sys/net80211/ieee80211_ageq.c (revision 218912) +++ sys/net80211/ieee80211_ageq.c (working copy) @@ -154,7 +154,7 @@ * deltas (in seconds) relative to the head so we can check * and/or adjust only the head of the list. If a frame's age * exceeds the time quanta then remove it. The list of removed - * frames is is returned to the caller joined by m_nextpkt. + * frames is returned to the caller joined by m_nextpkt. */ struct mbuf * ieee80211_ageq_age(struct ieee80211_ageq *aq, int quanta) Index: sys/x86/isa/clock.c === --- sys/x86/isa/clock.c (revision 218912) +++ sys/x86/isa/clock.c (working copy) @@ -475,7 +475,7 @@ /* * Use `i8254' instead of `timer' in external names because `timer' -* is is too generic. Should use it everywhere. +* is too generic. Should use it everywhere. */ freq = i8254_freq; error = sysctl_handle_int(oidp, freq, 0, req); Index: sys/libkern/jenkins.h === --- sys/libkern/jenkins.h (revision
bin/154928: remove duplicate the the from a large section of base code
Number: 154928 Category: bin Synopsis: remove duplicate the the from a large section of base code Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: change-request Submitter-Id: current-users Arrival-Date: Mon Feb 21 05:50:09 UTC 2011 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: Environment: Description: There are a lot of typos and duplicate words in the FreeBSD base. This patch removes one of the more common ones: the the Do the size of the patch (1170 6678 49537) I decided not to attach to the PR but to leave it on the web: http://people.freebsd.org/~eadler/files/remove-the-the.patch I have a few more coming soon to fix other common typos :-) How-To-Repeat: Fix: Release-Note: Audit-Trail: Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/154395: [patch] remove obsolete
Number: 154395
Category: misc
Synopsis: [patch] remove obsolete
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Sun Jan 30 15:20:10 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
grep -ER {(SYSTEM|SYSLIB|LOCALLIB)DIR /usr/ports
turns up only one port which depends on the 4 obsolete variables defined in
bsd.gnustep.mk
I do not use gnustep so I am unable to test the following patch but the touched
port along with a few other gnustep ports seem ok.
How-To-Repeat:
Fix:
Index: Mk/bsd.gnustep.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.gnustep.mk,v
retrieving revision 1.63
diff -u -r1.63 bsd.gnustep.mk
--- Mk/bsd.gnustep.mk 11 Jun 2010 09:12:37 - 1.63
+++ Mk/bsd.gnustep.mk 30 Jan 2011 14:48:27 -
@@ -189,12 +189,6 @@
GNUSTEP_LOCAL_TOOLS= ${GNUSTEP_LOCAL_ROOT}/Tools
GNUSTEP_LOCAL_SERVICES=${GNUSTEP_LOCAL_ROOT}/Library/Services
-# Obsolete, for compatibility only
-SYSTEMDIR= ${GNUSTEP_SYSTEM_ROOT}
-SYSMAKEDIR=${GNUSTEP_MAKEFILES}
-SYSLIBDIR= ${GNUSTEP_SYSTEM_LIBRARIES}
-LOCALLIBDIR= ${GNUSTEP_LOCAL_LIBRARIES}
-
.if defined(WITH_GNUSTEP_DEVEL)
PKGNAMESUFFIX?=-devel${PKGNAMESUFFIX2}
PLIST_SUB+=GNUSTEP_DEVEL=
Index: Makefile
===
RCS file: /home/ncvs/ports/x11-themes/etoile-camaelon/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- Makefile5 Jun 2010 06:14:27 - 1.14
+++ Makefile30 Jan 2011 14:54:14 -
@@ -36,9 +36,9 @@
@${CAT} ${PKGMESSAGE}
install-user:
- @(. ${SYSMAKEDIR}/GNUstep.sh defaults write Camaelon Theme Nesedah)
+ @(. ${GNUSTEP_MAKEFILES}/GNUstep.sh defaults write Camaelon Theme
Nesedah)
deinstall-user:
- @(. ${SYSMAKEDIR}/GNUstep.sh defaults delete Camaelon Theme)
+ @(. ${GNUSTEP_MAKEFILES}/GNUstep.sh defaults delete Camaelon Theme)
.include bsd.port.mk
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
bin/154381: [patch] add mlinks from [bxl]zless.1 to less.1
Number: 154381
Category: bin
Synopsis: [patch] add mlinks from [bxl]zless.1 to less.1
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: change-request
Submitter-Id: current-users
Arrival-Date: Sat Jan 29 18:30:11 UTC 2011
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
The programs [bxl]zless lack manual pages.
How-To-Repeat:
man xzless
Fix:
Index: Makefile
===
--- Makefile(revision 217870)
+++ Makefile(working copy)
@@ -14,7 +14,11 @@
${BINDIR}/zless ${BINDIR}/bzless \
${BINDIR}/zless ${BINDIR}/xzless \
${BINDIR}/zless ${BINDIR}/lzless
-MLINKS=less.1 more.1
+MLINKS=less.1 more.1 \
+ less.1 bzless.1 \
+ less.1 xzless.1 \
+ less.1 lzless.1
+
CLEANFILES= less.1
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/154381: [patch] add mlinks from [bxl]zless.1 to less.1
The following reply was made to PR bin/154381; it has been noted by GNATS.
From: Eitan Adler li...@eitanadler.com
To: bug-follo...@freebsd.org, li...@eitanadler.com
Cc:
Subject: Re: bin/154381: [patch] add mlinks from [bxl]zless.1 to less.1
Date: Sat, 29 Jan 2011 13:36:25 -0500
Add zless as well
Index: Makefile
===
--- Makefile (revision 217870)
+++ Makefile (working copy)
@@ -14,7 +14,12 @@
${BINDIR}/zless ${BINDIR}/bzless \
${BINDIR}/zless ${BINDIR}/xzless \
${BINDIR}/zless ${BINDIR}/lzless
-MLINKS= less.1 more.1
+MLINKS= less.1 more.1 \
+ less.1 bzless.1 \
+ less.1 xzless.1 \
+ less.1 lzless.1 \
+ less.1 zless.1
+
CLEANFILES= less.1
.include Makefile.common
--
Eitan Adler
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/153995: [patch] update ROADMAP.txt
Number: 153995 Category: misc Synopsis: [patch] update ROADMAP.txt Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: sw-bug Submitter-Id: current-users Arrival-Date: Fri Jan 14 19:30:11 UTC 2011 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: Environment: Description: Just some housekeeping - update ROADMAP.txt to include the latest changes. How-To-Repeat: Fix: Index: ROADMAP.txt === --- ROADMAP.txt (revision 217412) +++ ROADMAP.txt (working copy) @@ -47,6 +47,7 @@ stable/5/ stable/6/ stable/7/ + stable/8/ Releases: release/2.0/ (branched from head/) @@ -96,6 +97,8 @@ release/6.2.0/ release/6.3.0/ release/7.0.0/ + release/8.0.0/ + release/8.1.0/ Release Engineering / Errata branches: releng/ALPHA_2_0 (branched from head/) @@ -121,6 +124,9 @@ releng/6.2 (branched from stable/6/) releng/6.3 (branched from stable/6/) releng/7.0 (branched from stable/7/) + releng/8.0 (branched from stable/8/) + releng/8.1 (branched from stable/8/) + releng/8.2 (branched from stable/8/) Vendor layout: vendor/$vendor - roots for a given vendor import Release-Note: Audit-Trail: Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/153995: [patch] update ROADMAP.txt
The following reply was made to PR misc/153995; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-follo...@freebsd.org, li...@eitanadler.com Cc: Subject: Re: misc/153995: [patch] update ROADMAP.txt Date: Fri, 14 Jan 2011 14:37:14 -0500 I forgot about the 7.x set. IMHO I don't really think we need to keep a listing of all the branches in this file and perhaps they should just be removed (and remove the general information) Index: ROADMAP.txt === --- ROADMAP.txt(revision 217412) +++ ROADMAP.txt(working copy) @@ -47,6 +47,7 @@ stable/5/ stable/6/ stable/7/ + stable/8/ Releases: release/2.0/ (branched from head/) @@ -96,6 +97,11 @@ release/6.2.0/ release/6.3.0/ release/7.0.0/ + release/7.1.0/ + release/7.2.0/ + release/7.3.0/ + release/8.0.0/ + release/8.1.0/ Release Engineering / Errata branches: releng/ALPHA_2_0 (branched from head/) @@ -121,6 +127,13 @@ releng/6.2 (branched from stable/6/) releng/6.3 (branched from stable/6/) releng/7.0 (branched from stable/7/) + releng/7.1 (branched from stable/7/) + releng/7.2 (branched from stable/7/) + releng/7.3 (branched from stable/7/) + releng/7.4 (branched from stable/7/) + releng/8.0 (branched from stable/8/) + releng/8.1 (branched from stable/8/) + releng/8.2 (branched from stable/8/) Vendor layout: vendor/$vendor - roots for a given vendor import -- Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: misc/153995: [patch] update ROADMAP.txt
The following reply was made to PR misc/153995; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-follo...@freebsd.org Cc: Subject: Re: misc/153995: [patch] update ROADMAP.txt Date: Fri, 14 Jan 2011 14:39:41 -0500 Sorry, and *leave* the general information. On Fri, Jan 14, 2011 at 2:37 PM, Eitan Adler li...@eitanadler.com wrote: I forgot about the 7.x set. IMHO I don't really think we need to keep a listing of all the branches in this file and perhaps they should just be removed (and remove the general information) Index: ROADMAP.txt =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- ROADMAP.txt (revision 217412) +++ ROADMAP.txt (working copy) @@ -47,6 +47,7 @@ =C2=A0 stable/5/ =C2=A0 stable/6/ =C2=A0 stable/7/ + =C2=A0stable/8/ =C2=A0Releases: =C2=A0 release/2.0/ =C2=A0 =C2=A0 (branched from head/) @@ -96,6 +97,11 @@ =C2=A0 release/6.2.0/ =C2=A0 release/6.3.0/ =C2=A0 release/7.0.0/ + =C2=A0release/7.1.0/ + =C2=A0release/7.2.0/ + =C2=A0release/7.3.0/ + =C2=A0release/8.0.0/ + =C2=A0release/8.1.0/ =C2=A0Release Engineering / Errata branches: =C2=A0 releng/ALPHA_2_0 (branched from head/) @@ -121,6 +127,13 @@ =C2=A0 releng/6.2 =C2=A0 =C2=A0 =C2=A0 (branched from stable/6/) =C2=A0 releng/6.3 =C2=A0 =C2=A0 =C2=A0 (branched from stable/6/) =C2=A0 releng/7.0 =C2=A0 =C2=A0 =C2=A0 (branched from stable/7/) + =C2=A0releng/7.1 =C2=A0 =C2=A0 =C2=A0 (branched from stable/7/) + =C2=A0releng/7.2 =C2=A0 =C2=A0 =C2=A0 (branched from stable/7/) + =C2=A0releng/7.3 =C2=A0 =C2=A0 =C2=A0 (branched from stable/7/) + =C2=A0releng/7.4 =C2=A0 =C2=A0 =C2=A0 (branched from stable/7/) + =C2=A0releng/8.0 =C2=A0 =C2=A0 =C2=A0 (branched from stable/8/) + =C2=A0releng/8.1 =C2=A0 =C2=A0 =C2=A0 (branched from stable/8/) + =C2=A0releng/8.2 =C2=A0 =C2=A0 =C2=A0 (branched from stable/8/) =C2=A0Vendor layout: =C2=A0 vendor/$vendor - roots for a given vendor import -- Eitan Adler --=20 Eitan Adler ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
bin/152871: [patch] Request for exp-run and comment
Number: 152871
Category: bin
Synopsis: [patch] Request for exp-run and comment
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: change-request
Submitter-Id: current-users
Arrival-Date: Mon Dec 06 20:40:09 UTC 2010
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:FreeBSD
Organization:
Environment:
This is a request for an exp run and comments about this patch.
Description:
I noticed a line in bsd.port.mk Kludge for pre-3.0 systems
# Kludge for pre-3.0 ystems
MACHINE_ARCH?= i386
According to cvs blame asami@ added both lines in revision 1.306 in 1999
Furthermore in bsd.port.mk it says ports should test against ARCH and
not MACHINE_ARCH
but bsd.port.subdir.mk uses MACHINE_ARCH on line 209.
bsd.gnustep.mk has a similar test for MACHINE_ARCH instead of ARCH on
line 136 (r1.1 by dinoex)
1) Should the initial line be removed
2) Should bsd.port.subdir.mk be changed to use ARCH instead?
3) Should bsd.gnustep.mk be changed to use ARCH instead?
Overall I've been finding lots of inconsistent old hacks in bsd.*.mk
and its difficult to tell which ones are still needed and which ones
are not :-(
How-To-Repeat:
Fix:
--- remove-machine-arch.patch begins here ---
Index: bsd.port.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.660
diff -u -r1.660 bsd.port.mk
--- bsd.port.mk 4 Dec 2010 07:30:13 - 1.660
+++ bsd.port.mk 6 Dec 2010 02:49:24 -
@@ -38,9 +38,7 @@
# different actions for different values.
#
# ARCH - The architecture of the target machine, such as would
be
-#returned by uname -p. (Note: Ports should
test against
-#ARCH, and not the host machine's architecture
which is
-#MACHINE_ARCH, to enable ports to be
cross-built.)
+#returned by uname -p.
# OPSYS- Portability clause. This is the operating
system the
#makefile is being used on. Automatically set
to
#FreeBSD, NetBSD, or OpenBSD as
appropriate.
@@ -1208,9 +1206,6 @@
ARCH!= ${UNAME} -p
.endif
-# Kludge for pre-3.0 systems
-MACHINE_ARCH?= i386
-
# Get the operating system type
.if !defined(OPSYS)
OPSYS!=${UNAME} -s
Index: bsd.gnustep.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.gnustep.mk,v
retrieving revision 1.63
diff -u -r1.63 bsd.gnustep.mk
--- bsd.gnustep.mk 11 Jun 2010 09:12:37 - 1.63
+++ bsd.gnustep.mk 6 Dec 2010 02:49:24 -
@@ -133,10 +133,10 @@
GNUSTEP_ART_PORT?= x11-toolkits/gnustep-art
GNUSTEP_CAIRO_PORT?= x11-toolkits/gnustep-cairo
-.if ${MACHINE_ARCH} == i386
+.if ${ARCH} == i386
GNU_ARCH= ix86
.else
-GNU_ARCH= ${MACHINE_ARCH}
+GNU_ARCH= ${ARCH}
.endif
.if !defined(USE_MAKEFILE)
Index: bsd.port.subdir.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.port.subdir.mk,v
retrieving revision 1.76
diff -u -r1.76 bsd.port.subdir.mk
--- bsd.port.subdir.mk 25 May 2010 15:18:06 - 1.76
+++ bsd.port.subdir.mk 6 Dec 2010 02:49:24 -
@@ -206,8 +206,8 @@
${ECHO_MSG} === ${DIRPRFX}$$sub skipped; \
fi; \
done; \
- if test -d ${.CURDIR}/$${sub}.${MACHINE_ARCH}; then \
- edir=$${sub}.${MACHINE_ARCH}; \
+ if test -d ${.CURDIR}/$${sub}.${ARCH}; then \
+ edir=$${sub}.${ARCH}; \
elif test -d ${.CURDIR}/$${sub}; then \
edir=$${sub}; \
else \
--- remove-machine-arch.patch ends here ---
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/152852: [patch] add link to WantedPorts to handbook
Number: 152852 Category: misc Synopsis: [patch] add link to WantedPorts to handbook Confidential: no Severity: non-critical Priority: low Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: sw-bug Submitter-Id: current-users Arrival-Date: Sun Dec 05 20:00:20 UTC 2010 Closed-Date: Last-Modified: Originator: Eitan Adler Release: Organization: Environment: Description: Some people would like to contribute to ports but don't know what needs to be ported. How-To-Repeat: Fix: Index: book.sgml === RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v retrieving revision 1.1087 diff -u -r1.1087 book.sgml --- book.sgml 30 Nov 2010 22:42:02 - 1.1087 +++ book.sgml 5 Dec 2010 16:42:54 - @@ -86,6 +86,10 @@ typing command:set tabstop=4/command once the file has been loaded./para /note + para +Looking for something easy to start with? Take a look at the +ulink url=http://wiki.freebsd.org/WantedPorts;list of requested ports/ulink and see if you can work on one (or more). + /para /chapter chapter id=quick-porting Release-Note: Audit-Trail: Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
bin/152856: [patch] allow up to be used instead of update in freebsd-update
Number: 152856
Category: bin
Synopsis: [patch] allow up to be used instead of update in freebsd-update
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: change-request
Submitter-Id: current-users
Arrival-Date: Mon Dec 06 03:10:06 UTC 2010
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
To make it easier for users used to a VCS that allows up to be a shortcut for
update.
How-To-Repeat:
Fix:
Index: portsnap.sh
===
--- portsnap.sh (revision 215710)
+++ portsnap.sh (working copy)
@@ -143,6 +143,9 @@
cron | extract | fetch | update)
COMMANDS=${COMMANDS} $1
;;
+ up)
+ COMMANDS=${COMMANDS} update
+ ;;
*)
if [ $# -gt 1 ]; then usage; fi
if echo ${COMMANDS} | grep -vq extract; then
--
Eitan Adler
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
misc/152795: Remove old KDE_ORIGVER
Number: 152795
Category: misc
Synopsis: Remove old KDE_ORIGVER
Confidential: no
Severity: non-critical
Priority: low
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: sw-bug
Submitter-Id: current-users
Arrival-Date: Thu Dec 02 23:10:05 UTC 2010
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
There is a variable set in bsd.kde.mk that is not used anywhere in the ports
tree
How-To-Repeat:
#grep -R ORIGVER ..
./Mk/bsd.kde.mk:KDE_ORIGVER=${KDE_VERSION}
./Tools/scripts/portsvar.sh:# KDE_ORIGVER = ${KDE_VERSION}
Fix:
Index: Mk/bsd.kde.mk
===
RCS file: /home/ncvs/ports/Mk/bsd.kde.mk,v
retrieving revision 1.81
diff -u -r1.81 bsd.kde.mk
--- Mk/bsd.kde.mk 11 Jun 2009 09:09:28 - 1.81
+++ Mk/bsd.kde.mk 2 Dec 2010 22:58:11 -
@@ -101,7 +101,6 @@
# Yeah, it's namespace pollution, but this is really the best place for this
# stuff. Arts does NOT use it anymore.
KDE_VERSION= 3.5.10
-KDE_ORIGVER= ${KDE_VERSION}
KDE_PREFIX?= ${LOCALBASE}
QTCPPFLAGS?=
cvs diff: Diffing Tools/scripts
Index: Tools/scripts/portsvar.sh
===
RCS file: /home/ncvs/ports/Tools/scripts/portsvar.sh,v
retrieving revision 1.1
diff -u -r1.1 portsvar.sh
--- Tools/scripts/portsvar.sh 11 Jan 2006 07:06:51 - 1.1
+++ Tools/scripts/portsvar.sh 2 Dec 2010 22:58:11 -
@@ -18,7 +18,6 @@
# RUBY_ARCH = i386-freebsd6
# % portsvar.sh -w kde -e KDE_
# KDE_MAINTAINER = w...@freebsd.org
-# KDE_ORIGVER = ${KDE_VERSION}
# KDE_PREFIX = ${LOCALBASE}
# KDE_VERSION = 3.5.0
# MASTER_SITE_KDE_kde = ${kmaster:s...@%subdir%/@@g}
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
Re: bin/146541: [patch] add check option to md5(1)
The following reply was made to PR bin/146541; it has been noted by GNATS. From: Eitan Adler li...@eitanadler.com To: bug-follo...@freebsd.org Cc: Subject: Re: bin/146541: [patch] add check option to md5(1) Date: Tue, 18 May 2010 09:28:56 +0300 --0016e64f5e8fe94fb60486d875f7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable -- Forwarded message -- From: jhell jh...@dataix.net Date: Mon, May 17, 2010 at 10:11 PM Subject: Re: adding check option to md5(1) [was: md5(1) and cal(1) on -questions] I have reviewed this patch for functionality and my final conclusion is commit it. Though I would like to see the same functionality that the GNU GPL'd version of md5 has with the '-c' option and being able to check every sum that is listed in a file against a file on disk(c), this version brings the availability to doing the checking right from md5 and utils from a script. I have also edited the manual page portion of the patch to include the '[-c string]' option in the SYNOPSIS section of the man pages. This newly generated patch was generated from the root of the source tree. # cd /path/to/src # patch /path/to/patch-file # cd /path/to/src/sbin/md5 # make obj make depend make make install -- =C2=A0jhell --0016e64f5e8fe94fb60486d875f7 Content-Type: text/plain; charset=US-ASCII; name=md5-checksum.patch Content-Disposition: attachment; filename=md5-checksum.patch Content-Transfer-Encoding: base64 X-Attachment-Id: 0.1 SW5kZXg6IHNiaW4vbWQ1L21kNS4xCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNiaW4vbWQ1L21kNS4xCShyZXZp c2lvbiAyMDgxOTQpCisrKyBzYmluL21kNS9tZDUuMQkod29ya2luZyBjb3B5KQpAQCAtOCwxOCAr OCwyMiBAQAogLlNoIFNZTk9QU0lTCiAuTm0gbWQ1CiAuT3AgRmwgcHFydHgKKy5PcCBGbCBjIEFy IHN0cmluZwogLk9wIEZsIHMgQXIgc3RyaW5nCiAuT3AgQXIKIC5ObSBzaGExCiAuT3AgRmwgcHFy dHgKKy5PcCBGbCBjIEFyIHN0cmluZwogLk9wIEZsIHMgQXIgc3RyaW5nCiAuT3AgQXIKIC5ObSBz aGEyNTYKIC5PcCBGbCBwcXJ0eAorLk9wIEZsIGMgQXIgc3RyaW5nCiAuT3AgRmwgcyBBciBzdHJp bmcKIC5PcCBBcgogLk5tIHJtZDE2MAogLk9wIEZsIHBxcnR4CisuT3AgRmwgYyBBciBzdHJpbmcK IC5PcCBGbCBzIEFyIHN0cmluZwogLk9wIEFyCiAuU2ggREVTQ1JJUFRJT04KQEAgLTczLDYgKzc3 LDggQEAKIFRoZSBoZXhhZGVjaW1hbCBjaGVja3N1bSBvZiBlYWNoIGZpbGUgbGlzdGVkIG9uIHRo ZSBjb21tYW5kIGxpbmUgaXMgcHJpbnRlZAogYWZ0ZXIgdGhlIG9wdGlvbnMgYXJlIHByb2Nlc3Nl ZC4KIC5CbCAtdGFnIC13aWR0aCBpbmRlbnQKKy5JdCBGbCBjIEFyIHN0cmluZworQ29tcGFyZSBm aWxlcyB0byB0aGlzIG1kNSBzdHJpbmcKIC5JdCBGbCBzIEFyIHN0cmluZwogUHJpbnQgYSBjaGVj a3N1bSBvZiB0aGUgZ2l2ZW4KIC5BciBzdHJpbmcgLgpAQCAtMTAxLDcgKzEwNyw4IEBACiBhbmQK IC5ObSBybWQxNjAKIHV0aWxpdGllcyBleGl0IDAgb24gc3VjY2VzcywKLWFuZCAxIGlmIGF0IGxl YXN0IG9uZSBvZiB0aGUgaW5wdXQgZmlsZXMgY291bGQgbm90IGJlIHJlYWQuCisxIGlmIGF0IGxl YXN0IG9uZSBvZiB0aGUgaW5wdXQgZmlsZXMgY291bGQgbm90IGJlIHJlYWQsCithbmQgMiBpZiBh dCBsZWFzdCBvbmUgZmlsZSBkb2VzIG5vdCBoYXZlIHRoZSBzYW1lIGhhc2ggYXMgdGhlIC1jIG9w dGlvbi4KIC5TaCBTRUUgQUxTTwogLlhyIGNrc3VtIDEgLAogLlhyIG1kNSAzICwKSW5kZXg6IHNi aW4vbWQ1L21kNS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNiaW4vbWQ1L21kNS5jCShyZXZpc2lvbiAyMDgx OTQpCisrKyBzYmluL21kNS9tZDUuYwkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQsOCBAQAog aW50IHFmbGFnOwogaW50IHJmbGFnOwogaW50IHNmbGFnOwordW5zaWduZWQgY2hhciogY2hlY2tB Z2FpbnN0OworaW50CWNoZWNrc0ZhaWxlZDsKIAogdHlwZWRlZiB2b2lkIChESUdFU1RfSW5pdCko dm9pZCAqKTsKIHR5cGVkZWYgdm9pZCAoRElHRVNUX1VwZGF0ZSkodm9pZCAqLCBjb25zdCB1bnNp Z25lZCBjaGFyICosIHNpemVfdCk7CkBAIC0xMzgsOCArMTQwLDEzIEBACiAgCQlkaWdlc3QgPSAw OwogCiAJZmFpbGVkID0gMDsKLQl3aGlsZSAoKGNoID0gZ2V0b3B0KGFyZ2MsIGFyZ3YsICJwcXJz OnR4IikpICE9IC0xKQorCWNoZWNrQWdhaW5zdCA9IE5VTEw7CisJY2hlY2tzRmFpbGVkID0gMDsK Kwl3aGlsZSAoKGNoID0gZ2V0b3B0KGFyZ2MsIGFyZ3YsICJjOnBxcnM6dHgiKSkgIT0gLTEpCiAJ CXN3aXRjaCAoY2gpIHsKKwkJY2FzZSAnYyc6CisJCQljaGVja0FnYWluc3QgPSBvcHRhcmc7CisJ CQlicmVhazsKIAkJY2FzZSAncCc6CiAJCQlNREZpbHRlcigmQWxnb3JpdGhtW2RpZ2VzdF0sIDEp OwogCQkJYnJlYWs7CkBAIC0xNzMsMTIgKzE4MCwxOSBAQAogCQkJCWZhaWxlZCsrOwogCQkJfSBl bHNlIHsKIAkJCQlpZiAocWZsYWcpCi0JCQkJCXByaW50ZigiJXNcbiIsIHApOworCQkJCQlwcmlu dGYoIiVzIiwgcCk7CiAJCQkJZWxzZSBpZiAocmZsYWcpCi0JCQkJCXByaW50ZigiJXMgJXNcbiIs IHAsICphcmd2KTsKKwkJCQkJcHJpbnRmKCIlcyAlcyIsIHAsICphcmd2KTsKIAkJCQllbHNlCi0J CQkJCXByaW50ZigiJXMgKCVzKSA9ICVzXG4iLAorCQkJCQlwcmludGYoIiVzICglcykgPSAlcyIs CiAJCQkJCSAgICBBbGdvcml0aG1bZGlnZXN0XS5uYW1lLCAqYXJndiwgcCk7CisJCQkJaWYgKGNo ZWNrQWdhaW5zdCAmJiBzdHJjbXAoY2hlY2tBZ2FpbnN0LHApKQorCQkJCXsKKwkJCQkJY2hlY2tz RmFpbGVkKys7CisJCQkJCWlmICghcWZsYWcpCisJCQkJCQlwcmludGYoIiVzIiwiWyBGYWlsZWQg XSIpOworCQkJCX0KKwkJCQlwcmludGYoIlxuIik7CiAJCQl9CiAJCX0gd2hpbGUgKCorK2FyZ3Yp OwogCX0gZWxzZSBpZiAoIXNmbGFnICYmIChvcHRpbmQgPT0gMSB8fCBxZmxhZyB8fCByZmxhZykp CkBAIC0xODYsNiArMjAwLDggQEAKIAogCWlmIChmYWlsZWQgIT0gMCkKIAkJcmV0dXJuICgxKTsK KwlpZiAoY2hlY2tzRmFpbGVkICE9IDApCisJCXJldHVybiAoMik7CiAKIAlyZXR1cm4gKDApOwog fQpAQCAtMTk4LDEyICsyMTQsMjAgQEAKIAlzaXplX3QgbGVuID0gc3RybGVuKHN0cmluZyk7CiAJ
bin/146541: [patch] add check option to md5(1)
Number: 146541
Category: bin
Synopsis: [patch] add check option to md5(1)
Confidential: no
Severity: non-critical
Priority: medium
Responsible:freebsd-bugs
State: open
Quarter:
Keywords:
Date-Required:
Class: change-request
Submitter-Id: current-users
Arrival-Date: Thu May 13 08:00:17 UTC 2010
Closed-Date:
Last-Modified:
Originator: Eitan Adler
Release:
Organization:
Environment:
Description:
This patch adds a -c option to md5(1) and related utilities that accepts as a
command line option a hash to check against.
If the -q option is not specified it prints [ failed ] if the hash of the
given filename or string does not match.
Regardless of -q it returns 2 on any mismatch.
I sent a the patch to -hackers without any feedback.
How-To-Repeat:
Fix:
Patch attached with submission follows:
Index: md5.1
===
--- md5.1 (revision 207433)
+++ md5.1 (working copy)
@@ -73,6 +73,8 @@
The hexadecimal checksum of each file listed on the command line is printed
after the options are processed.
.Bl -tag -width indent
+.It Fl c Ar string
+Compare files to this md5 string
.It Fl s Ar string
Print a checksum of the given
.Ar string .
@@ -101,7 +103,8 @@
and
.Nm rmd160
utilities exit 0 on success,
-and 1 if at least one of the input files could not be read.
+1 if at least one of the input files could not be read,
+and 2 if at least one file does not have the same hash as the -c option.
.Sh SEE ALSO
.Xr cksum 1 ,
.Xr md5 3 ,
Index: md5.c
===
--- md5.c (revision 207433)
+++ md5.c (working copy)
@@ -44,6 +44,8 @@
int qflag;
int rflag;
int sflag;
+unsigned char* checkAgainst;
+intchecksFailed;
typedef void (DIGEST_Init)(void *);
typedef void (DIGEST_Update)(void *, const unsigned char *, size_t);
@@ -138,8 +140,13 @@
digest = 0;
failed = 0;
- while ((ch = getopt(argc, argv, pqrs:tx)) != -1)
+ checkAgainst = NULL;
+ checksFailed = 0;
+ while ((ch = getopt(argc, argv, c:pqrs:tx)) != -1)
switch (ch) {
+ case 'c':
+ checkAgainst = optarg;
+ break;
case 'p':
MDFilter(Algorithm[digest], 1);
break;
@@ -173,12 +180,19 @@
failed++;
} else {
if (qflag)
- printf(%s\n, p);
+ printf(%s, p);
else if (rflag)
- printf(%s %s\n, p, *argv);
+ printf(%s %s, p, *argv);
else
- printf(%s (%s) = %s\n,
+ printf(%s (%s) = %s,
Algorithm[digest].name, *argv, p);
+ if (checkAgainst strcmp(checkAgainst,p))
+ {
+ checksFailed++;
+ if (!qflag)
+ printf(%s,[ Failed ]);
+ }
+ printf(\n);
}
} while (*++argv);
} else if (!sflag (optind == 1 || qflag || rflag))
@@ -186,6 +200,8 @@
if (failed != 0)
return (1);
+ if (checksFailed != 0)
+ return (2);
return (0);
}
@@ -198,12 +214,20 @@
size_t len = strlen(string);
char buf[HEX_DIGEST_LENGTH];
+ alg-Data(string,len,buf);
if (qflag)
- printf(%s\n, alg-Data(string, len, buf));
+ printf(%s, buf);
else if (rflag)
- printf(%s \%s\\n, alg-Data(string, len, buf), string);
+ printf(%s \%s\, buf, string);
else
- printf(%s (\%s\) = %s\n, alg-name, string,
alg-Data(string, len, buf));
+ printf(%s (\%s\) = %s, alg-name, string, buf);
+ if (checkAgainst strcmp(buf,checkAgainst))
+ {
+ checksFailed++;
+ if (!qflag)
+ printf(%s, [ failed ]);
+ }
+ printf(\n);
}
/*
* Measures the time to digest TEST_BLOCK_COUNT TEST_BLOCK_LEN-byte blocks.
Release-Note:
Audit-Trail:
Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
conf/146064: [patch] allow users to specify location for backups in default cron scripts
Number: 146064 Category: conf Synopsis: [patch] allow users to specify location for backups in default cron scripts Confidential: no Severity: non-critical Priority: medium Responsible:freebsd-bugs State: open Quarter: Keywords: Date-Required: Class: change-request Submitter-Id: current-users Arrival-Date: Mon Apr 26 12:50:01 UTC 2010 Closed-Date: Last-Modified: Originator: Eitan Adler Release:FreeBSD 8.0 Organization: Environment: Description: Discussion starts at http://lists.freebsd.org/pipermail/freebsd-hackers/2010-April/031663.html How-To-Repeat: Fix: Index: 200.backup-passwd === --- 200.backup-passwd (revision 207071) +++ 200.backup-passwd (working copy) @@ -24,7 +24,7 @@ doesn't exist rc=2 else - bak=/var/backups + bak=$backup_location rc=0 echo Index: 210.backup-aliases === --- 210.backup-aliases (revision 207071) +++ 210.backup-aliases (working copy) @@ -19,7 +19,7 @@ /etc/mail/aliases doesn't exist rc=2 else - bak=/var/backups + bak=$backup_location rc=0 echo Index: ../../defaults/periodic.conf === --- ../../defaults/periodic.conf(revision 207071) +++ ../../defaults/periodic.conf(working copy) @@ -22,6 +22,8 @@ # periodic script dirs local_periodic=/usr/local/etc/periodic +# General options +backup_location=/var/backups # Daily options Release-Note: Audit-Trail: Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org
