[Bug 175314] [regression] bsdgrep(1) broken multidot escaping since r225435

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=175314

Ed Maste  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|kev...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 175314] [regression] bsdgrep(1) broken multidot escaping since r225435

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=175314

--- Comment #3 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Fri Apr 21 14:36:10 UTC 2017
New revision: 317254
URL: https://svnweb.freebsd.org/changeset/base/317254

Log:
  bsdgrep: add BSD_GREP_FASTMATCH knob for built-in fastmatch

  Bugs have been found in the fastmatch implementation as used in bsdgrep.
  Some have been fixed (r316495) while fixes for others are in review
  (D10098).

  In comparison with the fastmatch implementation, Kyle Evans found that:

  - regex(3)'s performance with literal expressions offers a speed
improvement over fastmatch

  - regex(3)'s performance, both with simple BREs and EREs, seems to be
comparable

  The regex implementation was imported in r226035, and the commit message
  reports:

  This is a temporary solution until the whole regex library is
  not replaced so that BSD grep development can continue and the
  backported code gets some review and testing. This change only
  improves scalability slightly, there is no big performance boost
  yet but several minor bugs have been found and fixed.

  Introduce a WITH_/WITHOUT_BSD_GREP_FASTMATCH knob to support testing
  of both approaches.

  PR:   175314, 194823
  Submitted by: Kyle Evans 
  Reviewed by:  bdrewery (in part)
  Differential Revision:https://reviews.freebsd.org/D10282

Changes:
  head/share/man/man5/src.conf.5
  head/share/mk/src.opts.mk
  head/tools/build/options/WITHOUT_BSD_GREP_FASTMATCH
  head/usr.bin/grep/Makefile
  head/usr.bin/grep/grep.c
  head/usr.bin/grep/grep.h
  head/usr.bin/grep/util.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 175314] [regression] bsdgrep(1) broken multidot escaping since r225435

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=175314

--- Comment #2 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Wed Apr  5 18:41:46 UTC 2017
New revision: 316536
URL: https://svnweb.freebsd.org/changeset/base/316536

Log:
  bsdgrep: create additional tests for coverage on recent fixes

  Create additional tests to cover regressions that were discovered by
  PRs linked to reviews D10098, D10102, and D10104.

  It is worth noting that neither bsdgrep(1) nor gnugrep(1) in the base
  system currently pass all of these tests, and gnugrep(1) not quite being
  up to snuff was also noted in at least one of the PRs.

  PR:   175314 202022 195763 180990 197555 197531 181263 209116
  Submitted by: Kyle Evans 
  Reviewed by:  cem, ngie, emaste
  MFC after:1 month
  Differential Revision:https://reviews.freebsd.org/D10112

Changes:
  head/contrib/netbsd-tests/usr.bin/grep/d_color_a.in
  head/contrib/netbsd-tests/usr.bin/grep/d_color_a.out
  head/contrib/netbsd-tests/usr.bin/grep/d_color_b.in
  head/contrib/netbsd-tests/usr.bin/grep/d_color_b.out
  head/contrib/netbsd-tests/usr.bin/grep/d_color_c.out
  head/contrib/netbsd-tests/usr.bin/grep/d_escmap.in
  head/contrib/netbsd-tests/usr.bin/grep/d_f_file_empty.in
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_a.in
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_a.out
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_b.in
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_b.out
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_c.in
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_c.out
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_d.in
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_e.in
  head/contrib/netbsd-tests/usr.bin/grep/d_oflag_zerolen_e.out
  head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
  head/usr.bin/grep/tests/Makefile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 175314] [regression] bsdgrep(1) broken multidot escaping since r225435

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=175314

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 175314] [regression] bsdgrep(1) broken multidot escaping since r225435

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=175314

Kyle Evans  changed:

   What|Removed |Added

 CC||bsdpo...@kyle-evans.net

--- Comment #1 from Kyle Evans  ---
Created attachment 179167
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179167=edit
Proposed patch to address bsdgrep abusing memory

This was irritating to track down. There were two major problems here:

1.) wescmap was being built on top of uninitialized memory -- therefore, every
dot was theoretically escaped with junk=true
2.) The pre-processed pattern never makes it to fg->pattern, so escmap (also
uninitialized memory) was being built based on the processed pattern (without
escapes)

This caused mass-hilarity and there's no way this could have worked since
import. Attached patch addresses both issues by switching both xmalloc()'s to
xcalloc and making a copy of the original pat (sans start marker at least) to
examine for escapes.

I also touched formatting a bit in the area that I had to make more changes to,
because it was difficult to parse through at first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"