[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Mark Linimon  changed:

   What|Removed |Added

 CC|ema...@freebsd.org  |
   Assignee|b...@freebsd.org|ema...@freebsd.org
  Component|bin |misc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #12 from Ed Maste  ---
(In reply to Ed Maste from comment #11)
Twitter exchange with SQLite's author here:
https://twitter.com/DRichardHipp/status/1002919969510821888

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #11 from Ed Maste  ---
Change in my WIP branch:
https://github.com/emaste/freebsd/commit/77572f574f8c4aa2d9f4eaee

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Ed Maste  changed:

   What|Removed |Added

 Status|Open|In Progress

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Ed Maste  changed:

   What|Removed |Added

 CC||ema...@freebsd.org

--- Comment #10 from Ed Maste  ---
I believe the sqlite issue is a bug.  For cases where posix_fallocate is
supported by the operating system but returns EINVAL indicating that the
filesystem does not support the operation we should just treat the call as
advisory, and carry on.

-  if( err ) return SQLITE_IOERR_WRITE;
+  if( err!=EINVAL ) return SQLITE_IOERR_WRITE;

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Eitan Adler  changed:

   What|Removed |Added

 Status|In Progress |Open

--- Comment #9 from Eitan Adler  ---
For bugs matching the following conditions:
- Status == In Progress
- Assignee == "b...@freebsd.org"
- Last Modified Year <= 2017

Do
- Set Status to "Open"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #7 from commit-h...@freebsd.org ---
A commit references this bug:

Author: brooks
Date: Mon Nov 13 02:47:52 UTC 2017
New revision: 454097
URL: https://svnweb.freebsd.org/changeset/ports/454097

Log:
  Update to a new snapshot.

  This includes the fix for posix_fallocate not being supported on ZFS.

  PR:   223383, 223440
  Reported by:  Mark Millard

Changes:
  head/devel/llvm-devel/Makefile
  head/devel/llvm-devel/Makefile.snapshot
  head/devel/llvm-devel/distinfo
  head/devel/llvm-devel/pkg-plist

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #6 from commit-h...@freebsd.org ---
A commit references this bug:

Author: brooks
Date: Mon Nov 13 01:45:13 UTC 2017
New revision: 454093
URL: https://svnweb.freebsd.org/changeset/ports/454093

Log:
  Merge from src and upstream LLVM:

  lld: accept EINVAL to indicate posix_fallocate is unsupported

  As of r325320 posix_fallocate on a ZFS filesystem returns EINVAL to
  indicate that the operation is not supported. (I think this is a strange
  choice of errno on the part of POSIX.)

  PR:   223383, 223440
  Reported by:  Mark Millard

Changes:
  head/devel/llvm40/Makefile
  head/devel/llvm40/files/patch-lib_Support_Unix_Path.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #5 from commit-h...@freebsd.org ---
A commit references this bug:

Author: brooks
Date: Sun Nov 12 09:09:35 UTC 2017
New revision: 454025
URL: https://svnweb.freebsd.org/changeset/ports/454025

Log:
  Merge from src:

  lld: accept EINVAL to indicate posix_fallocate is unsupported

  As of r325320 posix_fallocate on a ZFS filesystem returns EINVAL to
  indicate that the operation is not supported. (I think this is a strange
  choice of errno on the part of POSIX.)

  PR:   223383, 223440
  Reported by:  Mark Millard

Changes:
  head/devel/llvm50/Makefile
  head/devel/llvm50/files/patch-lib_Support_Unix_Path.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #4 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Wed Nov  8 00:39:04 UTC 2017
New revision: 325523
URL: https://svnweb.freebsd.org/changeset/base/325523

Log:
  MFC r325420: lld: accept EINVAL to indicate posix_fallocate is unsupported

  As of r325320 posix_fallocate on a ZFS filesystem returns EINVAL to
  indicate that the operation is not supported. (I think this is a strange
  choice of errno on the part of POSIX.)

  PR:   223383, 223440
  Reported by:  Mark Millard
  Sponsored by: The FreeBSD Foundation

Changes:
_U  stable/11/
  stable/11/contrib/llvm/lib/Support/Unix/Path.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #3 from Ed Maste  ---
> contrib/sqlite3/sqlite3.c
> crypto/heimdal/lib/sqlite/sqlite3.c

AFAICT this is the only issue that needs more effort / investigation, as it
appears that it does not correctly handle EINVAL or EOPNOTSUPP:

#if defined(HAVE_POSIX_FALLOCATE) && HAVE_POSIX_FALLOCATE
  /* The code below is handling the return value of osFallocate() 
  ** correctly. posix_fallocate() is defined to "returns zero on success, 
  ** or an error number on  failure". See the manpage for details. */
  int err;
  do{
err = osFallocate(pFile->h, buf.st_size, nSize-buf.st_size);
  }while( err==EINTR );
  if( err ) return SQLITE_IOERR_WRITE;
#else

Other source files with posix_fallocate / fallocate do not have an issue:

> contrib/netbsd-tests/lib/libc/sys/t_posix_fallocate.c

It's only testing that posix_fallocate doesn't change errno, and that EBADF is
returned for a bad fd (-1), so no issue here.

> contrib/llvm/lib/Support/Unix/Path.inc

Fixed by r325420

> contrib/pjdfstest/pjdfstest.c

Appears to be test harness only; I did not find a test invoking posix_fallocate
or fallocate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Ed Maste  changed:

   What|Removed |Added

   Assignee|ema...@freebsd.org  |freebsd-bugs@FreeBSD.org
 Status|New |In Progress

--- Comment #2 from Ed Maste  ---
I have addressed one of the cases Mark identified (in lld), but the remainder
still need to be reviewed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Mark Linimon  changed:

   What|Removed |Added

   Assignee|freebsd-bugs@FreeBSD.org|ema...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

--- Comment #1 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Sun Nov  5 00:51:53 UTC 2017
New revision: 325420
URL: https://svnweb.freebsd.org/changeset/base/325420

Log:
  lld: accept EINVAL to indicate posix_fallocate is unsupported

  As of r325320 posix_fallocate on a ZFS filesystem returns EINVAL to
  indicate that the operation is not supported. (I think this is a strange
  choice of errno on the part of POSIX.)

  PR:   223383, 223440
  Reported by:  Mark Millard
  Tested by:Mark Millard
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation

Changes:
  head/contrib/llvm/lib/Support/Unix/Path.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Ed Maste  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2233
   ||83

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440

Bug ID: 223440
   Summary: world needs review and adjustment for the disabling of
fallocate for zfs (-r325320), lld included
   Product: Base System
   Version: CURRENT
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: mar...@dsl-only.net

-r325320 breaks lld when referring zfs file systems:
lld needs to be updated. See:

https://lists.freebsd.org/pipermail/freebsd-current/2017-November/067432.html

for Ed Maste's patch.( Ed is probably acting
independent of this submittal. Systems that
use or require lld can be a problem to update
for a range on or after -r325320. aarch64
in particular could be problematical for
self hosting.)

Note that configure-testing of a specific live
file system is probably not a good idea since
a mix of file systems is allowed to be in use
at the same time overall. (lld has a run-time
test that is adjusted.)

It appears that sqlite3 might use fallocate.
And heimdal (via its sqlite3.c). I've not
reviewed the details for any of the below
that do not trace to the lld issue:

# grep -rl "fallocate" /usr/src/* | more
/usr/src/contrib/sqlite3/configure.ac
/usr/src/contrib/sqlite3/configure
/usr/src/contrib/sqlite3/sqlite3.c
/usr/src/contrib/netbsd-tests/lib/libc/sys/t_posix_fallocate.c
/usr/src/contrib/compiler-rt/lib/dfsan/libc_ubuntu1404_abilist.txt
/usr/src/contrib/compiler-rt/include/sanitizer/linux_syscall_hooks.h
/usr/src/contrib/llvm/lib/Support/Unix/Path.inc
/usr/src/contrib/pjdfstest/configure.ac
/usr/src/contrib/pjdfstest/tests/misc.sh
/usr/src/contrib/pjdfstest/pjdfstest.c
/usr/src/contrib/openbsm/NEWS
/usr/src/contrib/openbsm/etc/audit_event
/usr/src/crypto/heimdal/lib/sqlite/sqlite3.c
/usr/src/lib/libc/sys/posix_fallocate.2
/usr/src/lib/libc/sys/Symbol.map
/usr/src/lib/libc/sys/Makefile.inc
/usr/src/lib/libc/tests/sys/Makefile
/usr/src/lib/clang/include/llvm/Config/config.h
/usr/src/share/man/man9/VOP_ALLOCATE.9
/usr/src/sys/compat/freebsd32/syscalls.master
/usr/src/sys/compat/freebsd32/freebsd32_syscalls.c
/usr/src/sys/compat/freebsd32/freebsd32_sysent.c
/usr/src/sys/compat/freebsd32/capabilities.conf
/usr/src/sys/compat/freebsd32/freebsd32_misc.c
/usr/src/sys/compat/freebsd32/freebsd32_proto.h
/usr/src/sys/compat/freebsd32/freebsd32_syscall.h
/usr/src/sys/compat/freebsd32/freebsd32_systrace_args.c
/usr/src/sys/compat/cloudabi/cloudabi_file.c
/usr/src/sys/compat/linux/linux_file.c
/usr/src/sys/i386/linux/linux_sysent.c
/usr/src/sys/i386/linux/linux_proto.h
/usr/src/sys/i386/linux/linux_syscalls.c
/usr/src/sys/i386/linux/linux_systrace_args.c
/usr/src/sys/i386/linux/linux_syscall.h
/usr/src/sys/i386/linux/syscalls.master
/usr/src/sys/sys/fcntl.h
/usr/src/sys/sys/syscall.h
/usr/src/sys/sys/syscall.mk
/usr/src/sys/sys/syscallsubr.h
/usr/src/sys/sys/sysproto.h
/usr/src/sys/kern/init_sysent.c
/usr/src/sys/kern/syscalls.master
/usr/src/sys/kern/systrace_args.c
/usr/src/sys/kern/capabilities.conf
/usr/src/sys/kern/vfs_syscalls.c
/usr/src/sys/kern/syscalls.c
/usr/src/sys/amd64/linux32/linux32_syscall.h
/usr/src/sys/amd64/linux32/linux32_systrace_args.c
/usr/src/sys/amd64/linux32/syscalls.master
/usr/src/sys/amd64/linux32/linux32_syscalls.c
/usr/src/sys/amd64/linux32/linux32_sysent.c
/usr/src/sys/amd64/linux32/linux32_proto.h
/usr/src/sys/amd64/linux/linux_proto.h
/usr/src/sys/amd64/linux/syscalls.master
/usr/src/sys/amd64/linux/linux_syscalls.c
/usr/src/sys/amd64/linux/linux_systrace_args.c
/usr/src/sys/amd64/linux/linux_syscall.h
/usr/src/sys/amd64/linux/linux_sysent.c
/usr/src/tests/sys/pjdfstest/config.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"