[Bug 232939] /sbin/ipfw cannot add 'not icmp6types' RULE OPTIONS (MATCH PATTERN)

2018-11-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232939

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch
   Assignee|b...@freebsd.org|a...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 232939] /sbin/ipfw cannot add 'not icmp6types' RULE OPTIONS (MATCH PATTERN)

2018-11-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232939

--- Comment #3 from bugs.freebsd@mx.zzux.com ---
After being patched /sbin/ipfw seems to be ok, in part of this issue.
Thanks!

And by the way, the word 'ip6' is confusing
for example, one of my rules:
ipfw list 32442
32442 count tag 64 ip from table(107,11) to table(107,11) not ip6 icmp6types
136
Then I copy this output to new command line:
ipfw add 5 count tag 64 ip from 'table(107,11)' to 'table(107,11)' not ip6
icmp6types 136
5 count tag 64 not ip6 from table(107,11) to table(107,11) ip6 icmp6types
136

Rule 5 is meaningless

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 232939] /sbin/ipfw cannot add 'not icmp6types' RULE OPTIONS (MATCH PATTERN)

2018-11-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232939

--- Comment #2 from commit-h...@freebsd.org ---
A commit references this bug:

Author: ae
Date: Sat Nov  3 20:05:50 UTC 2018
New revision: 340100
URL: https://svnweb.freebsd.org/changeset/base/340100

Log:
  Do not use bzero() for the O_ICMP6TYPE opcode.

  The buffer is already zeroed in compile_rule() function, and also it
  may contain configured F_NOT flag in o.len field. This fixes the filling
  for "not icmp6types" opcode.

  PR:   232939
  MFC after:3 days

Changes:
  head/sbin/ipfw/ipv6.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 232939] /sbin/ipfw cannot add 'not icmp6types' RULE OPTIONS (MATCH PATTERN)

2018-11-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232939

Andrey V. Elsukov  changed:

   What|Removed |Added

 CC||a...@freebsd.org

--- Comment #1 from Andrey V. Elsukov  ---
Created attachment 198919
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=198919=edit
Proposed patch

Can you try this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 232939] /sbin/ipfw cannot add 'not icmp6types' RULE OPTIONS (MATCH PATTERN)

2018-11-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232939

Bug ID: 232939
   Summary: /sbin/ipfw cannot add 'not icmp6types' RULE OPTIONS
(MATCH PATTERN)
   Product: Base System
   Version: 11.2-RELEASE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: bin
  Assignee: b...@freebsd.org
  Reporter: bugs.freebsd@mx.zzux.com

Example:

> ipfw add 45000 count icmptypes 1,2
45000 count ip from any to any icmptypes 1,2

> ipfw add 45001 count not icmptypes 1,2
45001 count ip from any to any not icmptypes 1,2

> ipfw add 45002 count icmp6types 135,136
45002 count ip from any to any ip6 icmp6types 135,136

> ipfw add 45003 count not icmp6types 135,136
45003 count ip from any to any ip6 icmp6types 135,136

> ipfw show 45000-45003
45000 00 count ip from any to any icmptypes 1,2
45001 00 count ip from any to any not icmptypes 1,2
45002 00 count ip from any to any ip6 icmp6types 135,136
45003 00 count ip from any to any ip6 icmp6types 135,136


There's no difference between 45002 & 45003.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"