[Bug 279268] [patch] xdm dies when pressing CTRL-C if pam_xdg.so is used
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279268 --- Comment #3 from commit-h...@freebsd.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=9fe726012df9a125a40df0b70a2e5c6f6b7bb913 commit 9fe726012df9a125a40df0b70a2e5c6f6b7bb913 Author: Andre Albsmeier AuthorDate: 2024-05-27 06:31:34 + Commit: Emmanuel Vadot CommitDate: 2024-06-03 07:35:41 + pam_xdg: pam_get_item can return NULL Fix pam_xdg as pam_get_item can return NULL, this happens when pressing control + C in xdm for example. MFC after: 1 week PR: 279268 (cherry picked from commit cca0ce62f367d03ed429bf99e41e6aca8cb7f2ac) lib/libpam/modules/pam_xdg/pam_xdg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279268] [patch] xdm dies when pressing CTRL-C if pam_xdg.so is used
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279268 Emmanuel Vadot changed: What|Removed |Added Resolution|--- |FIXED Status|New |Closed --- Comment #2 from Emmanuel Vadot --- Commited, thanks a lot. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279268] [patch] xdm dies when pressing CTRL-C if pam_xdg.so is used
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279268 --- Comment #1 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=cca0ce62f367d03ed429bf99e41e6aca8cb7f2ac commit cca0ce62f367d03ed429bf99e41e6aca8cb7f2ac Author: Andre Albsmeier AuthorDate: 2024-05-27 06:31:34 + Commit: Emmanuel Vadot CommitDate: 2024-05-27 06:33:14 + pam_xdg: pam_get_item can return NULL Fix pam_xdg as pam_get_item can return NULL, this happens when pressing control + C in xdm for example. MFC after: 1 week PR: 279268 lib/libpam/modules/pam_xdg/pam_xdg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279268] [patch] xdm dies when pressing CTRL-C if pam_xdg.so is used
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279268 Mark Linimon changed: What|Removed |Added Keywords||crash -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279268] [patch] xdm dies when pressing CTRL-C if pam_xdg.so is used
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279268
Bug ID: 279268
Summary: [patch] xdm dies when pressing CTRL-C if pam_xdg.so is
used
Product: Base System
Version: 14.0-STABLE
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: bin
Assignee: b...@freebsd.org
Reporter: m...@fbsd2.e4m.org
Created attachment 250918
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=250918=edit
patch
After updating to latest 14.1 BETA xdm crashed when Ctrl-C was pressed on the
logon screen. Running xdm in debug mode showed:
SetPrompt(0, , LOGIN_PROMPT_NOT_SHOWN(0))
SetPrompt(1, , LOGIN_PROMPT_NOT_SHOWN(0))
pam_msg: PAM_PROMPT_ECHO_ON (2): ' Login:'
SetPrompt(0,Login:, LOGIN_PROMPT_ECHO_ON(1))
RedrawFail('Login incorrect or forbidden by policy', 0)
dispatching :0
RedrawFail('Login incorrect or forbidden by policy', 0)
(CTRL-C now)
GreetDone: , (password is 0 long)
REMANAGE_DISPLAY
Done dispatch :0
xdm error (pid 8751): pam_authenticate failure: Conversation failure
Unsecure display :0
Greet connection closed
Manager wait returns pid: 8751 sig 11 core 0 code 0
Display exited with unknown status 2816
I fixed it with the attached patch (not knowing if this is correct :-)).
Apparently pam_get_item() can return NULL in but pam_xdg.c continues with
it...
--
You are receiving this mail because:
You are the assignee for the bug.
