Re: i915 driver update testing
Am Sun, 05 Oct 2014 21:54:22 +0200 Koop Mast schrieb: > On Fri, 2014-10-03 at 20:02 +0300, Konstantin Belousov wrote: > > Please find at the > > https://kib.kiev.ua/kib/drm/i915.1.patch > > a patch which provides some updates to the i915 driver. At large, this > > is import of the batch of Linux commits, and as such, it is interesting > > mostly as attempt to restart the race to get us more up to date Linux code > > imported. It might provide some bug fixes, most likely for IvyBridge. > > Interesting from the development PoV is the update of the GEM i/o ioctl > > code path to mimic Linux code structure. > > > > I am asking _only_ for reports of regressions with the patch applied, > > comparing with the code which is currently in HEAD. I will not debug > > any existing bugs, my goal right now is to commit this update, which is > > needed for further work. I.e., only when you get an issue with the patch > > applied, but cannot reproduce the problem without the patch, please > > prepare a bug report. > > > > FYI, the driver will attach to haswell gfx, but I am not interested in > > reports about this (see above paragraph). On my test box, which is Core > > i7 4770S, the mode-setting and front-buffer rendering works, but Mesa > > immediately cause renderer to bug out. > > > > Work was sponsored by The FreeBSD Foundation, both by time and hardware, > > and Intel provided access to the documentation. > > Hi, I got a working X-server and framebuffer console on my Sandybridge > system. The only regression I noticed so far is the line below, where > the number after 'expected' changes per time the line is printed. > > Oct 5 21:50:12 crashalot kernel: error: [drm:pid1049:gen6_sanitize_pm] > *ERROR* Power management discrepancy: GEN6_RP_INTERRUPT_LIMITS expected > 160d, was 1600 > Oct 5 21:51:04 crashalot kernel: error: [drm:pid1049:gen6_sanitize_pm] > *ERROR* Power management discrepancy: GEN6_RP_INTERRUPT_LIMITS expected > 160d, was 1600 > Oct 5 21:53:14 crashalot kernel: error: [drm:pid1170:gen6_sanitize_pm] > *ERROR* Power management discrepancy: GEN6_RP_INTERRUPT_LIMITS expected > 160d, was 1600 > > ___ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" Is this patch supposed to work also with IvyBridge type iGPUs, i.w. P4600 (the iGPU of some XEONs of the i5-122Xv2 series)? When I load drm2 and i915kms via loader.conf, the box gets black screen and then dies. Oliver signature.asc Description: PGP signature
Re: Ver 2 of the patch [was: Re: i915 driver update testing]
2014-10-08 19:05 GMT+02:00 Konstantin Belousov : > On Tue, Oct 07, 2014 at 04:04:54PM -0400, Adam McDougall wrote: > > On 10/07/2014 14:01, Konstantin Belousov wrote: > > > On Tue, Oct 07, 2014 at 07:44:19PM +0300, Konstantin Belousov wrote: > > >> >From the same frame, please do > > >> p *(struct drm_i915_private *)(dev->private) > p *(struct drm_i915_private *)(dev->dev_private) > > > > > > > I probably figured out what is wrong, but it is still interesting to > > > see this piece of data. > > > > > > For everybody who has the issue with blank screen or panic after > > > the patch: > > > 1. please try the updated patch, > > > https://www.kib.kiev.ua/kib/drm/i915.2.patch > > > 2. if you use "kldload i915kms" to test the patch and get the blank > > >screen, verify do you get panic or just a black screen. It is > > >expected for sc, not so for vt. For vt, if you do get blank screen > > >and not a panic, do not load i915kms manually and run the X server. > > >I am interested if running X server does show proper output. > > > > > > > Backtrace seems the same, I repeated the prior commands: > > http://www.egr.msu.edu/~mcdouga9/i915-patch2-1.txt > > There are more occurences of the bug I fixed once in patch version 2. > Also, since pmap changes were committed in modified form, please try > the updated patch at https://www.kib.kiev.ua/kib/drm/i915.3.patch . > On my Samsung ATIV Book 2 the result is always the blank screen with i915.2.patch or i9153.patch. The result of the command "kldload i915kms" or running the X server is always the blank screen. Note: if I listen some music, after the "blank screen", I can hear some noise from speakers. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: [PATCH] Lock scd(4): test or the driver will be removed
On 10/8/14 11:53 AM, John Baldwin wrote: This patch adds locking to scd(4) and marks it MPSAFE. It also uses bus_*() instead of bus_space_*(). The patch is against HEAD but probably applies to 9 and 10 as well. http://people.freebsd.org/~jhb/patches/scd_locking.patch Note that this driver is using a deprecated API that will be removed in 11. If no one tests updates to this driver then it is not feasible to continue maintaining it in the tree. In that case, it will be removed from HEAD one month from today. Hey John, which APIs are being used? ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
[PATCH] Lock scd(4): test or the driver will be removed
This patch adds locking to scd(4) and marks it MPSAFE. It also uses bus_*() instead of bus_space_*(). The patch is against HEAD but probably applies to 9 and 10 as well. http://people.freebsd.org/~jhb/patches/scd_locking.patch Note that this driver is using a deprecated API that will be removed in 11. If no one tests updates to this driver then it is not feasible to continue maintaining it in the tree. In that case, it will be removed from HEAD one month from today. -- John Baldwin ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
[PATCH] Fix si(4) to use bus_space: test or the driver will be removed
This patch fixes the si(4) driver to use the bus_space methods to access memory and I/O resources instead of directly calling inb()/outb() and using rman_get_virtual(). The patch is against HEAD but probably applies to 9 and 10 as well. http://people.freebsd.org/~jhb/patches/si_bus_space.patch If no one tests updates to this driver then it is not feasible to continue maintaining it in the tree. In that case, it will be removed from HEAD one month from today. -- John Baldwin ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Ver 2 of the patch [was: Re: i915 driver update testing]
On 10/08/2014 13:05, Konstantin Belousov wrote: > On Tue, Oct 07, 2014 at 04:04:54PM -0400, Adam McDougall wrote: >> On 10/07/2014 14:01, Konstantin Belousov wrote: >>> On Tue, Oct 07, 2014 at 07:44:19PM +0300, Konstantin Belousov wrote: >>>> >From the same frame, please do >>>> p *(struct drm_i915_private *)(dev->private) > p *(struct drm_i915_private *)(dev->dev_private) > >>> >>> I probably figured out what is wrong, but it is still interesting to >>> see this piece of data. >>> >>> For everybody who has the issue with blank screen or panic after >>> the patch: >>> 1. please try the updated patch, >>> https://www.kib.kiev.ua/kib/drm/i915.2.patch >>> 2. if you use "kldload i915kms" to test the patch and get the blank >>>screen, verify do you get panic or just a black screen. It is >>>expected for sc, not so for vt. For vt, if you do get blank screen >>>and not a panic, do not load i915kms manually and run the X server. >>>I am interested if running X server does show proper output. >>> >> >> Backtrace seems the same, I repeated the prior commands: >> http://www.egr.msu.edu/~mcdouga9/i915-patch2-1.txt > > There are more occurences of the bug I fixed once in patch version 2. > Also, since pmap changes were committed in modified form, please try > the updated patch at https://www.kib.kiev.ua/kib/drm/i915.3.patch . > No apparent change: http://www.egr.msu.edu/~mcdouga9/i915-patch3-1.txt I made a log of the source operations and compile to be certain I was using the right patch properly: http://www.egr.msu.edu/~mcdouga9/20141008-compile.txt Are any of these an issue in the patch? Seem unrelated but hopefully harmless: diff --git a/sys/dev/md/md.c b/sys/dev/md/md.c diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c diff --git a/sys/kern/uipc_shm.c b/sys/kern/uipc_shm.c diff --git a/sys/kern/uipc_syscalls.c b/sys/kern/uipc_syscalls.c diff --git a/sys/vm/default_pager.c b/sys/vm/default_pager.c diff --git a/sys/vm/device_pager.c b/sys/vm/device_pager.c diff --git a/sys/vm/phys_pager.c b/sys/vm/phys_pager.c diff --git a/sys/vm/sg_pager.c b/sys/vm/sg_pager.c diff --git a/sys/vm/swap_pager.c b/sys/vm/swap_pager.c diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c diff --git a/sys/vm/vm_glue.c b/sys/vm/vm_glue.c diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c diff --git a/sys/vm/vm_pager.c b/sys/vm/vm_pager.c diff --git a/sys/vm/vm_pager.h b/sys/vm/vm_pager.h diff --git a/sys/vm/vnode_pager.c b/sys/vm/vnode_pager.c Thanks. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Ver 2 of the patch [was: Re: i915 driver update testing]
On Tue, Oct 07, 2014 at 04:04:54PM -0400, Adam McDougall wrote: > On 10/07/2014 14:01, Konstantin Belousov wrote: > > On Tue, Oct 07, 2014 at 07:44:19PM +0300, Konstantin Belousov wrote: > >> >From the same frame, please do > >> p *(struct drm_i915_private *)(dev->private) p *(struct drm_i915_private *)(dev->dev_private) > > > > I probably figured out what is wrong, but it is still interesting to > > see this piece of data. > > > > For everybody who has the issue with blank screen or panic after > > the patch: > > 1. please try the updated patch, > > https://www.kib.kiev.ua/kib/drm/i915.2.patch > > 2. if you use "kldload i915kms" to test the patch and get the blank > >screen, verify do you get panic or just a black screen. It is > >expected for sc, not so for vt. For vt, if you do get blank screen > >and not a panic, do not load i915kms manually and run the X server. > >I am interested if running X server does show proper output. > > > > Backtrace seems the same, I repeated the prior commands: > http://www.egr.msu.edu/~mcdouga9/i915-patch2-1.txt There are more occurences of the bug I fixed once in patch version 2. Also, since pmap changes were committed in modified form, please try the updated patch at https://www.kib.kiev.ua/kib/drm/i915.3.patch . ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Floating-point review
I'm looking for someone who known more about floating-point than I do to review one of me changes. The change in question adds 6 new functions to the ARM libc to perform floating-point comparisons. These functions are required as part of the ABI spec. The review is at [1]. I am mostly interested in having someone check __aeabi_cfcmpeq_helper and __aeabi_cdcmpeq_helper are correct. They should both return when either argument is a quiet NaN unless one is a signalling NaN for floats and doubles respectively. These functions are used by a functions that is defined to not raise a floating point exception with comparing with quiet NaNs and all comparisons with signalling NaNs could potentially raise an exception. Because of this requirement these functions are used to filter out the cases we have one or more quiet NaNs and no signalling NaNs. Andrew [1] https://reviews.freebsd.org/D872 ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
