[CFR][PATCH] drm2: don't assume that dev-driver-max_ioctl *dev-driver-compat_ioctls_nr

2014-11-28 Thread Eygene Ryabinkin
Konstantin, *, good day.

I noticed that the current ioctl processing code for drm2 implicitely
assumes that the number of native ioctls is higher than that of 32-bit
compat ones, so it immediately gives EINVAL when
nr = dev-driver-max_ioctl.  Seems that in future such assumption
may not be true in all cases.

This can be fixed with the following patch:
  http://codelabs.ru/fbsd/patches/drm2/drm_drv-untangle-32bit-compat.diff

Any thoughts on it?

Thanks.
-- 
Eygene Ryabinkin,,,^..^,,,
[ Life's unfair - but root password helps!   | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]


pgp4NKeZVlbnb.pgp
Description: PGP signature


witness and modules.

2014-11-28 Thread Julian Elischer
Do we need to compile all modules with witness definitions when 
linking with a kernel compiled with witness?
This was true at one stage but I remember some work was done to make 
them compatible.




___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: RFC: Remove pty(4)

2014-11-28 Thread Julian Elischer

On 11/28/14, 2:37 AM, Alfred Perlstein wrote:

On Nov 27, 2014, at 1:52 AM, Konstantin Belousov wrote:


On Wed, Nov 26, 2014 at 04:41:27PM -0800, Davide Italiano wrote:

On Mon, Aug 25, 2014 at 12:37 PM, John Baldwin j...@freebsd.org wrote:

On Wednesday, August 20, 2014 11:00:14 AM Davide Italiano wrote:

One of my personal goals for 11 is to get rid of cloning mechanism
entirely, and pty(4) is one of the few in-kernel drivers still relying
on such mechanism.

Why this is good thing to do ?


[...]

You don't, but other people care about ABI.

Besides older jails which you do not care about, there is significant
set of programs which were coded to use Berkley' pty directly.  Even
high-profile applications like Emacs automatically selected pty(4)
up to its previous version on FreeBSD.


[...]

I do not see why dev_clone event makes your so unhappy.  I object against
removal of it (and this is what you are aiming at, it seems).  It provides
useful functionality, which is not substituted by anything cdevpriv(9)
can provide.


[...]


Thank you kib, I feel the same about leaving the pty system as it is.
the pty ABI is so well known and so ubiquitous that I think changing 
it in any major way is asking for trouble.
Also whatever you do,  jails running 4.x (or older) software MUST 
continue to run, and be able to have ptys behave as they expect.




-Alfred
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org



___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: [CFR][PATCH] drm2: don't assume that dev-driver-max_ioctl *dev-driver-compat_ioctls_nr

2014-11-28 Thread Konstantin Belousov
On Fri, Nov 28, 2014 at 04:29:42PM +0300, Eygene Ryabinkin wrote:
 Konstantin, *, good day.
 
 I noticed that the current ioctl processing code for drm2 implicitely
 assumes that the number of native ioctls is higher than that of 32-bit
 compat ones, so it immediately gives EINVAL when
 nr = dev-driver-max_ioctl.  Seems that in future such assumption
 may not be true in all cases.
I very much doubt that it could become true. Compat32 ioctl cannot
exist without its wider counterpart.

 
 This can be fixed with the following patch:
   http://codelabs.ru/fbsd/patches/drm2/drm_drv-untangle-32bit-compat.diff
 
 Any thoughts on it?
I think either current way or patch are fine, but why changing something
which is fine ?
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Possible bug in softfloat

2014-11-28 Thread Steve Kargl
In a thread on comp.lang.c, it was pointed out that softfloat
has a bug and in checking src/lib/libc/softfloat I confimed
the issue is present in FreeBSD.  What I hae not confirmed 
is whether or not it is possible to hit this bug.  In fact,
it may only hit arm and mips.  Anyway, here's the patch


Index: softfloat/bits64/softfloat-macros
===
--- softfloat/bits64/softfloat-macros   (revision 275211)
+++ softfloat/bits64/softfloat-macros   (working copy)
@@ -157,7 +157,7 @@
 z0 = a0count;
 }
 else {
-z1 = ( count  64 ) ? ( a0( count  63 ) ) : 0;
+z1 = ( count  128 ) ? ( a0( count  63 ) ) : 0;
 z0 = 0;
 }
 *z1Ptr = z1;

-- 
Steve
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Possible bug in softfloat

2014-11-28 Thread Adrian Chadd
On 28 November 2014 at 10:34, Steve Kargl
s...@troutmask.apl.washington.edu wrote:
 In a thread on comp.lang.c, it was pointed out that softfloat
 has a bug and in checking src/lib/libc/softfloat I confimed
 the issue is present in FreeBSD.  What I hae not confirmed
 is whether or not it is possible to hit this bug.  In fact,
 it may only hit arm and mips.  Anyway, here's the patch

So we should just commit this?


-a



 Index: softfloat/bits64/softfloat-macros
 ===
 --- softfloat/bits64/softfloat-macros   (revision 275211)
 +++ softfloat/bits64/softfloat-macros   (working copy)
 @@ -157,7 +157,7 @@
  z0 = a0count;
  }
  else {
 -z1 = ( count  64 ) ? ( a0( count  63 ) ) : 0;
 +z1 = ( count  128 ) ? ( a0( count  63 ) ) : 0;
  z0 = 0;
  }
  *z1Ptr = z1;

 --
 Steve
 ___
 freebsd-current@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-current
 To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Possible bug in softfloat

2014-11-28 Thread Steve Kargl
On Fri, Nov 28, 2014 at 10:54:25AM -0800, Adrian Chadd wrote:
 On 28 November 2014 at 10:34, Steve Kargl
 s...@troutmask.apl.washington.edu wrote:
  In a thread on comp.lang.c, it was pointed out that softfloat
  has a bug and in checking src/lib/libc/softfloat I confimed
  the issue is present in FreeBSD.  What I hae not confirmed
  is whether or not it is possible to hit this bug.  In fact,
  it may only hit arm and mips.  Anyway, here's the patch
 
 So we should just commit this?
 

I suspect the answer is yes, but I have no idea on how
to trigger this code path.  I also have no access to 
arm or mips hardware where the problem may manifest only.  

It may also be appropriate to have someone else confirm
that the patch is indeed correct.

-- 
steve
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Possible bug in softfloat

2014-11-28 Thread Adrian Chadd
You can easily fire up a mips32 / mips64 emulator build - cross-build
a world+kernel, build an image, then run qemu-devel to boot it.

https://wiki.freebsd.org/FreeBSD/MipsEmulation

You should be able to get a 32 bit soft-float mips environment inside
there which you can use to trigger it.
(And also run whatever other floating point validation suite you may hvae.)



-adrian


On 28 November 2014 at 11:07, Steve Kargl
s...@troutmask.apl.washington.edu wrote:
 On Fri, Nov 28, 2014 at 10:54:25AM -0800, Adrian Chadd wrote:
 On 28 November 2014 at 10:34, Steve Kargl
 s...@troutmask.apl.washington.edu wrote:
  In a thread on comp.lang.c, it was pointed out that softfloat
  has a bug and in checking src/lib/libc/softfloat I confimed
  the issue is present in FreeBSD.  What I hae not confirmed
  is whether or not it is possible to hit this bug.  In fact,
  it may only hit arm and mips.  Anyway, here's the patch

 So we should just commit this?


 I suspect the answer is yes, but I have no idea on how
 to trigger this code path.  I also have no access to
 arm or mips hardware where the problem may manifest only.

 It may also be appropriate to have someone else confirm
 that the patch is indeed correct.

 --
 steve
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


RFT: Please help testing the llvm/clang 3.5.0 import

2014-11-28 Thread Dimitry Andric
Hi,

We're working on updating llvm, clang and lldb to 3.5.0 in head.  This
is quite a big update again, and any help with testing is appreciated.

To try this out, ensure you have good backups or snapshots, then build
world and kernel from the projects/clang350-import branch [1].  Please
use a Subversion mirror [2], if you are able to.

The status of this project branch is as follows:

* Since llvm/clang 3.5.0 requires C++11 support, you can only build it
  when your current installation has both clang (= 3.3) and libc++
  installed.  E.g., FreeBSD 10.x and later should work out of the box,
  but for FreeBSD 9.x you should first build libc++ with clang, and
  install it.  Older versions of FreeBSD will not work.
* Both the i386 and amd64 arches are expected to work completely, e.g.
  they should build, install and run without any problems.  For some
  less-used parts of world and kernel, you might encounter warnings
  that are not fixed yet.  To ignore those, you can use NO_WERROR, but
  please create bug reports for them.
* The different ARM builds still need work, any help would be greatly
  appreciated there.
* PowerPC (32 and 64 bit) will most likely not work yet, until we can
  figure out how to build parts of the tree with clang, other parts with
  gcc.
* Sparc64 might work at least partially, but has not been tested on
  real hardware.
* A ports exp-run has been requested [3].

The tentative goal is to be able to import this new version before the
end of the year, hopefully before Christmas.

If you encounter issues, please report them in FreeBSD Bugzilla [4],
unless you think it is better discussed on one of the appropriate
mailing lists.

-Dimitry

[1] svn://svn.freebsd.org/base/projects/clang350-import
[2] 
https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/svn.html#svn-mirrors
[3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195480
[4] https://bugs.freebsd.org/submit/



signature.asc
Description: Message signed with OpenPGP using GPGMail


/usr/sbin/cron and /usr/sbin/fifolog_{create,reader,writer} winds up in ${DESTDIR}/ during installworld, as of r275212

2014-11-28 Thread Trond Endrestøl
Something's wrong in base/head when /usr/sbin/cron and 
/usr/sbin/fifolog_{create,reader,writer} winds up in ${DESTDIR}/ 
during installworld.

Seen on amd64 as of r275212, both with and without DESTDIR set.

Is it a pilot error on my part?

-- 
+---++
| Vennlig hilsen,   | Best regards,  |
| Trond Endrestøl,  | Trond Endrestøl,   |
| IT-ansvarlig, | System administrator,  |
| Fagskolen Innlandet,  | Gjøvik Technical College, Norway,  |
| tlf. mob.   952 62 567,   | Cellular...: +47 952 62 567,   |
| sentralbord 61 14 54 00.  | Switchboard: +47 61 14 54 00.  |
+---++
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: /usr/sbin/cron and /usr/sbin/fifolog_{create,reader,writer} winds up in ${DESTDIR}/ during installworld, as of r275212

2014-11-28 Thread Baptiste Daroussin
On Fri, Nov 28, 2014 at 10:54:07PM +0100, Trond Endrestøl wrote:
 Something's wrong in base/head when /usr/sbin/cron and 
 /usr/sbin/fifolog_{create,reader,writer} winds up in ${DESTDIR}/ 
 during installworld.
 
 Seen on amd64 as of r275212, both with and without DESTDIR set.
 
 Is it a pilot error on my part?
 
My fault, let me fix.

regards,
Bapt


pgpzfcdbMoOla.pgp
Description: PGP signature


Re: /usr/sbin/cron and /usr/sbin/fifolog_{create, reader, writer} winds up in ${DESTDIR}/ during installworld, as of r275212

2014-11-28 Thread Dimitry Andric
On 28 Nov 2014, at 22:54, Trond Endrestøl trond.endres...@fagskolen.gjovik.no 
wrote:
 
 Something's wrong in base/head when /usr/sbin/cron and
 /usr/sbin/fifolog_{create,reader,writer} winds up in ${DESTDIR}/
 during installworld.
 
 Seen on amd64 as of r275212, both with and without DESTDIR set.
 
 Is it a pilot error on my part?

I have seen this too.  I thought it was just a fluke, but maybe it is not. :-)

-Dimitry



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: /usr/sbin/cron and /usr/sbin/fifolog_{create, reader, writer} winds up in ${DESTDIR}/ during installworld, as of r275212

2014-11-28 Thread Baptiste Daroussin
On Fri, Nov 28, 2014 at 10:59:00PM +0100, Dimitry Andric wrote:
 On 28 Nov 2014, at 22:54, Trond Endrestøl 
 trond.endres...@fagskolen.gjovik.no wrote:
  
  Something's wrong in base/head when /usr/sbin/cron and
  /usr/sbin/fifolog_{create,reader,writer} winds up in ${DESTDIR}/
  during installworld.
  
  Seen on amd64 as of r275212, both with and without DESTDIR set.
  
  Is it a pilot error on my part?
 
 I have seen this too.  I thought it was just a fluke, but maybe it is not. :-)
 
 -Dimitry
 

Fixed in r275218

Sorry,
Bapt


pgpfoQhX0U1Jh.pgp
Description: PGP signature