Re: ci.freebsd.org's FreeBSD-head-i386-testvm fails for: pkg: No packages available to install matching 'scapy' have been found in the repositories

2018-07-08 Thread Li-Wen Hsu
On Thu, Jul 5, 2018 at 11:51 PM Mark Millard  wrote:
>
> https://ci.freebsd.org/job/FreeBSD-head-i386-testvm/6978/console shows:
>
> 22:34:39 All repositories are up to date.
> 22:34:39 + sudo chroot ufs pkg install -y kyua perl5 scapy ksh93 python
> 22:34:39 Updating FreeBSD repository catalogue...
> 22:34:39 FreeBSD repository is up to date.
> 22:34:39 All repositories are up to date.
> 22:34:39 Updating database digests format: . done
> 22:34:39 pkg: No packages available to install matching 'scapy' have been 
> found in the repositories
> 22:34:39 Build step 'Execute shell' marked build as failure
> 22:34:39 FTP: Current build result is [FAILURE], not going to run.
>
> There is a:
>
> https://svnweb.freebsd.org/ports/head/net/scapy/
>

It's not in head's pkg repository because it was skipped in last
completed pkg build:

http://beefy12.nyi.freebsd.org/build.html?mastername=head-amd64-default=p473790_s335878
(ipv6 only)

The reason is libdnet did not build, which needs this:

https://svnweb.freebsd.org/changeset/base/335928

The on-going pkg build will have scapy restored:

http://beefy12.nyi.freebsd.org/build.html?mastername=head-amd64-default=p474051_s336054

Li-Wen

-- 
Li-Wen Hsu 
https://lwhsu.org
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: -r336099 and later: broke ci.freebsd.prg's FreeBSD-head-amd64-build

2018-07-08 Thread Warner Losh
Yea, there's a stray space in that string.

r336114 should fix that.

Warner

On Sun, Jul 8, 2018 at 4:50 PM, Mark Millard  wrote:

> https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9386/consoleText
> shows:
>
> ===> zlib (install)
> install -T release -o root -g wheel -m 555   zlib.ko
> /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel/
> install -T debug -o root -g wheel -m 555   zlib.ko.debug
> /usr/obj/usr/src/amd64.amd64/release/dist/kernel/usr/lib/
> debug/boot/kernel/
> kldxref /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel
> kldxref: Parse error of description string U16:vendor; U16:device
> *** Error code 1
>
> Stop.
> make[4]: stopped in /usr/src/sys/modules
>
>
> Note the "U16:vendor; U16:device" reference and such text in
> the below (and other check-ins after it). . .
>
>
> Author: imp
> Date: Sun Jul  8 20:39:38 2018
> New Revision: 336099
> URL:
> https://svnweb.freebsd.org/changeset/base/336099
>
>
> Log:
>   Add PNP info to PCI attachment of ena driver
> . . .
>
> Modified:
>   head/sys/dev/ena/ena.c
>   head/sys/dev/ena/ena.h
>
> Modified: head/sys/dev/ena/ena.c
> 
> ==
> --- head/sys/dev/ena/ena.c  Sun Jul  8 20:39:23 2018(r336098)
> +++ head/sys/dev/ena/ena.c  Sun Jul  8 20:39:38 2018(r336099)
> @@ -3947,6 +3947,8 @@ static driver_t ena_driver = {
>
>  devclass_t ena_devclass;
>  DRIVER_MODULE(ena, pci, ena_driver, ena_devclass, 0, 0);
> +MODULE_PNP_INFO("U16:vendor; U16:device", pci, ena, ena_vendor_info_array,
> +sizeof(ena_vendor_info_array[0]), nitems(ena_vendor_info_array) - 1);
>  MODULE_DEPEND(ena, pci, 1, 1, 1);
>  MODULE_DEPEND(ena, ether, 1, 1, 1);
>
> . . .
>
>
> ===
> Mark Millard
> marklmi at yahoo.com
> ( dsl-only.net went
> away in early 2018-Mar)
>
>
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


-r336099 and later: broke ci.freebsd.prg's FreeBSD-head-amd64-build

2018-07-08 Thread Mark Millard
https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9386/consoleText shows:

===> zlib (install)
install -T release -o root -g wheel -m 555   zlib.ko 
/usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel/
install -T debug -o root -g wheel -m 555   zlib.ko.debug 
/usr/obj/usr/src/amd64.amd64/release/dist/kernel/usr/lib/debug/boot/kernel/
kldxref /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel
kldxref: Parse error of description string U16:vendor; U16:device
*** Error code 1

Stop.
make[4]: stopped in /usr/src/sys/modules


Note the "U16:vendor; U16:device" reference and such text in
the below (and other check-ins after it). . .


Author: imp
Date: Sun Jul  8 20:39:38 2018
New Revision: 336099
URL: 
https://svnweb.freebsd.org/changeset/base/336099


Log:
  Add PNP info to PCI attachment of ena driver
. . .

Modified:
  head/sys/dev/ena/ena.c
  head/sys/dev/ena/ena.h

Modified: head/sys/dev/ena/ena.c
==
--- head/sys/dev/ena/ena.c  Sun Jul  8 20:39:23 2018(r336098)
+++ head/sys/dev/ena/ena.c  Sun Jul  8 20:39:38 2018(r336099)
@@ -3947,6 +3947,8 @@ static driver_t ena_driver = {
 
 devclass_t ena_devclass;
 DRIVER_MODULE(ena, pci, ena_driver, ena_devclass, 0, 0);
+MODULE_PNP_INFO("U16:vendor; U16:device", pci, ena, ena_vendor_info_array,
+sizeof(ena_vendor_info_array[0]), nitems(ena_vendor_info_array) - 1);
 MODULE_DEPEND(ena, pci, 1, 1, 1);
 MODULE_DEPEND(ena, ether, 1, 1, 1);

. . .


===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: GELI with UEFI supporting Boot Environments goes to HEAD when?

2018-07-08 Thread Eric McCorkle
I intend to endorse this patch over my own once I'm able to test it out on my 
test images.

My approach is highly EFI-specific, and it made sense to do it that way when 
boot1.efi was still a thing. The architecture agnostic method makes more sense 
now that it's gone. 

On July 8, 2018 3:31:47 PM EDT, Ian Lepore  wrote:
>On Sun, 2018-07-08 at 21:08 +0200, Oliver Pinter wrote:
>> Hi!
>> 
>> Have you or Warner any update on this code?
>> 
>> On Thursday, April 12, 2018, Eric McCorkle 
>> wrote:
>> 
>
>Are you aware of https://reviews.freebsd.org/D15743 ?
>
>That's my changes to add geli support to loader(8) in an architecture-
>agnostic way, so that "it just works" for all platforms and flavors of
>loader. It has been succesfully tested on armv6/7 (ubldr) and on x86
>using qemu.  The x86 tests cover ufs and zfs, legacy bios and uefi. The
>only variations that aren't tested yet are the uefi flavors, because
>the current rootgen.sh script for assembling test images is still using
>boot1.efi and I don't know enough about efi myself to update the script
>to make it assemble images the new way Warner envisions.
>
>-- Ian
>
>> > 
>> > I'm in the middle of moving to a new apartment right now.  It's
>> > going to
>> > be a bit before I can get to this.
>> > 
>> > On 04/11/2018 20:31, Warner Losh wrote:
>> > > 
>> > > OK. I've pushed in the main part of it. The additional work I
>> > > have
>> > > shouldn't affect any of this stuff.  I was going to look at what
>> > > part(s)
>> > > of your open reviewed needed to be redone tomorrow and send you
>> > > feedback, but if you wanted to get a start before then, I'm happy
>> > > to
>> > > answer questions. All the rest of my work is going to be
>> > > selecting the
>> > > root partition when we're told to us a specific partition, so
>> > > will be
>> > > very constrained.
>> > > 
>> > > Warner
>> > > 
>> > > On Wed, Apr 11, 2018 at 6:02 PM, Eric McCorkle > > > net
>> > > > wrote:
>> > > 
>> > > I think the thing to do at this point is to wait for the
>> > > current
>> > work on
>> > > 
>> > > loader.efi to land, then adapt my patches to apply against
>> > > that work.
>> > > 
>> > > On 04/11/2018 15:06, Warner Losh wrote:
>> > > > Still reviewing the code. I'm worried it's too i386
>> > > specific and it
>> > > > conflicts with some work I'm doing. I'll have a list of
>> > > actionable
>> > > > critiques this week.
>> > > >
>> > > > Warner
>> > > >
>> > > > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter
>> > > > > > > 
>> > > > > > >>
>> > > > wrote:
>> > > >
>> > > > Hi!
>> > > >
>> > > > Is there any update regarding the rebase or the
>> > > inclusion to
>> > base
>> > > 
>> > > > system?
>> > > > On 3/28/18, Eric McCorkle > > > > > e...@metricspace.net>
>> > > 
>> > > > > > > et>>>
>> > wrote:
>> > > 
>> > > > > I'll do another rebase from head just to be sure
>> > > > >
>> > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh <
>> > i...@bsdimp.com 
>> > > 
>> > > > >> wrote:
>> > > > >>It's on my list for nexr, finally. I have an
>> > > alternate patch
>> > for
>> > > 
>> > > > >>loader.efi
>> > > > >>from ESP, but i don't think it will affect the GELI
>> > > stuff. I
>> > have some
>> > > 
>> > > > >>time
>> > > > >>slotted for integration issues though.
>> > > > >>
>> > > > >>I am quite mindful of the freeze dates I  have
>> > > some uefi
>> > boot
>> > > 
>> > > > >>loader
>> > > > >>protocol changes that I need to get in.
>> > > > >>
>> > > > >>Warner
>> > > > >>
>> > > > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" <
>> > tommi.pern...@iki.fi 
>> > > 
>> > > > > > > fi>>>
>> > wrote:
>> > > 
>> > > > >>
>> > > > >>> Awesome, thanks for the update and the work that
>> > > you have
>> > done!
>> > > 
>> > > > >>>
>> > > > >>> Now we just need some more reviewers eyes on the
>> > > code :)
>> > > > >>>
>> > > > >>> Br,
>> > > > >>>
>> > > > >>> Tommi
>> > > > >>>
>> > > > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle <
>> > e...@metricspace.net 
>> > > 
>> > > > > > > et>>>
>> > > > >>wrote:
>> > > > >>>
>> > > >  FYI, I just IFC'ed everything, and the current
>> > > patches
>> > > are still
>> > > > >>fine.
>> > > > 
>> > > > 

Re: GELI with UEFI supporting Boot Environments goes to HEAD when?

2018-07-08 Thread Oliver Pinter
On Sunday, July 8, 2018, Ian Lepore  wrote:

> On Sun, 2018-07-08 at 21:08 +0200, Oliver Pinter wrote:
> > Hi!
> >
> > Have you or Warner any update on this code?
> >
> > On Thursday, April 12, 2018, Eric McCorkle 
> > wrote:
> >
>
> Are you aware of https://reviews.freebsd.org/D15743 ?
>
> That's my changes to add geli support to loader(8) in an architecture-
> agnostic way, so that "it just works" for all platforms and flavors of
> loader. It has been succesfully tested on armv6/7 (ubldr) and on x86
> using qemu.  The x86 tests cover ufs and zfs, legacy bios and uefi. The
> only variations that aren't tested yet are the uefi flavors, because
> the current rootgen.sh script for assembling test images is still using
> boot1.efi and I don't know enough about efi myself to update the script
> to make it assemble images the new way Warner envisions.
>
>
Not yet, but thanks for the link!


> -- Ian
>
> > >
> > > I'm in the middle of moving to a new apartment right now.  It's
> > > going to
> > > be a bit before I can get to this.
> > >
> > > On 04/11/2018 20:31, Warner Losh wrote:
> > > >
> > > > OK. I've pushed in the main part of it. The additional work I
> > > > have
> > > > shouldn't affect any of this stuff.  I was going to look at what
> > > > part(s)
> > > > of your open reviewed needed to be redone tomorrow and send you
> > > > feedback, but if you wanted to get a start before then, I'm happy
> > > > to
> > > > answer questions. All the rest of my work is going to be
> > > > selecting the
> > > > root partition when we're told to us a specific partition, so
> > > > will be
> > > > very constrained.
> > > >
> > > > Warner
> > > >
> > > > On Wed, Apr 11, 2018 at 6:02 PM, Eric McCorkle  > > > net
> > > > > wrote:
> > > >
> > > > I think the thing to do at this point is to wait for the
> > > > current
> > > work on
> > > >
> > > > loader.efi to land, then adapt my patches to apply against
> > > > that work.
> > > >
> > > > On 04/11/2018 15:06, Warner Losh wrote:
> > > > > Still reviewing the code. I'm worried it's too i386
> > > > specific and it
> > > > > conflicts with some work I'm doing. I'll have a list of
> > > > actionable
> > > > > critiques this week.
> > > > >
> > > > > Warner
> > > > >
> > > > > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter
> > > > >  > > > 
> > > >  > > > >>
> > > > > wrote:
> > > > >
> > > > > Hi!
> > > > >
> > > > > Is there any update regarding the rebase or the
> > > > inclusion to
> > > base
> > > >
> > > > > system?
> > > > > On 3/28/18, Eric McCorkle  > > >  > > e...@metricspace.net>
> > > >
> > > > >  > > > et>>>
> > > wrote:
> > > >
> > > > > > I'll do another rebase from head just to be sure
> > > > > >
> > > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh <
> > > i...@bsdimp.com 
> > > >
> > > > > >> wrote:
> > > > > >>It's on my list for nexr, finally. I have an
> > > > alternate patch
> > > for
> > > >
> > > > > >>loader.efi
> > > > > >>from ESP, but i don't think it will affect the GELI
> > > > stuff. I
> > > have some
> > > >
> > > > > >>time
> > > > > >>slotted for integration issues though.
> > > > > >>
> > > > > >>I am quite mindful of the freeze dates I  have
> > > > some uefi
> > > boot
> > > >
> > > > > >>loader
> > > > > >>protocol changes that I need to get in.
> > > > > >>
> > > > > >>Warner
> > > > > >>
> > > > > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" <
> > > tommi.pern...@iki.fi 
> > > >
> > > > >  > > > fi>>>
> > > wrote:
> > > >
> > > > > >>
> > > > > >>> Awesome, thanks for the update and the work that
> > > > you have
> > > done!
> > > >
> > > > > >>>
> > > > > >>> Now we just need some more reviewers eyes on the
> > > > code :)
> > > > > >>>
> > > > > >>> Br,
> > > > > >>>
> > > > > >>> Tommi
> > > > > >>>
> > > > > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle <
> > > e...@metricspace.net 
> > > >
> > > > >  > > > et>>>
> > > > > >>wrote:
> > > > > >>>
> > > > >  FYI, I just IFC'ed everything, and the current
> > > > patches
> > > > are still
> > > > > >>fine.
> > > > > 
> > > > >  Also, the full GELI + standalone loader has been
> > > > deployed
> > > > on one of
> > > > > >>my
> > > > 

Re: GELI with UEFI supporting Boot Environments goes to HEAD when?

2018-07-08 Thread Ian Lepore
On Sun, 2018-07-08 at 21:08 +0200, Oliver Pinter wrote:
> Hi!
> 
> Have you or Warner any update on this code?
> 
> On Thursday, April 12, 2018, Eric McCorkle 
> wrote:
> 

Are you aware of https://reviews.freebsd.org/D15743 ?

That's my changes to add geli support to loader(8) in an architecture-
agnostic way, so that "it just works" for all platforms and flavors of
loader. It has been succesfully tested on armv6/7 (ubldr) and on x86
using qemu.  The x86 tests cover ufs and zfs, legacy bios and uefi. The
only variations that aren't tested yet are the uefi flavors, because
the current rootgen.sh script for assembling test images is still using
boot1.efi and I don't know enough about efi myself to update the script
to make it assemble images the new way Warner envisions.

-- Ian

> > 
> > I'm in the middle of moving to a new apartment right now.  It's
> > going to
> > be a bit before I can get to this.
> > 
> > On 04/11/2018 20:31, Warner Losh wrote:
> > > 
> > > OK. I've pushed in the main part of it. The additional work I
> > > have
> > > shouldn't affect any of this stuff.  I was going to look at what
> > > part(s)
> > > of your open reviewed needed to be redone tomorrow and send you
> > > feedback, but if you wanted to get a start before then, I'm happy
> > > to
> > > answer questions. All the rest of my work is going to be
> > > selecting the
> > > root partition when we're told to us a specific partition, so
> > > will be
> > > very constrained.
> > > 
> > > Warner
> > > 
> > > On Wed, Apr 11, 2018 at 6:02 PM, Eric McCorkle  > > net
> > > > wrote:
> > > 
> > > I think the thing to do at this point is to wait for the
> > > current
> > work on
> > > 
> > > loader.efi to land, then adapt my patches to apply against
> > > that work.
> > > 
> > > On 04/11/2018 15:06, Warner Losh wrote:
> > > > Still reviewing the code. I'm worried it's too i386
> > > specific and it
> > > > conflicts with some work I'm doing. I'll have a list of
> > > actionable
> > > > critiques this week.
> > > >
> > > > Warner
> > > >
> > > > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter
> > > >  > > 
> > >  > > >>
> > > > wrote:
> > > >
> > > > Hi!
> > > >
> > > > Is there any update regarding the rebase or the
> > > inclusion to
> > base
> > > 
> > > > system?
> > > > On 3/28/18, Eric McCorkle  > >  > e...@metricspace.net>
> > > 
> > > >  > > et>>>
> > wrote:
> > > 
> > > > > I'll do another rebase from head just to be sure
> > > > >
> > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh <
> > i...@bsdimp.com 
> > > 
> > > > >> wrote:
> > > > >>It's on my list for nexr, finally. I have an
> > > alternate patch
> > for
> > > 
> > > > >>loader.efi
> > > > >>from ESP, but i don't think it will affect the GELI
> > > stuff. I
> > have some
> > > 
> > > > >>time
> > > > >>slotted for integration issues though.
> > > > >>
> > > > >>I am quite mindful of the freeze dates I  have
> > > some uefi
> > boot
> > > 
> > > > >>loader
> > > > >>protocol changes that I need to get in.
> > > > >>
> > > > >>Warner
> > > > >>
> > > > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" <
> > tommi.pern...@iki.fi 
> > > 
> > > >  > > fi>>>
> > wrote:
> > > 
> > > > >>
> > > > >>> Awesome, thanks for the update and the work that
> > > you have
> > done!
> > > 
> > > > >>>
> > > > >>> Now we just need some more reviewers eyes on the
> > > code :)
> > > > >>>
> > > > >>> Br,
> > > > >>>
> > > > >>> Tommi
> > > > >>>
> > > > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle <
> > e...@metricspace.net 
> > > 
> > > >  > > et>>>
> > > > >>wrote:
> > > > >>>
> > > >  FYI, I just IFC'ed everything, and the current
> > > patches
> > > are still
> > > > >>fine.
> > > > 
> > > >  Also, the full GELI + standalone loader has been
> > > deployed
> > > on one of
> > > > >>my
> > > >  laptops for some time now.
> > > > 
> > > >  On 02/21/2018 18:15, Eric McCorkle wrote:
> > > >  > The GELI work could be merged at this point,
> > > though it
> > > won't be
> > > > >>usable
> > > >  > without an additional patch to enable loader-
> > > only
> > > operation.  

Re: GELI with UEFI supporting Boot Environments goes to HEAD when?

2018-07-08 Thread Oliver Pinter
Hi!

Have you or Warner any update on this code?

On Thursday, April 12, 2018, Eric McCorkle  wrote:

> I'm in the middle of moving to a new apartment right now.  It's going to
> be a bit before I can get to this.
>
> On 04/11/2018 20:31, Warner Losh wrote:
> > OK. I've pushed in the main part of it. The additional work I have
> > shouldn't affect any of this stuff.  I was going to look at what part(s)
> > of your open reviewed needed to be redone tomorrow and send you
> > feedback, but if you wanted to get a start before then, I'm happy to
> > answer questions. All the rest of my work is going to be selecting the
> > root partition when we're told to us a specific partition, so will be
> > very constrained.
> >
> > Warner
> >
> > On Wed, Apr 11, 2018 at 6:02 PM, Eric McCorkle  > > wrote:
> >
> > I think the thing to do at this point is to wait for the current
> work on
> > loader.efi to land, then adapt my patches to apply against that work.
> >
> > On 04/11/2018 15:06, Warner Losh wrote:
> > > Still reviewing the code. I'm worried it's too i386 specific and it
> > > conflicts with some work I'm doing. I'll have a list of actionable
> > > critiques this week.
> > >
> > > Warner
> > >
> > > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter
> > >  > 
> >  > >>
> > > wrote:
> > >
> > > Hi!
> > >
> > > Is there any update regarding the rebase or the inclusion to
> base
> > > system?
> > > On 3/28/18, Eric McCorkle  e...@metricspace.net>
> > > >>
> wrote:
> > > > I'll do another rebase from head just to be sure
> > > >
> > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh <
> i...@bsdimp.com 
> > > >> wrote:
> > > >>It's on my list for nexr, finally. I have an alternate patch
> for
> > > >>loader.efi
> > > >>from ESP, but i don't think it will affect the GELI stuff. I
> have some
> > > >>time
> > > >>slotted for integration issues though.
> > > >>
> > > >>I am quite mindful of the freeze dates I  have some uefi
> boot
> > > >>loader
> > > >>protocol changes that I need to get in.
> > > >>
> > > >>Warner
> > > >>
> > > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" <
> tommi.pern...@iki.fi 
> > > >>
> wrote:
> > > >>
> > > >>> Awesome, thanks for the update and the work that you have
> done!
> > > >>>
> > > >>> Now we just need some more reviewers eyes on the code :)
> > > >>>
> > > >>> Br,
> > > >>>
> > > >>> Tommi
> > > >>>
> > > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle <
> e...@metricspace.net 
> > > >>
> > > >>wrote:
> > > >>>
> > >  FYI, I just IFC'ed everything, and the current patches
> > are still
> > > >>fine.
> > > 
> > >  Also, the full GELI + standalone loader has been deployed
> > on one of
> > > >>my
> > >  laptops for some time now.
> > > 
> > >  On 02/21/2018 18:15, Eric McCorkle wrote:
> > >  > The GELI work could be merged at this point, though it
> > won't be
> > > >>usable
> > >  > without an additional patch to enable loader-only
> > operation.  The
> > >  > patches are currently up for review:
> > >  >
> > >  > This is the order in which they'd need to be merged:
> > >  >
> > >  >
> > >  > https://reviews.freebsd.org/D12732
> > 
> > >  > >
> > >  >
> > >  > This one changes the efipart device.  Toomas Soome
> > identified
> > > some
> > >  > problems, which I have addressed.  He has not
> > re-reviewed it,
> > > >>however.
> > >  >
> > >  >
> > >  > https://reviews.freebsd.org/D12692
> > 
> > >  > >
> > >  >
> > >  > This adds some crypto code needed for GELI.  It simply
> > adds new
> > > >>code,
> > >  > and doesn't conflict with anything.
> > >  >
> > >  >
> > >  >