[patch on PR] make installworld DESTDIR= failure

2018-09-25 Thread Yoshihiro Ota
Hi,

Given 12-ALPHA added ntpd uid and gid, make installworld DESTDIR= fails 
as it checks ntpd user and group id under /etc instead of  $DESTDIR/etc.

I created a PR and then created a patch and tested; however, it doesn't look 
the PR got enough attension.

Could some one take a look at 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231334 ?

Thanks,
Hiro
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Buildowrld tries to use old ld, and fails

2018-09-25 Thread Ed Maste
On 25 September 2018 at 02:55,   wrote:
>
>> The normal procedure shouldn't need any LD= overrides; is there
>> something unique in your build? Any src.conf settings?
>
> Indeed, I had "WITHOUT_LLD_BOOTSTRAP=yes" in src.conf. Not sure how
> that line made it into this file on a number of my systems... perhaps
> an artifact of old -CURRENT upgrade procedure that I've forgotten about.

Glad to hear it's resolved now.

> I was just following a note 20180510 from UPDATING. It worked before.
> And there are no newer entries overruling the old note, so I thought
> it should still work as before...

Ah, indeed. In addition to that note now being obsolete (and no
superseding note) there's another issue: the LD= suggestion applied
only to buildkernel (but perhaps was not sufficiently clear).

> Strange that overriding LD works when pointing to ld from binutils, but
> not always with ld.lld linker; for example, 'stand/i386/mbr/' ignores
> "LD=ld.lld", but not "LD=/usr/local/bin/ld".

This is a side effect of the linker feature detection. What's
happening here is that when lld is detected the build adds the
-no-rosegment flag, so when LD=ld.lld is in use the flag is added,
then the linker invoked from the compiler driver doesn't handle the
flag. When LD=/usr/local/bin/ld the flag is not added at all.

I will see about an update for UPDATING.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Buildowrld tries to use old ld, and fails

2018-09-25 Thread soralx


> > Howdy!
> >
> >  Since a couple months ago, the world on -CURRENT cannot be built
> > using the normal procedure:
> >time env LD=ld.lld make -j6 buildworld buildkernel  
> 
> The normal procedure shouldn't need any LD= overrides; is there
> something unique in your build? Any src.conf settings?

Indeed, I had "WITHOUT_LLD_BOOTSTRAP=yes" in src.conf. Not sure how
that line made it into this file on a number of my systems... perhaps
an artifact of old -CURRENT upgrade procedure that I've forgotten about.

Soon as I emptied /etc/src.conf, and dropped the 'LD=' from environment,
the build succeeds no problem. Thanks, Ed!

> >  Here's the result:
> >[late in buildowrld process]
> >--- all_subdir_stand ---
> >/usr/obj/usr/src/amd64.amd64/tmp/usr/bin/ld: unrecognized option
> > '--no-rosegment' /usr/obj/usr/src/amd64.amd64/tmp/usr/bin/ld: use the
> > --help option for usage information cc: error: linker command failed
> > with exit code 1 (use -v to see invocation) make[5]: stopped
> > in /usr/src/stand/i386/mbr
> >
> >  Workaround is to use linker from binutils:
> >env LD=/usr/local/bin/ld make buildworld  
> 
> Just overriding LD isn't sufficient to choose a linker, because most
> linking is performed by the compiler driver (i.e., cc) which does not
> use the LD variable.

I was just following a note 20180510 from UPDATING. It worked before.
And there are no newer entries overruling the old note, so I thought
it should still work as before...

Strange that overriding LD works when pointing to ld from binutils, but
not always with ld.lld linker; for example, 'stand/i386/mbr/' ignores
"LD=ld.lld", but not "LD=/usr/local/bin/ld".

-- 
[SorAlx]  ridin' VN2000 Classic LT
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"