Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 7/16/19 5:37 PM, Warner Losh wrote: On Tue, Jul 16, 2019 at 3:32 PM Dennis Clarke wrote: The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Ha! Sometimes I hear people even sleep ? I was just thinking the probability of landing in that one failed buildworld was real real small and somehow myself and a few others managed to do it. The changes survived a buildworld on amd64. I had no reason to even suspect they might be troublesome on other archs. Since I have a busy day, I took a shortcut. I don't build universe for every change, there's simply not time. So it's more complicated than you're trying to paint. I am not trying to paint anything. I know there are a few of us with limited time and limited resources and we are all just doing what we can. In spite of this we have an open source UNIX with ZFS running. On more than just x86 little boxen. So we can expect bumps in the road : a typical bump in the road for ppc64 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239245 Yep .. changes happen and things break. Such is life. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On Tue, Jul 16, 2019 at 3:32 PM Dennis Clarke wrote: > > > The window would have been smaller. CI detected the breakage within 10 > > minutes, but I was away from my email attending to some household things > > for an hour more... > > > > Ha! Sometimes I hear people even sleep ? > > I was just thinking the probability of landing in that one failed > buildworld was real real small and somehow myself and a few others > managed to do it. > The changes survived a buildworld on amd64. I had no reason to even suspect they might be troublesome on other archs. Since I have a busy day, I took a shortcut. I don't build universe for every change, there's simply not time. So it's more complicated than you're trying to paint. Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Ha! Sometimes I hear people even sleep ? I was just thinking the probability of landing in that one failed buildworld was real real small and somehow myself and a few others managed to do it. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
[CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks
Good day.
Attached is the patch that makes built-in tbl(1) processor in mandoc
to avoid dumping core when it renders the table with empty "T{ T}"
block and horizontally-ruled table.
The simplest way to reproduce the issue is to either
- run 'man notmuch-config' with mail/notmuch installed;
- run 'mandoc tests/empty-table-cdata.1' against the attached
test-only manpage.
With the patch applied, one can utilize 'make check': regression
test was added. Perhaps an invocation of
{{{
mtree -deU -f /usr/src/etc/mtree/BSD.tests.dist -p /usr/tests
}}}
will be needed to run 'make check' without remaking/installing
the world.
The patch is for the fresh -CURRENT. Be interested in any results
of its application and usage.
Thanks!
P.S.: please, CC me: I am not subscribed to the list.
--
Eygene Ryabinkin,,,^..^,,,
[ Life's unfair - but root password helps! | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
mandoc: fix built-in tbl(1) processing of empty continuation blocks
Empty "T{ T}" (continuation) blocks produce NULL-valued string
for their data block: getdata() allocates structure with string
set to NULL and tbl_cdata() will just return when it sees
the end ("T}") of the block without any further manipulations
with dat->string.
This is completely legal; moreover, tbl.h specifies that for
'struct tbl_dat' the 'string' member is NULL when entry type
is not TBL_DATA_DATA. This is not so all the time, but one
shouldn't rely on this.
The segfault in question was plain NULL pointer dereference
triggered from tbl_term.c::tbl_hrule().
Added check for dpn->pos not being TBL_DATA_DATA. Also added
regression test to find such problems in the future.
The real-world case when manpage was provoking core dump
is notmuch-config.1 for mail/notmuch port: it is auto-generated
from reStructuredText, so has empty blocks at the places where
it would be enough just to specify the empty value.
Index: usr.bin/mandoc/Makefile
===
--- usr.bin/mandoc/Makefile (revision 349971)
+++ usr.bin/mandoc/Makefile (working copy)
@@ -101,4 +101,7 @@
CFLAGS.gcc+= -Wno-format
LIBADD= openbsd z
+HAS_TESTS=
+SUBDIR.${MK_TESTS}+= tests
+
.include
Index: usr.bin/mandoc/tests/Makefile
===
--- usr.bin/mandoc/tests/Makefile (nonexistent)
+++ usr.bin/mandoc/tests/Makefile (working copy)
@@ -0,0 +1,11 @@
+# $FreeBSD$
+
+PACKAGE= tests
+
+${PACKAGE}FILES+= empty-table-cdata.1
+
+ATF_TESTS_SH+= regression-tests
+
+BINDIR= ${TESTSDIR}
+
+.include
Property changes on: usr.bin/mandoc/tests/Makefile
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:keywords
## -0,0 +1 ##
+FreeBSD=%H
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Index: usr.bin/mandoc/tests/Makefile.depend
===
--- usr.bin/mandoc/tests/Makefile.depend (nonexistent)
+++ usr.bin/mandoc/tests/Makefile.depend (working copy)
@@ -0,0 +1,11 @@
+# $FreeBSD$
+# Autogenerated - do NOT edit!
+
+DIRDEPS = \
+
+
+.include
+
+.if ${DEP_RELDIR} == ${_DEP_RELDIR}
+# local dependencies - needed for -jN in clean tree
+.endif
Property changes on: usr.bin/mandoc/tests/Makefile.depend
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:keywords
## -0,0 +1 ##
+FreeBSD=%H
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Index: usr.bin/mandoc/tests/empty-table-cdata.1
===
--- usr.bin/mandoc/tests/empty-table-cdata.1 (nonexistent)
+++ usr.bin/mandoc/tests/empty-table-cdata.1 (working copy)
@@ -0,0 +1,21 @@
+.\" $FreeBSD$
+.
+.TH EMPTY-TABLE-CDATA 1 1970-01-01
+.SH Empty table cdata test for tbl processor
+.
+.PP
+The following table should not make mandoc to dump core:
+.
+.TS
+|l|l|.
+_
+A test
+_
+table T{
+T}
+_
+.TE
+.
+.SH Author
+.PP
+Eygene Ryabinkin, .
Property changes on: usr.bin/mandoc/tests/empty-table-cdata.1
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:keywords
## -0,0 +1 ##
+FreeBSD=%H
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Index: usr.bin/mandoc/tests/regression-tests.sh
===
--- usr.bin/mandoc/tests/regression-tests.sh (nonexistent)
+++ usr.bin/mandoc/tests/regression-tests.sh (working copy)
@@ -0,0 +1,20 @@
+# $FreeBSD$
+
+
+SRCDIR=$(atf_get_srcdir)
+
+
+atf_test_case
FreeBSD in Windows
Hi, I need to know and with great detail how Microsoft uses FreeBSD in Windows. Thank You, Jonathan Moore ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
FreeBSD CI Weekly Report 2019-07-14
(Please send the followup to freebsd-testing@ and note Reply-To is set.) FreeBSD CI Weekly Report 2019-07-14 === Here is a summary of the FreeBSD Continuous Integration results for the period from 2019-07-08 to 2019-07-14. During this period, we have: * 1628 builds (97.4% passed, 2.6% failed) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 317 test runs (54.3% passed, 37.5% unstable, 8.2% exception) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 48 doc builds (100% passed) (The statistics from experimental jobs are omitted) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. The latest web version of this report is available at https://hackmd.io/s/Bk5EdrMbB and archive is available at http://hackfoldr.org/freebsd-ci-report/, any help is welcome. ## Fixed Tests * https://ci.freebsd.org/job/FreeBSD-head-i386-test/ * sys.opencrypto.runtests.main Fixed in [r349872](https://reviews.freebsd.org/rS349872) ## Failing Tests * https://ci.freebsd.org/job/FreeBSD-head-i386-test/ * sys.netpfil.pf.forward.v6 * sys.netpfil.pf.forward.v4 * sys.netpfil.pf.set_tos.v4 * Analysis from kp@: * https://lists.freebsd.org/pipermail/freebsd-testing/2019-June/001933.html * https://lists.freebsd.org/pipermail/freebsd-testing/2019-June/001934.html * https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/ * Same as -head: * sys.netpfil.pf.forward.v6 * sys.netpfil.pf.forward.v4 * sys.netpfil.pf.set_tos.v4 * sys.opencrypto.runtests.main * Needs MFC more than r349872. * lib.libregex.exhaust_test.regcomp_too_big * flaky, sometimes failed with: ``` /usr/src/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c:72: p != NULL not met ``` * https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/ * local.kyua.* (31 cases) * local.lutok.* (3 cases) ## Failing and Flaky Tests (from experimental jobs) * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d https://bugs.freebsd.org/237641 * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~60 failing cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details ## Disabled Tests * lib.libc.sys.mmap_test.mmap_truncate_signal https://bugs.freebsd.org/211924 * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * usr.bin.procstat.procstat_test.command_loogle.com/ine_arguments https://bugs.freebsd.org/233587 * usr.bin.procstat.procstat_test.environment https://bugs.freebsd.org/233588 * sys.netinet.socket_afinet.socket_afinet_bind_zero (new) https://bugs.freebsd.org/238781 ## Issues ### Cause build fails * https://bugs.freebsd.org/233735 Possible build race: genoffset.o /usr/src/sys/sys/types.h: error: machine/endian.h: No such file or directory * https://bugs.freebsd.org/233769 Possible build race: ld: error: unable to find library -lgcc_s * https://bugs.freebsd.org/238828 Possible build race: lib/libsysdecode/tables.h:948: error: 'IPV6_MIN_MEMBERSHIPS' undeclared ### Cause kernel panics * https://bugs.freebsd.org/238870 sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy cause panic Patch exists: * https://reviews.freebsd.org/D20868 * https://reviews.freebsd.org/D20869 ### Open * https://bugs.freebsd.org/237077 possible race in build: /usr/src/sys/amd64/linux/linux_support.s:38:2: error: expected relocatable expression * https://bugs.freebsd.org/237403 Tests in sys/opencrypto should be converted to Python3 * https://bugs.freebsd.org/237641 Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237652 tests.hotspare.hotspare_test.hotspare_snapshot_001_pos timeout since somewhere in (r346814, r 346845] * https://bugs.freebsd.org/237655 Non-deterministic panic when running pf tests in interface ioctl code (NULL passed to strncmp) * https://bugs.freebsd.org/237656 "Freed UMA keg (rtentry) was not empty (18 items). Lost 1 pages of memory." seen when running sys/netipsec tests * https://bugs.freebsd.org/237657 sys.kern.pdeathsig.signal_delivered_ptrace timing out periodically on i386 * https://bugs.freebsd.org/238781 sys.netinet.socket_afinet.socket_afinet_bind_zero does not work when mac_portacl(4) loaded ### Others * [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) * https://issues.tmatesoft.com/issue/SVNKIT-740 The patch is
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On Tue, Jul 16, 2019 at 5:04 AM Dennis Clarke wrote: > On 7/16/19 6:55 AM, Dimitry Andric wrote: > > On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > >> > >> On 7/16/19 2:48 AM, Warner Losh wrote: > >>> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke > >>> wrote: > /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function > 'getdevtype': > /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > of unsigned expression < 0 is always false > > Anyone else seeing this ? > > >>> Fixed hours ago in 350020. > >> > >> Hours ago. Cool. However is there no CI testing on ppc64? > > > > There is a CI build, in any case: > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ > > > > It showed a failure for build #11532 (r350018): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ > > > > and also how it got fixed in build #11533 (r350020): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ > > > > Unfortunately there is no test job which attempts to fire up a world > > inside e.g. qemu. > > Oh well, thank you for the info. Lucky me that I fell into the exact > same build problem which only happens rarely. Hardly a lottery ticket > win but I am happy to see the CI information. > The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 7/16/19 6:55 AM, Dimitry Andric wrote: On 16 Jul 2019, at 12:36, Dennis Clarke wrote: On 7/16/19 2:48 AM, Warner Losh wrote: On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison of unsigned expression < 0 is always false Anyone else seeing this ? Fixed hours ago in 350020. Hours ago. Cool. However is there no CI testing on ppc64? There is a CI build, in any case: https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ It showed a failure for build #11532 (r350018): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ and also how it got fixed in build #11533 (r350020): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ Unfortunately there is no test job which attempts to fire up a world inside e.g. qemu. Oh well, thank you for the info. Lucky me that I fell into the exact same build problem which only happens rarely. Hardly a lottery ticket win but I am happy to see the CI information. Dennis ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > > On 7/16/19 2:48 AM, Warner Losh wrote: >> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke >> wrote: >>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': >>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison >>> of unsigned expression < 0 is always false >>> >>> Anyone else seeing this ? >>> >> Fixed hours ago in 350020. > > Hours ago. Cool. However is there no CI testing on ppc64? There is a CI build, in any case: https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ It showed a failure for build #11532 (r350018): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ and also how it got fixed in build #11533 (r350020): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ Unfortunately there is no test job which attempts to fire up a world inside e.g. qemu. -Dimitry signature.asc Description: Message signed with OpenPGP
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 7/16/19 2:48 AM, Warner Losh wrote: On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison of unsigned expression < 0 is always false Anyone else seeing this ? Fixed hours ago in 350020. Hours ago. Cool. However is there no CI testing on ppc64? Maybe a jenkins type of deal would be helpful but the code base is moving so fast that it may only catch a few things here and there. Regardless the ppc64 world has bigger problems this morning : r350018 will panic on ppc64 PowerMac G5 in vm_phys_enqueue_contig https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239245 Another day another panic. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: > /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': > /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > of unsigned expression < 0 is always false > > Anyone else seeing this ? > Fixed hours ago in 350020. Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
sbin/camcontrol/camcontrol.c error breaks buildworld
In r350018 for a buildworld I am running into : . . . cc --sysroot=/usr/obj/usr/src/r350018/powerpc.powerpc64/tmp -B/usr/obj/usr/src/r350018/powerpc.powerpc64/tmp/usr/bin -O2 -pipe -I/usr/src/r350018/sbin/nvmecontrol -DWITH_NVME -DRESCUE -MD -MF.depend.camcontrol.o -MTcamcontrol.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/r350018/sbin/camcontrol/camcontrol.c -o camcontrol.o cc1: warnings being treated as errors /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison of unsigned expression < 0 is always false *** Error code 1 Stop. make[6]: stopped in /usr/src/r350018/sbin/camcontrol *** Error code 1 Stop. make[5]: stopped in /usr/obj/usr/src/r350018/powerpc.powerpc64/rescue/rescue *** Error code 1 Stop. make[4]: stopped in /usr/src/r350018/rescue/rescue *** Error code 1 Stop. make[3]: stopped in /usr/src/r350018/rescue *** Error code 1 Stop. make[2]: stopped in /usr/src/r350018 *** Error code 1 Stop. make[1]: stopped in /usr/src/r350018 *** Error code 1 Stop. make: stopped in /usr/src/r350018 # Anyone else seeing this ? -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
