psm0: unable to allocate IRQ

2022-10-02 Thread Chris 

I've spent the last 2 days attempting to get a fresh install of
stable/13-n252407-f42139db639 working on a Dell Inspiron 5755.
The problem I struggled with was getting the trackpad (synaptics?)
to be recognized and function. As it is, it's only ever recognized
as a mouse, and then, only if i kldload(8) ums(4). I'm pretty
sure this is on a psm(4). But any attempts to use psm fail with
psm0: unable to allocate IRQ.
An error I found in dmesg(8) on a verbose boot. Anybody familiar
with this, or have any thoughts on how I might track this down?

To rule out hardware; I installed Slackware along side the
FreeBSD install, and it has no trouble creating a full featured
trackpad under the MATE DE.

Thank you for all your time, and consideration.

--chris

0xBDE49540.asc
Description: application/pgp-keys

Re: Build Break?

2022-10-02 Thread Larry Rosenman 



On 10/02/2022 11:44 am, Larry Rosenman wrote:


On 10/02/2022 11:27 am, Alexander V. Chernikov wrote:
02.10.2022, 17:18, "Larry Rosenman" :

On 10/02/2022 8:12 am, Alexander V. Chernikov wrote:  On 1 Oct 2022, at 
22:57, Larry Rosenman  wrote:


--- all_subdir_nfscommon ---
Building
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o
--- all_subdir_netgraph ---
--- all_subdir_netgraph/deflate ---
Building
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc
--- all_subdir_netgraph/device ---
Building
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386
--- all_subdir_netgraph/echo ---
===> netgraph/echo (all)
--- all_subdir_netlink ---
--- netlink_io.o ---
/usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration
of function 'mtx_lock' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
NLP_LOCK(nlp);  That's interesting. netlink_io.c includes sys/mutex.h 
which defines

mutex_lock() / mutex_unlock().
Could you share the diff between GENERIC and LER-MINIMAL?


I sent the diff in another message, but here is LER-MINIMAL. Thank you!
So it's non-networking config. I'll make netlink build  conditional on 
INET || INET6 today/tomorrow.


I actually kldload a bunch of stuff.
kld_list="aesni coretemp filemon linux ichsmb ichwd cpuctl cryptodev 
dtraceall i

pmi "
kld_list="$kld_list if_bridge bridgestp if_tuntap hwpmc tcp_rack mfip 
ioat"
kld_list="$kld_list if_bce usb ukbd usb_quirk usb_template ums uhci xhci 
ehci oh

ci"
kld_list="$kld_list efirt nfscl nfscommon nfsd nfslockd nfssvc"
kld_list="$kld_list ataintel geom_label"
#kld_list="$kld_list geom_label"


--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106


--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106

also MINIMAL (which I INCLUDE) does have INET/INET6...

PFA MINIMAL

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106#
# MINIMAL -- Mostly Minimal kernel configuration file for FreeBSD/amd64
#
# Many definitions of minimal are possible. The one this file follows is
# GENERIC, minus all functionality that can be replaced by loading kernel
# modules.
#
# Exceptions:
# o While UFS is buildable as a module, the current module lacks
#   some features (ACL, GJOURNAL) that GENERIC includes.
# o acpi as a module has been reported flakey and not well tested, so
#   is included in the kernel.
# o (non-loaded) random is included due to uncertainty...
# o Many networking things are included
#
# For now, please run changes to these list past i...@freebsd.org
#
# For more information on this file, please read the config(5) manual page,
# and/or the handbook section on Kernel Configuration Files:
#
#
https://docs.freebsd.org/en/books/handbook/kernelconfig/#kernelconfig-config
#
# The handbook is also available locally in /usr/share/doc/handbook
# if you've installed the doc distribution, otherwise always see the
# FreeBSD World Wide Web server (https://www.FreeBSD.org/) for the
# latest information.
#
# An exhaustive list of options and more detailed explanations of the
# device lines is also present in the ../../conf/NOTES and NOTES files.
# If you are in doubt as to the purpose or necessity of a line, check first
# in NOTES.
#
# $FreeBSD$

cpu HAMMER
ident   MINIMAL

makeoptions DEBUG=-g# Build kernel with gdb(1) debug symbols
makeoptions WITH_CTF=1  # Run ctfconvert(1) for DTrace support

options SCHED_ULE   # ULE scheduler
options NUMA# Non-Uniform Memory Architecture 
support
options PREEMPTION  # Enable kernel thread preemption
options INET# InterNETworking
options INET6   # IPv6 communications protocols
options TCP_OFFLOAD # TCP offload
options SCTP_SUPPORT# Allow kldload of SCTP
options FFS # Berkeley Fast Filesystem
options SOFTUPDATES # Enable FFS soft updates support
options UFS_ACL # Support for access control lists
options UFS_DIRHASH # Improve performance on big directories
options UFS_GJOURNAL# Enable gjournal-based UFS journaling
options QUOTA   # Enable disk quotas for UFS
options MD_ROOT # MD is a potential root device
options COMPAT_FREEBSD32# Compatible with i386 binaries
options COMPAT_FREEBSD4 # Compatible with FreeBSD4
options COMPAT_

Re: Build Break?

2022-10-02 Thread Larry Rosenman 



On 10/02/2022 11:27 am, Alexander V. Chernikov wrote:


02.10.2022, 17:18, "Larry Rosenman" :

On 10/02/2022 8:12 am, Alexander V. Chernikov wrote:  On 1 Oct 2022, at 
22:57, Larry Rosenman  wrote:


--- all_subdir_nfscommon ---
Building
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o
--- all_subdir_netgraph ---
--- all_subdir_netgraph/deflate ---
Building
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc
--- all_subdir_netgraph/device ---
Building
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386
--- all_subdir_netgraph/echo ---
===> netgraph/echo (all)
--- all_subdir_netlink ---
--- netlink_io.o ---
/usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration
of function 'mtx_lock' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
NLP_LOCK(nlp);  That's interesting. netlink_io.c includes sys/mutex.h 
which defines

mutex_lock() / mutex_unlock().
Could you share the diff between GENERIC and LER-MINIMAL?


I sent the diff in another message, but here is LER-MINIMAL. Thank you!
So it's non-networking config. I'll make netlink build  conditional on 
INET || INET6 today/tomorrow.


I actually kldload a bunch of stuff.
kld_list="aesni coretemp filemon linux ichsmb ichwd cpuctl cryptodev 
dtraceall i

pmi "
kld_list="$kld_list if_bridge bridgestp if_tuntap hwpmc tcp_rack mfip 
ioat"
kld_list="$kld_list if_bce usb ukbd usb_quirk usb_template ums uhci xhci 
ehci oh

ci"
kld_list="$kld_list efirt nfscl nfscommon nfsd nfslockd nfssvc"
kld_list="$kld_list ataintel geom_label"
#kld_list="$kld_list geom_label"


--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106


--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106

Meta Mode (was: Re: BOOT CRASH -- Current -CURRENT)

2022-10-02 Thread Cy Schubert 
In message 
, Warner Losh writes:
> --65ac9c05ea048b2a
> Content-Type: text/plain; charset="UTF-8"
> Content-Transfer-Encoding: quoted-printable
>
> On Sat, Oct 1, 2022 at 9:06 PM Larry Rosenman  wrote:
>
> > On 10/01/2022 10:04 pm, Warner Losh wrote:
> >
> > Do  you have a /boot tarball that can be loaded in a VM that recreates th=
> e
> > problem (along with a clean hash)?
> >
> > But before you try that, have you tried a completely clean rebuild of the
> > kernel to preclude the possibility that something is somehow cross thread=
> ed?
> >
> > Warner
> >
> > On Sat, Oct 1, 2022 at 8:39 PM Larry Rosenman  wrote:
> >
> >
> > =E2=9D=AF more info.11
> > Dump header from device: /dev/mfid0p3
> >Architecture: amd64
> >Architecture Version: 2
> >Dump Length: 126748815
> >Blocksize: 512
> >Compression: zstd
> >Dumptime: 2022-10-01 21:26:40 -0500
> >Hostname:
> >Magic: FreeBSD Kernel Dump
> >Version String: FreeBSD 14.0-CURRENT #168
> > ler/freebsd-main-changes-n258354-6cdd871ebc4: Sat Oct  1 21:13:01 CDT
> > 2022
> >  r...@borg.lerctr.org:/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL
> >Panic String: page fault
> >Dump Parity: 501115454
> >Bounds: 11
> >Dump Status: good
> >
> > I do have source and debug stuff, BUT kgdb croaks on me.
> >
> > I *CAN* give access to the machine.
> >
> > the console backtrace showed something about the kld load of
> > dependencies.
> >
> >
> >
> > --
> > Larry Rosenman http://people.freebsd.org/~ler
> > Phone: +1 214-642-9640 E-Mail: l...@freebsd.org
> > US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
> >
> > let me wipe /usr/obj, and rebuild everything (I *DO* use meta-mode).
> >
>
> I've had fewer problems with it than non-meta mode, but this looks like a
> 'corruption' or 'cross threaded' crash I've chased in the past that went
> away with a rebuild. So it's better to be sure...

I think so too. What may appear to be a gratuitous rebuild of llvm, for 
example, is in fact meta mode rebuilding because of some makefile change. 
Without meta mode I've experienced odd weirdnesses that are fixed through a 
subsequent clean build.

I just started using meta mode again this week after a few years hiatus to 
see if it addresses the occasional weird behaviour due to something not 
being rebuilt when it should have been.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX: Web:  http://www.FreeBSD.org
NTP:   Web:  https://nwtime.org

e^(i*pi)+1=0

Re: Build Break?

2022-10-02 Thread Alexander V . Chernikov 
02.10.2022, 17:18, "Larry Rosenman" :On 10/02/2022 8:12 am, Alexander V. Chernikov wrote: On 1 Oct 2022, at 22:57, Larry Rosenman  wrote:  --- all_subdir_nfscommon --- Building  /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o --- all_subdir_netgraph --- --- all_subdir_netgraph/deflate --- Building  /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc --- all_subdir_netgraph/device --- Building  /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386 --- all_subdir_netgraph/echo --- ===> netgraph/echo (all) --- all_subdir_netlink --- --- netlink_io.o --- /usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration  of function 'mtx_lock' is invalid in C99  [-Werror,-Wimplicit-function-declaration]NLP_LOCK(nlp); That’s interesting. netlink_io.c includes sys/mutex.h which defines  mutex_lock() / mutex_unlock().  Could you share the diff between GENERIC and LER-MINIMAL? I sent the diff in another message, but here is LER-MINIMAL.Thank you!So it’s non-networking config. I’ll make netlink build  conditional on INET || INET6 today/tomorrow.-- Larry Rosenman http://www.lerctr.org/~lerPhone: +1 214-642-9640 E-Mail: l...@lerctr.orgUS Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106

Re: Build Break?

2022-10-02 Thread Larry Rosenman 

On 10/02/2022 8:12 am, Alexander V. Chernikov wrote:

On 1 Oct 2022, at 22:57, Larry Rosenman  wrote:

--- all_subdir_nfscommon ---
Building 
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o

--- all_subdir_netgraph ---
--- all_subdir_netgraph/deflate ---
Building 
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc

--- all_subdir_netgraph/device ---
Building 
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386

--- all_subdir_netgraph/echo ---
===> netgraph/echo (all)
--- all_subdir_netlink ---
--- netlink_io.o ---
/usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration 
of function 'mtx_lock' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]

   NLP_LOCK(nlp);
That’s interesting. netlink_io.c includes sys/mutex.h which defines 
mutex_lock() / mutex_unlock().

 Could you share the diff between GENERIC and LER-MINIMAL?


I sent the diff in another message, but here is LER-MINIMAL.

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
# LER-MINIMAL  -- kernel config based on MINIMAL

include MINIMAL
ident   LER-MINIMAL

nooptions   WITNESS # Enable checks to detect deadlocks and 
cycles
nooptions   WITNESS_SKIPSPIN# Don't run witness on spinlocks for 
speed
options KDB_UNATTENDED
#optionsDEBUG_MEMGUARD
#optionsDEBUG_REDZONE
makeoptions WITH_EXTRA_TCP_STACKS=1
options TCPHPTS
device  mfi
options TCP_RFC7413
# Kernel dump features.
options EKCD# Support for encrypted kernel dumps
options GZIO# gzip-compressed kernel and user dumps
options ZSTDIO  # zstd-compressed kernel and user dumps
options NETDUMP # netdump(4) client support
# ipsec support
options IPSEC_SUPPORT
device  crypto

#netgraph debug
options NETGRAPH_DEBUG

#tcp ratelimit
options RATELIMIT

## INVARIANTS
options INVARIANT_SUPPORT
#optionsINVARIANTS

Re: Build Break?

2022-10-02 Thread Larry Rosenman 

On 10/02/2022 8:12 am, Alexander V. Chernikov wrote:

On 1 Oct 2022, at 22:57, Larry Rosenman  wrote:

--- all_subdir_nfscommon ---
Building 
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o

--- all_subdir_netgraph ---
--- all_subdir_netgraph/deflate ---
Building 
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc

--- all_subdir_netgraph/device ---
Building 
/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386

--- all_subdir_netgraph/echo ---
===> netgraph/echo (all)
--- all_subdir_netlink ---
--- netlink_io.o ---
/usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration 
of function 'mtx_lock' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]

   NLP_LOCK(nlp);
That’s interesting. netlink_io.c includes sys/mutex.h which defines 
mutex_lock() / mutex_unlock().

 Could you share the diff between GENERIC and LER-MINIMAL?


attached.

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
--- GENERIC	2022-08-18 14:44:35.576844000 -0500
+++ LER-MINIMAL	2022-10-02 10:46:41.308926000 -0500
@@ -1,401 +1,32 @@
-#
-# GENERIC -- Generic kernel configuration file for FreeBSD/amd64
-#
-# For more information on this file, please read the config(5) manual page,
-# and/or the handbook section on Kernel Configuration Files:
-#
-#https://docs.freebsd.org/en/books/handbook/kernelconfig/#kernelconfig-config
-#
-# The handbook is also available locally in /usr/share/doc/handbook
-# if you've installed the doc distribution, otherwise always see the
-# FreeBSD World Wide Web server (https://www.FreeBSD.org/) for the
-# latest information.
-#
-# An exhaustive list of options and more detailed explanations of the
-# device lines is also present in the ../../conf/NOTES and NOTES files.
-# If you are in doubt as to the purpose or necessity of a line, check first
-# in NOTES.
-#
-# $FreeBSD$
+# LER-MINIMAL  -- kernel config based on MINIMAL
 
-cpu		HAMMER
-ident		GENERIC
+include		MINIMAL
+ident		LER-MINIMAL
 
-makeoptions	DEBUG=-g		# Build kernel with gdb(1) debug symbols
-makeoptions	WITH_CTF=1		# Run ctfconvert(1) for DTrace support
-
-options 	SCHED_ULE		# ULE scheduler
-options 	NUMA			# Non-Uniform Memory Architecture support
-options 	PREEMPTION		# Enable kernel thread preemption
-options 	VIMAGE			# Subsystem virtualization, e.g. VNET
-options 	INET			# InterNETworking
-options 	INET6			# IPv6 communications protocols
-options 	IPSEC_SUPPORT		# Allow kldload of ipsec and tcpmd5
-options		ROUTE_MPATH		# Multipath routing support
-options		FIB_ALGO		# Modular fib lookups
-options 	TCP_OFFLOAD		# TCP offload
-options 	TCP_BLACKBOX		# Enhanced TCP event logging
-options 	TCP_HHOOK		# hhook(9) framework for TCP
-options		TCP_RFC7413		# TCP Fast Open
-options 	SCTP_SUPPORT		# Allow kldload of SCTP
-options		KERN_TLS		# TLS transmit & receive offload
-options 	FFS			# Berkeley Fast Filesystem
-options 	SOFTUPDATES		# Enable FFS soft updates support
-options 	UFS_ACL			# Support for access control lists
-options 	UFS_DIRHASH		# Improve performance on big directories
-options 	UFS_GJOURNAL		# Enable gjournal-based UFS journaling
-options 	QUOTA			# Enable disk quotas for UFS
-options 	MD_ROOT			# MD is a potential root device
-options 	NFSCL			# Network Filesystem Client
-options 	NFSD			# Network Filesystem Server
-options 	NFSLOCKD		# Network Lock Manager
-options 	NFS_ROOT		# NFS usable as /, requires NFSCL
-options 	MSDOSFS			# MSDOS Filesystem
-options 	CD9660			# ISO 9660 Filesystem
-options 	PROCFS			# Process filesystem (requires PSEUDOFS)
-options 	PSEUDOFS		# Pseudo-filesystem framework
-options 	TMPFS			# Efficient memory filesystem
-options 	GEOM_RAID		# Soft RAID functionality.
-options 	GEOM_LABEL		# Provides labelization
-options 	EFIRT			# EFI Runtime Services support
-options 	COMPAT_FREEBSD32	# Compatible with i386 binaries
-options 	COMPAT_FREEBSD4		# Compatible with FreeBSD4
-options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
-options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
-options 	COMPAT_FREEBSD7		# Compatible with FreeBSD7
-options 	COMPAT_FREEBSD9		# Compatible with FreeBSD9
-options 	COMPAT_FREEBSD10	# Compatible with FreeBSD10
-options 	COMPAT_FREEBSD11	# Compatible with FreeBSD11
-options 	COMPAT_FREEBSD12	# Compatible with FreeBSD12
-options 	COMPAT_FREEBSD13	# Compatible with FreeBSD13
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
-options 	KTRACE			# ktrace(1) support
-options 	STACK			# stack(9) support
-options 	SYSVSHM			# SYSV-style shared memory
-options 	SYSVMSG			# SYSV-style message queues
-options 	SYSVSEM			# SYSV-style semaphores
-options 	_KPOSIX_PRIORITY_SCHEDULING # POSIX P1003_1B real-time extensions
-options 	PRINTF_BUFR_SIZE=128	# Prevent printf output being intersper

Re: Build Break?

2022-10-02 Thread Alexander V. Chernikov 



> On 1 Oct 2022, at 22:57, Larry Rosenman  wrote:
> 
> --- all_subdir_nfscommon ---
> Building 
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o
> --- all_subdir_netgraph ---
> --- all_subdir_netgraph/deflate ---
> Building 
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc
> --- all_subdir_netgraph/device ---
> Building 
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386
> --- all_subdir_netgraph/echo ---
> ===> netgraph/echo (all)
> --- all_subdir_netlink ---
> --- netlink_io.o ---
> /usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration of 
> function 'mtx_lock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>NLP_LOCK(nlp);
That’s interesting. netlink_io.c includes sys/mutex.h which defines 
mutex_lock() / mutex_unlock().
 Could you share the diff between GENERIC and LER-MINIMAL?

>^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp)  mtx_lock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:159:2: error: implicit declaration of 
> function 'mtx_unlock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>NLP_UNLOCK(nlp);
>^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro 
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)mtx_unlock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:159:2: note: did you mean 'mtx_lock'?
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro 
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)mtx_unlock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:146:2: note: 'mtx_lock' declared here
>NLP_LOCK(nlp);
>^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp)  mtx_lock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:177:2: error: implicit declaration of 
> function 'mtx_lock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>SOCKBUF_LOCK(sb);
>^
> /usr/src/sys/sys/sockbuf.h:187:28: note: expanded from macro 'SOCKBUF_LOCK'
> #define SOCKBUF_LOCK(_sb)   mtx_lock(SOCKBUF_MTX(_sb))
>^
> /usr/src/sys/netlink/netlink_io.c:189:2: error: implicit declaration of 
> function 'mtx_unlock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>SOCKBUF_UNLOCK(sb);
>^
> /usr/src/sys/sys/sockbuf.h:189:30: note: expanded from macro 'SOCKBUF_UNLOCK'
> #define SOCKBUF_UNLOCK(_sb) mtx_unlock(SOCKBUF_MTX(_sb))
>^
> /usr/src/sys/netlink/netlink_io.c:202:2: error: implicit declaration of 
> function 'mtx_lock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>NLP_LOCK(nlp);
>^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp)  mtx_lock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:207:3: error: implicit declaration of 
> function 'mtx_unlock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>NLP_UNLOCK(nlp);
>^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro 
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)mtx_unlock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:225:3: error: implicit declaration of 
> function 'mtx_unlock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>SOCKBUF_UNLOCK(sb);
>^
> /usr/src/sys/sys/sockbuf.h:189:30: note: expanded from macro 'SOCKBUF_UNLOCK'
> #define SOCKBUF_UNLOCK(_sb) mtx_unlock(SOCKBUF_MTX(_sb))
>^
> /usr/src/sys/netlink/netlink_io.c:232:2: error: implicit declaration of 
> function 'mtx_unlock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>NLP_UNLOCK(nlp);
>^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro 
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp)mtx_unlock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:281:2: error: implicit declaration of 
> function 'mtx_lock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>NLP_LOCK(nlp);
>^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp)  mtx_lock(&((_nlp)->nl_lock))
>^
> /usr/src/sys/netlink/netlink_io.c:299:2: error: implicit declaration of 
> function 'mtx_unlock' is invalid in C99 
> [-Werror,-Wimplicit-function-declaratio