Re: Missing ktls_ocf.ko

2023-02-16 Thread Gordon Bergling
Hi Rick,

On Thu, Feb 16, 2023 at 05:49:02AM -0800, Rick Macklem wrote:
> On Thu, Feb 16, 2023 at 12:15 AM Gordon Bergling  wrote:
> >
> > Hi,
> >
> > I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very
> > recent -CURRENT there is no such kernel module present.
> >
> > Has there anything changed in -CURRENT about this kernel module?
> 
> I don't think the module exists or is needed any more, but jhb@ can confirm
> this.  Sounds like a man page update is needed and that's your specialty.
>

I had the same thought but actually the documentation is already correct,
I just looked at the 13-STABLE man page not on the -CURRENT one.

> >
> > On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel.

--Gordon


signature.asc
Description: PGP signature


Re: Missing ktls_ocf.ko

2023-02-16 Thread Rick Macklem
On Thu, Feb 16, 2023 at 12:15 AM Gordon Bergling  wrote:
>
> Hi,
>
> I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very
> recent -CURRENT there is no such kernel module present.
>
> Has there anything changed in -CURRENT about this kernel module?

I don't think the module exists or is needed any more, but jhb@ can confirm
this.  Sounds like a man page update is needed and that's your specialty.

rick

>
> On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel.
>
> --Gordon



Re: Missing ktls_ocf.ko

2023-02-16 Thread Gordon Bergling
Hi Herbert,

On Thu, Feb 16, 2023 at 09:37:14AM +0100, Herbert J. Skuhra wrote:
> On Thu, Feb 16, 2023 at 09:15:04AM +0100, Gordon Bergling wrote:
> > Hi,
> > 
> > I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very
> > recent -CURRENT there is no such kernel module present.
> > 
> > Has there anything changed in -CURRENT about this kernel module?
> > 
> > On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel.
> 
> commit 21e3c1fbe2460f144f6d4dfd61c3346b2de59667
> Author: John Baldwin
> Date:   Tue May 25 16:59:19 2021 -0700
> 
> Assume OCF is the only KTLS software backend.
> 
> This removes support for loadable software backends.  The KTLS OCF
> support is now always included in kernels with KERN_TLS and the
> ktls_ocf.ko module has been removed.  The software encryption routines
> now take an mbuf directly and use the TLS mbuf as the crypto buffer
> when possible.
> 
> Bump __FreeBSD_version for software backends in ports.
> 
> Reviewed by:gallatin, markj
> Sponsored by:   Netflix
> Differential Revision:  https://reviews.freebsd.org/D30138
> 
> 
> Does this answer your question?

Thanks for pointing me to this commit. This answers my question and I will
update the manual page for 14-CURRENT so that the documentation is matching
the state for 14-CURRENT.

--Gordon


signature.asc
Description: PGP signature


Re: Missing ktls_ocf.ko

2023-02-16 Thread Herbert J. Skuhra
On Thu, Feb 16, 2023 at 09:15:04AM +0100, Gordon Bergling wrote:
> Hi,
> 
> I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very
> recent -CURRENT there is no such kernel module present.
> 
> Has there anything changed in -CURRENT about this kernel module?
> 
> On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel.

commit 21e3c1fbe2460f144f6d4dfd61c3346b2de59667
Author: John Baldwin
Date:   Tue May 25 16:59:19 2021 -0700

Assume OCF is the only KTLS software backend.

This removes support for loadable software backends.  The KTLS OCF
support is now always included in kernels with KERN_TLS and the
ktls_ocf.ko module has been removed.  The software encryption routines
now take an mbuf directly and use the TLS mbuf as the crypto buffer
when possible.

Bump __FreeBSD_version for software backends in ports.

Reviewed by:gallatin, markj
Sponsored by:   Netflix
Differential Revision:  https://reviews.freebsd.org/D30138


Does this answer your question?

--
Herbert



Re: Build breakage with WITH_BEARSSL=1

2023-02-16 Thread Mina Galić


--- Original Message ---
On Thursday, February 16th, 2023 at 08:30, Stephane Rochoy 
 wrote:


> Warner Losh i...@bsdimp.com writes:
> 
> > On Wed, Feb 15, 2023, 1:09 PM Mina Galić free...@igalic.co
> > wrote:
> > 
> > > Would be nice if we could get upstream to actually fix this,
> > > but i don't even know how to submit bugs there…
> > 
> > Agreed. I didn't recall off of the top of my head, so I did the
> > quick bandaid.
> 
> 
> Hi,
> 
> It may be worth contacting BearSSL's maintainer directly: Thomas
> Pornin por...@bolet.org. The guy was very responsive and helpful
> 
> back in 2020 :)
> 
> Regards,
> --
> Stéphane Rochoy
> O: Stormshield

after re-reading https://bearssl.org/contrib.html
that's exactly what it says to do:

"Suggestions, comments, patches and other contributions are welcome. They 
should simply be sent to me (por...@bolet.org) by email."

(reading is hard)




Re: Build breakage with WITH_BEARSSL=1

2023-02-16 Thread Stephane Rochoy



Warner Losh  writes:


On Wed, Feb 15, 2023, 1:09 PM Mina Galić 
wrote:


Would be nice if we could get upstream to actually fix this,
but i don't even know how to submit bugs there…



Agreed. I didn't recall off of the top of my head, so I did the
quick bandaid.


Hi,

It may be worth contacting BearSSL's maintainer directly: Thomas
Pornin . The guy was very responsive and helpful
back in 2020 :)

Regards,
--
Stéphane Rochoy
O: Stormshield



Missing ktls_ocf.ko

2023-02-16 Thread Gordon Bergling
Hi,

I recently tried to load ktls_ocf.ko as stated in ktls(4), but on a very
recent -CURRENT there is no such kernel module present.

Has there anything changed in -CURRENT about this kernel module?

On 13-STABLE and 13.1-RELEASE I find the module in /boot/kernel.

--Gordon


signature.asc
Description: PGP signature