zfs autotrim default to off now

[Pete Wright]

looking at a recent pull of CURRENT i'm noticing this in the git logs:

#15079 set autotrim default to 'off' everywhere

which references this openzfs PR:
https://github.com/openzfs/zfs/pull/15079


looking at the PR i'm not seeing a reference to a bug report or anything, is
anyone able to point me to a bug report for this.  it seems like a pretty major
issue:
"As it turns out having autotrim default to 'on' on FreeBSD never really worked
due to mess with defines where userland and kernel module were getting different
default values (userland was defaulting to 'off', module was thinking it's 
'on')."

i'd just like to make sure i better understand the issue and can see if my
systems are impacted.

thanks!
-pete

-- 
Pete Wright
p...@nomadlogic.org

Re: Question about KBI change / new feature

[Zhenlei Huang]

> On Aug 23, 2023, at 1:06 AM, Warner Losh  wrote:
> 
> 
> 
> On Mon, Aug 21, 2023 at 9:42 AM Zhenlei Huang  > wrote:
> Hi,
> 
> The https://www.freebsd.org/releases/14.0R/schedule/ 
>  says CURRENT/14 's KBI is 
> froze
> and new features should be avoided.
> 
> I'm working on https://reviews.freebsd.org/D39638 
>  (sysctl(9): Enable vnet sysctl variables 
> be loader tunable)
> and I think it is new feature, but not quite sure whether the KBI changed.
> 
> So,
> 
> 1. Is it a KBI change ?
> 
> IMHO, It's a KPI change, not a KBI breakage. So from that perspective, it's 
> OK.

Thanks for the explanation !

>  
> 2. It is a simple change ( while so far as I know currently only tested by 
> myself on x86 and qemu riscv ), can
> it catch up with 14 ?
> 
> That I'm less sure of. I think it's good, but I'm gun shy about approving / 
> committing vnet things. The review suggests,
> though, there's at least some consensus for having this in the tree.

I always hesitate to PING someone to review ;)

Well I'm going to prepare to commit some of the stack, D41525, D39638, D39852, 
D39866, if no objections.

As for D40127, I have mixed filling about it. It might be too complex (for a 
simple function).
I wonder if we can have per-vnet `loader tunnable` to archive the same goal.

Best regards,
Zhenlei

Re: Possible issue with linux xattr support?

[Cy Schubert]

On August 27, 2023 12:55:23 PM PDT, Felix Palmen  wrote:
>* Dmitry Chagin  [20230827 22:46]:
>> On Sun, Aug 27, 2023 at 07:59:32PM +0200, Felix Palmen wrote:
>> > * Dmitry Chagin  [20230827 20:54]:
>> > > 1. which fs are you using?
>> > 
>> > ZFS.
>> > 
>> > > 2. jailed?
>> > 
>> > Yes, this is during building ports with poudriere.
>> > 
>> 
>> I think it's a weird prohibition on changing system namespace extattr
>> attributes, look to comments in extattr_check_cred()
>
>Maybe that's when I should finally start trying to understand the stuff
>in src.git ;)
>
>> I can fix this completely disabling exttatr for jailed proc,
>> however, it's gonna be bullshit, though
>
>Would probably be better than nothing. AFAIK, "Linux jails" are used a
>lot, probably with userlands from distributions actually using xattr.
>
>Cheers, Felix
>

If we are to break it to fix a problem, maybe a sysctl to enable/disable then?


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:Web:  https://FreeBSD.org
NTP: Web:  https://nwtime.org
e^(i*pi)+1=0

Pardon the typos. Small keyboard in use.

Re: Possible issue with linux xattr support?

[Felix Palmen]

* Dmitry Chagin  [20230827 22:46]:
> On Sun, Aug 27, 2023 at 07:59:32PM +0200, Felix Palmen wrote:
> > * Dmitry Chagin  [20230827 20:54]:
> > > 1. which fs are you using?
> > 
> > ZFS.
> > 
> > > 2. jailed?
> > 
> > Yes, this is during building ports with poudriere.
> > 
> 
> I think it's a weird prohibition on changing system namespace extattr
> attributes, look to comments in extattr_check_cred()

Maybe that's when I should finally start trying to understand the stuff
in src.git ;)

> I can fix this completely disabling exttatr for jailed proc,
> however, it's gonna be bullshit, though

Would probably be better than nothing. AFAIK, "Linux jails" are used a
lot, probably with userlands from distributions actually using xattr.

Cheers, Felix

-- 
 Felix Palmen  {private}   fe...@palmen-it.de
 -- ports committer -- {web}  http://palmen-it.de
 {pgp public key}  http://palmen-it.de/pub.txt
 {pgp fingerprint} 6936 13D5 5BBF 4837 B212  3ACC 54AD E006 9879 F231


signature.asc
Description: PGP signature

Re: Possible issue with linux xattr support?

[Dmitry Chagin]

On Sun, Aug 27, 2023 at 07:59:32PM +0200, Felix Palmen wrote:
> * Dmitry Chagin  [20230827 20:54]:
> > 1. which fs are you using?
> 
> ZFS.
> 
> > 2. jailed?
> 
> Yes, this is during building ports with poudriere.
> 

I think it's a weird prohibition on changing system namespace extattr
attributes, look to comments in extattr_check_cred()
I can fix this completely disabling exttatr for jailed proc,
however, it's gonna be bullshit, though



> Cheers, Felix
> 
> -- 
>  Felix Palmen  {private}   fe...@palmen-it.de
>  -- ports committer -- {web}  http://palmen-it.de
>  {pgp public key}  http://palmen-it.de/pub.txt
>  {pgp fingerprint} 6936 13D5 5BBF 4837 B212  3ACC 54AD E006 9879 F231

Re: Possible issue with linux xattr support?

[Felix Palmen]

* Dmitry Chagin  [20230827 20:54]:
> 1. which fs are you using?

ZFS.

> 2. jailed?

Yes, this is during building ports with poudriere.

Cheers, Felix

-- 
 Felix Palmen  {private}   fe...@palmen-it.de
 -- ports committer -- {web}  http://palmen-it.de
 {pgp public key}  http://palmen-it.de/pub.txt
 {pgp fingerprint} 6936 13D5 5BBF 4837 B212  3ACC 54AD E006 9879 F231


signature.asc
Description: PGP signature

Re: Possible issue with linux xattr support?

[Dmitry Chagin]

On Sun, Aug 27, 2023 at 07:15:57PM +0200, Felix Palmen wrote:
> * Felix Palmen  [20230825 19:54]:
> > To verify, I removed xattr support completely from coreutils (and also
> > sed) in commit "linuxsrc: Disable usage of xattr" and indeed, with this
> > change, GNU's install works as it should.
> 
> I now ran into a second case which makes it very likely the xattr
> support is indeed the problem. Trying to create a port for python
> setuptools, calling "setup.py install" with debugging opened showed me
> this error:
> 
> #v+
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/command/install.py",
>  line 706, in run
> self.run_command(cmd_name)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/cmd.py",
>  line 317, in run_command
> self.distribution.run_command(command)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/dist.py",
>  line 1217, in run_command
> super().run_command(command)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/dist.py",
>  line 987, in run_command
> cmd_obj.run()
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/command/install_egg_info.py",
>  line 42, in run
> self.execute(
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/cmd.py",
>  line 338, in execute
> util.execute(func, args, msg, dry_run=self.dry_run)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/util.py",
>  line 344, in execute
> func(*args)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/command/install_egg_info.py",
>  line 63, in copytree
> unpack_archive(self.source, self.target, skimmer)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/archive_util.py",
>  line 53, in unpack_archive
> driver(filename, extract_dir, progress_filter)
>   File 
> "/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/archive_util.py",
>  line 88, in unpack_directory
> shutil.copystat(f, target)
>   File "/usr/lib64/python3.11/shutil.py", line 380, in copystat
> _copyxattr(src, dst, follow_symlinks=follow)
>   File "/usr/lib64/python3.11/shutil.py", line 322, in _copyxattr
> names = os.listxattr(src, follow_symlinks=follow_symlinks)
> ^^
> PermissionError: [Errno 1] Operation not permitted: 
> 'setuptools.egg-info/top_level.txt'
> #v-
> 
> I then rebuilt python passing "ac_cv_header_sys_xattr_h=no" to its
> configure script, so it thinks there is no sys/xattr.h header. Indeed,
> this made the problem installing setuptools go away.
> 
> Cheers, Felix

Hi,

1. which fs are you using?
2. jailed?




> 
> -- 
>  Felix Palmen  {private}   fe...@palmen-it.de
>  -- ports committer -- {web}  http://palmen-it.de
>  {pgp public key}  http://palmen-it.de/pub.txt
>  {pgp fingerprint} 6936 13D5 5BBF 4837 B212  3ACC 54AD E006 9879 F231

etcupdate -p, and other uses of etcupdate(8) (was: Has the update procedure changed?)

[Graham Perrin]

On 07/08/2023 16:51, Kevin Oberman wrote:
UPDATING seems to match the Makefile except that Makefile is far less 
detailed. The Makefile even says "See src/UPDATING `COMMON ITEMS' for 
more complete information."


…  "etcupdate -p". …


 prompted me to 
look at 
. 



Is this fortune-provided tip outdated?

Re: Possible issue with linux xattr support?

[Felix Palmen]

* Felix Palmen  [20230825 19:54]:
> To verify, I removed xattr support completely from coreutils (and also
> sed) in commit "linuxsrc: Disable usage of xattr" and indeed, with this
> change, GNU's install works as it should.

I now ran into a second case which makes it very likely the xattr
support is indeed the problem. Trying to create a port for python
setuptools, calling "setup.py install" with debugging opened showed me
this error:

#v+
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/command/install.py",
 line 706, in run
self.run_command(cmd_name)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/cmd.py",
 line 317, in run_command
self.distribution.run_command(command)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/dist.py",
 line 1217, in run_command
super().run_command(command)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/dist.py",
 line 987, in run_command
cmd_obj.run()
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/command/install_egg_info.py",
 line 42, in run
self.execute(
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/cmd.py",
 line 338, in execute
util.execute(func, args, msg, dry_run=self.dry_run)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/_distutils/util.py",
 line 344, in execute
func(*args)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/command/install_egg_info.py",
 line 63, in copytree
unpack_archive(self.source, self.target, skimmer)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/archive_util.py",
 line 53, in unpack_archive
driver(filename, extract_dir, progress_filter)
  File 
"/wrkdirs/usr/ports/devel/linuxsrc-setuptools/work/setuptools-63.1.0/setuptools/archive_util.py",
 line 88, in unpack_directory
shutil.copystat(f, target)
  File "/usr/lib64/python3.11/shutil.py", line 380, in copystat
_copyxattr(src, dst, follow_symlinks=follow)
  File "/usr/lib64/python3.11/shutil.py", line 322, in _copyxattr
names = os.listxattr(src, follow_symlinks=follow_symlinks)
^^
PermissionError: [Errno 1] Operation not permitted: 
'setuptools.egg-info/top_level.txt'
#v-

I then rebuilt python passing "ac_cv_header_sys_xattr_h=no" to its
configure script, so it thinks there is no sys/xattr.h header. Indeed,
this made the problem installing setuptools go away.

Cheers, Felix

-- 
 Felix Palmen  {private}   fe...@palmen-it.de
 -- ports committer -- {web}  http://palmen-it.de
 {pgp public key}  http://palmen-it.de/pub.txt
 {pgp fingerprint} 6936 13D5 5BBF 4837 B212  3ACC 54AD E006 9879 F231


signature.asc
Description: PGP signature