Re: [CFT] Add -Wbounded to gcc
On 2012-07-11 05:41, Pedro Giffuni wrote: I have a patch from OpenBSD that adds -Wbounded to gcc: http://people.freebsd.org/~pfg/patches/patch-gcc-bounded Unfortunately it breaks world, or at least binutils, at this time: _ ... cc1: warnings being treated as errors peigen.c: In function '_bfd_pei_swap_aux_in': peigen.c:241: warning: array size (14) smaller than bound length (18) peigen.c:241: warning: array size (14) smaller than bound length (18) peigen.c: In function '_bfd_pei_swap_aux_out': peigen.c:314: warning: array size (14) smaller than bound length (18) peigen.c:314: warning: array size (14) smaller than bound length (18) *** Error code 1 Stop in /usr/src/gnu/usr.bin/binutils/libbfd. *** Error code 1 Stop in /usr/src/gnu/usr.bin/binutils. ___ OpenBSD has a fix but before attempting to clean this, and whatever else would break, I can't help but ask: is it worth it? Does it catch any really interesting bound overruns? If the number of false positives is very large, then it generally isn't worth the pain. Or the option should be turned off by default, and only enabled for WARNS=some_arbitrary_high_number. That said, fixing binutils (and particularly libbfd, which is what you are seeing here) is rather hopeless, it should be compiled with a low WARNS= setting anyway. :) ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [CFT] Add -Wbounded to gcc
--- Mer 11/7/12, Dimitry Andric d...@freebsd.org ha scritto: ... Does it catch any really interesting bound overruns? Nah .. I arrived to the conclusion that it's not really worth it :). If the number of false positives is very large, then it generally isn't worth the pain. Or the option should be turned off by default, and only enabled for WARNS=some_arbitrary_high_number. It is nice to have but I don't think we should turn it on for any level. I will have to look at how to do that. Thanks, Pedro. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
[CFT] Add -Wbounded to gcc
Hello; I have a patch from OpenBSD that adds -Wbounded to gcc: http://people.freebsd.org/~pfg/patches/patch-gcc-bounded Unfortunately it breaks world, or at least binutils, at this time: _ ... cc1: warnings being treated as errors peigen.c: In function '_bfd_pei_swap_aux_in': peigen.c:241: warning: array size (14) smaller than bound length (18) peigen.c:241: warning: array size (14) smaller than bound length (18) peigen.c: In function '_bfd_pei_swap_aux_out': peigen.c:314: warning: array size (14) smaller than bound length (18) peigen.c:314: warning: array size (14) smaller than bound length (18) *** Error code 1 Stop in /usr/src/gnu/usr.bin/binutils/libbfd. *** Error code 1 Stop in /usr/src/gnu/usr.bin/binutils. ___ OpenBSD has a fix but before attempting to clean this, and whatever else would break, I can't help but ask: is it worth it? best regards, Pedro. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [CFT] Add -Wbounded to gcc
On Tue, Jul 10, 2012 at 10:41:44PM -0500, Pedro Giffuni wrote: I have a patch from OpenBSD that adds -Wbounded to gcc: http://people.freebsd.org/~pfg/patches/patch-gcc-bounded Unfortunately it breaks world, or at least binutils, at this time: _ ... cc1: warnings being treated as errors peigen.c: In function '_bfd_pei_swap_aux_in': peigen.c:241: warning: array size (14) smaller than bound length (18) peigen.c:241: warning: array size (14) smaller than bound length (18) peigen.c: In function '_bfd_pei_swap_aux_out': peigen.c:314: warning: array size (14) smaller than bound length (18) peigen.c:314: warning: array size (14) smaller than bound length (18) *** Error code 1 Stop in /usr/src/gnu/usr.bin/binutils/libbfd. *** Error code 1 Stop in /usr/src/gnu/usr.bin/binutils. ___ OpenBSD has a fix but before attempting to clean this, and whatever else would break, I can't help but ask: is it worth it? IMHO, no. -- Steve ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
