Re: [PATCH] if_ar and if_sr compile problem
Maksim Yevmenkin [EMAIL PROTECTED] wrote: it looks like if_ar and if_sr modules will not compile unless you have enabled NETGRAPH. patches are simple and attached. Sorry for the breakage, yes. #include sys/syslog.h #include dev/ar/if_ar.h #else /* NETGRAPH */ +#include netinet/in.h +#include netinet/in_systm.h +#include netinet/ip.h +#include net/slcompress.h I'll probably solve it differently so no low-level driver needs to include all those header files. -- cheers, Jorg .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
[PATCH] if_ar and if_sr compile problem
Hackers, it looks like if_ar and if_sr modules will not compile unless you have enabled NETGRAPH. patches are simple and attached. thanks, max p.s. i'm trying today's -current. --- if_ar.c.origThu Dec 27 16:25:55 2001 +++ if_ar.c Thu Dec 27 15:44:19 2001 @@ -69,6 +69,10 @@ #include sys/syslog.h #include dev/ar/if_ar.h #else /* NETGRAPH */ +#include netinet/in.h +#include netinet/in_systm.h +#include netinet/ip.h +#include net/slcompress.h #include net/if_sppp.h #include net/bpf.h #endif /* NETGRAPH */ --- if_sr.c.origThu Dec 27 16:26:57 2001 +++ if_sr.c Thu Dec 27 16:09:33 2001 @@ -70,6 +70,10 @@ #ifdef NETGRAPH #include sys/syslog.h #else /* NETGRAPH */ +#include netinet/in.h +#include netinet/in_systm.h +#include netinet/ip.h +#include net/slcompress.h #include net/if_sppp.h #include net/bpf.h
Re: [PATCH] if_ar and if_sr compile problem
there are SEPARATE modules for the netgraph versions ng_sr and ng_ar, compiled from the same sources.. ng_sync_sr and ng_sync_ar are specifically for the non-netgraph versions. -r-xr-xr-x 1 root wheel 26500 Nov 7 00:08 /boot/kernel/ng_sync_ar.ko -r-xr-xr-x 1 root wheel 28523 Nov 7 00:08 /boot/kernel/ng_sync_sr.ko compiled from /sys/modules/netgraph/sync_sr and sync_ar you need to find what is broken in the NON netgraph case.. On Thu, 27 Dec 2001, Maksim Yevmenkin wrote: Hackers, it looks like if_ar and if_sr modules will not compile unless you have enabled NETGRAPH. patches are simple and attached. thanks, max p.s. i'm trying today's -current. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [PATCH] if_ar and if_sr compile problem
Julian Elischer wrote: there are SEPARATE modules for the netgraph versions ng_sr and ng_ar, compiled from the same sources.. ng_sync_sr and ng_sync_ar are specifically for the non-netgraph versions. -r-xr-xr-x 1 root wheel 26500 Nov 7 00:08 /boot/kernel/ng_sync_ar.ko -r-xr-xr-x 1 root wheel 28523 Nov 7 00:08 /boot/kernel/ng_sync_sr.ko compiled from /sys/modules/netgraph/sync_sr and sync_ar you need to find what is broken in the NON netgraph case.. [...] it looks like if_ar and if_sr modules will not compile unless you have enabled NETGRAPH. patches are simple and attached. ok, i'm sorry :) i said it wrong. what i meant to say is that there are also non-NETGRAPH modules called if_ar and if_sr and these two will not compile, because of missing headers. thanks, max To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [PATCH] if_ar and if_sr compile problem
Hi Max, You are right about the problem and I guess the fix is one way to do it. I would prefer that if_sppp.h does not require device drivers to suddenly need to include network include files, so I have asked Joerg about it. Julian Elischer wrote: there are SEPARATE modules for the netgraph versions ng_sr and ng_ar, compiled from the same sources.. ng_sync_sr and ng_sync_ar are specifically for the non-netgraph versions. -r-xr-xr-x 1 root wheel 26500 Nov 7 00:08 /boot/kernel/ng_sync_ar.ko -r-xr-xr-x 1 root wheel 28523 Nov 7 00:08 /boot/kernel/ng_sync_sr.ko compiled from /sys/modules/netgraph/sync_sr and sync_ar you need to find what is broken in the NON netgraph case.. [...] it looks like if_ar and if_sr modules will not compile unless you have enabled NETGRAPH. patches are simple and attached. ok, i'm sorry :) i said it wrong. what i meant to say is that there are also non-NETGRAPH modules called if_ar and if_sr and these two will not compile, because of missing headers. thanks, max John -- John Hay -- [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
