Re: ATAPI-CD corruption since GEOMification ( possible fix)
It seems Peter Edwards wrote: With a -current built after atapi-cd was changed over to GEOM, reads from a filesystem mounted on a CD device are being corrupted, with junk being inserted into the file from offset 63489 onwards. I had a quick look around atapi-cd.c, and I think I spotted the problem: applying this patch certainly stopped the corruption I was seeing. Anyone else seeing this? Can someone verify that this is indeed the correct fix? Yeps looks like what I intended, but apprarently didn't type :( Fix committed, thanks! -Søren ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
ATAPI-CD corruption since GEOMification ( possible fix)
With a -current built after atapi-cd was changed over to GEOM, reads
from a filesystem mounted on a CD device are being corrupted, with
junk being inserted into the file from offset 63489 onwards.
I had a quick look around atapi-cd.c, and I think I spotted the
problem: applying this patch certainly stopped the corruption
I was seeing. Anyone else seeing this? Can someone verify that
this is indeed the correct fix?
My CD device probes as:
acd1: CDRW CW088D ATAPI CD-R/RW at ata1-slave PIO4
If its of any interest.
Index: atapi-cd.c
===
RCS file: /usr/cvs/FreeBSD-CVS/src/sys/dev/ata/atapi-cd.c,v
retrieving revision 1.152
diff -u -r1.152 atapi-cd.c
--- atapi-cd.c 7 Nov 2003 08:31:09 - 1.152
+++ atapi-cd.c 8 Nov 2003 21:06:15 -
@@ -1018,7 +1018,7 @@
u_int pos, size = cdp-iomax - cdp-iomax % bp-bio_to-sectorsize;
struct bio *bp2;
- for (pos = 0; pos bp-bio_length; pos += bp-bio_length) {
+ for (pos = 0; pos bp-bio_length; pos += size) {
if (!(bp2 = g_clone_bio(bp))) {
bp-bio_error = ENOMEM;
break;
--
Peter Edwards.
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: ATAPI-CD corruption since GEOMification ( possible fix)
V so, 08. 11. 2003 v 23:10, Peter Edwards pe: With a -current built after atapi-cd was changed over to GEOM, reads from a filesystem mounted on a CD device are being corrupted, with junk being inserted into the file from offset 63489 onwards. I had a quick look around atapi-cd.c, and I think I spotted the problem: applying this patch certainly stopped the corruption I was seeing. Anyone else seeing this? Can someone verify that this is indeed the correct fix? Yes, I see the corruption too. Yes, your fix works here. This is nasty! -- Pav Lucistnik [EMAIL PROTECTED] What do we know about love? Love is like a pear. Pear is sweet and have a specific shape. Try to exactly define the shape of a pear. -- Marigold: 50 Years Of Poetry signature.asc Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?= =?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?= =?ISO-8859-1?Q?_zpr=E1vy?=
