Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc)

2015-12-23 Thread NGie Cooper 

> On Dec 22, 2015, at 10:27, Garrett Cooper  wrote:
> 
> 
>> On Dec 22, 2015, at 08:23, John Baldwin  wrote:
>> 
>>> On Monday, December 21, 2015 11:01:36 AM John Baldwin wrote:
 On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote:
 Hi John,
   I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran into 
 the -Wsign-compare issue below when running make libraries with 
 buildworld, because it’s building libkvm with gcc 4.2.1 :/… I’ve tried 
 bootstrapping with clang/clang37, but haven’t been able to yet. I’ll try 
 installing 10.2-RELEASE via freebsd-update so I can use clang instead of 
 gcc.
 Thanks!
 -NGie
>>> 
>>> We don't actually support going from 9 to 11.  However, these constants
>>> should probably be explicitly unsigned anyway.  I haven't tested this at
>>> all, but something like this:
>>> 
>>> Index: head/lib/libkvm/kvm_i386.h
>>> ===
>>> --- head/lib/libkvm/kvm_i386.h  (revision 292553)
>>> +++ head/lib/libkvm/kvm_i386.h  (working copy)
>>> @@ -57,8 +57,8 @@
>>> #defineI386_PG_PS  0x080
>>> #defineI386_PG_FRAME_PAE   (0x000ff000ull)
>>> #defineI386_PG_PS_FRAME_PAE(0x000fffe0ull)
>>> -#defineI386_PG_FRAME   (0xf000)
>>> -#defineI386_PG_PS_FRAME(0xffc0)
>>> +#defineI386_PG_FRAME   (0xf000u)
>>> +#defineI386_PG_PS_FRAME(0xffc0u)
>>> 
>>> #ifdef __i386__
>>> _Static_assert(PAGE_SHIFT == I386_PAGE_SHIFT, "PAGE_SHIFT mismatch");
>> 
>> This passed a universe build on HEAD.  If you can test that it fixes the 9.3 
>> -> 11.0
>> bootstrap I will commit it.
> 
> I'll fire up a 9.3 VM and give it a shot.
> Thanks :)!!

Hmm… no bueno on ref9-amd64. What likely needs to be done is that the directory 
needs to be built by itself with gcc on i386.
Thanks!
-NGie

cc1: warnings being treated as errors
In file included from /scratch/tmp/ngie/svn/lib/libkvm/kvm_i386.c:63:
/scratch/tmp/ngie/svn/lib/libkvm/kvm_i386.h:73: warning: comparison between 
signed and unsigned
*** [kvm_i386.So] Error code 1

bmake[5]: stopped in /scratch/tmp/ngie/svn/lib/libkvm
1 error

bmake[5]: stopped in /scratch/tmp/ngie/svn/lib/libkvm
*** [lib/libkvm__L] Error code 2

bmake[4]: stopped in /scratch/tmp/ngie/svn

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc)

2015-12-22 Thread Garrett Cooper 

> On Dec 22, 2015, at 08:23, John Baldwin  wrote:
> 
>> On Monday, December 21, 2015 11:01:36 AM John Baldwin wrote:
>>> On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote:
>>> Hi John,
>>>I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran into 
>>> the -Wsign-compare issue below when running make libraries with buildworld, 
>>> because it’s building libkvm with gcc 4.2.1 :/… I’ve tried bootstrapping 
>>> with clang/clang37, but haven’t been able to yet. I’ll try installing 
>>> 10.2-RELEASE via freebsd-update so I can use clang instead of gcc.
>>> Thanks!
>>> -NGie
>> 
>> We don't actually support going from 9 to 11.  However, these constants
>> should probably be explicitly unsigned anyway.  I haven't tested this at
>> all, but something like this:
>> 
>> Index: head/lib/libkvm/kvm_i386.h
>> ===
>> --- head/lib/libkvm/kvm_i386.h  (revision 292553)
>> +++ head/lib/libkvm/kvm_i386.h  (working copy)
>> @@ -57,8 +57,8 @@
>> #defineI386_PG_PS  0x080
>> #defineI386_PG_FRAME_PAE   (0x000ff000ull)
>> #defineI386_PG_PS_FRAME_PAE(0x000fffe0ull)
>> -#defineI386_PG_FRAME   (0xf000)
>> -#defineI386_PG_PS_FRAME(0xffc0)
>> +#defineI386_PG_FRAME   (0xf000u)
>> +#defineI386_PG_PS_FRAME(0xffc0u)
>> 
>> #ifdef __i386__
>> _Static_assert(PAGE_SHIFT == I386_PAGE_SHIFT, "PAGE_SHIFT mismatch");
> 
> This passed a universe build on HEAD.  If you can test that it fixes the 9.3 
> -> 11.0
> bootstrap I will commit it.

I'll fire up a 9.3 VM and give it a shot.
Thanks :)!!
-NGie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc)

2015-12-22 Thread John Baldwin 
On Monday, December 21, 2015 11:01:36 AM John Baldwin wrote:
> On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote:
> > Hi John,
> > I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran 
> > into the -Wsign-compare issue below when running make libraries with 
> > buildworld, because it’s building libkvm with gcc 4.2.1 :/… I’ve tried 
> > bootstrapping with clang/clang37, but haven’t been able to yet. I’ll try 
> > installing 10.2-RELEASE via freebsd-update so I can use clang instead of 
> > gcc.
> > Thanks!
> > -NGie
> 
> We don't actually support going from 9 to 11.  However, these constants
> should probably be explicitly unsigned anyway.  I haven't tested this at
> all, but something like this:
> 
> Index: head/lib/libkvm/kvm_i386.h
> ===
> --- head/lib/libkvm/kvm_i386.h  (revision 292553)
> +++ head/lib/libkvm/kvm_i386.h  (working copy)
> @@ -57,8 +57,8 @@
>  #defineI386_PG_PS  0x080
>  #defineI386_PG_FRAME_PAE   (0x000ff000ull)
>  #defineI386_PG_PS_FRAME_PAE(0x000fffe0ull)
> -#defineI386_PG_FRAME   (0xf000)
> -#defineI386_PG_PS_FRAME(0xffc0)
> +#defineI386_PG_FRAME   (0xf000u)
> +#defineI386_PG_PS_FRAME(0xffc0u)
>  
>  #ifdef __i386__
>  _Static_assert(PAGE_SHIFT == I386_PAGE_SHIFT, "PAGE_SHIFT mismatch");

This passed a universe build on HEAD.  If you can test that it fixes the 9.3 -> 
11.0
bootstrap I will commit it.

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc)

2015-12-21 Thread John Baldwin 
On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote:
> Hi John,
>   I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran 
> into the -Wsign-compare issue below when running make libraries with 
> buildworld, because it’s building libkvm with gcc 4.2.1 :/… I’ve tried 
> bootstrapping with clang/clang37, but haven’t been able to yet. I’ll try 
> installing 10.2-RELEASE via freebsd-update so I can use clang instead of gcc.
> Thanks!
> -NGie

We don't actually support going from 9 to 11.  However, these constants
should probably be explicitly unsigned anyway.  I haven't tested this at
all, but something like this:

Index: head/lib/libkvm/kvm_i386.h
===
--- head/lib/libkvm/kvm_i386.h  (revision 292553)
+++ head/lib/libkvm/kvm_i386.h  (working copy)
@@ -57,8 +57,8 @@
 #defineI386_PG_PS  0x080
 #defineI386_PG_FRAME_PAE   (0x000ff000ull)
 #defineI386_PG_PS_FRAME_PAE(0x000fffe0ull)
-#defineI386_PG_FRAME   (0xf000)
-#defineI386_PG_PS_FRAME(0xffc0)
+#defineI386_PG_FRAME   (0xf000u)
+#defineI386_PG_PS_FRAME(0xffc0u)
 
 #ifdef __i386__
 _Static_assert(PAGE_SHIFT == I386_PAGE_SHIFT, "PAGE_SHIFT mismatch");



-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc)

2015-12-19 Thread NGie Cooper 
Hi John,
I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran 
into the -Wsign-compare issue below when running make libraries with 
buildworld, because it’s building libkvm with gcc 4.2.1 :/… I’ve tried 
bootstrapping with clang/clang37, but haven’t been able to yet. I’ll try 
installing 10.2-RELEASE via freebsd-update so I can use clang instead of gcc.
Thanks!
-NGie

% git log --show-notes --grep svn -n 1
commit 69774947bfffd5e16d26b60a82d880aa659abbf2
Author: imp 
Date:   Sat Dec 19 19:20:48 2015 +

Move some MIPS specific flags to be more congruent with other
architectures.

Notes:
svn path=/head/; revision=292474

% make buildworld

--- lib/libkvm__L ---
--- kvm_i386.o ---
cc   -O2 -pipe -O2 -pipe -DLIBC_SCCS -I/usr/src/git/lib/libkvm   -MD -MP 
-MF.depend.kvm_i386.o -MTkvm_i386.o -std=gnu99 -fstack-protector-strong 
-Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter 
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized 
-Wno-pointer-sign   -c /usr/src/git/lib/libkvm/kvm_i386.c -o kvm_i386.o
--- lib/libnv__L ---
--- obj ---
--- lib/libkvm__L ---
cc1: warnings being treated as errors
In file included from /usr/src/git/lib/libkvm/kvm_i386.c:63:
/usr/src/git/lib/libkvm/kvm_i386.h:73: warning: comparison between signed and 
unsigned
*** [kvm_i386.So] Error code 1

bmake[3]: stopped in /usr/src/git/lib/libkvm
1 error

bmake[3]: stopped in /usr/src/git/lib/libkvm
*** [lib/libkvm__L] Error code 2

bmake[2]: stopped in /usr/src/git
--- lib/libmd__L ---
A failure has been detected in another branch of the parallel make

bmake[3]: stopped in /usr/src/git/lib/libmd
*** [lib/libmd__L] Error code 2

bmake[2]: stopped in /usr/src/git
2 errors

bmake[2]: stopped in /usr/src/git
*** [libraries] Error code 2
…
% cc --version
cc (GCC) 4.2.1 20070831 patched [FreeBSD]
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
%
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"