Hmm, -current has same problem.  It should fix in -current...

--- Begin Message ---
Hi all,

fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called.
Shouldn't this be SELECTIVE_RESET?

As I'm not familiar with fxp, would someone check and commit it to the
repositry?  The current code clears all the hardware mc filters
already set, as a result, the box can't receive any multicast packets
(this is a serious problem especially when using ipv6).

---
Keiichi SHIMA
IIJ Research Laboratory  <[EMAIL PROTECTED]>
KAME Project <[EMAIL PROTECTED]>


--- orig/if_fxp.c       Thu Nov  8 18:30:10 2001
+++ if_fxp.c    Thu Nov 22 17:22:38 2001
@@ -1429,7 +1429,7 @@
         * Issue software reset, which also unloads the microcode.
         */
        sc->flags &= ~FXP_FLAG_UCODE;
-       CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET);
+       CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET);
        DELAY(50);
 
        /*

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-stable" in the body of the message
--- End Message ---
--- Begin Message ---
I noticed this fixes my problem, but I don't know this patch is
logically correct or not.

I think we should commit this before 4.5-RELEASE if this is correct
way.  Can someone comment this?


At Thu, 22 Nov 2001 08:47:09 +0000 (UTC),
Keiichi SHIMA / 島慶一 wrote:
> fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called.
> Shouldn't this be SELECTIVE_RESET?
> 
> As I'm not familiar with fxp, would someone check and commit it to the
> repositry?  The current code clears all the hardware mc filters
> already set, as a result, the box can't receive any multicast packets
> (this is a serious problem especially when using ipv6).
...
> --- orig/if_fxp.c     Thu Nov  8 18:30:10 2001
> +++ if_fxp.c  Thu Nov 22 17:22:38 2001
> @@ -1429,7 +1429,7 @@
>        * Issue software reset, which also unloads the microcode.
>        */
>       sc->flags &= ~FXP_FLAG_UCODE;
> -     CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET);
> +     CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET);
>       DELAY(50);
>  
>       /*


-- 
Jun Kuriyama <[EMAIL PROTECTED]> // IMG SRC, Inc.
             <[EMAIL PROTECTED]> // FreeBSD Project

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-stable" in the body of the message
--- End Message ---

Reply via email to